Noah
4fab553da0
Bug 1821928 - Convert toolkit/components/translation to ES modules. r=Standard8,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D172505
2023-03-14 21:16:46 +00:00
Mark Banner
55bba8e918
Bug 1819019 - Update consumers of services/common to import ES modules directly. r=markh,webdriver-reviewers,extension-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D171055
2023-02-28 10:11:55 +00:00
Emilio Cobos Álvarez
7b8e46d7ec
Bug 1817053 - Remove translation-notification.js and co completely. r=mconley,fluent-reviewers,gregtatum,flod
...
I double-checked that the extension works with this patch.
Differential Revision: https://phabricator.services.mozilla.com/D169992
2023-02-17 09:22:47 +00:00
Gijs Kruitbosch
efef52fc92
Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D166179
2023-01-31 11:48:41 +00:00
Mark Banner
c01accb9b4
Bug 1811339 - Stop using nsIScriptableUnicodeConverter in browser/components/translation. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D167298
2023-01-20 12:05:32 +00:00
Gijs Kruitbosch
9946c4fcbb
Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D167153
2023-01-19 20:16:42 +00:00
Mark Banner
9189ff3f6f
Bug 1798018 - Convert consumers of toolkit/modules/tests to import ES modules direct. r=Gijs,webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich
...
Differential Revision: https://phabricator.services.mozilla.com/D160664
2022-11-01 13:26:38 +00:00
Mark Banner
8d1ebcb9d6
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
4e978b56b5
Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
...
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.
As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).
For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.
For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.
Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.
Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-27 04:18:16 +00:00
Marian-Vasile Laza
f54a464c90
Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html.
2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
f875681246
Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
...
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.
As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).
For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.
For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.
Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.
Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-26 17:40:30 +00:00
Emilio Cobos Álvarez
13572bce66
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd
Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE
2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Eemeli Aro
656bd06683
Bug 1734220 - Migrate translation-notification.js to Fluent. r=jaws,fluent-reviewers,flod
...
The strings from the translation.dtd and translation.properties files are all
merged into a single translationNotification.ftl file.
The string concatenation used in the original is maintained here, as DOM
Localization does not allow for using a <menulist> as a localized element.
Differential Revision: https://phabricator.services.mozilla.com/D155110
2022-09-02 11:03:31 +00:00
Eemeli Aro
4ce19437ce
Bug 1785216 - Migrate notification.dtd to Fluent. r=jaws,fluent-reviewers,flod,mconley
...
Except for the close-notification-message, all of the notification.dtd
strings are only used by popupnotification.js. Accordingly, the strings
are migrated to two different FTL files.
Differential Revision: https://phabricator.services.mozilla.com/D154890
2022-09-02 11:03:31 +00:00
John Bieling
24210e2c3a
Bug 1764698 - Move LanguageDetector.jsm and related files to toolkit. r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D151606
2022-08-23 05:59:55 +00:00
Mark Banner
7428be4a86
Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Tooru Fujisawa
f3a8c52c53
Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Ryan VanderMeulen
3187ab6878
Bug 1776496 - Re-enable some passing browser-chrome tests. r=preferences-reviewers,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D150280
2022-06-27 13:57:41 +00:00
Joel Maher
5bf232d7af
Bug 1776212 - cleanup e10s in manifest conditions for bc/dt. r=aryx,necko-reviewers,extension-reviewers,preferences-reviewers,dragana,zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D150127
2022-06-23 17:49:07 +00:00
Mark Banner
61c02dadbe
Bug 1770727 - Fix ESLint rule mozilla/use-services on sjs files and expose Services to sjs files. r=Gijs
...
Depends on D147080
Differential Revision: https://phabricator.services.mozilla.com/D147081
2022-06-07 19:14:08 +00:00
Tooru Fujisawa
d1b65526d4
Bug 1772100 - Part 19: Use plain object for lazy getter in browser/components/translation/. r=florian
...
Differential Revision: https://phabricator.services.mozilla.com/D148029
2022-06-06 22:46:26 +00:00
Tooru Fujisawa
4f96aa80b2
Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 04:42:10 +00:00
Molnar Sandor
77402a5caa
Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
...
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
c7229a1a17
Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 02:49:14 +00:00
Molnar Sandor
05e3775a6c
Backed out 4 changesets (bug 1770727) for causing mochitest failures in test_bug1180105/test_access_control. CLOSED TREE
...
Backed out changeset 6323b526b0ac (bug 1770727)
Backed out changeset fc7ea80aa2ff (bug 1770727)
Backed out changeset 2a358ba86652 (bug 1770727)
Backed out changeset 464d1af6523b (bug 1770727)
2022-05-24 17:24:40 +03:00
Mark Banner
dac6401c3b
Bug 1770727 - Fix ESLint rule mozilla/use-services on sjs files and expose Services to sjs files. r=Gijs
...
Depends on D147080
Differential Revision: https://phabricator.services.mozilla.com/D147081
2022-05-24 12:59:09 +00:00
Kagami Sascha Rosylight
1409f37ca3
Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
...
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().
Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-04-06 11:57:57 +00:00
Gijs Kruitbosch
8e67201171
Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 16:16:42 +00:00
Norisz Fay
acdd6851cd
Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE
...
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
27039e2946
Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 08:18:51 +00:00
criss
4eec7e25a3
Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE
...
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
c8f12f94dc
Bug 1703953 - Part 2: Apply mozilla/use-isInstance rules for .jsm files r=webdriver-reviewers,pip-reviewers,mhowell,Gijs,whimboo
...
This replaces all `instanceof` uses for DOM interfaces, since the operator in priviliged context works same as .isInstance().
Differential Revision: https://phabricator.services.mozilla.com/D141785
2022-03-29 13:11:00 +00:00
Mark Banner
2d563feacc
Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-17 22:13:08 +00:00
Cristian Tuns
e8374bd569
Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE
2022-03-14 12:27:48 -04:00
Mark Banner
0ce30e3008
Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-14 10:19:40 +00:00
Mark Banner
8bb4667fae
Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
smolnar
e89faa903f
Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE
2022-03-10 11:58:45 +02:00
Mark Banner
fe937b78bd
Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
Mark Banner
646bcf3159
Bug 1758139 - Ignore no-unused-vars issues in test_cld2.js. r=florian
...
Differential Revision: https://phabricator.services.mozilla.com/D140352
2022-03-08 16:59:19 +00:00
Mark Banner
fbf379686b
Bug 1758090 - Stop using ChromeUtils.import(..., null) for importing modules in browser/. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D140319
2022-03-08 16:59:18 +00:00
Evgenia Kotovich
0d0980ee0d
Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-18 09:26:33 +00:00
Noemi Erli
2bba3cec69
Backed out changeset 2ab6bb03dcc1 (bug 1576768) for causing failures in test_double_submit.html CLOSED TREE
2021-10-18 02:05:57 +03:00
Evgenia Kotovich
3e3dff109c
Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-17 14:59:14 +00:00
Alexandru Michis
dac6815201
Backed out changeset 7c08aa027893 (bug 1576768) for causing multiple failures.
...
CLOSED TREE
2021-10-15 16:52:43 +03:00
Evgenia Kotovich
a8b32926fa
Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-15 12:58:11 +00:00
Neil Deakin
a62618baa7
Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-17 09:04:59 +00:00
Narcis Beleuzu
72152613c6
Backed out 3 changesets (bug 1690390) for mochitest failures on test_notificationbox.xhtml . CLOSED TREE
...
Backed out changeset e6404b7424cd (bug 1690390)
Backed out changeset a161177099af (bug 1690390)
Backed out changeset cc7e02d3d418 (bug 1690390)
2021-09-16 23:41:21 +03:00
Neil Deakin
82501df9f7
Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D107755
2021-09-16 19:11:17 +00:00