Kris Maglione
a7b308c3a2
Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
...
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Marco Bonardo
ba1483da46
Bug 1450210
- Remove remaining references to the POST data anno. r=standard8
...
MozReview-Commit-ID: 5AOMj1VBgT7
--HG--
extra : rebase_source : 3b89f4a26e77b37a0da8ff8640af4a648c93b351
2018-03-30 12:33:02 +02:00
Kit Cambridge
4f0c3cba86
Bug 1199077 - Add Places APIs to store the bookmarks sync ID and last sync time. r=mak,tcsc
...
MozReview-Commit-ID: 7yEGZl5pIru
--HG--
extra : rebase_source : bdb8a72ed179a20ade7bf5f46097fb9337d1895b
2018-03-03 11:27:58 -08:00
Kit Cambridge
0c40fa1232
Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
...
MozReview-Commit-ID: 1glcCPj2X90
--HG--
extra : rebase_source : 2d8372029df5851ecbb30a65393325442addd84c
2018-03-01 13:37:13 -08:00
Mark Banner
2155e56144
Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
...
MozReview-Commit-ID: DcEMAlrXu8R
--HG--
extra : rebase_source : c98e6a50702ef0c238d036fa2a26f4a6ac9f15af
2018-02-16 20:30:04 +00:00
Dorel Luca
7065341d2f
Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
...
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)
--HG--
extra : rebase_source : cb7317f5afa7c828ec3b6d9b7679b474fa9cf5da
2018-03-14 18:23:46 +02:00
Mark Banner
80abee119b
Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
...
MozReview-Commit-ID: DcEMAlrXu8R
--HG--
extra : rebase_source : a956958f5c9adde0ee775e9bc918a8970564bbb7
2018-02-16 20:30:04 +00:00
Mark Banner
28f08cc0dc
Bug 1443835 - Prevent modifications to the root folder via PlacesUtils.bookmarks.insert and PlacesUtils.bookmarks.update. r=mak
...
MozReview-Commit-ID: KQjxc3PA2SY
--HG--
extra : rebase_source : 1a6063f424271ac3bfdae23af25a4e8abdd71ac9
2018-03-07 17:24:01 +00:00
Mark Banner
8e43da7d18
Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut. r=mak
...
MozReview-Commit-ID: OqKDMEqxeA
--HG--
extra : rebase_source : d716baa2dc2cf6433a7e7c4be79882b085d1ed51
2018-03-02 15:42:25 +00:00
Mark Banner
2e4db142aa
Bug 1440761 - Enable no-unused-vars for global scope on jsm files in toolkit/. r=mossop
...
MozReview-Commit-ID: 7Okqmw5dBcL
--HG--
extra : rebase_source : 6fff67e5e4bf483e6903a68a713d0b7d6c659d3b
2018-02-23 19:25:59 +00:00
Florian Quèze
682b1ec3b2
Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8.
2018-02-23 20:50:01 +01:00
Kit Cambridge
e5d15ed6c2
Bug 1435354 - Remove the keywords cache observer and implement cache invalidation. r=mak
...
MozReview-Commit-ID: dRGyz042JM
--HG--
extra : rebase_source : 06e6a38403f2aabe322520d74bbe0a178cd30684
2018-02-20 22:04:59 -08:00
Felipe Gomes
35c0e50b23
Bug 1438577 - Add API to fetch bookmarks by GUID prefix. r=mak
...
MozReview-Commit-ID: GPEp5Vxrz5z
--HG--
extra : rebase_source : f8be9cfdad6db7f00366cef587751649538f74df
2018-02-20 13:31:41 -03:00
Mark Banner
d6729b8d28
Bug 1432614 - Remove now unnecessary updating and maintenance of Places' root folder titles. r=kitcambridge,mak
...
The titles for the root bookmark folders in the database will now never get updated. This
avoids doing maintenance and changing them if the locale changes.
The UI is now responsible for displaying the correct title.
WebExtensions API will get the UI visible names.
MozReview-Commit-ID: ErPPJXxy2d3
--HG--
extra : rebase_source : f08caa5b0d00ae81ffabf4a1076bd56b66414418
2018-01-04 16:35:56 +00:00
Mark Banner
362505f227
Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
...
MozReview-Commit-ID: HzJ9y1fiEz1
--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Coroiu Cristina
1c85c04c62
Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
...
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
7785b2e489
Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
...
MozReview-Commit-ID: HzJ9y1fiEz1
--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Andrew McCreight
5dec0e0beb
Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
...
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.
It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)
MozReview-Commit-ID: DeSHcClQ7cG
--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178
Backed out 3 changesets (bug 1431533
) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
...
Backed out changeset a1eca62826a1 (bug 1431533
)
Backed out changeset 34c999fa006b (bug 1431533
)
Backed out changeset e2674287e57f (bug 1431533
)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb
Backed out 2 changesets (bug 1431533
) for ESlint failures on a CLOSED TREE
...
Backed out changeset 6e56f4c8843e (bug 1431533
)
Backed out changeset 12fc4dee861c (bug 1431533
)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375
Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
...
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Mark Banner
85b029c2ae
Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak
...
MozReview-Commit-ID: 9ZMA2A879O8
--HG--
rename : toolkit/components/places/tests/bookmarks/test_protectRoots.js => toolkit/components/places/tests/legacy/test_protectRoots.js
extra : rebase_source : d386b6e8b9e1bfc4568032d094a48d7d9a3b3a48
2017-12-21 09:16:48 +00:00
Doug Thayer
43771ba19d
Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
...
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.
MozReview-Commit-ID: 5TUueknq3ng
--HG--
extra : rebase_source : 1892edfcaa7b6afd29ce794a93d6ab3d46c48895
2017-11-07 12:01:53 -08:00
Mark Banner
0e947c9d32
Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
...
MozReview-Commit-ID: GL9nKfypie1
--HG--
extra : rebase_source : 5cd1c4d848dc32611349e25eb7297ba50890f0a9
2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs
1d0ba383ae
Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE
2017-10-31 14:19:52 +02:00
Mark Banner
d059b763bb
Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
...
MozReview-Commit-ID: GL9nKfypie1
--HG--
extra : rebase_source : ca8ec95e51899bc1fb18e7a39f42a96569a2d4d1
2017-10-26 10:14:14 +01:00
Marco Bonardo
c4ffb970fc
Bug 1404631 - Bookmarks.insertTree should have an option to fixup input and skip broken entries. r=standard8
...
MozReview-Commit-ID: 47edAJolOwE
--HG--
extra : rebase_source : 4d9e286ca108a687c786ad842db3976f1d3fc814
2017-10-07 11:15:47 +02:00
Dan Banner
7caa92d5d8
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Josh Aas
8d88b9d1a8
Bug 1095427
- Convert HTML bookmarks import code to the new async Bookmarks.jsm API. r=mak
...
Original patch by Josh, completed by Standard8.
MozReview-Commit-ID: Baun3n69n1b
--HG--
extra : rebase_source : e83e6a3cb0cc448c407042eabf6f6acaf1aabe68
2017-10-02 16:53:00 +01:00
Mark Banner
f1daedfa92
Bug 1407164 - Fix strict warnings in Bookmarks.jsm relating to undefined property source - don't delete item properties too soon. r=mak
...
MozReview-Commit-ID: AJJRSHYqPch
--HG--
extra : rebase_source : bb2d043215be9e2493ddd5dff452999dd95d1db2
2017-10-10 09:13:19 +01:00
Mark Banner
1a2f65447b
Bug 1405317 - When inserting trees of bookmarks, avoid updating the last modified date when marking annotations. r=mak
...
MozReview-Commit-ID: Ik8DKwtiXoM
--HG--
extra : rebase_source : 4e6f0b5b1778cd8b9355a35908baccd850d7c5ca
2017-10-03 21:18:10 +01:00
Kit Cambridge
0d29ca233e
Bug 1393904 - Ensure `insertTree` removes Sync tombstones for restored bookmarks. r=mak
...
MozReview-Commit-ID: EbGybRbhWKJ
--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
2017-08-25 12:04:22 -07:00
Bob Silverberg
8268904c53
Bug 1293853 - Part 2: Include separators in results from bookmarks.search, r=standard8
...
This API is only used by WebExtensions, which previously wanted to exclude separators,
but now we want the WebExtensions APIs to be able to return separators.
MozReview-Commit-ID: 7PApWDwWMr1
--HG--
extra : rebase_source : c5e816900cb0288f1cdba86ec07f6565a1c79880
2017-08-29 13:19:05 -04:00
Mark Banner
3966840fb0
Bug 1316348 - Make eraseEverything notify for removals within the top-level bookmarks folders to ensure correct updates on the UI. r=mak
...
MozReview-Commit-ID: 2bt24qqOd4S
--HG--
extra : rebase_source : b6a5ee35e535655ecc249953de532645f40ddc8d
2017-08-23 15:54:36 +01:00
sellsellgo
54fa77007d
Bug 1347452 - Assigned item.guid using PlacesUtils.history.makeGuid() in insertBookmark(). r=mak
...
MozReview-Commit-ID: LgVFlgNEzHf
--HG--
extra : rebase_source : 2aa9f76bae35842c07bf062f2f4da8c084eed30e
2017-08-17 09:50:25 +02:00
Kit Cambridge
674b6aad46
Bug 1389716 - `Bookmarks.reorder` shouldn't call `withConnectionWrapper` from within a transaction. r=mak
...
MozReview-Commit-ID: A6aMesfFcpF
--HG--
extra : rebase_source : f15465df235a0e1ce22feac62add454ff75104a9
2017-08-11 19:02:48 -07:00
Kit Cambridge
18e2c40fe8
Bug 1380718 - Include the operation name in bookmark validation errors. r=mak
...
MozReview-Commit-ID: H4vp6ZULSq7
--HG--
extra : rebase_source : a3bb16fd51700d9de0d31bf574a82e5ce4dfca94
2017-07-13 10:09:49 -07:00
Mayank Srivastav
a78d4768e0
Bug 1354032 - Remove Places analyze call and use PRAGMA optimize(0x02) for optimizations. r=mak
...
MozReview-Commit-ID: AOkh3vOKD4E
--HG--
extra : rebase_source : a8a02b6fc4e5bc607f04c10192edef78f1109749
2017-05-30 19:14:39 +05:30
Sebastian Hengst
86c27b0a76
Backed out changeset 03b8979ccf32 (bug 1354032) for failing database-related mochitests, e.g. browser/components/resistfingerprinting/test/mochitest/test_geolocation.html. r=backout on a CLOSED TREE
2017-07-15 15:51:28 +02:00
Mayank Srivastav
1404e8bc7e
Bug 1354032 - Remove Places analyze call and use PRAGMA optimize(0x02) for optimizations. r=mak
...
MozReview-Commit-ID: AOkh3vOKD4E
--HG--
extra : rebase_source : 90f13425b7d5aec779787612781c2a49dd005037
2017-05-30 19:14:39 +05:30
Kit Cambridge
8311a354e2
Bug 1379798 - Ensure `insertTree` notifies observers with the correct parent ID. r=standard8
...
MozReview-Commit-ID: LBm8VddumPJ
--HG--
extra : rebase_source : 6c1624a408843afe64f7efab24704502034bee9d
2017-07-10 14:38:21 -07:00
Mark Banner
35f3666937
Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
...
MozReview-Commit-ID: EnhSBHMjurr
--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
2017-07-11 22:49:55 +01:00
Marco Bonardo
d3bad38937
Bug 1376929 - Fix places-related mochitests in chrome/ for async-transactions. r=standard8
...
MozReview-Commit-ID: ILrvOGzu1zo
--HG--
extra : rebase_source : de00f7f734711e2d2c8521626ad8857ab858bb97
2017-07-03 15:46:56 +02:00
Kit Cambridge
31ccf3dc94
Bug 1360872
- Return empty strings for `null` bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 963b09955610d099b1acb508472a2a3c24202d73
2017-06-06 14:37:22 -07:00
Sebastian Hengst
acb0601c26
Backed out changeset d7e7ced3622f (bug 1360872
) for failing xpcshell's test_async_transactions.js | test_creating_and_removing_a_separator, at least on OS X. r=backout
2017-06-30 19:29:17 +02:00
Kit Cambridge
c1537b7958
Bug 1360872
- Return empty strings for `null` bookmark titles. r=mak
...
MozReview-Commit-ID: Dd2sEfYvnBt
--HG--
extra : rebase_source : 8b09ca049f0891cfc3a909f7b7d2807511586b48
2017-06-06 14:37:22 -07:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
a2c238b900
Bug 1095425 - Convert PlacesTransactions to the new Bookmarks.jsm API. r=standard8
...
MozReview-Commit-ID: 12pPCGmzV4X
--HG--
extra : rebase_source : 1f8a73a5e84f34cd683abfba854c8413b0cd49b8
2015-04-28 15:19:43 +03:00
Sebastian Hengst
2cfb02f19d
Backed out changeset c0fd6c0590be (bug 1360872
) for unused parentId at toolkit/components/places/Bookmarks.jsm:461. r=backout
2017-06-30 00:16:35 +02:00