2f23818440
Bug 1339617 - move GetClosure call prior to canceling timer; r=mayhemer
...
Some recent work on timers changed how we handle callbacks and
associated closure data: prior to these changes, canceling timers would
not null out associated closure data, so calling GetClosure() on a timer
after canceling it would return what you had put in. After these
changes, however, GetClosure() after cancellation would retrieve a null
value, causing anything that assumed non-nullness to crash. The simple
fix is to move the GetClosure() call prior to Cancel()'ing the timer.
2017-02-21 13:35:52 -05:00
4476c148e4
Bug 1333568. r=valentin
2017-02-18 11:35:50 -05:00
8c4ce17711
Merge inbound to m-c a=merge
...
MozReview-Commit-ID: DCUf7VEDrTt
2017-02-17 13:38:51 -08:00
7d4bd52fae
Bug 1330907 - Rename Telemetry::ID to Telemetry::HistogramID. r=dexter
...
Changed |print("enum ID : uint32_t {", file=output)| to |print("enum HistogramID : uint32_t {", file=output)| at line 53 of the file |toolkit/components/telemetry/gen-histogram-enum.py|, and then replaced all the textual occurrences of |Telemetry::ID| to |Telemetry::HistogramID| and |ID| to |HistogramID| in 43 other files.
2017-02-16 00:45:15 +05:30
d2667a2b27
Bug 1060419 - make AppendPrintf and nsPrintfCString use Printf.h, r=froydnj
...
MozReview-Commit-ID: 2E8FoiNxU8L
--HG--
extra : rebase_source : 810ac727bef0751f24edea18c52e0ec170bf367d
2016-12-14 09:32:21 -07:00
5f8f360823
Bug 1060419 - make log_print use Printf.h, r=froydnj
...
MozReview-Commit-ID: BIZ1GQEZ1vs
--HG--
extra : rebase_source : 2f1f0aa12493c44f352d9a7e8683e7bb72d2d75b
2016-12-15 20:16:31 -07:00
d85b37d5f5
Bug 1335181 - add BUG_COMPONENT to netwerk/* and dom/network/* files. r=mcmanus
...
MozReview-Commit-ID: AeIuBnLx6IF
2017-02-02 06:33:47 -05:00
359ae91eac
Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby
2017-01-12 17:38:48 +01:00
348bfffc19
Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj
2016-12-02 13:46:53 -08:00
fd99cf4221
Bug 1318888 - Remove a few other mentions of appId's from Necko; r=mcmanus
2016-11-21 15:00:49 -05:00
1488007b30
Bug 1318206 - Remove some unused code for clearing app data; r=baku,mcmanus
2016-11-17 08:30:21 -05:00
b500aaacf6
Bug 1316206 - Fix RefPtr assignments from 0 - r=froydnj
...
Giving '0' (literal zero) to RefPtr is now ambiguous, as both
RefPtr(decltype(nullptr)) and RefPtr(T*) could be used.
In any case, our coding standards mandate the use of 'nullptr' for pointers.
So I'm changing all zeroes into nullptr's where necessary.
MozReview-Commit-ID: A458A4e9for
--HG--
extra : rebase_source : bc4107ce1767329e3dddfe34c55ba79202192e06
2016-11-08 14:34:06 +11:00
2a51f65d99
Bug 1237152 - rename clear-origin-data to clear-origin-attributes-data, r=smaug
...
find \( -name '*.cpp' -o -name '*.h' -o -name '*.js' -o -name '*.jsm' -o -name '*.idl' -o -name '*.html' \) \
-a -type f -exec sed -i 's/clear-origin-data/clear-origin-attributes-data/g' {} \;
2016-10-07 17:45:10 +08:00
056d5a6135
Bug 1301629 - Fix incorrect parameter name in comments. r=ettseng
...
--HG--
extra : rebase_source : a45c6c9641ceb70301e8bcd957a3e21c95aef423
2016-09-14 19:57:20 +02:00
c2306345d5
Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
...
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.
The patch also does some associated clean-up.
- Replaces some uses of nsIMemoryReporterCallback with the preferred
nsIHandleReportCallback typedef.
- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
parameter names, for consistency.
- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.
- Uses the MOZ_COLLECT_REPORT macro in all suitable places.
Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.
--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
04be8d005a
Bug 1296164 (part 1) - Use [must_use] on nsIFile.{create,createUnique}. r=froydnj.
...
And fix numerous missing checks that this change identifies.
--HG--
extra : rebase_source : 97b0a6e8f9375c937dadb59c1110bb54b7633134
2016-08-18 13:30:12 +10:00
b64548f6c6
Bug 1295085 - Replace PR_snprintf and s[n]printf calls with SprintfLiteral in netwerk/. r=jduell
2016-08-15 01:09:06 -07:00
175543fda8
Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj
2016-08-14 23:43:21 -07:00
a57972337d
Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj
2016-08-14 23:44:00 -07:00
bab6d17ebf
Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
...
This patch makes the following changes on many in-class methods.
- NS_IMETHODIMP F() override; --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final; --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...} --> NS_IMETHOD F() final {...}
Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.
--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
e7f10a07fd
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
564db81aea
Bug 1286735 - Add after-shutdown nullchecks to the appcache code, r=michal
...
--HG--
extra : rebase_source : ebf25a8b608f9fb604907528b88cac201546e135
2016-07-27 12:10:00 +02:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
303d9bf656
Bug 1278439 - Adding missing prefs service null checks in netwerk/. r=valentin.
...
--HG--
extra : rebase_source : 837c2579c05e99f09f302d03f44279aff0894f24
2016-07-14 13:47:44 +10:00
ba3387e6a0
Bug 1281793 - Remove some non-used telemetry IDs - part 7 - network/cache (2), r=mayhemer
2016-06-29 15:19:13 +02:00
93583dc002
Bug 1281793 - Remove some non-used telemetry IDs - part 2 - network/cache, r=gfritzsche
2016-06-28 19:29:28 +02:00
32708ad758
Backed out changeset 4bf710c1a503 (bug 1281793)
2016-06-28 17:04:51 +02:00
875e53018c
Bug 1281793 - Remove some non-used telemetry IDs - part 2 - network/cache, r=gfritzsche
2016-06-28 16:44:42 +02:00
b42f297a3a
Bug 1273683: Purge any evidence that dougt could write code. r=dougt
2016-06-06 06:51:16 -07:00
2cd574f25f
Bug 1274376 - more mozilla::net namespaces r=dragana
...
--HG--
extra : rebase_source : 914d48f23a4a5db052a789b9e21c1ff922533d35
2016-05-18 22:02:57 -04:00
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
490b63ff9c
Bug 1259129 - Fix wrong CondVar::Wait() usage in netwerk/cache, r=honzab
2016-05-13 08:56:22 +02:00
941ab1f522
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-05-05 01:45:00 -07:00
ba3fe0975c
Backed out changeset 85ce8cb0639a (bug 1268313)
...
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
48a594a09e
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-04-28 14:08:25 -07:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
3be1728969
Bug 1262397 - fix a few emacs modelines; r=me
...
DONTBUILD because comment fixes are always safe, right?
2015-10-12 23:45:30 -04:00
a2f068b2ad
Bug 1253085 - Remove the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}. r=froydnj.
...
This is easy because it's never needed.
--HG--
extra : rebase_source : 78830dab41c40a1544fa55fc69ca9c1c6709d767
2016-03-16 15:33:44 +11:00
2a55d065b7
Bug 1238160 - Rename OriginAttributes.mInBrowser and associated methods. r=bz,mayhemer
...
This change renames OriginAttributes.mInBrowser to mInIsolatedMozBrowser and
nsIPrincipal::GetIsInBrowserElement to GetIsInIsolatedMozBrowserElement. Other
methods that pass these values around also have name changes.
Tokens such as "inBrowser" have previously been serialized into cache keys, used
as DB column names, stored in app registries, etc. No changes are made to any
serialization formats. Only runtime method and variable names are updated.
No behavior changes are made in this patch, so some renamed methods may have
nonsensical implementations. These are corrected in subsequent patches
focused on behavior.
MozReview-Commit-ID: 66HfMlsXFLs
2016-03-02 10:35:56 -06:00
b700af6edd
Bug 1234540 - verify the validity of hashEntry, if it's null return with NS_ERROR_FAILURE. r=michal
2016-02-26 10:30:12 +02:00
686438c658
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
2016-02-10 08:23:00 +01:00
5b358688b7
Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures
...
--HG--
extra : rebase_source : fb6fd434c8e3f4b5fa53ea645a54c07cab207894
2016-02-08 11:17:38 +01:00
69cf7e035f
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
...
--HG--
extra : rebase_source : 3c6bba6613a14e48239d302bdd0f7fe2e322265d
2016-02-07 10:56:00 +01:00
d7371d07d0
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
d381b4bca6
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
373593275e
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
d36e6cf36c
Bug 1165256 - Make appcache fully work with OriginAttribues. r=jduell
2016-01-18 20:20:08 +01:00
7ed406b2be
Bug 1238290 - fix bad necko deps on unified_sources r=valentin.gosu
...
---
netwerk/base/ARefBase.h | 2 ++
netwerk/base/CaptivePortalService.cpp | 1 +
netwerk/base/CaptivePortalService.h | 1 +
netwerk/base/EventTokenBucket.cpp | 4 +++-
netwerk/base/LoadContextInfo.cpp | 3 +++
netwerk/base/LoadInfo.cpp | 3 +++
netwerk/base/MemoryDownloader.cpp | 1 +
netwerk/base/Predictor.cpp | 1 +
netwerk/base/RedirectChannelRegistrar.h | 1 +
netwerk/base/nsBaseChannel.cpp | 1 +
netwerk/base/nsChannelClassifier.cpp | 1 +
netwerk/base/nsDirectoryIndexStream.cpp | 3 ++-
netwerk/base/nsDownloader.cpp | 1 +
netwerk/base/nsIOService.cpp | 1 +
netwerk/base/nsIncrementalDownload.cpp | 3 +++
netwerk/base/nsNetUtil.cpp | 4 ++++
netwerk/base/nsNetUtil.h | 1 +
netwerk/base/nsProtocolProxyService.cpp | 1 +
netwerk/base/nsSecCheckWrapChannel.cpp | 2 ++
netwerk/base/nsUDPSocket.cpp | 4 +++-
netwerk/cache/nsDiskCacheBinding.cpp | 2 +-
netwerk/cache/nsDiskCacheDeviceSQL.cpp | 2 ++
netwerk/cache/nsMemoryCacheDevice.cpp | 2 +-
netwerk/cache2/CacheFileUtils.cpp | 2 ++
netwerk/cache2/CacheStorageService.h | 1 +
netwerk/ipc/NeckoParent.cpp | 1 +
netwerk/ipc/RemoteOpenFileChild.cpp | 1 +
netwerk/protocol/about/nsAboutBloat.cpp | 1 +
netwerk/protocol/about/nsAboutCacheEntry.cpp | 1 +
netwerk/protocol/about/nsAboutProtocolHandler.cpp | 1 +
netwerk/protocol/data/DataChannelParent.cpp | 1 +
netwerk/protocol/file/nsFileProtocolHandler.cpp | 1 +
netwerk/protocol/ftp/FTPChannelParent.cpp | 2 ++
netwerk/protocol/ftp/FTPChannelParent.h | 1 +
netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 1 +
netwerk/protocol/ftp/nsFtpProtocolHandler.h | 1 +
netwerk/protocol/http/Http2Compression.cpp | 1 +
netwerk/protocol/http/Http2Session.cpp | 1 +
netwerk/protocol/http/Http2Stream.h | 2 ++
netwerk/protocol/http/HttpBaseChannel.cpp | 4 ++++
netwerk/protocol/http/HttpBaseChannel.h | 1 +
netwerk/protocol/http/HttpChannelChild.cpp | 25 ++--------------------
netwerk/protocol/http/HttpChannelChild.h | 24 +++++++++++++++++++++
netwerk/protocol/http/HttpChannelParent.cpp | 1 +
netwerk/protocol/http/HttpChannelParent.h | 1 +
.../protocol/http/HttpChannelParentListener.cpp | 1 +
netwerk/protocol/http/HttpChannelParentListener.h | 1 +
netwerk/protocol/http/InterceptedChannel.cpp | 1 +
netwerk/protocol/http/NullHttpChannel.cpp | 1 +
netwerk/protocol/http/NullHttpTransaction.cpp | 1 +
netwerk/protocol/http/PackagedAppService.cpp | 14 ++++++++++--
netwerk/protocol/http/PackagedAppService.h | 4 +++-
netwerk/protocol/http/PackagedAppVerifier.cpp | 1 +
netwerk/protocol/http/nsCORSListenerProxy.cpp | 2 +-
netwerk/protocol/http/nsHttpBasicAuth.cpp | 1 +
netwerk/protocol/http/nsHttpChannel.cpp | 2 ++
netwerk/protocol/http/nsHttpChunkedDecoder.cpp | 1 +
netwerk/protocol/http/nsHttpConnectionInfo.cpp | 2 ++
netwerk/protocol/http/nsHttpConnectionMgr.cpp | 1 +
netwerk/protocol/http/nsHttpDigestAuth.cpp | 1 +
netwerk/protocol/viewsource/nsViewSourceHandler.h | 4 ++++
.../protocol/websocket/BaseWebSocketChannel.cpp | 1 +
.../websocket/WebSocketEventListenerParent.cpp | 1 +
.../protocol/websocket/WebSocketEventService.cpp | 3 +++
netwerk/protocol/websocket/WebSocketFrame.cpp | 2 ++
netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 1 +
.../protocol/wyciwyg/nsWyciwygProtocolHandler.cpp | 1 +
netwerk/streamconv/converters/mozTXTToHTMLConv.cpp | 1 +
.../streamconv/converters/nsFTPDirListingConv.cpp | 1 +
.../streamconv/converters/nsHTTPCompressConv.cpp | 2 ++
netwerk/streamconv/converters/nsHTTPCompressConv.h | 1 +
netwerk/streamconv/converters/nsIndexedToHTML.cpp | 1 +
netwerk/streamconv/converters/nsMultiMixedConv.cpp | 2 ++
netwerk/streamconv/converters/nsTXTToHTMLConv.cpp | 2 ++
netwerk/streamconv/converters/nsUnknownDecoder.cpp | 2 ++
75 files changed, 147 insertions(+), 32 deletions(-)
2016-01-08 20:20:50 -05:00
03f5630fd2
Bug 1235298 - Annotate intentional switch fallthroughs to suppress -Wimplicit-fallthrough warnings in netwerk/. r=mcmanus
2015-11-22 21:58:33 -08:00
b342baf62e
Bug 1187134 (part 1) - Replace nsBaseHashtable::Enumerate() calls in netwerk/cache{,2}/ with iterators. r=valentin.
...
--HG--
extra : rebase_source : 0955e8f7a94794d7615c3a17650908d410b52559
2015-11-29 14:01:44 -08:00
Nathan Froyd
Honza Bambas
Wes Kocher
Vedant Sareen
Tom Tromey
Joel Maher
Andrea Marchesini
Tomislav Jurin
Ehsan Akhgari
Gerald Squelart
Yoshi Huang
Umesh Panchaksharaiah
Nicholas Nethercote
Chris Peterson
Igor
Carsten "Tomcat" Book
Kyle Huey
Patrick McManus
Michal Novotny
Nathan Froyd
J. Ryan Stinnett
Bogdan Postelnicu
Aidin Gharibnavaz
Birunthan Mohanathas
Phil Ringnalda