b9191bb2ce
Bug 1646613 - Rename profiler overhead variables to include their true unit - r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D97993
2020-11-30 10:44:13 +00:00
afc3515f1c
Bug 1679631 - documentation: Upgrade the markdown dependency r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D98107
2020-11-28 17:56:16 +00:00
5079cc5b3f
Bug 1588710 - Do not fail on stack protector on some asm chromium & breakpad sandboxing code r=mhentges
...
caused:
[task 2020-11-05T10:14:26.012Z] 10:14:26 INFO - In file included from Unified_cpp_sandbox_linux2.cpp:137:
[task 2020-11-05T10:14:26.012Z] 10:14:26 ERROR - /builds/worker/checkouts/gecko/security/sandbox/chromium/sandbox/linux/seccomp-bpf/syscall.cc:369:3: error: Unable to protect inline asm that clobbers stack pointer against stack clash [-Werror,-Wstack-protector]
[task 2020-11-05T10:14:26.012Z] 10:14:26 INFO - asm volatile(
[task 2020-11-05T10:14:26.013Z] 10:14:26 INFO - ^
[task 2020-11-05T10:14:26.013Z] 10:14:26 INFO - 1 error generated.
Differential Revision: https://phabricator.services.mozilla.com/D97567
2020-11-27 10:14:01 +00:00
2c9c8170d3
Bug 1679396 - Upgrade Sphinx and update requirements r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D97994
2020-11-27 08:54:33 +00:00
b1cecbf72f
Bug 1679065 - Update dependency pylint to v2.6.0 r=linter-reviewers,marco DONTBUILD
...
Reported here: https://github.com/sylvestre/gecko-dev/pull/207/files
Differential Revision: https://phabricator.services.mozilla.com/D97896
2020-11-23 21:22:30 +00:00
41d3960fca
Bug 1679056 - Update to flake8 3.8.4.r=sylvestre
...
PR can be found here:
https://github.com/sylvestre/gecko-dev/pull/165
./mach lint -l flake8
Differential Revision: https://phabricator.services.mozilla.com/D97895
2020-11-23 20:27:21 +00:00
4a5fc87a13
Bug 1679053 - Update dependency codespell to v2 r=linter-reviewers,championshuttler,marco DONTBUILD
...
PR can be found here:
https://github.com/sylvestre/gecko-dev/pull/309
Differential Revision: https://phabricator.services.mozilla.com/D97892
2020-11-23 20:19:36 +00:00
6cc0abebf9
Bug 1679053 - Fix a typo in the doc r=linter-reviewers,championshuttler,marco DONTBUILD
...
Fix with:
$ ./mach lint -l codespell --fix
Differential Revision: https://phabricator.services.mozilla.com/D97891
2020-11-23 20:19:28 +00:00
97196a2329
Bug 1679054 - Update dependency sphinx-copybutton to v0.3.1 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Reported here:
https://github.com/sylvestre/gecko-dev/pull/227
Differential Revision: https://phabricator.services.mozilla.com/D97893
2020-11-23 20:04:24 +00:00
dd80614fa0
Bug 1678062 - Remove unnecessary includes. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D97467
Depends on D96561
2020-11-23 16:12:02 +00:00
2499964dc8
Bug 1676361 - Clean up profiler includes. r=gerald
...
Differential Revision: https://phabricator.services.mozilla.com/D96539
Depends on D96538
2020-11-23 16:09:13 +00:00
ae75be244a
Bug 1677466 - Split Endpoint.h and ProtocolMessageUtils.h from ProtocolUtils.h. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D93568
Depends on D93567
2020-11-23 16:06:42 +00:00
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
ecaaa56bed
Bug 1641000 - Fix linting error on buffer.rst r=lint-fix
2020-11-20 21:38:21 +02:00
dbae6744d9
Bug 1641000 - Start documenting the Gecko Profiler; r=gerald
...
This patch represents joint authoriship by Greg Tatum and Gerald Squelart.
This is a work in progress start to documenting the Gecko Profiler. We
collaborated on this on GitHub.
https://github.com/gregtatum/gecko-dev/tree/profiler-docs/tools/profiler/docs
Differential Revision: https://phabricator.services.mozilla.com/D97655
2020-11-20 18:55:26 +00:00
0d164d3a9f
Bug 1674476 - ChromeUtils.addProfilerMarker should support capturing a stack or setting the category, r=gerald,gregtatum.
...
Differential Revision: https://phabricator.services.mozilla.com/D95406
2020-11-20 15:41:16 +00:00
a56d00ddb7
Bug 1678159 - Move WritePropertyTime to SpliceableJSONWriter::TimeProperty - r=gregtatum
...
TimeStamps in markers must now be streamed through `SpliceableJSONWriter::TimeProperty(name, timestamp)`.
This is consistent with all other JSON-writing functions being in `SpliceableJSONWriter` (and base class `JSONWriter`).
Depends on D97556
Differential Revision: https://phabricator.services.mozilla.com/D97557
2020-11-20 02:23:08 +00:00
7c60972925
Bug 1678181 - Output chartLabel and tableLabel in marker schema - r=gregtatum
...
Depends on D97555
Differential Revision: https://phabricator.services.mozilla.com/D97556
2020-11-20 02:19:57 +00:00
202a726127
Bug 1678181 - Add thorough tests for custom marker definitions - r=gregtatum
...
This adds tests for custom marker types, exercizing most streaming and schema functions.
Depends on D96971
Differential Revision: https://phabricator.services.mozilla.com/D97555
2020-11-20 02:18:53 +00:00
4e01a769dc
Bug 1678466 - Speed up converter.py when processing a big set of changes. r=jrmuizel
...
If a changeset has multiple parents, and those parents get pruned away
such that the changeset ends up with identical parents, we now collapse
those parents into a single parent. This avoids unnecessary recursion
and repetition of work. Generally this is only a problem when processing
a large number of changesets, as the recursion will be exponential with
the depth of the tree, and small numbers of changesets generally have
shallow trees.
Differential Revision: https://phabricator.services.mozilla.com/D97683
2020-11-19 22:26:35 +00:00
a6033eb204
Bug 1678070 - mozlint/license: remove .hg from the exclude list r#linter-reviewers, hsivonen r=linter-reviewers,ahal DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D97484
2020-11-19 15:57:15 +00:00
43412d8254
Bug 1676130 - part 2: Let `mach try release` overwrite the content of build/defines.sh r=jcristau
...
Differential Revision: https://phabricator.services.mozilla.com/D96410
2020-11-19 13:28:58 +00:00
11a06b90fa
Bug 1671403 - Also prevent re-entrant operations when a mutex is locked in the ProfilerParent - r=canaltinova
...
Expand `profiler_is_locked_on_current_thread()` to also return true if the ProfileBufferGlobalController mutex is locked on the current thread.
This will prevent some profiler-re-entrant operations (like native allocation markers) from running.
In particular, this removes potential deadlocks similar to the one found in bug 1671403:
- SamplerThread: In the sampling loop, lock the main profiler mutex, run a local update, which attempts to lock the ProfileBufferGlobalController mutex.
- ProfilerChild thread: While processing an IPC message with an update, lock the ProfileBufferGlobalController mutex, then resolve the update, which records a native allocation with a backtrace that attempts to lock the main profiler mutex.
With this patch, the native allocation won't record a marker while the ProfileBufferGlobalController mutex is locked.
Differential Revision: https://phabricator.services.mozilla.com/D96970
2020-11-19 11:48:14 +00:00
d225beb0eb
Bug 1671403 - Also prevent re-entrant operations when the ProfilerChild mutex is locked on the current thread - r=canaltinova
...
Expand `profiler_is_locked_on_current_thread()` to also return true if the ProfilerChild mutex is locked on the current thread.
This will prevent some profiler-re-entrant operations (like native allocation markers) from running.
In particular, this removes the potential deadlock found in bug 1671403:
- SamplerThread: In the sampling loop, lock the main profiler mutex, run a ProfilerChild update, which attempts to lock the ProfilerChild mutex.
- ProfilerChild thread: While processing an IPC message with an update, lock the ProfilerChild mutex, then resolve the update, which records a native allocation with a backtrace that attempts to lock the main profiler mutex.
With this patch, the native allocation won't record a marker while the ProfilerChild mutex is locked.
Differential Revision: https://phabricator.services.mozilla.com/D96969
2020-11-19 11:47:46 +00:00
73e2871fa8
Bug 1525737 - Remove layout/xul/grid directory. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D53296
2020-11-17 01:20:33 +00:00
8b72e2eb8d
Bug 1677868 - Rename "Java Main Thread" to "AndroidUI (Java)" in the profiler. r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D97378
2020-11-18 23:15:27 +00:00
c27bc89bad
Bug 1666566 - Bump Gecko profile version to 22, to use marker schema - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96684
2020-11-18 21:57:15 +00:00
b3314a1582
Bug 1675409 - Removed now-unused ProfilerMarkerPayload and all dependencies - r=gregtatum,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D96054
2020-11-18 21:56:57 +00:00
a10f7166db
Bug 1675409 - Migrated TracingMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96053
2020-11-18 21:55:51 +00:00
cc0abcfaee
Bug 1675409 - Migrated TextMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96052
2020-11-18 21:54:13 +00:00
8ed348d0c7
Bug 1675409 - Migrated UserTimingMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96051
2020-11-18 21:53:09 +00:00
bfc0fb9f6d
Bug 1675409 - Migrated IPCMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96050
2020-11-18 21:52:41 +00:00
1a240b02aa
Bug 1675409 - Migrated NativeAllocationMarkerPayload to Markers 2.0 API - r=gregtatum
...
Because it's easy to send markers to the main thread, we don't need to store the main thread id in memory_hooks functions and objects.
Differential Revision: https://phabricator.services.mozilla.com/D96049
2020-11-18 21:52:07 +00:00
01b81bd553
Bug 1675409 - Migrated JsAllocationMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96048
2020-11-18 21:51:29 +00:00
423c352bcc
Bug 1675409 - Migrated GC markers to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96046
2020-11-18 21:50:43 +00:00
42eb92f290
Bug 1675409 - Migrated ScreenshotPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96044
2020-11-18 21:50:15 +00:00
c3d6e979a5
Bug 1675409 - Migrated MediaSampleMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96043
2020-11-18 21:49:52 +00:00
fea07678c1
Bug 1675409 - Migrated ContentBuildPayload and ContentFullPaintPayload to Markers 2.0 API - r=gregtatum
...
In this case, the same marker type "CONTENT_FULL_PAINT_TIME" is used in separate places, so it makes sense to put the marker type definition in a common location.
Differential Revision: https://phabricator.services.mozilla.com/D96042
2020-11-18 21:49:50 +00:00
6e65d94961
Bug 1675409 - Migrated NetworkMarkerPayload to Markers 2.0 API - r=gregtatum,necko-reviewers,julienw
...
While migrating, profiler_add_network_marker was optimized to avoid some string allocations.
Differential Revision: https://phabricator.services.mozilla.com/D96040
2020-11-18 21:48:17 +00:00
4d9cfb4113
Bug 1675409 - Migrated LogMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96039
2020-11-18 21:47:24 +00:00
46fed8e10f
Bug 1675409 - Migrated LongTaskMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96038
2020-11-18 21:46:56 +00:00
4d44faceb9
Bug 1675409 - Migrated StyleMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96037
2020-11-18 21:46:23 +00:00
237baa429c
Bug 1675409 - Migrated HangMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96036
2020-11-18 21:45:54 +00:00
3a35222f5f
Bug 1675409 - Migrated VsyncMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96035
2020-11-18 21:45:21 +00:00
e172777c88
Bug 1675409 - Migrated LayerTranslationMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96033
2020-11-18 21:44:53 +00:00
3c5d417916
Bug 1675409 - Migrated PrefMarkerPayload to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96031
2020-11-18 21:44:18 +00:00
67510d8def
Bug 1675409 - Migrated (media) Budget to Markers 2.0 API - r=gregtatum
...
Differential Revision: https://phabricator.services.mozilla.com/D96030
2020-11-18 21:43:50 +00:00
efd002addd
Backed out 2 changesets (bug 1677396, bug 1677868) for perma failures on browser_startup_syncIPC.js. CLOSED TREE
...
Backed out changeset e43e56bfbfc6 (bug 1677396)
Backed out changeset 0ecfa354c74c (bug 1677868)
2020-11-19 01:03:25 +02:00
a121e8f0c7
Bug 1677868 - Rename "Java Main Thread" to "AndroidUI (Java)" in the profiler. r=canaltinova
...
Differential Revision: https://phabricator.services.mozilla.com/D97378
2020-11-18 21:01:46 +00:00
244eb9e36c
Backed out changeset 2fd8d2e0ae94 (bug 1666566) as per Gerald's request. CLOSED TREE
2020-11-18 22:05:59 +02:00
Gerald Squelart
Zac Svoboda
Sylvestre Ledru
Renovate Bot
championshuttler
Simon Giesecke
smolnar
Greg Tatum
Florian Quèze
Kartikaya Gupta
Johan Lorenzo
Tim Nguyen
Markus Stange
Razvan Maries