b7bb398730
Bug 1516454 - Use rust lengths for border corners. r=boris
...
The test in https://github.com/web-platform-tests/wpt/pull/15423 hasn't been
synced over yet, but it passes with this patch of course.
Differential Revision: https://phabricator.services.mozilla.com/D20960
2019-02-26 06:01:34 -08:00
a499294d09
Backed out 4 changesets (bug 1516454, bug 1530247) for multiple failures on Linux x64 asan. CLOSED TREE
...
Backed out changeset 180c7672c57c (bug 1516454)
Backed out changeset a460a4d0a66c (bug 1516454)
Backed out changeset c6ab8d3dd19a (bug 1530247)
Backed out changeset 43862dc87e0b (bug 1516454)
2019-02-26 00:49:27 +02:00
b411b3894d
Bug 1516454 - Use rust lengths for border corners. r=boris
...
The test in https://github.com/web-platform-tests/wpt/pull/15423 hasn't been
synced over yet, but it passes with this patch of course.
Differential Revision: https://phabricator.services.mozilla.com/D20960
2019-02-25 12:42:31 -08:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
40b1e83d81
Bug 1498734 - Always compute angle values to degrees. r=xidorn
...
This matches the spec, https://drafts.csswg.org/css-values/#angles , which says:
> All <angle> units are compatible, and deg is their canonical unit.
And https://drafts.csswg.org/css-values/#compat , which says:
>When serializing computed values [...], compatible units [...] are converted into a single canonical unit.
And also other implementations (Blink always serializes angles as degrees in
computed style for example).
Also allows us to get rid of quite a bit of code, and makes computed angle value
representation just a number, which is nice.
Differential Revision: https://phabricator.services.mozilla.com/D8619
--HG--
extra : moz-landing-system : lando
2018-10-13 00:41:03 +00:00
2afd829d0f
Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
...
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
dc7e13b5d5
Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. r=heycam
...
MozReview-Commit-ID: GLLseBxhUiP
--HG--
extra : rebase_source : 2940610dbb5e81e463db82459a46a54eb693e5cb
2017-11-20 14:05:19 +08:00
320b123d4b
Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. r=heycam
...
MozReview-Commit-ID: LFxZGzyyii6
--HG--
extra : rebase_source : 516a8ed1a372d483f4c96cd392c1d382b0b4e38a
2017-11-20 13:30:27 +08:00
680815cd6e
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
740fbc891f
Bug 1378000 - Remove nsStyleCoord::HashValue(); r=bholley
...
This method is dead code.
2017-07-03 21:55:18 -04:00
e43e63e3a7
Bug 1331102 - Move #include around to avoid triggering this issue. r=heycam
...
MozReview-Commit-ID: Fx2DbUwuf0v
--HG--
extra : rebase_source : 01625a1fb08bd5fe06a7095314cc093c37f89a17
2017-02-21 22:27:58 +11:00
53633b1c42
Bug 1320014 Part 14 - Convert NS_SIDE_TO_HALF_CORNER to a constexpr function. r=mats
...
MozReview-Commit-ID: 4MQu8omCdcg
--HG--
extra : rebase_source : 0bce3eb380c2bacd5a4576e1a57c96afb8b57160
2017-01-05 16:23:16 +08:00
9a76c43bf0
Bug 1320014 Part 13 - Convert NS_SIDE_TO_FULL_CORNER to a constexpr function. r=mats
...
MozReview-Commit-ID: 4r4jEN2LklH
--HG--
extra : rebase_source : 8a60bbb322f586af1a859b9408b10685169913e7
2017-01-05 16:13:34 +08:00
78cc3f541d
Bug 1320014 Part 12 - Convert NS_SIDE_IS_VERTICAL to a constexpr function. r=mats
...
MozReview-Commit-ID: GFdigJKppuR
--HG--
extra : rebase_source : d3a66d22d99d2988d5c3c44bc1da51e30efa8d1a
2017-01-05 16:07:02 +08:00
160ed71c4e
Bug 1320014 Part 11 - Convert NS_FULL_TO_HALF_CORNER to a constexpr function. r=mats
...
Because the new function checks types, we need to change the fullCorner type
in nsComputedDOMStyle::GetEllipseRadii() and
StyleAnimationValue::ExtractComputedValue() from uint8_t to |Corner| to fix
build error.
MozReview-Commit-ID: 5NuFE3yA2QD
--HG--
extra : rebase_source : 8f94209b24bd909839358cd502f462edb9ce3116
2017-01-05 14:59:17 +08:00
cf828e1584
Bug 1320014 Part 10 - Convert NS_HALF_TO_FULL_CORNER to a constexpr function. r=mats
...
MozReview-Commit-ID: 1PECc7hm249
--HG--
extra : rebase_source : 7784720bb9ae061689cba0b30c0aebc779d818b1
2017-01-05 14:39:58 +08:00
229d433359
Bug 1320014 Part 9 - Convert NS_HALF_CORNER_IS_X to a constexpr function. r=mats
...
MozReview-Commit-ID: 3d2opSIjAUc
--HG--
extra : rebase_source : 03e55f0458dd305fa782ca1e46c32069045e86e9
2017-01-05 14:30:14 +08:00
797609894a
Bug 1320014 Part 7 - Convert half corner indices #define to an enum. r=mats
...
MozReview-Commit-ID: 8lNtjV14WTN
--HG--
extra : rebase_source : dbfa992a2ee3cab2f639fb5a68463a673410ade6
2017-01-05 11:31:38 +08:00
2dada2d6e0
Bug 1320014 Part 6 - Remove #define NS_CORNER_[TOP_LEFT/TOP_RIGHT/BOTTOM_RIGHT/BOTTOM_LEFT] r=mats
...
MozReview-Commit-ID: ERAwdxKZPf7
--HG--
extra : rebase_source : 53eb8d15ecd0d9d8fd0c7b88872b210b54104725
2017-01-04 18:15:30 +08:00
14dede68ec
Bug 1321495 part 2: Add needed "using namespace" declarations to several .cpp files in layout/style, to preemptively fix unified-build bustage. r=TYLin
...
MozReview-Commit-ID: 5p6DhiZ5YFg
--HG--
extra : rebase_source : 17a90dbe63af0b4e3a7c29881336fc31fbaf726d
2016-12-01 10:37:44 -08:00
754b6c9659
Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats
...
This patch was written with the help of the following script. Also, manually
add mozilla qualifier to the enum values in nsStyleCoord.h, gfxRect.h, and
Types.h to make it build.
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "NS_SIDE_TOP" "eSideTop"
rename "NS_SIDE_RIGHT" "eSideRight"
rename "NS_SIDE_BOTTOM" "eSideBottom"
rename "NS_SIDE_LEFT" "eSideLeft"
MozReview-Commit-ID: 9T0ORsqM6nP
--HG--
extra : rebase_source : 884ad96104c6e9cf6c8b3145d2d3a071ecccfe6a
2016-11-18 18:12:25 +08:00
242708cf72
Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
...
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
2015-02-09 14:34:50 -08:00
d3826daa16
Back out Bug 1127201 (part 2) for various problems.
2015-02-06 15:04:32 -08:00
d34f0301b8
Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
...
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
2015-02-04 20:05:36 -08:00
891ddf7cb3
Bug 948265 - Add CSS hue-rotate filter to nsCSSFilterInstance. r=mstange,dbaron
2014-08-20 15:46:59 -07:00
5a3e19e62c
Bug 1026344 - Part 4: Make nsStyleCoord::Calc refcounted and introduce a non-refcounted nsStyleCoord::CalcValue. r=dbaron
...
This means that style structs holding computed calc() values are now able to be
stored in the rule tree.
2014-06-19 13:18:03 +10:00
12935dcb17
Bug 976787 part 1: Add the grid-template-{columns,rows} properties to the style system. r=dholbert
2014-03-10 15:54:13 -07:00
2824b29025
Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
...
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:
# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.mm" \) | \
xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
modules/libmar/src/mar_private.h \
modules/libmar/src/mar.h
# assert_replacer.py
#!/usr/bin/python
import sys
import re
pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")
def replaceInPlace(fname):
print fname
f = open(fname, "rw+")
lines = f.readlines()
for i in range(0, len(lines)):
while True:
index = re.search(pattern, lines[i])
if index != None:
index = index.start()
lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
for j in range(i + 1, len(lines)):
if lines[j].find(" ", index) == index:
lines[j] = lines[j][0:index] + lines[j][index+4:]
else:
break
else:
break
f.seek(0, 0)
f.truncate()
f.write("".join(lines))
f.close()
argc = len(sys.argv)
for i in range(1, argc):
replaceInPlace(sys.argv[i])
--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00
3250bd906e
[Bug 847110] Fix up includes in layout/style r=dbaron
2013-03-02 19:31:48 -05:00
2ff8ad5b57
Bug 761393 - Add a method to hash an nsStyleCoord. r=dbaron
2012-08-26 21:08:32 -07:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
d6d762688c
Bug 779010 - Use nsStyleCoord equality operator to compare nsStyleSides and nsStyleCorners. r=dbaron
2012-07-30 19:25:28 -07:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
a252d1e95b
Depend on assignment and copy construction of unions in nsStyleCoord. (Bug 730240) r=bzbarsky
2012-02-24 21:23:14 -08:00
f4fb4a1991
Bug 729142 - Convert layout/style to MOZ_STATIC_ASSERT. r=dbaron
2012-02-23 08:19:00 -08:00
e0c4316236
Bug 716628. Implement support for 'turn' unit in CSS. r=dbaron
2012-02-04 00:01:23 -05:00
92064e6d3f
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
3d7d18c200
Simplify storage of computed calc() as a result of removing min() and max(). (Bug 363249) r=bzbarsky a2.0=blocking2.0:beta6
2010-09-11 09:27:13 -07:00
8e923adf2c
Remove support for min() and max() in calc(): remove support for parsing and storage. (Bug 363249) r=bzbarsky a2.0=blocking2.0:beta6
2010-09-11 09:27:12 -07:00
089f0fbb38
Make nsStyleCoord::operator== check deep equality of calc() expressions rather than just doing pointer comparison. (Bug 585715) r=bzbarsky a2.0=blocking+
2010-08-31 12:05:12 -04:00
2a023744e6
Add support for calc() to the 'width' property. (Bug 585715) r=bzbarsky a2.0=blocking2.0+
2010-08-11 12:32:53 -07:00
2d6d3fc9eb
Add storage for calc() expressions to nsStyleCoord. (Bug 363249) r=bzbarsky
2010-07-02 21:18:55 -07:00
fbdc2c3138
Add nsStyleCoord::Array type. (Bug 363249) r=bzbarsky
2010-07-02 21:18:55 -07:00
f67d8257ba
Get rid of (void) C-isms in nsStyleCoord. (Bug 363249) r=bzbarsky
2010-05-11 08:49:44 -07:00
5c26b37323
Bug 513395: Implement revised CSS gradient notation (1/2): parser and data structure changes
2009-11-02 11:36:43 -08:00
8461beec27
Switch nsStyleAnimation from using nsStyleCoord to using its own nsStyleAnimation::Value, so we don't have to add nontrivial destructors to nsStyleCoord. (Bug 522852) r=dholbert,bzbarsky
2009-10-20 07:46:16 -04:00
a24f436459
Better disambiguate nsStyleCoord constructors taking nscoord and nscolor. (Bug 521352) r=bzbarsky
2009-10-13 19:38:20 -07:00
176ee39664
Bug 474049: Add support for SMIL animation of CSS properties in SVG. r=birtles sr=roc
2009-10-02 14:37:25 -07:00
587ac05e42
Add support for color values to nsStyleCoord so nsStyleAnimation can animate colors. (Bug 504652) r=bzbarsky
2009-09-11 06:46:36 -04:00
Emilio Cobos Álvarez
Cosmin Sabou
Sylvestre Ledru
Chris Peterson
Ting-Yu Lin
Daniel Holbert
Ehsan Akhgari
Xidorn Quan
Nicholas Nethercote
Andrew McCreight
Max Vujovic
Cameron McCormack
Simon Sapin
David Zbarsky
Paul Adenot
Matt Woodrow
Gervase Markham
L. David Baron
Zack Weinberg
Boris Zbarsky
Michael Wu
Zack Weinberg ext:(%2C%20Ms2ger%20%3Cms2ger%40gmail.com%3E)