That variable, and the function that references it is only used by the openh264
code, so move it there.
Differential Revision: https://phabricator.services.mozilla.com/D9967
--HG--
extra : moz-landing-system : lando
Taskcluster knows where mozharness generates the logs, and can upload them from
there. Thus, mozharness no longer needs to copy the logs to a new directory.
Differential Revision: https://phabricator.services.mozilla.com/D9966
--HG--
extra : moz-landing-system : lando
Upgrade from optparse to argparse:
1. 'type' field now needs to be callable (deleted if type was 'string' as that is the default)
2. 'extend' action re-implemented for argparse
3. 'callback' action no longer exists, re-implemented as a custom argparse action (only used in buildbase.py)
4. minor api changes, e.g 'add_option' -> 'add_argument'
MozReview-Commit-ID: HcKowF13Da3
--HG--
extra : rebase_source : e5e8160d91263fb273f790dbda5e2c2b2e02eaf6
We use `hg init` to create the directory. Because this is what
typically occurs.
We also remove the disabling of "dotencode" in the hgrc. This was added
in https://hg.mozilla.org/build/mozharness/rev/b1dbc0f56ff8 (bug 857853)
for reasons that are unclear to me. We should never disable dotencode
because it may make some repositories not clonable on Windows
filesystems.
Disabling dotencode will also interfere with the latest version of
robustcheckout, which requires its presence.
MozReview-Commit-ID: 35qBsgwp0uW
--HG--
extra : rebase_source : b786fb38f6b09da9614ac40f5de8231b8305bf5d
Tests based on this code fail in Mercurial 3.8+ due to `hg rebase`
changing its behavior for selecting default revisions. I was going
to update the code to work with 3.8+. However, I could find no actual
consumers of this method! Annotate says this was added back in
mozharness 0.4. However, I can't find a reason for it being added.
Nor can I find any consumers of this method in the mozharness repo
outside the tests. This smells like dead code to me.
MozReview-Commit-ID: 3Q6MTjQJT1p
--HG--
extra : rebase_source : 2c488b70136bc9856f6075297d7c32e3b69079ad
Instead of downloading a file first and then unpacking it, we would like to
fetch it into memory and then unpacking directly from there.
This saves writing the file first to disk, thus, saving on IO.
MozReview-Commit-ID: JdNGnxIYEvy
--HG--
extra : rebase_source : 73c280fd23f3066d04dd3af07ac443db77dfd6d0
Get rid of external unpack tools (unzip and tar) and use the Python internal classes instead.
This patch only changes this behavior for the base script class but not for custom code in other
test scripts and modules, which would make it too complex. A follow-up bug will be filed instead.
MozReview-Commit-ID: L0eoITlqTdC
--HG--
extra : rebase_source : c8bb3447bece192d6d8cbf3f505f840ec2843112
Get rid of external unpack tools (unzip and tar) and use the Python internal classes instead.
This patch only changes this behavior for the base script class but not for custom code in other
test scripts and modules, which would make it too complex. A follow-up bug will be filed instead.
MozReview-Commit-ID: L0eoITlqTdC
--HG--
extra : rebase_source : 3cda5a442ea25f1098949b7c1a80428188355e7a
Get rid of external unpack tools (unzip and tar) and use the Python internal classes instead.
This patch only changes this behavior for the base script class but not for custom code in other
test scripts and modules, which would make it too complex. A follow-up bug will be filed instead.
MozReview-Commit-ID: L0eoITlqTdC
--HG--
extra : rebase_source : 5c9f04c29eddea09f2bbac18d9fc491671b1ccdf
Functionality for doing an optimal clone/pull+share+purge+update is now
implemented in the robustcheckout extension so it can be implemented in one
place and used by all the various tools needing to perform a "robust"
checkout using optimal practices.
This commit switches the MercurialVCS to use it.
Functionality for interfacing with shared repos and associated tests have
been removed because this is all implemented and tested in robustcheckout.
Various other tests have also been removed because they are redundant with
tests in the robustcheckout extension.
MozReview-Commit-ID: FGvmSHKM5e0
--HG--
extra : rebase_source : 8f31a1e79d448478fa63b17582313409ac06fe69
extra : histedit_source : 3031dd8f83b0c64abc110252fd270f1917168663
The code for ensure_repo_and_revision() has been completely overhauled.
We now require shared repos using auto pooled storage via the share
extension. This ensures that only a single copy of a logical
repository's history is stored on disk. e.g. if you clone
mozilla-central, inbound, and try, they'll all automatically share the
same storage.
The new code ensures the destination repo is using modern conventions
and will delete the destination repo if it isn't. So once this gets
deployed to production, machines will slowly start using optimal
storage. This should make VCS operations significantly faster.
Another optimization that is now in here is we check for presence of the
wanted revision before doing `hg pull`. This saves some communication
with the server if the revision is already present locally.
This change effectively requires a modern version of Mercurial to be
installed to run ensure_repo_and_revision(). Since Mercurial <3.7.3 has
security vulnerabilities, we shouldn't be running <3.7.3 in automation.
So I think this will be OK. If not, it will certainly be easy to
identify which machines aren't updated!
MozReview-Commit-ID: 62jtAsDj7rU
--HG--
extra : rebase_source : a43d7f54b16e71940e45ddf05402449575fccfee
Tom Prince
Chris AtLee
Sebastian Hengst
Andrew Halberstadt
Axel Hecht
Gregory Szorc
Richard Barnes
Armen Zambrano Gasparnian
Henrik Skupin
Wes Kocher
Carsten "Tomcat" Book
Rail Aliiev
Julien Pagès
Aki Sasaki
Mike Shal
Jordan Lund