Notes:
* NS_Atomize never returns null, so this patch removes a null check on its
return value.
* There's no need for the |atom| local variable and for our swap() call on it.
It's equivalent and simpler for us to just directly assign mWatchID, rather
than to use this disposable local variable.
Differential Revision: https://phabricator.services.mozilla.com/D4394
--HG--
extra : moz-landing-system : lando
This is a regression from bug 1450250, which removed a if (!GetCx()) early
return in this function.
That early return was wrong, both because it prevented elements that were in
shadow trees from targeting other elements, but also because that check was not
present in AfterSetAttr, which means that dynamic updates to the attribute would
work.
Pass the SVGAnimationElement itself to resolve references. That's what we do for
attribute mutations, and also it's the same behavior we have, since the ID
lookup IDTracker does only depends on containing shadow root and containing
document, and that's invariant between a kid and it's DOM parent.
Some other code has been updated to take references instead of pointers so the
null-safety of those methods is explicit.
Differential Revision: https://phabricator.services.mozilla.com/D4349
--HG--
extra : moz-landing-system : lando
(Path is actually r=froydnj.)
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.
MozReview-Commit-ID: 91U22X2NydP
--HG--
rename : xpcom/ds/nsIAtom.h => xpcom/ds/nsAtom.h
extra : rebase_source : ac3e904a21b8b48e74534fff964f1623ee937c67
Thomas Nguyen
Daniel Holbert
Emilio Cobos Álvarez
Narcis Beleuzu
Noemi Erli
Boris Zbarsky
Adrian Wielgosik
Nicholas Nethercote
Wes Kocher
Jonathan Watt
Sebastian Hengst