This patch was heavily inspired by the existing 7z customizations that read the download token into the "postSigningData" file. In both cases, the installation self-extractor copies some data into the same temporary directory where the installer is written. It will then be up to the NSIS installer to copy that file into the installation directory (that work will be done later in this stack).
This patch also includes changes to some files that were regenerated based on the code changes made.
- `mozilla_customizations.diff` was updated so that it still reflects all Mozilla-made code changes to 7z.
- The `7zSD.ARM64.sfx` and `7zSD.Win32.sfx` executables were re-built from the new code.
- `SFXSetup.vcxproj` was updated to use newer toolchains.
Differential Revision: https://phabricator.services.mozilla.com/D171109
I wanted to figure out how to re-generate `mozilla_customizations.diff` in a way that matched the way that it was originally created. This is so that (a) I could ensure that I was starting with a clean slate and that the current `mozilla_customizations.diff` matched the existing changes to `other-licenses/7zstub/src` and (b) when I regenerated `mozilla_customizations.diff` after making further changes to it, the patch of the diff changes would be at least somewhat readable rather than being a huge mess.
Some aspects of regenerating it created changes that I think are appropriate (ex: the full path to the user directory being present in the diff'ed file names). There were also some changes that I just couldn't figure out how to avoid (ex: the length of the function name context line). I'm not sure what diff utility was originally used, but I'm hoping that documenting how I generated it this time will allow it to be generated consistently in the future. And this commit should bring it in line with that consistency.
Differential Revision: https://phabricator.services.mozilla.com/D171108
This relation isn't part of the ATK and IA2 specs.
In ATK and the older way of retrieving relations in IA2, we have to calculate all relations.
Since LINKS_TO can be slow and it isn't supported by ATK and IA2 anyway, let's just not expose it at all for them.
Differential Revision: https://phabricator.services.mozilla.com/D161775
This relation isn't part of the ATK and IA2 specs.
In ATK and the older way of retrieving relations in IA2, we have to calculate all relations.
Since LINKS_TO can be slow and it isn't supported by ATK and IA2 anyway, let's just not expose it at all for them.
Differential Revision: https://phabricator.services.mozilla.com/D161775
This relation isn't part of the ATK and IA2 specs.
In ATK and the older way of retrieving relations in IA2, we have to calculate all relations.
Since LINKS_TO can be slow and it isn't supported by ATK and IA2 anyway, let's just not expose it at all for them.
Differential Revision: https://phabricator.services.mozilla.com/D161775
This patch starts pinning Firefox to the Taskbar by default on all supported Windows versions. The main addition here is a port of our existing taskbar pinning code for modern Windows 10 & 11 versions to an NSIS plugin (compiled version also included).
After discussion with a few stakeholders, we also decided that we will never pin during an update on Windows 10 or 11. (Arguably we could stop on Windows 7 & 8 as well - but I don't really see any harm in carrying forward our pre-existing behaviour there.) With this in mind, I dropped all the second pinning attempt code (which was only ever enabled for Windows 10).
Differential Revision: https://phabricator.services.mozilla.com/D148288
This patch starts pinning Firefox to the Taskbar by default on all supported Windows versions. The main addition here is a port of our existing taskbar pinning code for modern Windows 10 & 11 versions to an NSIS plugin (compiled version also included).
After discussion with a few stakeholders, we also decided that we will never pin during an update on Windows 10 or 11. (Arguably we could stop on Windows 7 & 8 as well - but I don't really see any harm in carrying forward our pre-existing behaviour there.) With this in mind, I dropped all the second pinning attempt code (which was only ever enabled for Windows 10).
Differential Revision: https://phabricator.services.mozilla.com/D148288
This patch starts pinning Firefox to the Taskbar by default on all supported Windows versions. The main addition here is a port of our existing taskbar pinning code for modern Windows 10 & 11 versions to an NSIS plugin (compiled version also included).
After discussion with a few stakeholders, we also decided that we will never pin during an update on Windows 10 or 11. (Arguably we could stop on Windows 7 & 8 as well - but I don't really see any harm in carrying forward our pre-existing behaviour there.) With this in mind, I dropped all the second pinning attempt code (which was only ever enabled for Windows 10).
Differential Revision: https://phabricator.services.mozilla.com/D148288
Automatically generated path that adds flag `REQUIRES_UNIFIED_BUILD = True` to `moz.build`
when the module governed by the build config file is not buildable outside on the unified environment.
This needs to be done in order to have a hybrid build system that adds the possibility of combing
unified build components with ones that are built outside of the unified eco system.
Differential Revision: https://phabricator.services.mozilla.com/D122345
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
BitsUtils.cpp only references MOZ_MUST_USE in a comment about forking a copy of mozilla::ScopeExit to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE from mfbt/Attributes.h). [[nodiscard]] doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE.
Differential Revision: https://phabricator.services.mozilla.com/D89296
The license used to be LGPL so the code lived in other-licenses, but it was changed to BSD eleven years ago. Let's move it over to third_party/python/ply where it belongs.
./mach vendor python ply==3.10
`diff -r` between the original `ply` directory and the new one only comes up with the new file `third_party/python/ply/CHANGES` which isn't relevant to the functionality of the code, so this should be a no-op all told.
Differential Revision: https://phabricator.services.mozilla.com/D73341
This is all the code and build files for an NSIS plugin that enables
rendering a web page as the content of an NSIS dialog.
Documentation and the compiled binary are in later commits in this series.
Depends on D56576
Differential Revision: https://phabricator.services.mozilla.com/D56577
Minify this file by removing the dialogs we don't need and hiding all the
unnecessary controls in the one we do need, so the stub installer code
doesn't have to do that manually (I would have removed those controls
altogether, but the NSIS compiler errors out if you do that).
The dialog resources were edited directly in-place using
Resource Hacker <http://angusj.com/resourcehacker/>.
Differential Revision: https://phabricator.services.mozilla.com/D56576
The changes made to CityHash are no longer necessary with mingw-clang, so we
can revert them to the original upstream implementation.
Differential Revision: https://phabricator.services.mozilla.com/D56991
--HG--
extra : moz-landing-system : lando
This patch includes:
* The new icon file itself
* A modified Win32 SFX binary with the icon resource replaced and no other changes
* A rebuilt ARM64 binary (because rebuilding it is just as easy as resource hacking it)
* And I also took the opportunity to update the VC project to the 2019 toolchain
and removed the requirement for a particular Windows 10 SDK version.
Differential Revision: https://phabricator.services.mozilla.com/D46846
--HG--
extra : moz-landing-system : lando
Also reduce the timeout for terminating the thread to 5 seconds, because 10
seconds is too long to be completely hanging the UI.
Differential Revision: https://phabricator.services.mozilla.com/D33844
--HG--
extra : moz-landing-system : lando
Robin Steuber
Sylvestre Ledru
James Teh
Butkovits Atila
Marian-Vasile Laza
Ryan VanderMeulen
Ben Hearsum
Cristian Tuns
smolnar
Mike Hommey
Andi-Bogdan Postelnicu
Morgan Reschenberg
Emilio Cobos Álvarez
Petr Sumbera
ssengupta
Adam Gashlin
Chris Peterson
Ricky Stewart
Molly Howell
Kristen Wright
Chris Fronk
shindli
Marco Zehe
Csoregi Natalia
Tom Ritter
Tom Prince
Daniel Varga
Oana Pop Rus
Samuel Thibault