0700ed831b
Bug 1626362 - Don't forward loads to DocumentLoadListener if nsDocumentOpenInfo returned a failure, since doing so would lose the error code. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D79409
2020-06-25 04:33:46 +00:00
6a2048cf42
Bug 1626362 - Let DocumentLoadListener determine if docshell will display content (from the channel or from loading an error page), and only allow switching to a new process if so. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80111
2020-06-25 04:33:27 +00:00
8fa4e5c092
Bug 1626362 - Make mOriginalUriString available in DocumentLoadListener and docshell. r=nika,necko-reviewers,valentin
...
This also fixes a bug where we were setting mOriginalUriString in docshell before InternalLoad (which clears it), instead of after.
Differential Revision: https://phabricator.services.mozilla.com/D80110
2020-06-25 04:33:14 +00:00
19c4b43cba
Bug 1626362 - Move url classifier notifications to parent process. r=nika,necko-reviewers,JuniorHsu
...
We shouldn't need to handle this with an early return in docshell, since the classifier failure codes won't display an error page anyway.
Differential Revision: https://phabricator.services.mozilla.com/D80108
2020-06-25 04:32:28 +00:00
e7b1c3e32f
Bug 1647307 - Simplify SessionHistoryInfo ID handling, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D80553
2020-06-25 16:20:32 +00:00
6d4dc7f680
Backed out 13 changesets (bug 1633935) as requested by Junior. CLOSED TREE
...
Backed out changeset 398fc19f5f6a (bug 1633935)
Backed out changeset 25822279ba5b (bug 1633935)
Backed out changeset e87b11c172b9 (bug 1633935)
Backed out changeset 709f8d50aa33 (bug 1633935)
Backed out changeset 3b268ac50692 (bug 1633935)
Backed out changeset ac9c5c1e5162 (bug 1633935)
Backed out changeset 292a5b34e9f7 (bug 1633935)
Backed out changeset 6251c22cc8f1 (bug 1633935)
Backed out changeset 73b51a139c91 (bug 1633935)
Backed out changeset 2a9873ad6856 (bug 1633935)
Backed out changeset be03e0e7b645 (bug 1633935)
Backed out changeset df5abc2c0734 (bug 1633935)
Backed out changeset 19dcca77a1cf (bug 1633935)
2020-06-25 20:25:36 +03:00
5270b37037
Bug 1645786 - IPCBlobInputStream for socket process, r=smaug,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D80680
2020-06-25 12:21:14 +00:00
11d9d8e44d
Bug 1647605 - add remotetype to nsiparentchannel (and inheritors) r=kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D80887
2020-06-25 12:00:52 +00:00
0b44a1b2ab
Bug 1645896 - Add a console log origins that have their cookies partitioned by dFPI. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D80675
2020-06-25 05:51:29 +00:00
6f84249b41
Bug 1337953 - Make nsDeque templated on pointer type r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79629
2020-06-25 02:39:23 +00:00
e67ceab432
Backed out 9 changesets (bug 1626362) for failures on a-download-click-404.html. CLOSED TREE
...
Backed out changeset d29ac651a4fd (bug 1626362)
Backed out changeset 5ba5cf98a95d (bug 1626362)
Backed out changeset 69b5b01da9c1 (bug 1626362)
Backed out changeset 1d31061f4421 (bug 1626362)
Backed out changeset a627870e35fb (bug 1626362)
Backed out changeset 5f3ee46032b6 (bug 1626362)
Backed out changeset 5b170666991e (bug 1626362)
Backed out changeset 4d31c2ede058 (bug 1626362)
Backed out changeset 66a9ba0f87cb (bug 1626362)
2020-06-25 02:45:52 +03:00
e4ec7daea6
Bug 1626362 - Don't forward loads to DocumentLoadListener if nsDocumentOpenInfo returned a failure, since doing so would lose the error code. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D79409
2020-06-24 22:04:07 +00:00
cc5c400765
Bug 1626362 - Let DocumentLoadListener determine if docshell will display content (from the channel or from loading an error page), and only allow switching to a new process if so. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80111
2020-06-24 22:03:52 +00:00
e9d06799ca
Bug 1626362 - Make mOriginalUriString available in DocumentLoadListener and docshell. r=nika,necko-reviewers,valentin
...
This also fixes a bug where we were setting mOriginalUriString in docshell before InternalLoad (which clears it), instead of after.
Differential Revision: https://phabricator.services.mozilla.com/D80110
2020-06-24 22:03:39 +00:00
87cdbac816
Bug 1626362 - Move url classifier notifications to parent process. r=nika,necko-reviewers,JuniorHsu
...
We shouldn't need to handle this with an early return in docshell, since the classifier failure codes won't display an error page anyway.
Differential Revision: https://phabricator.services.mozilla.com/D80108
2020-06-24 22:03:04 +00:00
8a0ff94b82
Bug 1648132 - Do not allow setting new listener after we handle all the IPCs before SendOnStartReqeust, r=kershaw
...
HttpChannelChild::OnStartRequest should copy argument only since HttpChannelChild::RecvAttachStreamFilter, who sets new listener, could be after OnStartRequest.
Differential Revision: https://phabricator.services.mozilla.com/D80964
2020-06-24 21:38:57 +00:00
a57b938715
Backed out changeset 8cb44457d718 (bug 1645901) for failures on /cookies/path/match.html. CLOSED TREE
2020-06-25 00:35:58 +03:00
ea21b3dd8e
Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-24 19:59:04 +00:00
dceac2df15
Bug 1646476: Remove unnecessary GetInProcessScriptableParent usage in LoadInfo. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80062
2020-06-22 14:26:49 +00:00
d9f9720ce1
Bug 1645901 - only waiting for main thread OnStartRequestSent for LOAD_DOCUMENT_NEEDS_COOKIE, r=mayhemer,necko-reviewers
...
Depends on D79771
Differential Revision: https://phabricator.services.mozilla.com/D80682
2020-06-24 14:01:02 +00:00
592b80d333
Backed out changeset 7ff5210dae5e (bug 1645896) for build bustages. CLOSED TREE
2020-06-24 13:39:43 +03:00
63042412c1
Bug 1647638 - Fix static-analysis warnings in nsStandardURL r=mayhemer,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D80624
2020-06-24 10:18:49 +00:00
e956550085
Bug 1647638 - Add nsStandardURL assertions r=mayhemer,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D80600
2020-06-24 10:12:15 +00:00
6be693b933
Bug 1645896 - Add a console log origins that have their cookies partitioned by dFPI. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D80675
2020-06-24 10:11:45 +00:00
90a64f0da1
Backed out 4 changesets (bug 1646582) for Browser-chrome failures on nsIWebProgress.addProgressListener. CLOSED TREE
...
Backed out changeset 2111dd0d6dc0 (bug 1646582)
Backed out changeset e6c496c5a4b1 (bug 1646582)
Backed out changeset 49b4ae8c8be0 (bug 1646582)
Backed out changeset 9d42ec89240c (bug 1646582)
2020-06-24 07:50:07 +03:00
acd97f7b2c
Bug 1646582 - Remove RemoteWebProgressManager. r=nika,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D80129
2020-06-24 03:25:09 +00:00
ebecc62699
Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers
...
One line fix with a bunch of explanation.
When we perform networking on the socket process, OnDataAvailable could be sent directly from socket process to child process.
Therefore, it could be racy with OnStartRequest which is from parent process to child process by nature.
This patch is to resolve the failure (cancel) by parent process.
For example, https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/nsHttpChannel.cpp#2713
Bug 1641496 introduce a status check to avoid ODA message being process
[2] https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpBackgroundChannelChild.cpp#163-171
It prevents putting ODA to the channel event queue in child process.
However, this is based on that `OnStartRequest` already finished excution, which is usually true if OnStartRequest is sent via PHttpChannel.
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpChannelChild.cpp#417-422
ChannelEventQueue::RunOrEnque simply runs the OnStartRequest given there on the same thread and the queue is empty, since no blocking events from different thread are before OnStartRequest.
Now we are moving the next chapter. OnStartRequest is queued given we want to switch thread.
The failure status, which is initiated in parent process, is set in HttpChannelChild::OnStartRequest which could be later than the status check [2]
Therefore, we need another check to prevent ODA, which is already in the event queue, being processed.
We intentionally keep [2] for performance.
Differential Revision: https://phabricator.services.mozilla.com/D79771
2020-06-23 17:02:55 +00:00
521cb5ca3f
Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers
...
The WebRequest will suspend the channel in nsHttpChannel::PrepareToConnect(), apply the stream filter, send the main thread IPC and resume.
That is, PHttpChannel::AttachStreamFilter should be handled in Child before OnStartRequest goes to listener.
Differential Revision: https://phabricator.services.mozilla.com/D79770
2020-06-23 16:58:40 +00:00
c95a90a842
Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers
...
Bug 1015466 move them from PContent to Pbg since it believes those events are fine
to received before OnStopRequest. Bug 1588241 move it back to PContent since those
events are before OnStartRequest.
Now we're moving OnStartRequest to pBg, so here's another ping-pong time :)
Differential Revision: https://phabricator.services.mozilla.com/D79587
2020-06-23 16:58:38 +00:00
73b5a6dc72
Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers
...
Depends on D77751
Differential Revision: https://phabricator.services.mozilla.com/D77752
2020-06-23 16:58:36 +00:00
25d87d22ae
Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers
...
Depends on D77750
Differential Revision: https://phabricator.services.mozilla.com/D77751
2020-06-23 16:58:33 +00:00
f9f9c2b3c0
Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers
...
Now OnStartRequest is passed to child process via pBg. Every IPC which is passed thru main thread could become a race.
For the redirection flow in child process is:
(1) HTC::ConnectParent(): Let parent know this is the targeted child, so OnStartRequest could start here.
(2) HTC::CompleteRedirectSetup(listener): Now we're finish the setup, including listener. From now on, we're ready to accept OnStartRequest
Hence, between (1) and (2), and need to suspend the eventQ to prevent OnStartRequest pump without listener.
On the other hand, if the redirection is vetoed by parent, (2) will not be sent. RecvDeleteSelf instead.
Resuming the eventQ to prevent leakage.
Depends on D77749
Differential Revision: https://phabricator.services.mozilla.com/D77750
2020-06-23 16:58:29 +00:00
b90ea93ae9
Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers
...
Depends on D76971
Differential Revision: https://phabricator.services.mozilla.com/D76972
2020-06-23 16:57:10 +00:00
347250b5c8
Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers
...
We move OnStartRequest from PHttpChannel to PHttpBackgroundChannel, thus adjusting
message-metadata.ini
Depends on D76970
Differential Revision: https://phabricator.services.mozilla.com/D76971
2020-06-23 16:56:53 +00:00
7d6e5f2dd9
Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers
...
Depends on D76969
Differential Revision: https://phabricator.services.mozilla.com/D76970
2020-06-23 16:56:45 +00:00
f49f6361a4
Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers
...
Depends on D73529
Differential Revision: https://phabricator.services.mozilla.com/D76969
2020-06-23 16:56:32 +00:00
8d354f9a81
Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D73529
2020-06-23 16:56:15 +00:00
70c8aeee0b
Bug 1647769 - Update to Neqo 0.4.4 r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D80687
2020-06-23 18:51:19 +00:00
1e83952038
Bug 1643515 - Implement HttpTransactionParent::ActorDestroy properly, r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80513
2020-06-23 17:14:55 +00:00
78dfb0a991
Bug 1590762 - Part 3: Keep track of current loads in BrowsingContext. r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D75110
2020-06-23 13:01:37 +00:00
ca5db92916
Bug 1590762 - Part 2: Bump the id for channel registration to uint64_t. r=mattwoodrow,necko-reviewers,valentin
...
This patch also makes the identifier for channels global, in the sense
that the generated identifier is generated outside of and passed to
the nsIRedirectChannelRegistrar.
Differential Revision: https://phabricator.services.mozilla.com/D79820
2020-06-23 13:18:56 +00:00
6aa5b38d30
Bug 1641905 - ThirdPartyUtil::IsThirdPartyWindow for fission, r=dimi,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D79307
2020-06-17 20:18:23 +00:00
adf7461931
Bug 1637648 - P5: Create mConfirmer when network.trr.confirmationNS is changed r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D78887
2020-06-23 11:11:49 +00:00
0fecb3400a
Bug 1637648 - P4: Add needed observes for nsSocketTransportService r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D78885
2020-06-23 11:11:42 +00:00
62b5c4afb8
Bug 1637648 - P3: Forward observer notifications to socket process for nsHttpHandler r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D77307
2020-06-23 11:11:29 +00:00
87c26faa97
Bug 1637648 - P2: Make TRRServiceParent use nsIOService to forward observer notifications r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D77306
2020-06-23 11:11:16 +00:00
86ce6ac77d
Bug 1637648 - P1: Make nsIOService the single point to forward observer notifications to socket process r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D77305
2020-06-23 11:11:01 +00:00
c1c17273e8
Backed out changeset ce1a126dcf10 (bug 1641222) for failures at test_trr_httpssvc.js. CLOSED TREE
2020-06-23 12:48:49 +03:00
cb869c015c
Bug 1641222 - Follow CNAME/AliasForm chains r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D79264
2020-06-22 13:24:19 +00:00
f9d8e206df
Bug 1644239, r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80365
2020-06-23 07:51:25 +00:00
Matt Woodrow
Olli Pettay
Butkovits Atila
Andrea Marchesini
Frederik Braun
Nihanth Subramanya
Chris Fronk
Csoregi Natalia
Junior Hsu
Kris Maglione
Razvan Maries
Valentin Gosu
Dorel Luca
Andy Grover
Kershaw Chang
Andreas Farre