a6aead55f6
Bug 1795294 - Allow places menupopups to shrink under the available size. r=dao
...
I can also just drop min-width/height: 0 in the inline style if you'd
rather do that.
Differential Revision: https://phabricator.services.mozilla.com/D159402
2022-10-14 15:09:51 +00:00
9e1b731098
Bug 1510561 - Part 2: Apply `plugin:mozilla/valid-jsdoc` to `browser/components/places`. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D158562
2022-10-13 10:55:28 +00:00
4ba9b4dd1c
Bug 1792759 - part 1: Add `nsIEditor.clearUndoRedo()` to get rid of `nsIEditor.transactionManager` r=m_kato,NeilDeakin,Standard8
...
`nsIEditor.transactionManager` is used only for some simple purposes, however,
`nsIEditor` exposes the rich API. That makes it harder to maintain internal
code around transactions. Instead, `nsIEditor` exposes only simple and
necessary APIs.
This patch creates a new API to clear undo/redo history and make the users in
mozilla-central use it instead of using `nsITransactionManager.clear()`.
Differential Revision: https://phabricator.services.mozilla.com/D158336
2022-10-09 01:13:49 +00:00
d71d3c19ed
Bug 1792809 - Make library and other windows keep stretching after bug 1665476. r=eemeli
...
Much like the dialog changes in bug 1792730.
Differential Revision: https://phabricator.services.mozilla.com/D158351
2022-10-04 10:21:05 +00:00
8d1ebcb9d6
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
a9ba6e830d
Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 21:47:50 +00:00
130adc5d9a
Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE
2022-09-26 22:53:00 +03:00
3e99025d45
Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 18:51:57 +00:00
6c2d0d8cea
Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE
2022-09-26 20:44:40 +03:00
05dcda5a7f
Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 16:51:10 +00:00
13572bce66
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
c520b707bd
Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE
2022-09-02 16:35:55 +03:00
0777329f69
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
98719ef914
Bug 1786518 - Remove ensureRowIsVisible from firing in updateDetailsPane - r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D155391
2022-08-29 15:15:16 +00:00
7fc8beef67
Bug 1786055 - Drop find keys from editMenuKeys.inc.xhtml. r=mconley
...
It would appear that these <key> definitions in editMenuKeys.inc.xhtml
are not actaully used anywhere.
Differential Revision: https://phabricator.services.mozilla.com/D155448
2022-08-26 16:31:40 +00:00
a7401488af
Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
...
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.
Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).
In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.
Add a debug-only assertion to ensure we preserve behavior for now.
Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.
Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 23:13:41 +00:00
7f5e2711c6
Backed out 3 changesets (bug 1784265) for causing reftest failures on flex-emulation-1.xhtml. CLOSED TREE
...
Backed out changeset 415da4b53bdd (bug 1784265)
Backed out changeset e27b21c54b1f (bug 1784265)
Backed out changeset fcb1a053fbe2 (bug 1784265)
2022-08-13 01:14:13 +03:00
a2ec6564f3
Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
...
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.
Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).
In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.
Add a debug-only assertion to ensure we preserve behavior for now.
Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.
Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 19:34:34 +00:00
f0a33c9d81
Bug 1783207 - Add ellipsis to some menu label strings. r=flod
...
The copy guidance recommends adding an ellipsis to the end of labels for
controls that require an additional step to complete the action
specified by the label. We have some menuitems and panel buttons that
open a bookmark dialog or the edit bookmark panel that don't have an
ellipsis, so add that. Also, the form "Bookmark this x" has been changed
to "Bookmark x" in menuitems. Also, there's a "Print Selection" menuitem
that needed an ellipsis. Thanks for the review!
Differential Revision: https://phabricator.services.mozilla.com/D154320
2022-08-11 17:48:11 +00:00
6e336b34d6
Bug 1782638 - Simplify styling of bookmarks toolbar submenus. r=mak
...
Also, align them properly.
The issue is that we inherit the region margin introduced in bug 1772507, but
we were styling the panel in a way that causes the region to not match the
shadow size.
Simplify a bit the styling so that all the margins add up.
For uplift it'd be simpler to just set the new property to zero, I'll prepare a
patch for that. That would cause the shadows to count as popup contents, but
that's the pre-103 behavior which seems fine.
Differential Revision: https://phabricator.services.mozilla.com/D153856
2022-08-10 13:10:26 +00:00
6d15c3f4b2
Bug 1742842 - Workaround known issues in tests that currently keep vsync enabled forever, r=mconley,webdriver-reviewers,jdescottes.
...
Differential Revision: https://phabricator.services.mozilla.com/D153204
2022-08-01 16:04:15 +00:00
bf4b875752
Bug 1781782 - Run frequent xpcshell parallel failing tests sequential by default. r=ahal,necko-reviewers,extension-reviewers,application-update-reviewers,bytesized,rpl,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D153081
2022-07-30 01:33:28 +00:00
09b6bee447
Backed out 2 changesets (bug 1742842) for causing failures complaining about vsync. CLOSED TREE
...
Backed out changeset 82364f4b3520 (bug 1742842)
Backed out changeset b94a13888214 (bug 1742842)
2022-07-29 19:09:13 +03:00
2dcecd3dc8
Bug 1742842 - Workaround known issues in tests that currently keep vsync enabled forever, r=mconley.
...
Depends on D132055
Differential Revision: https://phabricator.services.mozilla.com/D153204
2022-07-29 15:31:19 +00:00
bf159ca171
Bug 1779988 - Part 1: Merge multiple ChromeUtils.defineESModuleGetters calls into one. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D152879
2022-07-28 00:54:20 +00:00
12ee099a88
Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D152253
2022-07-26 15:11:31 +00:00
8a275d4d92
Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-26 15:11:30 +00:00
dc4f2d6a41
Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE
...
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
2022-07-25 21:00:07 +03:00
4272200762
Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D152253
2022-07-25 12:46:49 +00:00
539b5dac0d
Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-25 12:46:48 +00:00
4bfafd41fa
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
e29957943b
Bug 1779982 - Migrate toolkit/components/places and browser/components/places to ESM. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D152004
2022-07-20 22:34:20 +00:00
078a07d922
Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D152003
2022-07-20 22:34:20 +00:00
102b779608
Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
...
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
2f65c79816
Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D152253
2022-07-20 15:50:43 +00:00
fd37e0e9da
Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-20 15:50:42 +00:00
23086da9b9
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
fa9b1b5f10
Bug 1779982 - Migrate toolkit/components/places and browser/components/places to ESM. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D152004
2022-07-20 15:50:40 +00:00
50f4bbf0ae
Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D152003
2022-07-20 15:50:39 +00:00
1108246986
Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
...
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
3c09fc13df
Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
...
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
17e34b4715
Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai
...
Differential Revision: https://phabricator.services.mozilla.com/D152253
2022-07-20 10:36:53 +00:00
3ad13294d8
Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
ac90e83952
Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-20 10:36:51 +00:00
e84aaa1b85
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
374f18ee33
Bug 1779982 - Migrate toolkit/components/places and browser/components/places to ESM. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D152004
2022-07-20 10:36:49 +00:00
47cd6c5eb6
Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D152003
2022-07-20 10:36:49 +00:00
bafca045c9
Bug 1779559 - Disable Windows' window occlusion in some more mochitests. r=sotaro
...
Differential Revision: https://phabricator.services.mozilla.com/D152105
2022-07-19 09:25:53 +00:00
05c0ca81e7
Bug 1777488 - Migrate browser/components/pagedata to ESM. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D151222
2022-07-12 10:05:04 +00:00
54623364da
Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Emilio Cobos Álvarez
trickypr
Masayuki Nakano
Mark Banner
Marian-Vasile Laza
Narcis Beleuzu
Butkovits Atila
James Teow
Eemeli Aro
Shane Hughes
Florian Quèze
Joel Maher
Tooru Fujisawa
smolnar
Iulian Moraru