We can't create a Redux store without reducers. Redux throws an error.
It's benign and doesn't impact anything (panels load reducers on-demand before accessing them), but it's annoying to see the error in the console and in tests.
Differential Revision: https://phabricator.services.mozilla.com/D81047
The WebExtensionInspectedWindow front is modified in order
to be able to parse the eval response.
We're doing it in a similar fashion to the other fronts methods
that can return ObjectFronts: everything is handled client side,
by the front, since an evaluation result can return primitive values,
long string or grips, and we can't define this through protocol.js in
a readable manner.
Some functions and a component are renamed to better represent
what they're doing.
Differential Revision: https://phabricator.services.mozilla.com/D58939
--HG--
rename : devtools/client/inspector/extensions/components/ObjectValueGripView.js => devtools/client/inspector/extensions/components/ExpressionResultView.js
extra : moz-landing-system : lando
The LongStringClient is removed and we replace its
usage with LongStringFront instead.
This require a few variable/function renaming, as
well as updating the mocks we use in node tests.
Switch usage to LongStringFront instead.
Differential Revision: https://phabricator.services.mozilla.com/D50579
--HG--
rename : devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/__mocks__/long-string-client.js => devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/__mocks__/string-front.js
rename : devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/create-long-string-client.js => devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/component/create-long-string-front.js
extra : moz-landing-system : lando
The object-client.js file is now a proper protocol.js front,
but is still named after a client.
This is confusing, so we rename and move the file next to other
fronts, and update all consumers to the new terminology.
Differential Revision: https://phabricator.services.mozilla.com/D49878
--HG--
rename : devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/__mocks__/object-client.js => devtools/client/debugger/packages/devtools-reps/src/object-inspector/tests/__mocks__/object-front.js
rename : devtools/shared/client/object-client.js => devtools/shared/fronts/object.js
extra : moz-landing-system : lando
The disableTask options is renamed to enableTaskMiddleware,
which defaults to false.
This caused failure in the dom mutation breakpoint test, because
we weren't waiting until the call to the server to remove the
breakpoints were done.
It wasn't an issue before because this was handle by the task
middleware, which catch rejections.
We fix this by only dispatching the action when the breakpoints are
indeed removed. We also tweak to waitForAllElements helper to be
able to wait for a specific count of element (it used to resolve
when there was at least the specified count, which is not ideal
when trying to assert removal of an element).
Differential Revision: https://phabricator.services.mozilla.com/D47584
--HG--
extra : moz-landing-system : lando
The inspector was using an outdated Reps bundle
for some time because some non-trivial changed
were made to the ObjectInspector that we wanted
to do as a follow up for in the inspector, but never
took the time to do so.
This will become a painpoint soon as we're planning
to do changes in reps for Fission.
This patch removes the old bundle, and mov the
inspector usage of Reps to the new bundle.
We introduce a new middleware, thunk-with-options,
that is similar to thunk but cab be bound with an
options object (on which we add dispatch and getState),
that will be then passed as parameter to the actions.
Since the task middelware is executed before the thunk one,
and given that it handles async function, it would bypass
the thunk-with-action middleware, making some objectInspector
actions fail. To workaround that, we add an option to createStore
to add the ability to disable the task middleware (which isn't
needed in the inspector).
The ObjectInspector reducer is also added to the
inspector store.
Differential Revision: https://phabricator.services.mozilla.com/D46141
--HG--
extra : moz-landing-system : lando
Razvan Caliman
Butkovits Atila
Nicolas Chevobbe
Logan Smyth
Julian Descottes
J. Ryan Stinnett
Gabriel Luong