58c7b8d171
Bug 1583179 - [devtools] Remove the reload and analyze performance buttons in the browser toolbox r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D149610
2022-06-21 15:15:49 +00:00
99952418e8
Bug 1766821 - Only copy the value of a field. r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D145832
2022-06-20 06:58:31 +00:00
6c38c84016
Bug 1508688 - Add `UNSAFE_` prefix to React deprecated lifecycle methods in devtools/client/netmonitor/. r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D149481
2022-06-16 10:03:10 +00:00
8708b3ac9e
Bug 1772363 - [devtools] Ensure actually watching resources before pause/resume UI is updated r=ochameau
...
Changing the pattern for toggling recording to ensure that pause/resumes actually
start or stops watching resources before the ui states gets updated.
Differential Revision: https://phabricator.services.mozilla.com/D148953
2022-06-14 15:38:07 +00:00
2b8049bcf5
Bug 1772363 - [devtools] Fix intermittent on browser_net_pause.js r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D148674
2022-06-09 09:34:31 +00:00
c3a1dc4ad3
Bug 1765631 - [devtools] Copy Request Headers hardcodes HTTP version r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D147580
2022-06-08 06:34:54 +00:00
27106e41bc
Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D147413
2022-06-07 12:18:49 +00:00
8acd16def6
Bug 1764348 - Pause / Resume should toggle listening to network resources r=ochameau
...
With this patch Pause and Resume, now stop and start listening to network requests.
Differential Revision: https://phabricator.services.mozilla.com/D148488
2022-06-07 12:18:49 +00:00
96c5408eef
Bug 1764348 - Enable browser console / browser toolbox console users turn on network monitoring manually r=nchevobbe
...
Highlights
- Network monitoring is turned off by default in browser console/ browser toolbox console on initial load.
- A new "Enable Network Monitoring" setting is added to enable users toggle on an off as they desire.
- The user setting is persisted across toolbox reopens.
Differential Revision: https://phabricator.services.mozilla.com/D145234
2022-06-06 13:56:05 +00:00
4d1529da83
Bug 1772211 - Fix typo. a=fix.
2022-06-03 12:34:06 +03:00
d03eb2b6c1
Bug 1772211 - disable browser_net_truncate-post-data.js with socket process networking for permanent failures
...
These started after the changes in bug 1772074.
Differential Revision: https://phabricator.services.mozilla.com/D148069
2022-06-03 08:40:32 +00:00
3133e874e5
Bug 1771608 - Eliminate mozilla/reject-osfile eslint warning in devTools code r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
...
## Removed Some Osfile.jsm and ChromeUtils Dependencies
```diff
- const { OS } = require("resource://gre/modules/osfile.jsm");
And / Or
- const ChromeUtils = require("ChromeUtils");
```
- devtools/client/memory/actions/io.js
- devtools/client/memory/utils.js
- devtools/client/netmonitor/src/har/har-menu-utils.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/shared/screenshot.js
- devtools/client/styleeditor/StyleEditorUI.jsm
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/client/webconsole/components/Input/JSTerm.js
- devtools/client/webconsole/test/browser/stub-generator-helpers.js
- devtools/server/actors/heap-snapshot-file.js
- devtools/server/actors/storage.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_01.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_02.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_03.js
- devtools/shared/DevToolsUtils.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
- devtools/shared/tests/xpcshell/test_fetch-file.js
- testing/talos/talos/tests/devtools/addon/content/tests/toolbox/screenshot.js
## IOUtils.read()
```diff
- OS.File.read(path);
+ IOUtils.read(path);
```
- devtools/client/aboutdebugging/test/browser/helper-real-usb.js
- devtools/client/netmonitor/src/har/har-menu-utils.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/client/webconsole/components/Input/JSTerm.js
- devtools/client/webconsole/test/browser/browser_jsterm_file_load_save_keyboard_shortcut.js
- devtools/client/webconsole/test/browser/browser_webconsole_context_menu_export_console_output.js
- devtools/shared/DevToolsUtils.js
## IOUtils.write()
```diff
- OS.File.writeAtomic(filePath, fileContent);
+ IOUtils.write(filePath, fileContent);
```
- devtools/client/webconsole/test/browser/stub-generator-helpers.js
- devtools/shared/DevToolsUtils.js
- devtools/shared/tests/xpcshell/test_fetch-file.js
## PathUtils.split()
```diff
- OS.Path.split(path);
+ PathUtils.split(path);
```
- devtools/client/styleeditor/StyleSheetEditor.jsm
## PathUtils.join()
```diff
- OS.Path.join(path, filename);
+ PathUtils.join(path, filename);
```
NOTE: If `filename` is an absolute path then `OS.Path` will ignore `path` and use `filename` but `PathUtils` will try to concatenate both paths. If filename can be an absolute path we need to use `PathUtils.isAbsolute()` and `PathUtils.joinRelative()` to make our desired behaviour explicit.
- devtools/client/debugger/test/mochitest/browser_dbg-chrome-create.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
## PathUtils.isAbsolute() and PathUtils.joinRelative()
```diff
- filename = OS.Path.join(path, filename);
+ filename = PathUtils.isAbsolute(filename)
+ ? filename
+ : PathUtils.joinRelative(path, filename);
```
- devtools/client/shared/screenshot.js
## IOUtils.remove()
```diff
- OS.File.remove(filePath);
+ IOUtils.remove(filePath);
```
- devtools/client/framework/test/browser_toolbox_screenshot_tool.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/responsive/test/browser/browser_screenshot_button_warning.js
- devtools/client/shared/test/shared-head.js
- devtools/client/webconsole/test/browser/browser_console_screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_file.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_fixed_header.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_selector.js
- testing/talos/talos/tests/devtools/addon/content/tests/toolbox/screenshot.js
## PathUtils.toFileURI()
```diff
- OS.Path.toFileURI(filePath);
+ PathUtils.toFileURI(filePath);
```
- devtools/client/framework/test/browser_toolbox_screenshot_tool.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/shared/test/shared-head.js
- devtools/client/webconsole/test/browser/browser_console_screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_file.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_fixed_header.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_selector.js
## PathUtils.filename()
```diff
- OS.Path.basename(path),
+ PathUtils.filename(path),
```
- devtools/client/memory/actions/io.js
- devtools/client/memory/utils.js
- devtools/client/styleeditor/StyleEditorUI.jsm
- devtools/client/styleeditor/StyleSheetEditor.jsm
## IOUtils.copy()
```diff
- OS.File.copy(path, dest);
+ IOUtils.copy(path, dest);
```
- devtools/client/memory/actions/io.js
## IOUtils.stat()
```diff
- OS.File.stat(filePath);
+ IOUtils.stat(filePath);
```
The objects that these `stat()` versions return differ from one another. This hasn't made much difference to the codebase but our changed usage is included here for completeness:
```diff
- this._fileModDate = info.lastModificationDate.getTime();
+ this._fileModDate = info.lastModified;
```
- devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js
- devtools/client/memory/test/xpcshell/head.js
- devtools/client/memory/test/xpcshell/test_action-export-snapshot.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/server/actors/heap-snapshot-file.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_01.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_02.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_03.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
## IOUtils.setPermissions
```diff
- OS.File.setPermissions(filePath, { unixMode: 0o744 });
+ IOUtils.setPermissions(filePath, 0o744);
```
- devtools/client/shared/remote-debugging/adb/adb-binary.js
## IOUtils.makeDirectory
```diff
- OS.File.makeDir(path);
+ IOUtils.makeDirectory(path);
```
- devtools/client/shared/remote-debugging/adb/adb-binary.js
## IOUtils.exists
```diff
- OS.File.exists(path);
+ IOUtils.exists(path);
```
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/shared/screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_file_load_save_keyboard_shortcut.js
- devtools/client/webconsole/test/browser/browser_webconsole_context_menu_export_console_output.js
## PathUtils.profileDir, PathUtils.localProfileDir and PathUtils.tempDir
```diff
- const profileDir = OS.Constants.Path.profileDir;
+ const profileDir = PathUtils.profileDir;
```
We can reduce reliance on `Osfile.jsm` in another bug bug this is a small step in that direction.
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/server/actors/storage.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
## IOUtils.getChildren(storagePath)
`IOUtils` does not have a direct equivalent of `OS.File.DirectoryIterator()` so we need to iterate more explicitely using `IOUtils.getChildren()`.
```diff
- async findStorageTypePaths(storagePath) {
- const iterator = new OS.File.DirectoryIterator(storagePath);
- const typePaths = [];
-
- await iterator.forEach(entry => {
- if (entry.isDir) {
- typePaths.push(entry.path);
- }
- });
-
- iterator.close();
- return typePaths;
- }
+ async findStorageTypePaths(storagePath) {
+ const children = await IOUtils.getChildren(storagePath);
+ const typePaths = [];
+
+ for (const path of children) {
+ const exists = await IOUtils.exists(path);
+ if (!exists) {
+ continue;
+ }
+
+ const stats = await IOUtils.stat(path);
+ if (stats.type === "directory") {
+ typePaths.push(path);
+ }
+ }
+
+ return typePaths;
+ }
```
- devtools/server/actors/storage.js
## Misc
Made `IOUtils` and `PathUtils` available to DevTools modules.
```diff
HeapSnapshot,
+ IOUtils,
L10nRegistry,
Localization,
NamedNodeMap,
NodeFilter,
+ PathUtils,
StructuredCloneHolder,
TelemetryStopwatch,
```
- devtools/shared/loader/builtin-modules.js
Differential Revision: https://phabricator.services.mozilla.com/D147589
2022-06-02 21:13:56 +00:00
43e6873145
Backed out 4 changesets (bug 1764348, bug 1771277) for causing multiple dt failures. CLOSED TREE
...
Backed out changeset 21c03813c9d0 (bug 1771277)
Backed out changeset 0ee89f81d7da (bug 1764348)
Backed out changeset 47658c248d9e (bug 1764348)
Backed out changeset 712947c3a514 (bug 1764348)
2022-06-02 23:13:28 +03:00
f1cdd9a344
Bug 1771277 - [devtools] Remove the websocket and server sent events prefs r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D147413
2022-06-02 14:35:25 +00:00
61afb77264
Bug 1764348 - Pause / Resume should toggle listening to network resources r=ochameau
...
With this patch Pause and Resume, now stop and start listening to network requests
Differential Revision: https://phabricator.services.mozilla.com/D146445
2022-06-02 14:35:24 +00:00
4cf961c731
Bug 1764348 - Enable browser console / browser toolbox console users turn on network monitoring manually r=nchevobbe
...
Highlights
- Network monitoring is turned off by default in browser console/ browser toolbox console on initial load.
- A new "Enable Network Monitoring" setting is added to enable users toggle on an off as they desire.
- The user setting is persisted across toolbox reopens.
Differential Revision: https://phabricator.services.mozilla.com/D145234
2022-06-02 14:35:24 +00:00
b32bbdb0ff
Bug 1354054 - [devtools] Network panel could display request priority r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D144524
2022-05-26 11:40:27 +00:00
4d189564be
Bug 1769572 - [devtools] The CONNECT method should no longer be sent on request resend r=nchevobbe
...
The CONNECT method sent on Edit & Resend of certain requests crashes firefox
based on https://bugzilla.mozilla.org/show_bug.cgi?id=1769572#c2 , Necko uses CONNECT in a special way, so lets restrict
the devtools from selecting and sending it.
The crash happens with both the current and new edit and resend panels, so this patch
needs to be tested for both.
Use the devtools.netmonitor.features.newEditAndResend and set it to true to enable the new edit and resend panel.
Note: The new edit and resend panel is enabled by default in Nightly.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1769572#c0 for the STR for the current Edit and Resend panel
See https://bugzilla.mozilla.org/show_bug.cgi?id=1769572#c7 for the STR for the new Edit and Resend
Differential Revision: https://phabricator.services.mozilla.com/D146820
2022-05-19 18:26:43 +00:00
b0725e2037
Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs
...
Depends on D146450
Differential Revision: https://phabricator.services.mozilla.com/D146598
2022-05-18 08:13:18 +00:00
3b0258336e
Bug 1769569 - Enable ESLint rule no-define-cc-etc for devtools sjs files. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D146449
2022-05-18 08:13:18 +00:00
c552340e0c
Backed out 5 changesets (bug 1769569) for causing devtools' browser/browser_page_redirection.js to fail. CLOSED TREE
...
Backed out changeset 66a42eb3a366 (bug 1769569)
Backed out changeset d3cc9629cd9a (bug 1769569)
Backed out changeset edcd3dade079 (bug 1769569)
Backed out changeset 29d8dd058b7a (bug 1769569)
Backed out changeset 1aed34fdf2d3 (bug 1769569)
2022-05-17 19:49:17 +02:00
5b82552956
Bug 1769569 - Disable reject-importGlobalProperties for sjs files via the ESLint rule. r=Gijs
...
Depends on D146450
Differential Revision: https://phabricator.services.mozilla.com/D146598
2022-05-17 16:50:32 +00:00
55789cb268
Bug 1769569 - Enable ESLint rule no-define-cc-etc for devtools sjs files. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D146449
2022-05-17 16:50:31 +00:00
a3d1bcf6f5
Bug 1766013 - [devtools] Rewrite old test for the currently panel to the New Request Panel. r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D144441
2022-04-27 14:57:03 +00:00
33be927b2a
Bug 1766099 - Part 2: Explicitly specify import or imported symbol for importScripts in devtools/. r=Standard8
...
Depends on D144671
Differential Revision: https://phabricator.services.mozilla.com/D144672
2022-04-27 11:40:40 +00:00
0a4230aa64
Bug 1758361 - [devtools] Fix crash when viewing request headers from upload stream r=nchevobbe
...
This patch fixes 2 crashes, for different reasons and improves/ adds tests to cover the issues
- The raw view of the `Request headers for upload stream` crashes when there
is only one header sent. This is covered by the scenario
```
[
"content-type: application/x-www-form-urlencoded\r",
"\r",
"\r",
"foo=bar&baz=123"
]
```
- The Request side panel crashes when there is no form data body content added to the payload sent.
This is covered in the test by the scenario
```
[
"content-type: application/x-www-form-urlencoded\r",
"\r",
"\r",
]
```
Differential Revision: https://phabricator.services.mozilla.com/D143339
2022-04-15 08:16:17 +00:00
42b7d01933
Bug 1758361 - [devtools] Cleanup post data tests r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D143338
2022-04-15 08:16:17 +00:00
f3012297a4
Bug 1762601 - Migrate all of devtools from Cu.import to ChromeUtils.import. r=jdescottes,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D142693
2022-04-04 13:41:02 +00:00
eb0de131a8
Bug 1762827 - [devtools] Remove old edit-and-resend-button rule. r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D142781
2022-04-04 12:09:03 +00:00
703b2daf31
Bug 1762550 - [devtools] Cleanup webconsole stylesheet imports. r=bomsy.
...
Remove httpi.css that was only used by the console, and load the individual
CSS files instead.
Remove widgets.css, which is a relic of the old console.
Remove textActions.ftl import, which doesn't seem to have any effect.
Differential Revision: https://phabricator.services.mozilla.com/D142658
2022-04-04 06:04:17 +00:00
71ead80661
Bug 1761991 - [devtools] Fix intermittent failure on custom HTTP panel tests r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D142543
2022-04-02 06:50:15 +00:00
50257b7a2b
Bug 1761510 - [devtools] Remove frame-link-source-inner element in Frame component. r=bomsy.
...
This simplifies the markup a bit, and hopefully could contribute to improve
layout and styling performance in the console.
Differential Revision: https://phabricator.services.mozilla.com/D142096
2022-03-31 06:55:09 +00:00
b20f70b87b
Bug 1761223 - [devtools] Fix the error Fix header intermittent TypeError on custom HTTP panel test r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D142221
2022-03-29 13:41:18 +00:00
291e4034b3
Bug 1750245 - [devtools] Adds test for basic functionality of the new HTTP Custom request panel r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D138659
2022-03-24 09:43:32 +00:00
10881177f1
Bug 1759202 - [devtools] Adds test for persistence of content on Custom request panel r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D140873
2022-03-15 08:04:43 +00:00
50a79212a7
Bug 1745414 - [devtools] Sync the URL parameters when the URL input is updated r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D140078
2022-03-12 11:46:48 +00:00
eb959d8afc
Bug 1758351 - [devtools] Change the name of the pref "devtools.netmonitor.features.newEditAndResendState" to "devtools.netmonitor.customRequest" r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D140493
2022-03-10 18:30:15 +00:00
eb82038342
Bug 1755464 - [devtools] Adds test for clear button of the new HTTP Custom request panel r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D139753
2022-03-09 13:45:36 +00:00
809cd2a13e
Bug 1598759 - Remove support for Large-Allocation HTTP header. r=nika,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D140459
2022-03-09 03:18:04 +00:00
3339cabe9d
Bug 1757382 - [devtools] Change the title to "Resend" on the Headers panel r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D139820
2022-03-02 11:53:48 +00:00
758798d070
Bug 1755434 - [devtools] Replace netmonitor duplicated worker-utils with shared worker-utils r=bomsy
...
Depends on D138759
Differential Revision: https://phabricator.services.mozilla.com/D138763
2022-03-01 19:55:39 +00:00
961a73bfd0
Bug 1756200 - [devtools] Changes multi-line text area feature to use mostly CSS r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D139140
2022-03-01 08:27:54 +00:00
d400f88399
Bug 1708356 - [devtools] Notify users when a XSSI string has been removed. r=bomsy
...
This changeset adds a NotificationBox to the ResponsePanel that notifies
users that a XSSI string was removed. This NotificationBox is only
displayed when the user is viewing parsed JSON using properties view.
Furthermore, when XSSI stripped characters are detected the ResponsePanel
will default to raw view.
Depends on D115442
Differential Revision: https://phabricator.services.mozilla.com/D115573
2022-02-28 18:25:22 +00:00
79e2fe263b
Bug 1708356 - [devtools] Only strip true XSSI prevention sequences while formatting JSON. r=bomsy
...
This fix makes sure that only valid XSSI prevention sequences are removed
from JSON payloads. Before, any string prepending the JSON payload was
removed which meant malformed JSON could still be displayed in properties
view as if it was valid which confused users.
Differential Revision: https://phabricator.services.mozilla.com/D115442
2022-02-28 18:25:21 +00:00
38ece30050
Bug 1754368 - fixed network-monitor block button padding. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D138938
2022-02-17 13:39:44 +00:00
0254ce5b17
Bug 1264621: open request in new tab when row is middle clicked r=Honza
...
Depends on D138655
Differential Revision: https://phabricator.services.mozilla.com/D138665
2022-02-17 09:26:59 +00:00
5ba8f75906
Bug 1754371 - [devtools] Get Edit and resend action from the Headers panel to work r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D138557
2022-02-16 20:53:11 +00:00
56c59fb18d
Bug 1744785 - [devtools] Adds a pref to persist edit and resend content across devtools sessions r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D137996
2022-02-16 13:50:39 +00:00
39ae6761a9
Bug 1754416 - [devtools] Fix narrow panel layout r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D138308
2022-02-14 09:54:50 +00:00
340fc67179
Bug 1753614 - [devtools] Rename mdn-utils file r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D138410
2022-02-11 17:18:41 +00:00
Hubert Boma Manilla
Zoltán Szatmáry
Tetsuharu Ohzeki
colin_czb
Molnar Sandor
Butkovits Atila
Michael Ratcliffe
Iulian Moraru
Mark Banner
Sebastian Hengst
Claudia
Tooru Fujisawa
Nicolas Chevobbe
Chris Peterson
Julian Descottes
Mattias de los Rios Rogers
osBins
patrickdemers6
Jan Odvarko