Andrew McCreight
38dac812ea
Bug 1599175, part 1 - Remove unused 'browingContextId' message field in PictureInPictureChild. r=mconley
...
This field is misspelled. Don't worry though, it is also unused.
Differential Revision: https://phabricator.services.mozilla.com/D54565
--HG--
extra : moz-landing-system : lando
2019-11-25 18:19:01 +00:00
Tim Nguyen
c466b25172
Bug 1597844 - Fix positioning of form validation and date/time input popups. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D53902
--HG--
extra : moz-landing-system : lando
2019-11-22 00:13:15 +00:00
Andreea Pavel
03a2c54d6f
Backed out 3 changesets (bug 1595154) for failing bc at browser_autocomplete_marked_detached_tab.js on a CLOSED TREE
...
Backed out changeset f512953534ac (bug 1595154)
Backed out changeset 803a2dfdda82 (bug 1595154)
Backed out changeset ddd336d5bf1a (bug 1595154)
--HG--
rename : browser/extensions/formautofill/FormAutofillChild.jsm => browser/extensions/formautofill/content/FormAutofillFrameScript.js
2019-11-20 05:03:37 +02:00
Neil Deakin
0541c1228b
Bug 1595154, change FormAutofillParent to inherit from JSWindowActor, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52722
--HG--
extra : moz-landing-system : lando
2019-11-20 01:25:27 +00:00
Neil Deakin
a6095ebaf4
Bug 1595154, replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52721
--HG--
rename : browser/extensions/formautofill/content/FormAutofillFrameScript.js => browser/extensions/formautofill/FormAutofillChild.jsm
extra : moz-landing-system : lando
2019-11-20 01:25:20 +00:00
Ciure Andrei
c24561eb05
Backed out 3 changesets (bug 1535437, bug 1591253) for causing browser_resizeVideo.js to permafail CLOSED TREE
...
Backed out changeset f7cc2f6d9640 (bug 1591253)
Backed out changeset bc637c20c7d4 (bug 1535437)
Backed out changeset 46b4eb05f2ae (bug 1535437)
2019-11-14 23:25:26 +02:00
Mark Striemer
54c97d535f
Bug 1535437 - Part 2: Resize PiP window when video source resizes r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50139
--HG--
extra : moz-landing-system : lando
2019-11-12 20:51:51 +00:00
Neil Deakin
bf4c789cae
Bug 1595875, fix handling of return value of FormAutoComplete:GetSelectedIndex that was incorrectly removed by 1573836, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52720
--HG--
extra : moz-landing-system : lando
2019-11-14 10:07:52 +00:00
Neil Deakin
fd6f562cbe
Bug 1533943, modify WebNavigation to inherit from JSWindowActor, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50886
--HG--
extra : source : 6e3c105cfcde3a6821120a83674f77692f5c7bf2
2019-11-14 00:53:29 +00:00
Daniel Varga
cc80b874b2
Backed out changeset 6e3c105cfcde (bug 1533943) for causing mochitest failures at mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html on a CLOSED TREE
2019-11-14 08:30:55 +02:00
Neil Deakin
641485fae3
Bug 1533943, modify WebNavigation to inherit from JSWindowActor, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50886
--HG--
extra : moz-landing-system : lando
2019-11-14 00:53:29 +00:00
Neil Deakin
de0e62029f
Bug 1590445, only adjust zoom level for FullZoomChange and TextZoomChange events for top-level frames, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D51617
--HG--
extra : moz-landing-system : lando
2019-11-05 00:08:18 +00:00
Mike Conley
83b7a85186
Bug 1582600 - Make PiP code handle the case where sometimes calling .get() on a weak reference throws NS_ERROR_XPC_BAD_CONVERT_NATIVE (bug 800957). r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D51939
--HG--
extra : moz-landing-system : lando
2019-11-07 18:31:42 +00:00
Carson Greene
6b4dc767f9
Bug 1591494 - Make KeyPressEventModelCheckerChild a JSWindowActorChild instead of ActorChild r=barret,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D51429
--HG--
extra : moz-landing-system : lando
2019-11-07 14:07:04 +00:00
Carson Greene
64dd6427d1
Bug 1576911 - Make ThumbnailsChild a JSWindowActorChild instead of ActorChild r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D45957
--HG--
extra : moz-landing-system : lando
2019-11-06 23:32:35 +00:00
Gabriel Luong
d1c32b6f80
Bug 1575075 - Add an audio toggle button in PiP to mute and unmute a video. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D51413
--HG--
extra : moz-landing-system : lando
2019-11-04 21:14:50 +00:00
Gijs Kruitbosch
00778dd54e
Bug 1591212 - make webchannel work with fission, r=vladikoff,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D51214
--HG--
rename : toolkit/modules/WebChannel.jsm => toolkit/actors/WebChannelParent.jsm
rename : browser/base/content/test/general/browser_web_channel.js => toolkit/modules/tests/browser/browser_web_channel.js
rename : browser/base/content/test/general/browser_web_channel.html => toolkit/modules/tests/browser/file_web_channel.html
rename : browser/base/content/test/general/browser_web_channel_iframe.html => toolkit/modules/tests/browser/file_web_channel_iframe.html
extra : moz-landing-system : lando
2019-11-02 00:39:35 +00:00
Teja Bayya
d5ff37172c
Bug 1576915 Port of Picture in Picture to JSWindowActors r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D49797
--HG--
extra : moz-landing-system : lando
2019-11-01 14:15:22 +00:00
Mike Conley
96bc42ea9f
Bug 1592729 - Don't allow initting Picture-in-Picture for MediaStream videos. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D51159
--HG--
extra : moz-landing-system : lando
2019-10-31 14:37:26 +00:00
Mark Striemer
8098a9825a
Bug 1590780 - Cleanup PiP video listeners when closed r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50670
--HG--
extra : moz-landing-system : lando
2019-10-25 22:22:23 +00:00
dennisschagt
31a3f7f1d0
Bug 1568373 - Use black background for Picture-in-Picture window r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D49348
--HG--
extra : moz-landing-system : lando
2019-10-17 16:29:43 +00:00
James Teh
cb2f077062
Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin
...
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.
In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.
This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.
Differential Revision: https://phabricator.services.mozilla.com/D43901
--HG--
extra : moz-landing-system : lando
2019-10-16 06:10:32 +00:00
Mike Conley
3c92d6087f
Bug 1587362 - Make sure PiP toggle mouse button listeners are attached to the right WindowRoot after tab tear out / in. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D48885
--HG--
extra : moz-landing-system : lando
2019-10-11 23:36:59 +00:00
shindli
cc3e1c3110
Backed out 2 changesets (bug 1587362) for causing very frequent bc failures in toolkit/mozapps/extensions/test/browser/browser_about_debugging_link.js CLOSED TREE
...
Backed out changeset d3142d807c7f (bug 1587362)
Backed out changeset c71f9a59bdfe (bug 1587362)
2019-10-12 02:32:13 +03:00
Mike Conley
8db106d422
Bug 1587362 - Make sure PiP toggle mouse button listeners are attached to the right WindowRoot after tab tear out / in. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D48885
--HG--
extra : moz-landing-system : lando
2019-10-11 21:00:15 +00:00
Matt Woodrow
e75df5c8ff
Bug 1578624 - P8: Use BrowsingContext::loadURI in RemoteWebNavigation. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D44764
--HG--
extra : moz-landing-system : lando
2019-10-11 02:27:42 +00:00
Mike Conley
51b7a87654
Bug 1585769 - Create a fresh <video> element for the Picture-in-Picture player window rather than cloning the original element. r=JSON_voorhees
...
Cloning the original node was needed when we needed the MediaInfo copied over, but
HTMLVideoElement::CloneElementVisually copies it over for us, so we can create a
fresh <video> element. This should also be a much healthier thing to do
security-wise, since we're not cloning strange nodes from the web.
Differential Revision: https://phabricator.services.mozilla.com/D48123
--HG--
extra : moz-landing-system : lando
2019-10-10 13:57:48 +00:00
Neil Deakin
ec8b2c4f13
Bug 1573836, make autocomplete component fission compatible, r=mak,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D47093
--HG--
rename : toolkit/modules/AutoCompletePopupContent.jsm => toolkit/actors/AutoCompleteChild.jsm
rename : toolkit/components/satchel/AutoCompletePopup.jsm => toolkit/actors/AutoCompleteParent.jsm
extra : moz-landing-system : lando
2019-10-09 19:02:57 +00:00
Brindusan Cristian
ef3c975bc9
Backed out 11 changesets (bug 1578624) for build bustages. CLOSED TREE
...
Backed out changeset b22733eb880f (bug 1578624)
Backed out changeset cb5e15489635 (bug 1578624)
Backed out changeset f1746b2f9dec (bug 1578624)
Backed out changeset d08a099a22ff (bug 1578624)
Backed out changeset 8ebd563c72a8 (bug 1578624)
Backed out changeset d8bfec2dc9b6 (bug 1578624)
Backed out changeset 591664928bce (bug 1578624)
Backed out changeset 63f5a619b9ef (bug 1578624)
Backed out changeset ff67cc13cdf3 (bug 1578624)
Backed out changeset 43556c937a09 (bug 1578624)
Backed out changeset 49065a55694d (bug 1578624)
2019-10-09 11:50:37 +03:00
Matt Woodrow
837665db5f
Bug 1578624 - P8: Use BrowsingContext::loadURI in RemoteWebNavigation. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D44764
--HG--
extra : moz-landing-system : lando
2019-10-09 06:37:51 +00:00
Narcis Beleuzu
3429292547
Backed out 11 changesets (bug 1578624) for bustages on WindowGlobalChild.h . CLOSED TREE
...
Backed out changeset 478897956ee0 (bug 1578624)
Backed out changeset ab9c09164df0 (bug 1578624)
Backed out changeset f461f10efa46 (bug 1578624)
Backed out changeset 9b958693a003 (bug 1578624)
Backed out changeset 3b8220a15051 (bug 1578624)
Backed out changeset 180407dc57a8 (bug 1578624)
Backed out changeset bb11892e2171 (bug 1578624)
Backed out changeset 4f5c28244290 (bug 1578624)
Backed out changeset 6c02bbe5c1c5 (bug 1578624)
Backed out changeset 1d762fdce921 (bug 1578624)
Backed out changeset 818bc6e20c7d (bug 1578624)
--HG--
extra : histedit_source : ea22e628bf35425402009e9af274602f342a7476
2019-10-09 08:52:25 +03:00
Matt Woodrow
dedb2503fc
Bug 1578624 - P8: Use BrowsingContext::loadURI in RemoteWebNavigation. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D44764
--HG--
extra : moz-landing-system : lando
2019-10-04 02:02:46 +00:00
Tyler
b354857779
Bug 1576908 - uses fission model for sending purge history messages r=mconley,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D45959
--HG--
extra : moz-landing-system : lando
2019-10-03 14:03:34 +00:00
Mike Conley
7429e303ed
Bug 1582502 - Don't interpret a click at 0,0 of a fullscreen video as a click on the Picture-in-Picture toggle. r=JSON_voorhees
...
We weren't handling the case where the toggle has no dimensions, so its X and Y
coordinate would be at 0,0, which would match a click in the top-left corner of
the screen for a video that was fullscreened.
This adds a check that ensures that the toggle has both width and height before
checking whether or not a mouse event occurred within it.
Differential Revision: https://phabricator.services.mozilla.com/D47789
--HG--
extra : moz-landing-system : lando
2019-10-01 18:07:14 +00:00
Mike Conley
5794ef1442
Bug 1549442 - Make sure to hide the Picture-in-Picture toggle when the mouse cursor leaves the window. r=JSON_voorhees
...
Originally, we were using the :hover pseudoclass to show the Picture-in-Picture toggle,
and using the DevTools InspectorUtils module to manually apply that :hover pseudoclass
in PictureInPictureToggleChild in the event that the <video> element wasn't able to get
the :hover element "naturally".
Removing this pseudoclass when the mouse leaves the browser window (without first
leaving the toggle) doesn't work, since the mouseout event (which we use to detect
the mouse leaving the window) fires _after_ :hover states would normally be cleared,
so it's too late to "unlock" it.
The solution ended up being replacing the :hover pseudoclass with a .hovering class
that PictureInPictureToggleChild continues to manage on its own.
Differential Revision: https://phabricator.services.mozilla.com/D47677
--HG--
extra : moz-landing-system : lando
2019-10-01 18:09:43 +00:00
Mike Conley
cf8d0284a0
Bug 1583882 - Close Picture-in-Picture player window if the originating <video> is removed from the DOM. r=JSON_voorhees
...
Differential Revision: https://phabricator.services.mozilla.com/D47613
--HG--
extra : moz-landing-system : lando
2019-10-01 16:20:51 +00:00
Neil Deakin
4348582007
Bug 1582833, update findbar state correctly when findbar is closed to allow keyboard to work properly, r=mikedeboer
...
Differential Revision: https://phabricator.services.mozilla.com/D46906
--HG--
extra : moz-landing-system : lando
2019-09-30 15:12:28 +00:00
Coroiu Cristina
c094fff9aa
Backed out changeset ea2c69779571 (bug 1577381) for a11y failures at accessible/tests/mochitest/attributes/test_obj_group.xul on a CLOSED TREE
2019-09-27 08:00:39 +03:00
James Teh
1adf6ac726
Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin
...
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.
In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.
This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.
Differential Revision: https://phabricator.services.mozilla.com/D43901
--HG--
extra : moz-landing-system : lando
2019-09-27 02:50:59 +00:00
Alexander Surkov
b56e085e0c
Bug 1584218 - form autofill and HTML:select don't respect ui.popup.disable_autohide preference r=emilio,MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D47322
--HG--
extra : moz-landing-system : lando
2019-09-26 22:07:07 +00:00
Tim Nguyen
b0d1ddb586
Bug 1581956 - Make search-textbox not use the <textbox> tag. r=surkov,MarcoZ
...
Differential Revision: https://phabricator.services.mozilla.com/D46219
--HG--
extra : moz-landing-system : lando
2019-09-25 19:12:48 +00:00
Neil Deakin
b6a3fc1ce5
Bug 1553384, remove old find/findAgain methods in typeaheadfind in favour of a single find method, r=mikedeboer
...
Differential Revision: https://phabricator.services.mozilla.com/D41232
--HG--
extra : moz-landing-system : lando
2019-09-18 09:31:43 +00:00
Neil Deakin
4ca768c7f6
Bug 1553384, update find extension api to support out-of-process iframes. r=mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D41229
--HG--
extra : moz-landing-system : lando
2019-09-17 23:31:34 +00:00
Neil Deakin
1ab71ae6f9
Bug 1553384, update findbar actors to inherit from JSWindowActor so that type ahead find works in out of process iframes, r=mikedeboer
...
Differential Revision: https://phabricator.services.mozilla.com/D41226
--HG--
extra : moz-landing-system : lando
2019-09-17 23:29:46 +00:00
Neil Deakin
9a9e65a7e5
Bug 1553384, find should iterate over each frame within a document in the parent process to allow out-of-process frames to be searched through, r=mikedeboer
...
Differential Revision: https://phabricator.services.mozilla.com/D41224
--HG--
extra : moz-landing-system : lando
2019-09-17 23:28:41 +00:00
Mike Conley
376b551e6b
Bug 1543810 - Regression test to ensure that the Picture-in-Picture works with videos that have pointer-events: none. r=JSON_voorhees
...
Differential Revision: https://phabricator.services.mozilla.com/D45232
--HG--
extra : moz-landing-system : lando
2019-09-14 14:27:37 +00:00
monikamaheshwari
9d60e0d578
Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D45629
--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Frederik Braun
a4a5944876
Bug 1530709 - Restrict styles to known selectors and single rules per message r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D43945
--HG--
extra : moz-landing-system : lando
2019-09-13 14:30:58 +00:00
Mike Conley
ef4806bc17
Bug 1543810 - Make sure Picture-in-Picture toggle works on videos that have pointer-events: none. r=JSON_voorhees
...
Differential Revision: https://phabricator.services.mozilla.com/D45231
--HG--
extra : moz-landing-system : lando
2019-09-11 18:38:30 +00:00
Noemi Erli
f74e07d847
Backed out 2 changesets (bug 1543810) for failing in browser_togglePointerEventsNone.js CLOSED TREE
...
Backed out changeset a0c079f40c78 (bug 1543810)
Backed out changeset 5aec6172783d (bug 1543810)
2019-09-11 19:04:59 +03:00