1087454416
Back out changeset 76411e442ff3 (bug 1262866) for causing the crashreporter browser-chrome tests to run on, and thus fail on, the --disable-crashreporter ASan builds
2016-04-11 20:34:05 -07:00
dc426e9cbb
Bug 1262866 - Include toolkit/crashreporter/test/browser/browser.ini in a more central moz.build to avoid a failure when running tests against --disable-crashreporter builds. r=mshal
...
MozReview-Commit-ID: 9DzmJjzpZe7
2016-04-11 11:21:20 -07:00
3540ae23db
Bug 1257486 - Annotate global memory status in the crash reporter for child process; r=bsmedberg
...
MozReview-Commit-ID: ExVZS3aAp41
--HG--
extra : rebase_source : 9ddf96d5ce95aa96629e8772ae33719a6898e235
2016-03-29 19:16:09 +08:00
f7a1b3fb60
Bug 1242051 - Add inter-directory test support file dependencies to ini manifests. r=gps
...
Previously, every test and support file would be synced to the objdir
when running any test. Now that only those support files and tests requested
are synced, we note support files required beyond those in a test's
directory in ini manifests.
MozReview-Commit-ID: EmlDz9d4lqt
2016-04-04 14:56:52 -07:00
ea170a13cf
Bug 1257209 - record uptime in crash metadata/pings, r=gfritzsche
...
MozReview-Commit-ID: 8MVRwALXvW5
--HG--
extra : rebase_source : e79362e885ca4986c1c4b8a3a82830de88f1107b
2016-03-16 16:59:06 -04:00
702c087507
Bug 1187270 - Add Telemetry session ID to crash annotations, r=gfritzsche
...
MozReview-Commit-ID: GwVI0dfsT4H
--HG--
extra : rebase_source : 0ae9efbce919efcd0f20314bd89848da017b7e57
2016-03-14 09:31:19 -04:00
58e5e16c44
backout d85b18faba72 (bug 1187270) for build bustage.
2016-03-15 15:51:56 -07:00
42e1362b4d
Bug 1187270 - Add Telemetry session ID to crash annotations, r=gfritzsche
...
MozReview-Commit-ID: GwVI0dfsT4H
--HG--
extra : rebase_source : fae01778b3afbe6ca9dfcf774cead01eeac50445
extra : histedit_source : 98c0c070effca99711e35b4b4c3124a9fbdba089
2016-03-14 09:31:19 -04:00
89f2907216
Bug 1254120 - Remove toolkit/crashreporter/test/Makefile.in; r=ted
...
MozReview-Commit-ID: 9RTd5ty1GDC
2016-03-11 14:24:36 -05:00
89e67972f0
Bug 1236108: Add support for exception-context annotations for content processes to the crash reporter; r=bsmedberg
...
This patch redefines XP_PATH_MAX on Windows to be MAX_PATH + 1. I did this
because the longer definition would actually not work with most Windows APIs.
Some APIs can work with longer lengths if the path is prefixed with "\\?\", but
that is not guaranteed in general.
See https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#maxpath
MozReview-Commit-ID: LhT5oM5hlkl
--HG--
extra : rebase_source : 377f92157010c924d8ab1d9af5f93a9496526d5f
2016-03-07 12:48:58 -08:00
cf23a40c78
Bug 1241930: Part 6 - convert all assertion methods used inside content tasks to the Assert.* family in toolkit tests. r=mconley
2016-03-04 14:32:34 +01:00
8801eafc2e
Bug 1245723 - Make crashreporter browser-chrome tests e10s compatible. r=felipe
2016-02-09 14:40:35 -08:00
ea6f9a1958
bug 1069556 - sync to Breakpad c53ed143108948eb7e2d7ee77dc8c0d92050ce7c. r=glandium, benwa
...
This commit contains a few things:
* Update our copy of google-breakpad to upstream c53ed143108948eb7e2d7ee77dc8c0d92050ce7c
* Get rid of all but one local patch, fold a few related local patches into one
* Misc build fixup to sync with upstream--adding a few new moz.build files,
source files
* The final bits of unhooking Breakpad from the profiler:
** Revert to only building toolkit/crashreporter if MOZ_CRASHREPORTER.
** Stop building bits of Breakpad that we only needed for the profiler.
** Remove a few bits of profiler code that were used to interface with Breakpad.
** Remove toolkit/crashreporter/breakpad-logging, which was only used to
suppress Breakpad logging for the in-process stackwalker.
* Upstream removed their Android-compat sys/ucontext.h because the Android NDK
added it, but the bionic we're using for Gonk builds is too old, so add a
copy of the previous version of those files to
toolkit/crashreporter/gonk-include to keep Gonk building.
* Consolidate moz.build files under toolkit/crashreporter/google-breakpad/client/linux
--HG--
rename : toolkit/crashreporter/google-breakpad/src/common/pathname_stripper.h => toolkit/crashreporter/google-breakpad/src/processor/pathname_stripper.h
rename : toolkit/crashreporter/google-breakpad/src/common/pathname_stripper_unittest.cc => toolkit/crashreporter/google-breakpad/src/processor/pathname_stripper_unittest.cc
extra : histedit_source : 43e65f5432657f548cac5aa7936461e58454c3b6%2C7b56ccc79d9d58ebde0583d920f3593e25212621
extra : rebase_source : f6dbfb8fb2ba5b27e63b26d57c404962679c7a76
extra : commitid : DMQlXPms868
extra : source : 09fd4f3ab6e764016fe073efb226f03b5969af59
extra : intermediate-source : 16f9d3a6d2ef6a6efd088e3b8eff0a4723daef8f
2016-01-27 09:39:53 -05:00
c8e4d5fbbc
Bug 1245649: Turn on use-isnan, no-unexpected-multiline, no-octal and no-self-compare. r=MattN
...
--HG--
extra : commitid : oKFzhSyf1r
extra : rebase_source : 0d31d93961cdfb2e5e467e0c7f28edb4ab14a083
2016-02-03 18:21:30 -08:00
e496a11771
Bug 1245649: Turn on no-extra-semi. r=markh
...
--HG--
extra : commitid : HReQFPDOA6x
extra : rebase_source : 303a92f511c3c9dd2d26135975d4dc7c85e823b3
2016-02-03 17:27:36 -08:00
33281c75f0
Bug 1245649: Turn on linebreak-style. r=Gijs
...
--HG--
extra : commitid : 7JJb4UFNKj9
extra : rebase_source : 5c30f388ad82d3b73ce7d14c71a48a1f0ed84db7
2016-02-03 17:04:56 -08:00
31fb709fc3
Bug 1243928 - Make these tests work in e10s. r=felipe
2016-02-02 13:44:11 -08:00
86f03db916
Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8
...
--HG--
extra : commitid : CKT2WDkxE4k
extra : rebase_source : 0be50c483317355b1e9af5985d53e85604748432
extra : histedit_source : 65d203f57ebd38b8c130e5db9aaa8ae3f507e7ac
2015-11-30 13:05:00 -08:00
6fcdc1e67d
Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN
...
--HG--
extra : commitid : 1iLsb7ZpSpI
extra : rebase_source : ed920934f04e520f5410454ec3930cd5992aa965
2015-12-03 10:02:45 -08:00
8caec249c9
Bug 1228742 - Don't install CrashTestUtils.jsm to dist/bin/modules. r=mshal
...
It's actually shipped by mistake, and it's copied to the appropriate
test directory by other means.
2015-12-01 08:25:22 +09:00
9985829ecc
Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj
2015-11-02 07:53:26 +02:00
65e2703499
Bug 1217082 - Remove for-each from toolkit/. r=Gijs
...
--HG--
extra : commitid : Ewr7Bixammr
extra : rebase_source : 91e560a7b8b8d4b78debb1db2512867262b18375
2015-10-19 04:57:14 +09:00
80fca20565
Bug 1194555 - Part 6: Run reporters asynchronously. r=njn,jld,ted
2015-10-14 16:52:59 -07:00
08997000eb
Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
...
Backed out changeset 647025383676 (bug 12029021202902
2015-10-07 14:03:21 +02:00
e7ef778c9d
Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
...
Backed out changeset cfc1820361f5 (bug 1202902
2015-10-07 12:13:45 +02:00
d06b6030f6
Bug 1202902 - Scripted fix the world.
2015-10-06 14:00:31 -07:00
8a0aa17cb2
Bug 1207497 - Part 2: Remove use of expression closure from tests in toolkit/. r=Gijs
...
--HG--
extra : commitid : F0AJXZT2xzk
extra : rebase_source : 4b076123afebebf10abfe62872d98f0a21e91ac8
2015-09-24 21:25:24 +09:00
64db2267cf
Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
ce50a0bf86
Bug 1194603 - Remove INTERNAL_TOOLS; r=mshal
...
Its only purpose is to disable PGO. Where that was not already explicitly done,
or irrelevant (because the directory only contains python), I disabled it in
moz.build.
2015-09-10 13:49:19 +02:00
50e851b877
Bug 830801 - Part 2. Remove NOMINMAX define from moz.build. r=mshal
2015-08-03 10:07:09 +09:00
543daa65bc
bug 1166759 - force annotateCrashReport arguments to be UTF-8. r=bsmedberg
...
--HG--
extra : rebase_source : ffc4ee94de01206b853d5f69b26d0ad62836c2b2
2015-05-22 10:50:32 -04:00
a224ee9100
Bug 1142300 - Closing descriptor when fscanf fails. r=erahm
2015-05-14 15:49:00 -07:00
fe90037862
Bug 1043692 - Add a DIST_INSTALL variable to moz.build, and replace NO_DIST_INSTALL with it. r=gps
2015-05-12 07:55:21 +09:00
254715ac08
Bug 1121013 part B - test that part A is writing out event files and annotations are making it back into the crash manager, r=ted
...
--HG--
extra : rebase_source : cf6a43d67c4876be6ec19db5f4389d405e88cfe0
extra : source : 7cecb4e23fcf3bd8693e7b421abe29abb07ce01e
2015-03-25 14:41:13 -04:00
6137a8c380
Bug 958147 - Choose one of run-if or skip-if and get rid of the other. r=ted
2015-01-28 06:17:00 -05:00
0babb98b86
Backout 7cbe50231e18 (bug 1103825) for xpcshell test failures
...
toolkit/crashreporter/test/unit_ipc/test_content_annotation.js was
failing with this commit applied. Backing out.
2014-11-25 19:16:57 -08:00
0f6c7a12e1
Bug 1103825 - Use misc tier in toolkit/crashreporter/test; r=mshal
...
--HG--
extra : rebase_source : 56e5266d114dc802ac769fbf3f3dc0cd48457a0b
extra : histedit_source : 7fc3e342616f87bd1ecd47e8cc375f0d77af849b
2014-11-23 16:21:31 -08:00
41848ac6fa
Bug 1044020 - Add duration of shutdown phases to Telemetry. r=froydnj
2014-11-10 13:58:14 +01:00
8ca591dc71
Bug 1084162 - Part 0: Mark testcrasher.dll as INTERNAL_TOOLS to prevent PGO. r=ted
2014-11-04 14:26:01 +13:00
47c853314f
Bug 1077148 part 4 - Add and use new moz.build templates for Gecko programs and libraries. r=gps
...
There are, sadly, many combinations of linkage in use throughout the tree.
The main differentiator, though, is between program/libraries related to
Gecko or not. Kind of. Some need mozglue, some don't. Some need dependent
linkage, some standalone.
Anyways, these new templates remove the need to manually define the
right dependencies against xpcomglue, nspr, mozalloc and mozglue
in most cases.
Places that build programs and were resetting MOZ_GLUE_PROGRAM_LDFLAGS
or that build libraries and were resetting MOZ_GLUE_LDFLAGS can now
just not use those Gecko-specific templates.
2014-10-30 13:06:12 +09:00
d292ee73f1
Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester
2014-10-07 18:18:28 -04:00
1090f50427
Backed out changeset 0ec9bd8e9880 (bug 1044020) for asan failures
2014-09-30 17:35:44 +01:00
33d73c6559
Bug 1044020 - Add the duration of shutdown phases to Telemetry. r=froydnj
2014-09-30 11:43:46 +02:00
579061de7c
Mac v2 signing - Bug 1060562 - Update xpcshell-tests for the new v2 bundle structure on OSX. r=jmaher
2014-09-29 11:51:29 -07:00
33d7b690ac
Backed out changeset 49b1465d3e5e (bug 1044020) for compilation failures
2014-09-29 15:41:54 +01:00
e3611bca94
Bug 1044020 - Add the duration of shutdown phases to Telemetry. r=froydnj
2014-09-25 17:19:34 +02:00
4b99580194
Bug 1059113 - Use templates for shared libraries and frameworks. r=gps
...
Also force to use the existing template for XPCOM components.
2014-09-04 09:04:45 +09:00
ed70c5f377
Bug 1041941 - Use templates for programs, simple programs, libraries and C++ unit tests. r=gps
2014-09-03 14:10:54 +09:00
73981dd834
Bug 1007534 - Part 6: xpcshell test for memory data in crash reporter. r=ted
2014-08-30 17:22:14 +12:00
8cb88f5b6b
Bug 1007534 - Part 5: Support memory files in CrashSubmit.jsm. r=ted
2014-08-30 17:21:25 +12:00
eb93e16fa1
Bug 1038342 - Add a Shutdown watchdog. r=froydnj, r=ted, sr=bsmedberg
2014-08-26 14:54:43 +02:00
89777800f9
Bug 1047267 - Move remaining OS_LIBS and EXTRA_LIBS to moz.build. r=gps
...
* * *
Bug 1047267 - To fold with "Move remaining OS_LIBS and EXTRA_LIBS to moz.build"
2014-08-07 14:21:03 +09:00
542214c4df
Bug 1044162 - part 1 - make EXTRA_{PP_,}JS_MODULES communicate their installation path; r=mshal
...
This patch makes EXTRA_{PP_,}JS_MODULES similar in functionality to
TESTING_JS_MODULES: we indicate the path relative to
$(FINAL_TARGET)/modules with an appropriate hierarchy of paths.
2014-07-25 13:40:07 -04:00
7cab62150a
Bug 1041936 part 2 - Directly use the static library "xul" to link into "xul-gtest" instead of having an intermediate library "xul" used by "xul-shared" and "xul-gtest". r=gps
2014-07-23 13:33:09 +09:00
95063176fa
Bug 1036894 part 9 - Replace all EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS with EXTRA_LIBS, OS_LIBS or OS_LDFLAGS, appropriately. r=gps
...
OS_LIBS for libraries that are not part of the gecko tree, EXTRA_LIBS for
libraries, such as NSPR, that are in the tree, but are not handled by
moz.build just yet. Those EXTRA_LIBS may also come from a system library.
However, in cases where the expanded variables are always empty for the
in-tree case, OS_LIBS is used (as for, e.g. MOZ_ZLIB_LIBS). OS_LDFLAGS is
used exclusively for non-library linker flags.
Always pass EXTRA_LIBS before OS_LIBS on linker command lines.
Forbid EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS in Makefiles.
2014-07-23 13:31:02 +09:00
5fab42fcaf
Bug 1036894 part 8 - Move most in-tree library linkage information to moz.build, as USE_LIBS. r=gps
2014-07-23 13:30:52 +09:00
d3f990ebdb
Bug 1040639 - Remove LIBS_DIR. r=mshal
2014-07-19 08:42:16 +09:00
24fcd57abd
Bug 1008944 - Expose AsyncShutdown barriers for OS.File. r=froydnj
2014-06-17 15:11:00 -04:00
d337b14be1
Bug 1022684 - add -Wno-unused-local-typedefs to various bits of crashreporter building; r=mshal
2014-06-09 11:12:06 -04:00
394d31a92b
Bug 1018895 - Make AsyncShutdown output easier to parse by TBPL. r=froydnj, r=edmorley
2014-06-03 01:14:00 -04:00
0629a4a901
Bug 987995, part 4 - Add new crash reporter annotations for JS out-of-memory conditions. r=mccr8,r=bsmedberg.
2014-05-22 08:18:02 -05:00
ee8279fff4
Bug 997440 - Fix some more error reporting in crashreporter tests. r=bholley
2014-05-20 22:52:19 -07:00
f1907fd96d
Bug 983313 - Write crash events for plugin crashes and hangs (part 1: main changes). r=bsmedberg
2014-05-12 11:58:18 -07:00
b8e40d8501
Bug 839778 - Use OS.File in about:crashes. r=adw
2014-04-13 14:28:18 -04:00
cae334e085
Bug 987404 - Disable failing mochitest-browser tests in e10s. r=ted.
2014-04-02 10:53:55 +11:00
bf44435306
Bug 961665 - Tests for OS.File.read. r=froydnj
2014-03-13 09:52:07 -04:00
d2b4456c69
Backed out changesets c6ca1aa3887a, d741e117a033, 1fd26e822e73, and 720962c9f993 (bug 961665) for build bustage and xpcshell failures.
2014-03-13 10:32:57 -04:00
e54ffe3fe8
Bug 961665 - Tests for OS.File.read. r=froydnj
2014-03-13 09:52:07 -04:00
d0df766a7d
Backed out changeset 6cc5a05281c3 (bug 976863) for xpcshell failures.
...
CLOSED TREE
2014-03-05 15:36:26 -05:00
605cb7f12d
Bug 976863 - Prevent tests from using CrashTestUtils.CRASH_ABORT on Windows; r=bsmedberg
...
--HG--
extra : rebase_source : 4f121bbe6b9ca87b2f4d6e2cbad4bb7a2ecb509a
2014-02-25 16:46:41 -08:00
a0a4ade497
Bug 875562 - Part 8: Write crash events for main process crashes; r=bsmedberg
...
This patch makes the crash reporter crash event directory aware and
writes main process crash event files at crash time.
--HG--
extra : rebase_source : 1d6a817ae401230b3fe8fcd236468ceb3e309a10
2014-02-18 15:58:03 -08:00
8453de76b1
Bug 965527 - Further AsyncShutdown error reporting for OS.File. r=yoric
2014-02-24 10:15:47 -05:00
33da18c67e
Bug 968856 - Move unconditional LOCAL_INCLUDES into moz.build; r=mshal
2014-02-15 21:24:59 +01:00
0f98f9b5f7
Bug 957123 - Extend error reporting of AsyncShutdown. r=froydnj
2014-02-07 16:09:02 -05:00
7338071654
Bug 875013 - VPATH removals in build, roboextender, crashreporter; r=ted
2014-01-21 18:01:22 -05:00
691df07b08
bug 918389 - move XPCOM abort messages into separate crash annotations. r=bsmedberg
...
--HG--
extra : rebase_source : d1762cb08c795020e2ca7612b903cd1f3d5ade50
2013-12-20 10:11:16 -05:00
0a92acb18d
Get rid of DOS line endings in test_crash_runtimeabort.js (no bug)
...
--HG--
extra : rebase_source : c59c15e2c3abde291d6a53a26c5f3d04aae8ab23
2013-12-20 10:11:04 -05:00
912bf8a846
Bug 940821 - Build crashreporter in unified mode; r=ted
2013-12-13 09:55:39 -05:00
6b9009565b
Bug 939271 - Part i: move mochitests to manifests in toolkit/crashreporter/test; r=ted
2013-11-28 15:04:19 +01:00
8fd06cf41b
Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal
2013-11-27 22:55:07 +09:00
b32a4ed166
Backout changeset 3fd4b546eed4 (bug 874266) and changeset a35d2e3a872f (bug 942043) for ASAN build bustage and Windows test bustage
...
--HG--
extra : amend_source : f20d09aeff1c8b5cbd0f1d24c7ce04e86f3aed1d
2013-11-28 14:24:05 +09:00
682364d535
Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal
2013-11-28 13:08:16 +09:00
b2e90f6233
Bug 914245 - Move FORCE_SHARED_LIB to moz.build. r=mshal
2013-11-19 11:47:45 +09:00
e80e877ab7
Bug 939044 - Remove most definitions of MODULE. r=mshal
2013-11-19 11:47:39 +09:00
3f65220584
Bug 934337 - Get rid of custom rules fiddling with SHARED_LIBRARY. r=mshal
...
While here, remove other custom rules in the same Makefiles.
2013-11-05 13:28:26 +09:00
b000a846c2
Bug 929905 - Consolidate sources in moz.build. r=gps
2013-10-25 08:23:05 +09:00
3fa7456cd6
Bug 913268 - Make CPP_SOURCES a StrictOrderingOnAppendList. r=mshal
2013-10-24 08:00:23 +09:00
d0cf2be39f
Bug 784739 - Switch from NULL to nullptr in toolkit/crashreporter/; r=ehsan
2013-10-10 16:39:09 -04:00
16f90ae98c
Bug 912099 - Part f: Make sure CPP_SOURCES only points to existing files in toolkit/crashreporter; r=mshal
2013-10-03 09:10:01 +02:00
333a672bf3
Bug 917764 - If clients fail to resolve AsyncShutdown blockers, crash the process. r=froydnj, r=ted
...
--HG--
rename : toolkit/modules/tests/xpcshell/test_phase.js => toolkit/modules/tests/xpcshell/test_AsyncShutdown.js
2013-09-30 10:59:40 -04:00
7bd3c0ae36
Bug 901990 - Part 2: Upgrade xpcshell manifests; r=ted
...
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell-unpack/head_unpack.js => toolkit/mozapps/extensions/test/xpcshell/head_unpack.js
2013-09-24 11:50:08 -07:00
c1414ec66f
bug 717758 - Breakpad test for abort() crashes. r=glandium
2013-09-16 14:44:25 -04:00
f8bc7fa754
Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps
2013-09-05 09:01:46 +09:00
ca9a717499
bug 842728 - init Breakpad from C++ in xpcshell, remove ability to init from script. r=bholley,gps
2013-08-15 14:48:12 -04:00
df453f8483
Bug 850380 - Derecursify and optimize XPIDL processing and move into precompile tier; r=glandium
2013-08-14 08:40:25 -07:00
fab2c2a3c8
Backed out changesets 1fa1f28c6edf and e74f694f31c4 (bug 850380) for PGO bustage on a CLOSED TREE.
2013-08-14 15:12:20 -04:00
d87c91cf0c
Bug 850380 - Derecursify and optimize XPIDL processing and move into precompile tier; r=glandium
2013-08-14 08:40:25 -07:00
e67903f544
Bug 889076 - Use the profile dir to store minidumps in the crashreporter xpcshell tests. r=ted
2013-07-10 14:10:04 -07:00
19850b9b8e
Bug 891632 - Port NO_DIST_INSTALL to moz.build; r=joey
...
Many of the moved variables are likely not needed. moz.build should one
day validate the sandbox's output and error if "useless" variables are
present.
--HG--
extra : rebase_source : 3abdea056c18d00ede8c15b37db60532eca58630
2013-07-10 12:08:21 -07:00
fab4df789a
Bug 880245 - Move EXTRA_JS_MODULES to moz.build (batch #2 ); r=joey
2013-06-17 15:22:56 -04:00
Phil Ringnalda
Chris Manchester
Cervantes Yu
Benjamin Smedberg
Daniel Holbert
Mike Shal
Aaron Klotz
Mike de Boer
Blake Kaplan
Ted Mielczarek
Dave Townsend
Mike Hommey
Birunthan Mohanathas
Tooru Fujisawa
Eric Rahm
Carsten "Tomcat" Book
Shu-yu Guo
Ms2ger
Makoto Kato
Jose' Rios
jp111
Gregory Szorc
David Rajchenbach-Teller
David Major
Andrew Halberstadt
Ed Morley
Stephen Pohl
Nathan Froyd
Jason Orendorff
Bob Owen
Drew Willcoxon
Marco Castelluccio
Mark Hammond
Ryan VanderMeulen
Ehsan Akhgari
Mihnea Dobrescu-Balaur