This method is not a virtual call, and also looks nicer.
This patch was mostly generated by a Python script, but I manually
cleaned up the code in a few places where statements didn't need to be
split across multiple lines any more.
MozReview-Commit-ID: 8JExxqSRc59
--HG--
extra : rebase_source : df6330a89e8d65dfe7a6fda0c8cb9f9732302efc
Long-running Firefox sessions with modern websites can accumulate
numerous serialized principal strings for session history. Even short
sessions can accumulate ~10MB of duplicated strings, and users have
reported 10s or even 100s of MB of duplicated strings. Let's cache the
string we generate for a given principal so we don't wind up with a
bunch of duplicate strings.
Async-ify some tests.
Moves some tests from browser-chrome to xpcshell.
Due to the move, I found out that we are fetching icons from network even when
we are not supposed to, so fix this bug (automatically tested by xpcshell through
disallowing remote network access).
Add a missing test for bookmark redirects, to cover the moved around code.
MozReview-Commit-ID: EB2Z0huovJh
--HG--
rename : toolkit/components/places/tests/browser/browser_favicon_setAndFetchFaviconForPage.js => toolkit/components/places/tests/favicons/test_setAndFetchFaviconForPage.js
rename : toolkit/components/places/tests/browser/browser_favicon_setAndFetchFaviconForPage_failures.js => toolkit/components/places/tests/favicons/test_setAndFetchFaviconForPage_failures.js
extra : rebase_source : 5289551f205bea9c5f2c6e68bbc70ce421b77311
Extension ports are automatically closed when the message manager of
the source is destroyed. When a tab is detached from a window, its
frameloader is moved to the new window and the original message
manager is destroyed.
Bug 1445537 started listening for SwapDocShells events, but that only
works for the first swap (e.g. detaching a tab once). To avoid early
disconnection of the port, we should continue to subscribe to
SwapDocShells events.
MozReview-Commit-ID: G2ZYAhNyHIL
--HG--
extra : rebase_source : 9f888482e63d2768adf3dbd1c484a483dc307b2b
Before we were falling back to using the raw version, which isn't
correct on at least beta (i.e. we would get `60.0` instead of `60.0b1`).
MozReview-Commit-ID: 7NfV6iRoj4y
--HG--
extra : rebase_source : de1ea9d64d1d03c8281fc0ab9efe4ffac6fd40cb
It's a concrete class of OmxPlatformLayer for accessing OpenMAX IL
libraries directly. It will be usable on various embedded linux systems.
Note that it's not enabled by default yet. Add the following config to
your mozconfig.
ac_add_options --enable-openmax
TODO: Implement zero-copy mode
MozReview-Commit-ID: EMEXAKzzR64
--HG--
extra : rebase_source : d7c5b9baf66d87db38723b278c57fd581a3cbf98
extra : intermediate-source : b8c671a02a4fce085433b16db998c9b04ace87db
extra : source : 131b65580e3dd5c9dcb0ba6a05c16ab90c2dcc68
As we add more behaviors to EventManager, the signature of the constructor
is going to get really clumsy. Head that off by converting it to take a
general parameters object.
This introduces a compatibility problem for existing webextension experiments,
put in a backward-compatibility shim for now.
MozReview-Commit-ID: 72QDfiwRm5j
--HG--
extra : rebase_source : 31c3fd561f373a5d75c4336de830aa5a2abfe797
Contexts for active extension views are kept in a Set on the owning extension.
That list is meant to be kept current, with views added and removed as they're
created and unloaded. A refactoring at some point in the past, though, changed
that so that we only cleaned up parent views at extension shutdown, not at
view shutdown.
MozReview-Commit-ID: FW8KHPOD9qc
--HG--
extra : rebase_source : fab255ba2fb5ee55be41c252c89930d38f6edbe8
extra : amend_source : 54863d79a1d571a7354aa15f74e2fc4448297777
Remove the syn dependency from gkrust-shared, which was added in bug 1373878
as a workaround for this Cargo bug:
https://github.com/rust-lang/cargo/issues/3923
MozReview-Commit-ID: L34J0davEYd
--HG--
extra : rebase_source : 79e5684cba143f6215e7dcf9367f82227bca48c5
With a common prefix, all of the URL Classifier gtests can be run
like this:
./mach gtest UrlClassifier*
MozReview-Commit-ID: IqQznsldFOD
--HG--
extra : rebase_source : 5da7496e9607083b452c915608a0ab9adae818ff
As requested, a test for the key limit pref.
This sets it to a value lower than the limit of events we can currently send
without truncation (100), but higher than is likely to be hit by tests (since
the first time we record an event, we read the pref, so we can't unsend it).
MozReview-Commit-ID: 7pGftCa1rz3
--HG--
extra : rebase_source : b3631ef7e1f436ded1ca8c6d3e8d6a2c3987ffb2
To test the TelemetryEvents portion of the code we need TelemetryEvents
tests. (The gtests only cover portions deeper than the TelemetryScalar API).
MozReview-Commit-ID: ExaiW0OiwFI
--HG--
extra : rebase_source : 1e352e1a8c8172d92eec3270d332818e6de5ba24
This also aligns the help button to the bottom of the window even when the meta tree is hidden.
MozReview-Commit-ID: GCmgThN569z
--HG--
extra : rebase_source : 0dba1f8b8f84d5d97706a283560a3a3c6d7278d8
Introducing the pref toolkit.telemetry.maxEventSummaryKeys which we should
hopefully never have to think about because (and yes, I risk being quoted in
future for this):
500 unique event names per process ought to be enough.
We check the preference just once but have to set it each time as the
KeyedScalar object may have been recreated while we weren't looking.
MozReview-Commit-ID: 8IE9dcfuynh
--HG--
extra : rebase_source : 1865645d75e53b9122c0855ce297b7488997d357
I considered a few different ways to do this, but storing the limit inside the
KeyedScalar itself was the cleanest. The limit check is too deep to pass it as
an argument, and making it conditional on the keyed scalar being called
"telemetry.event_counts" was too fragile.
MozReview-Commit-ID: AyfEKB40Abb
--HG--
extra : rebase_source : cdaf88cbf891682eeb1b79a0fbc4e1f8cac60501
Telemetry Events will now be counted in the keyed scalar
"telemetry.event_counts" even if their category is not enabled for recording.
The keys will be category#method#object and a follow-up commit will expand the
process limit of the number of these from 100 to 500, configurable by pref.
Unfortunately Event Telemetry needs a special API so that an event recorded in
multiple processes will be summarized to those processes separately.
MozReview-Commit-ID: 7dKcM3SXO6r
--HG--
extra : rebase_source : 42af54472ac648165ac64bc5ab5a5a666830efe8
TelemetryComms includes some ipc headers we don't have in the gtest build.
MozReview-Commit-ID: 9gK6KPHeUIa
--HG--
extra : rebase_source : 1cf09253f9bc1b5f31bdeec438ef2390a99c0bb8
This allows us to store Telemetry Event category (30), method (20),
object (20), and two delimiters (2) in a single key, like so:
oohwowlookthiscategoryissolong#thismethodislongtooo#thisobjectisnoslouch
MozReview-Commit-ID: BkoU1VAXFF9
--HG--
extra : rebase_source : b172e8dd8ee925f05545a944e340fb5a43c296b1
The maximum key length constraint should be strict greater-than, and the
maximum number of keys constraint should only be checked if we are creating a
new key.
MozReview-Commit-ID: 5fhfV8BbmRH
--HG--
extra : rebase_source : 6b55ffa83ff2960e081381425322f80d1e0ba087
Additionally,
- Remove `self = this` usage
- Remove access of the `Utils` object from the scope chain
- Modify DevTools debugger test case because all event listeners are the one unwrap-able object
MozReview-Commit-ID: 5kbLgD951CM
--HG--
extra : rebase_source : 7bc01c0fbf28fbd0251d5da7f3788d071b496ab5
The flag is used to trigger play() when the control first hides.
There is no reason to set only after transition ends. We can set it to false
as soon as we trigger play().
This is likely to fix a regression from bug 1449532 given that we have switched
to Web Animation API there.
MozReview-Commit-ID: F4n3rKdzYKr
--HG--
extra : rebase_source : 133fde3832c6303b87ad42e16ed397292cb98e7c
* Compare address timeLastModified as well as the selectedShippingAddress guid when handling new state
* Add tests to ensure editing or removing the selected address record correctly updates the UI
MozReview-Commit-ID: InQDP55Fs2
--HG--
extra : rebase_source : 38aa46594bfd0263b77b6e7b50a3ee10e14def39
Given we're no longer using dependent strings in
LookupCacheV4::PrefixString(), we will end up make a copy of the
prefixes at some point. Let's do it early and remove a bunch of
complicated code.
Make the string copies fallible so that we return an error and
fail the update instead of crashing.
MozReview-Commit-ID: 5cZHSDIJSlD
--HG--
extra : rebase_source : 0ad130c2be9caf528bb764296836e91fa8a30916
Also document the meaning of mPrimed in LookupCache.h.
MozReview-Commit-ID: 63GAHwU3Rx3
--HG--
extra : rebase_source : 11307604f957efbd6879db83f916a9cb369f93ff
Dependent strings are recommended only when dealing with a character
buffer (i.e. char*). Using it here makes it more likely that we'll
hang on to a string buffer that will be deallocated.
nsCString will by default share the underlying string buffers when
it can (i.e. when copying entire strings on the heap) so it should
be able to avoid unnecessary copies.
MozReview-Commit-ID: 3rTUYmouzcT
--HG--
extra : rebase_source : 8563bc242bf41cf8e12aa0b4ccba32c6a38d952a
Some of the tests don't handle update errors very well and rely on timeouts to
fire after several minutes. Since these tests are not actually testing update
failure modes, it's safe to fail quicly and terminate the test with an
exception.
MozReview-Commit-ID: EJgaWke6kl2
--HG--
extra : rebase_source : 486797e1a3c23c5a65ae7c5134fd4db7e663a3aa
Cleanup of all localization notes that refer to entities
that are not listed in the corresponding localization file.
MozReview-Commit-ID: Bl0VU9HoPfa
--HG--
extra : rebase_source : 86680b8ae037783304f045e94c7af7053a0f69e9
Reporting was already disabled in Bug 1443605.
This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only.
This keeps `addEvent` and related methods, as they are still in use on Android.
Andrew McCreight
Felipe Gomes
Nathan Froyd
Coroiu Cristina
Dragana Damjanovic
Honza Bambas
Jan-Erik Rediger
Ryan Hunt
Gurzau Raul
Tim Nguyen
Marco Bonardo
Jan Beich
Mathieu Leplatre
arthur.iakab
Rob Wu
William Lachance
Gijs Kruitbosch
Zibi Braniecki
Andreea Pavel
Phil Ringnalda
Jonathan Kingston
Csoregi Natalia
Tooru Fujisawa
Stephen A Pohl
Boris Zbarsky
Bob Owen
Noemi Erli
Margareta Eliza Balazs
Kris Maglione
Andrew Swan
Takuro Ashie
Brindusan Cristian
Jared Wein
Timothy Guan-tin Chien
Tom Ritter
Mike Cooper
Matt Brubeck
Kartikaya Gupta
Francois Marier
Tom Schuster
Manish Kumar
k88hudson
Kim Moir
Chris H-C
Paolo Amadini
Dão Gottwald
Kit Cambridge
Franziskus Kiefer
Ursula Sarracini
Sam Foster
Michael Kaply
Julian Descottes
Marco Castelluccio