This gives a very noticable increase in speed. When Brad finishes https://bugzil.la/1523336 we can stop walking the DOM and simply use `parentFlexElement` and `parentGridElement`.
Differential Revision: https://phabricator.services.mozilla.com/D18674
--HG--
extra : moz-landing-system : lando
I would have thought that the anonymous node fix would also have fixed this but we have had to manually add the before and after pseudo elements.
Differential Revision: https://phabricator.services.mozilla.com/D18536
--HG--
extra : moz-landing-system : lando
Removes the toggle filter button and makes the filter buttons toolbar permanently shown. At the same time removes relevant entries from actions/reducers. Also updates some tests which relied on showing and hiding the filter buttons toolbar. Also amends an unrelated test which relied on the non-presence of the filter buttons toolbar.
Differential Revision: https://phabricator.services.mozilla.com/D18504
--HG--
extra : moz-landing-system : lando
Adds a new `disabled` property to the Font Editor Redux store applicable to all input fields.
When inspecting a pseudo-element, this `disabled` property is set to true.
This allows the pseudo-element to be inspected, but prevents editing font property values because it's currently not possible to write them back to CSS rules other than element inline styles.
Differential Revision: https://phabricator.services.mozilla.com/D18364
--HG--
extra : moz-landing-system : lando
We were registering these key shortcut twice.
A first time from devtools-startup.js and another time from Toolbox.
Both shortcut listeners were called when the toolbox was running,
leading the toolbox to reopen while we were expecting it to be closed.
Depends on D17610
Differential Revision: https://phabricator.services.mozilla.com/D18097
--HG--
extra : moz-landing-system : lando
When destroying the target, Target.destroy (for local tabs) only calls DebuggerClient.close,
which isn't going to call `detach`. But we still do need to unregister
the tabNavigated/frameUpdate listener to prevent unecessary event from firing.
Depends on D17609
Differential Revision: https://phabricator.services.mozilla.com/D17610
--HG--
extra : moz-landing-system : lando
This patch makes it so that all target fronts inherits from a Target class mixin.
We are using a mixin as fronts should inherit from a custom Front class,
which is augmented with its own RDP request and events defined in its spec.
(This is done via FrontClassWithSpec(spec))
Depends on D15830
Differential Revision: https://phabricator.services.mozilla.com/D15831
--HG--
extra : moz-landing-system : lando
This is another very specific issue.
If you have `<img name="attributes"/>` in the dom then `document.attributes` will return the `<img>` tag.
In the source we bail if `!this.rawNode.attributes` but if we are on the document node this returns the image tag. Because the image tag is not a `NamedNodeMap` trying to iterate over the tag throws the error.
There is a test file [here](https://bugzilla.mozilla.org/attachment.cgi?id=9040577).
Differential Revision: https://phabricator.services.mozilla.com/D18340
--HG--
extra : moz-landing-system : lando
Michael Ratcliffe
Gijs Kruitbosch
Coroiu Cristina
Brian Hackett
Nicolas Chevobbe
Martin Koroknay
Shivam Singhal
Razvan Caliman
Gabriel Luong
Bogdan Tara
Gurzau Raul
Belén Albeza
Alexandre Poirot
Csoregi Natalia
Ciure Andrei
Daisuke Akatsuka
Patrick Brosset
Julian Descottes
shindli
Jason Laster
Jaril
Jeff Walden
David Walsh
Nicolas Chevobbe
Jason Laster