Existing code crashes on IonIC frames. Instead, use FrameIter to
determine caller. This also simplifies WASM handling. Also make inJit
use a similar approach for consistency.
Differential Revision: https://phabricator.services.mozilla.com/D18151
--HG--
extra : moz-landing-system : lando
On Android we aren't necessarily passing in the package path, so
mozversion can't extract the relevant metadata, and on other platforms
it could also fail if we pass in a script file or similar. In that
case we shouldn't fail.
Differential Revision: https://phabricator.services.mozilla.com/D18712
Automatic update from web-platform-tests
Correct the order of owner and repo args in tag_master.py (#15130)
This was harmless because the order was reversed both in the arguments
and where used, but did cause me confusion when comparing to docs:
https://developer.github.com/v3/git/refs/#create-a-reference
--
wpt-commits: 9c5701192b581208a028144cb0fc27e462541a49
wpt-pr: 15130
Automatic update from web-platform-tests
Clarify that object arg to assert_throws is for non-DOMExceptions
Previous text made it seem like passing any object with the correct "name" property would be fine, but in reality, if you're specifically expecting a DOMException, you should be passing a string. (per @Ms2ger feedback)
Preserved the original wording as much as possible otherwise.
(Probably `assert_throws` itself should check the error type if called with an object, and verify that it's *not* a DOMException. But that's a separate cleanup project.)
--
wpt-commits: 59ea76c698b416231e7dcdb877a6265ba82b49f8
wpt-pr: 15116
Automatic update from web-platform-tests
service worker: WPT: modernize and add debugging to claim-fetch.https.html.
This test is flaky in Chrome. One of the fetches fails but we only get
output "failed to fetch" from Chrome. Make the test easier to read using
async/await and add more debugging info.
Bug: 924448
Change-Id: Ib9a0537772b1160e627517ff3ed1cef820778705
Reviewed-on: https://chromium-review.googlesource.com/c/1441654
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626891}
--
wpt-commits: 2e71724144098b754b1839e0d8cdfdcbe13bd7dd
wpt-pr: 15120
Automatic update from web-platform-tests
Sub-sample accurate start for ABSN
Implement sub-sample accurate start for AudioBufferSourceNode.
Previously, if the start time was between sample boundaries, we would
start the output at the frame before the start time. This is actually
incorrect because we haven't actually started yet. We should start
the output at the next boundary, and interpolating the value based on
the true start time and the sample boundary.
Many tests needed to be updated. Basically for each test that needed
to be changed, the sample rate is set to a power of two and all ABSN
sources are updated to make sure the source starts exactly on a frame
boundary. We also took the opportunity to adjust the error thresholds
for the tests in case lower values could be used.
Some additional notes for the tests:
audiobuffersource-playbackrate-zero.html: Add new test to make sure
sub-sample accurate start handles a zero playback rate.
audiobuffersource-loop-points.html: add some code to save the actual
output. This is needed because a new reference file is needed since
the sample rate has changed.
Also manually tested all of the modified tests with Firefox nightly.
They all pass still (except for the new sub-sample test because
Firefox doesn't do sub-sample accurate start/stop).
Bug: 876917
Test: the-audiobuffersourcenode-interface/sub-sample-scheduling.html
Change-Id: Ib13ba30eaa160cfd10739feabac961bf074ee309
Reviewed-on: https://chromium-review.googlesource.com/c/1212270
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626753}
--
wpt-commits: 00fa50687cab43b660296389acad6cc48717f1d1
wpt-pr: 13061
Automatic update from web-platform-tests
Compute azimuth correctly according to the spec
The azimuth calculation is incorrect if one of the vectors is the
zero vector. The spec handles this case correctly by just using the
dot product alone with "normalized" vectors instead of trying to
divide the dot product by the lengths.
Bug: 893983
Test: panner-azimuth.html
Change-Id: I7f890ae3353a71ffccfc3138038572a8a18b2379
Reviewed-on: https://chromium-review.googlesource.com/c/1277666
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626665}
--
wpt-commits: f2b7361daff0d555c271f8ffa50dc22ac8e948c5
wpt-pr: 13477
Automatic update from web-platform-tests
[LayoutNG] ComputeReplacedSize min/max width/height fix
This fix introduces a difference between how Legacy and
NG handle an edge case.
When replaced element:
- has no intrinsic size, has no aspect ratio,
- has border+padding.
The spec specifies that element's inline size should be computed
as stretch-width, filling the container.
Legacy violates the spec by overflowing the container by
width of border+padding.
NG implements spec behavior.
Bug: 919297
Change-Id: I7839b94b2be86bbce30adeea6942ac5235ebacdc
Reviewed-on: https://chromium-review.googlesource.com/c/1414872
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624928}
--
wpt-commits: bde5f8f30d5eab46d471252fb08d7ee88d90310d
wpt-pr: 14888
Automatic update from web-platform-tests
Fix first arg of assert_throws
Apparently you should specifically use the string form of the first `assert_throws` argument to catch DOMExceptions.
--
Merge pull request #15115 from web-platform-tests/tabatkins-patch-1
Fix first arg of assert_throws
--
wpt-commits: cd7b4b3799261dcbbee7709991215be5a1585529, 81a7b60a91657be80c4fc15dce6617951f2e5278
wpt-pr: 15115
Automatic update from web-platform-tests
[LayoutNG] Compute table cell margins to zero.
In the bug we check when we are performing the layout overflow
calculation if we have margins and add them if necessary.
Because we were setting them in LayoutNG (and not in Legacy) it meant
that we were contributing to overflow!
This forces margins to compute to zero for table cells.
Bug: 924504
Change-Id: Ia3595e0b432a965e7ed4bd28a8b3cf046fdf3775
Reviewed-on: https://chromium-review.googlesource.com/c/1434919
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626650}
--
wpt-commits: 48480234722c9e283c8c5457916db073a25d68cd
wpt-pr: 15053
Automatic update from web-platform-tests
Fix preload tests failing on wpt.fyi dashboard, second attempt
https://crrev.com/c/1411963 fixed the url conflicts with other tests,
but the test still flakes when running repeatedly, because the resource
is loaded from disk cache in subsequent runs
(https://github.com/web-platform-tests/wpt/pull/14882).
We don't care if the preloaded resources came from cache in these tests,
so let's just verify the number of Resource Timing entries.
Bug: 922343
Change-Id: I2c1d146856a125dbbb641d7efb4e6151094f6a3e
Reviewed-on: https://chromium-review.googlesource.com/c/1436777
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626019}
--
wpt-commits: a52ae0c66f4a764f036d6b85e9d2e611acf45383
wpt-pr: 15075
Automatic update from web-platform-tests
Test: Add a display:none inline toggle test
This patch adds a test that exercises an invalidation path which
was recently fixed. The test is to ensure the behavior does not
regress.
R=chrishtr@chromium.org
Bug: 919954
Change-Id: I1e5d037462501b8bf81c0bcf8c909713ed6508ee
Reviewed-on: https://chromium-review.googlesource.com/c/1435684
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626574}
--
wpt-commits: cfa9ac2a264f58358af6aad8067d40714afe12e4
wpt-pr: 15082
Automatic update from web-platform-tests
Enable storing and updating mozleak metadata in wpt ini
This adds two new properties to wpt metadata files:
mozleak-allowed - This is a list of the form [process-name:object
name], which indicates objects that may be leaked in that specific
process. Automatic updates that find a leak may add that object to
this list.
mozleak-threshold - This is a list (but conceptually a map) of
[process-name: threshold bytes], indicating a threshold below which
leaks will not cause a test failure. This number is updated by setting
it to the observed value for a process.
Depends on D12410
Differential Revision: https://phabricator.services.mozilla.com/D12411
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1352355
gecko-commit: 02e4dbfecbc426e118199e4ce140db13814aaf7a
gecko-integration-branch: central
gecko-reviewers: ato
--
Enable leak checks by default in wpt debug builds
Depends on D12412
Differential Revision: https://phabricator.services.mozilla.com/D12413
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1352355
gecko-commit: f3f4ea333cc4268ca48cf4eef9f821c490401544
gecko-integration-branch: central
gecko-reviewers: ato
--
Fix use of wpt settings in firefox Browser
The settngs() method is called to get a list of session-level settings
that should be applied when running a test. If those settings differ
from the ones applied to the previous test then we have to restart the
browser. But if we set the session on the class in the settings method
then at shutdown time we'll have incorrect settings. This is important
for things like leak checking where the values affect the shutdown
process. So instead ensure that we only set the settings on the class
during startup.
Depends on D12414
Differential Revision: https://phabricator.services.mozilla.com/D13512
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1352355
gecko-commit: 36c4c80ddc1a12665af8cbcaef716e384caab99e
gecko-integration-branch: central
gecko-reviewers: ato
--
Fix thresholds in leak update tests
--
wpt-commits: d18e0a52f638ddd4953cdde8ac373f1d611f70cd, 69e6b3e51409c490b425596ac9b7c08a7382e3ae, 44a02fa6eb5173e685c20362ce1409fc4fbe907d, 53fa0b78c29165ceacf478f31add85c6e790f50a
wpt-pr: 14464
Automatic update from web-platform-tests
Enable full logging for verify runs on taskcluster
--
wpt-commits: c456b7df5d0978d1036399dbb50cdcbc2517c825
wpt-pr: 15074
Automatic update from web-platform-tests
Add a web platform test checking documentElement clientWidth is `Initial Containing Block` size even if there is visible overlow:hidden region due to minimum-scale.
Differential Revision: https://phabricator.services.mozilla.com/D15344
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1423013
gecko-commit: db57901030e954ada2c5ba75a3c6bd0160e6b7e2
gecko-integration-branch: central
gecko-reviewers: botond
--
wpt-commits: 827b5373f7d507fa12054934146e564b17901fb3
wpt-pr: 15109
Automatic update from web-platform-tests
Escaped EOF
Tests <https://github.com/w3c/csswg-drafts/issues/3182> and <https://github.com/w3c/csswg-drafts/issues/1821>
--
Use assert_throws, etc
Per @domenic's advice, go ahead and use assert_throws on the throwing call, and then just make the should-succeed call directly, as a throw will cause the test to fail anyway.
--
Merge pull request #15092 from web-platform-tests/tabatkins-patch-1
Escaped EOF
--
wpt-commits: 26f39eb230185a804fabc398810cdcdddefc49ac, f44998b147858a8a2832f66dd32bc9d1ecefb1b3, fc57d7ad7a2942cfa363d5a9b8c6c7d74f5bb693
wpt-pr: 15092
Automatic update from web-platform-tests
Revert "Add tentative WPT to verify download in sandbox"
This reverts commit 726375b6a0c5583f4d6c37a0d5edaf2421cb72b9.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 626289 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzI2Mzc1YjZhMGM1NTgzZjRkNmMzN2EwZDVlZGFmMjQyMWNiNzJiOQw
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/9272
Sample Failed Step: webkit_layout_tests on Intel GPU on Mac
Sample Flaky Test: external/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads_without_user_activation.sub.tentative.html
Original change's description:
> Add tentative WPT to verify download in sandbox
>
> General testing idea:
> For a network request, we store a token in stash. And after a fixed
> period of time sufficient for the download to finish, if there are
> any, we validate the token in the stash to see if the network request
> was issued and finished successfully.
>
> In the case of <a download> where the decision of download can be made
> before resource fetching, the server sets the token immediately.
>
> In the case of navigation to a download, the server will stream a
> response over 1 seconds and set the token at the end only when the
> socket has been connected. So it is able to detect any download
> cancellation while fetching the resource.
>
> Bug: 539938
> Change-Id: I734c8cc18d1f761f16646c6b859a6b731ab40ff5
> Reviewed-on: https://chromium-review.googlesource.com/c/1422667
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626289}
Change-Id: Id343b8de2a751856b27907ba4c8dfb52715e4598
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 539938
Reviewed-on: https://chromium-review.googlesource.com/c/1437999
Cr-Commit-Position: refs/heads/master@{#626323}
--
wpt-commits: a863d5ef0f2168e6fdcab0c46b640ffd5b4b593d
wpt-pr: 15093
Automatic update from web-platform-tests
Add tentative WPT to verify download in sandbox
General testing idea:
For a network request, we store a token in stash. And after a fixed
period of time sufficient for the download to finish, if there are
any, we validate the token in the stash to see if the network request
was issued and finished successfully.
In the case of <a download> where the decision of download can be made
before resource fetching, the server sets the token immediately.
In the case of navigation to a download, the server will stream a
response over 1 seconds and set the token at the end only when the
socket has been connected. So it is able to detect any download
cancellation while fetching the resource.
Bug: 539938
Change-Id: I734c8cc18d1f761f16646c6b859a6b731ab40ff5
Reviewed-on: https://chromium-review.googlesource.com/c/1422667
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626289}
--
wpt-commits: 3b1b4cff2e7078df6d6e1be8bd04e3daf551c727
wpt-pr: 14944
Automatic update from web-platform-tests
Reland add tentative WPT tests for stale while revalidate handling.
Add test to ensure that handling the fetch doesn't trigger stale
while revalidate loading.
Add test to ensure that scripts and css loaded trigger a stale
while revalidate cache hit.
The PR for the spec changes is here:
https://github.com/whatwg/fetch/pull/853
This reland removes the resource timing and moves to css (instead of
images) which were both unreliable.
BUG=348877
Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43
Reviewed-on: https://chromium-review.googlesource.com/c/1434776
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626264}
--
wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded
wpt-pr: 15047
Automatic update from web-platform-tests
WPT: service worker: test clients.get(resultingClientId) for cross-origin.
See https://github.com/w3c/ServiceWorker/issues/1385
Bug: 924959
Change-Id: I5e2850b743d0702b36f1f20a84c87591c3baab19
Reviewed-on: https://chromium-review.googlesource.com/c/1433657
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626265}
--
wpt-commits: 0e0e65d5a43926e584537ea0878b0c2fbc1b694c
wpt-pr: 15035
Automatic update from web-platform-tests
[resource-timing] Modify is_secure_context_ based on resource
This is a followup on [1], which fixes the case where the document's
protocol and the resource's protocol are not the same, and adds tests
to that effect.
[1]https://chromium-review.googlesource.com/c/chromium/src/+/1396129
Change-Id: I7e0fda2e1275cb38359bf5781994f1b273248e4d
Reviewed-on: https://chromium-review.googlesource.com/c/1409446
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623889}
--
wpt-commits: 4851d0827f2dc5762d257473e2d917bf4fc7ba69
wpt-pr: 14845
Automatic update from web-platform-tests
Removed XRDevice interface
This changes the entry point into the WebXR APIs, as described
by the latest spec changes. It makes the concept of which physical
piece of hardware is being used implicit. The CL is unfortunately
large, but that's almost entirely due to the number of tests that the
change affects.
Bug: 916299
Change-Id: I32f2acec810761bbddd1f6df6e8ca91673dd381e
Reviewed-on: https://chromium-review.googlesource.com/c/1383393
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626199}
--
wpt-commits: 8d51019f62e3a85f920a2502711beba1193a9d16
wpt-pr: 14828
Automatic update from web-platform-tests
Pass the full path to the flake8 config files (#15079)
* Pass the full path to the flake8 config files
* Remove whitespaces before `requirements.txt`
--
wpt-commits: a74dc2ebe38405ff9fee0ddd522272258bee7b2d
wpt-pr: 15079
Automatic update from web-platform-tests
Update expected value for test_tests_affected_idlharness
This uses the working copy so isn't really stable. We should make a fake idl file
to use in the test, or something, but for now unbreak master.
--
wpt-commits: fe50b07a051669d6545e629787358db6950a7644
wpt-pr: 15085
Ehsan Akhgari
Ted Campbell
Gabriel Luong
James Graham
moz-wptsync-bot
Philip Jägenstedt
Tab Atkins Jr
autofoolip
Matt Falkenhagen
Raymond Toy
Aleks Totic
Ian Kilpatrick
Kunihiko Sakamoto
vmpstr
Sven Sauleau
Gérard Talbot
Aleksey Shvayka
Hiroyuki Ikezoe
Findit
Yao Xiao
Dave Tapuska
Yoav Weiss
Brandon Jones
Geoffrey Sneddon
himorin / Atsushi Shimono