Граф коммитов

242 Коммитов

Автор SHA1 Сообщение Дата
Csoregi Natalia 954b969608 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)

--HG--
extra : rebase_source : 41ed149c97382bc1cf823abc56811b382cae0207
2020-04-10 21:19:15 +03:00
pbz 2f0f0d62d1 Bug 1615588 - Extended nsIPromptService to support tab modal prompts. r=johannh,MattN
This patch introduces a new tab modal system prompt type. It can be opened via the nsIPromptService
with a destination BrowsingContext. These tab system prompts overlap slightly with the upper
chrome UI to differentiate them from content prompts (previously called tab prompts).

- Extended nsIPromptService and nsIPrompt to accept 3 types of modal prompts:
  - Window prompts
  - Tab (system) prompts
  - Content prompts (the old tab prompts)
- Removed prompt code from Prompter.jsm, always call PromptParent window actor instead
- Added PromptChild window actor to forward pagehide events to parent actor
- Created additional prompt methods in nsIPromptService to prompt by browsingContext and modalType
- Backwards compatibility is maintained, consumers can still open content prompts calling nsIPrompt with a content window

Differential Revision: https://phabricator.services.mozilla.com/D66446

--HG--
extra : moz-landing-system : lando
2020-04-10 16:47:00 +00:00
Kris Maglione 46bf54858f Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : source : 4a3b391e08c420cc8289bd80d1b9229d4b41b24f
extra : intermediate-source : 453b858f4462272af20b61cdddc99b6c8e90bee9
2020-04-08 19:04:47 +00:00
Kris Maglione 5723600436 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : source : c0c2e85e33da4512a738ab9e334b9d1a78c54cbd
extra : intermediate-source : af763de00e9d87ff8244ba1da1d0fca3e7a9017c
2020-04-04 02:42:30 +00:00
Kris Maglione 7410799e2d Bug 1626404: Follow-up: Fix missing source BC in some window.open calls.
Differential Revision: https://phabricator.services.mozilla.com/D70253

--HG--
extra : source : 5349e52250182d10523c4444c0eaa8bb7559a36b
2020-04-08 21:10:10 +00:00
Bogdan Tara 260d94aaaa Backed out changeset 5349e5225018 (bug 1626404) frequent timeouts on test_postMessage_onOther.html CLOSED TREE 2020-04-09 11:35:45 +03:00
Bogdan Tara 7a09dad859 Backed out 6 changesets (bug 1626404) for frequent timeouts on test_postMessage_onOther.html CLOSED TREE
Backed out changeset 453b858f4462 (bug 1626404)
Backed out changeset f54ce6a36c75 (bug 1626404)
Backed out changeset ec63b18da4b9 (bug 1626404)
Backed out changeset b0d4b213b819 (bug 1626404)
Backed out changeset af763de00e9d (bug 1626404)
Backed out changeset 45b68d43bdbb (bug 1626404)
2020-04-09 11:07:40 +03:00
Kris Maglione cba965d479 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : source : 4a3b391e08c420cc8289bd80d1b9229d4b41b24f
extra : histedit_source : bf3dae0b7ad368d29c9ea060b9afa4c2de383b1b
2020-04-08 19:04:47 +00:00
Kris Maglione b58203d6e6 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : source : c0c2e85e33da4512a738ab9e334b9d1a78c54cbd
extra : histedit_source : c4e26d3ae24ce8f107128bd5da2633f7e503e5e4
2020-04-04 02:42:30 +00:00
Kris Maglione 5441f0bfaa Bug 1626404: Follow-up: Fix missing source BC in some window.open calls.
Differential Revision: https://phabricator.services.mozilla.com/D70253

--HG--
extra : moz-landing-system : lando
2020-04-08 21:10:10 +00:00
Oana Pop Rus 87d90e34dd Backed out 6 changesets (bug 1626404) for mochitest failures in BrowsingContext.cpp on a CLOSED TREE
Backed out changeset 4a3b391e08c4 (bug 1626404)
Backed out changeset 1a5a559ec6d5 (bug 1626404)
Backed out changeset 2ffdab0072e7 (bug 1626404)
Backed out changeset 6fb384961b99 (bug 1626404)
Backed out changeset c0c2e85e33da (bug 1626404)
Backed out changeset bf32b30efa49 (bug 1626404)

--HG--
extra : rebase_source : 466bf9356539fbc47cb015df212e38698322bfb3
2020-04-09 00:22:49 +03:00
Kris Maglione 3b9ea8eec4 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : moz-landing-system : lando
2020-04-08 19:04:47 +00:00
Kris Maglione 377621b8fc Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : moz-landing-system : lando
2020-04-04 02:42:30 +00:00
Nika Layzell 09988936b7 Bug 1616353 - Part 13: Don't create an extra BrowsingContext when opening a new tab from content, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D68045

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:59 +00:00
Nika Layzell f036c4e342 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:47 +00:00
Nika Layzell 17acacfbf5 Bug 1616353 - Part 7.2: Create and use nsOpenWindowInfo types in nsWindowWatcher logic, r=kmag
This patch builds on top of part 7.1 by creating this object within
nsWindowWatcher and ContentParent to carry the relevant information through
provider interfaces when creating new content windows. The nsOpenWindowInfo
object is not created for new chrome windows.

This patch does not propagate these flags all of the way through to the
nsFrameLoader. That change is performed in later parts to keep each part
smaller.

Differential Revision: https://phabricator.services.mozilla.com/D67051

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:32 +00:00
Nika Layzell 9f32ad2bfe Bug 1616353 - Part 7.1: Introduce a new nsOpenWindowInfo type, r=Gijs,kmag
This type replaces the individual properties, like nextRemoteTabId and
presetOpenerWindow, which were passed around by frontend code for window opening
requests performed by Gecko. This new type is intentionally native-only to make
it easier to pass more information down to newly created windows in the future.

Differential Revision: https://phabricator.services.mozilla.com/D67050

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:24 +00:00
Nika Layzell b40af4dcf3 Bug 1616353 - Part 6.5: Assert nsILoadContext attributes are correctly set when opening windows, r=smaug
This is necessary as, by this point, the BrowsingContext has already been
attached, and can no longer have its nsILoadContext flags updated.

Differential Revision: https://phabricator.services.mozilla.com/D67049

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:22 +00:00
Nika Layzell 35001ec24d Bug 1616353 - Part 6.3: Replace many nsILoadContext mutators with assertions, r=smaug
Many of these setters are redundant, and duplicate work done elsewhere. As it is
no longer correct to set nsILoadContext attributes at these times, they're being
replaced with assertions.

Differential Revision: https://phabricator.services.mozilla.com/D67047

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:16 +00:00
Nika Layzell 146e915363 Bug 1616353 - Part 5: Always set the opener for chrome windows late, r=kmag
This is OK, as all chrome BrowsingContext instances are always in the same
BrowsingContextGroup, so we don't need to have the initial opener avaliable when
creating the BrowsingContext to determine its BrowsingContextGroup.

This is used in part 7.2 to avoid propagating the opener window around when
creating chrome windows.

Differential Revision: https://phabricator.services.mozilla.com/D67044

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:09 +00:00
Nika Layzell 85be5590f7 Bug 1616353 - Part 4: Don't second-guess CHROME_{REMOTE,FISSION}_WINDOW flags, r=kmag
This could cause issues, as we could incorrectly override the decision made by
nsWindowWatcher, and then override the decision again after the method returns.
This could cause the initial content browser to be configured incorrectly.

Differential Revision: https://phabricator.services.mozilla.com/D67043

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:07 +00:00
Andreas Farre 25ca8d7890 Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika,bas
TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to also remove to the SystemGroup and instead
switch all SystemGroup dispatches to dispatches to main thread.

Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.

The SchedulerEventTarget has been removed, since there are no longer a
separate event target for every TaskCategory. Instead a
LabellingEventTarget has been added to DocGroup to handle the case
where an event is dispatched do DocGroup or when an AbstractThread is
created using a DocGroup. This means that we'll actually label more
events correctly with the DocGroup that they belong to.

DocGroups have also been moved to BrowsingContextGroup.

Depends on D67636

Differential Revision: https://phabricator.services.mozilla.com/D65936

--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:47 +00:00
Cosmin Sabou aefb5f9c88 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Nika Layzell a6eb0d207e Bug 1616353 - Part 13: Don't create an extra BrowsingContext when opening a new tab from content, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D68045

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:36 +00:00
Nika Layzell 60b5a34a33 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:22 +00:00
Nika Layzell 0d1eecbd25 Bug 1616353 - Part 7.2: Create and use nsOpenWindowInfo types in nsWindowWatcher logic, r=kmag
This patch builds on top of part 7.1 by creating this object within
nsWindowWatcher and ContentParent to carry the relevant information through
provider interfaces when creating new content windows. The nsOpenWindowInfo
object is not created for new chrome windows.

This patch does not propagate these flags all of the way through to the
nsFrameLoader. That change is performed in later parts to keep each part
smaller.

Differential Revision: https://phabricator.services.mozilla.com/D67051

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:02 +00:00
Nika Layzell e34d793539 Bug 1616353 - Part 7.1: Introduce a new nsOpenWindowInfo type, r=Gijs,kmag
This type replaces the individual properties, like nextRemoteTabId and
presetOpenerWindow, which were passed around by frontend code for window opening
requests performed by Gecko. This new type is intentionally native-only to make
it easier to pass more information down to newly created windows in the future.

Differential Revision: https://phabricator.services.mozilla.com/D67050

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:59 +00:00
Nika Layzell 7089e8383b Bug 1616353 - Part 6.5: Assert nsILoadContext attributes are correctly set when opening windows, r=smaug
This is necessary as, by this point, the BrowsingContext has already been
attached, and can no longer have its nsILoadContext flags updated.

Differential Revision: https://phabricator.services.mozilla.com/D67049

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:57 +00:00
Nika Layzell 337ec3df9a Bug 1616353 - Part 6.3: Replace many nsILoadContext mutators with assertions, r=smaug
Many of these setters are redundant, and duplicate work done elsewhere. As it is
no longer correct to set nsILoadContext attributes at these times, they're being
replaced with assertions.

Differential Revision: https://phabricator.services.mozilla.com/D67047

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:52 +00:00
Nika Layzell a523afcdb8 Bug 1616353 - Part 5: Always set the opener for chrome windows late, r=kmag
This is OK, as all chrome BrowsingContext instances are always in the same
BrowsingContextGroup, so we don't need to have the initial opener avaliable when
creating the BrowsingContext to determine its BrowsingContextGroup.

This is used in part 7.2 to avoid propagating the opener window around when
creating chrome windows.

Differential Revision: https://phabricator.services.mozilla.com/D67044

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:45 +00:00
Nika Layzell 459460743f Bug 1616353 - Part 4: Don't second-guess CHROME_{REMOTE,FISSION}_WINDOW flags, r=kmag
This could cause issues, as we could incorrectly override the decision made by
nsWindowWatcher, and then override the decision again after the method returns.
This could cause the initial content browser to be configured incorrectly.

Differential Revision: https://phabricator.services.mozilla.com/D67043

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:43 +00:00
Narcis Beleuzu 00218b8a49 Backed out 6 changesets (bug 1626404) for assertion failures on BrowsingContext.cpp . CLOSED TREE
Backed out changeset aed006ab4c20 (bug 1626404)
Backed out changeset ad87dcb98637 (bug 1626404)
Backed out changeset c065bd4594b4 (bug 1626404)
Backed out changeset a248fc78ab0c (bug 1626404)
Backed out changeset 52892d053ff1 (bug 1626404)
Backed out changeset 440b9193338a (bug 1626404)
2020-04-04 05:29:30 +03:00
Kris Maglione c106c09af2 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : moz-landing-system : lando
2020-04-04 00:36:30 +00:00
Kris Maglione eab4010949 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : moz-landing-system : lando
2020-04-04 00:13:04 +00:00
Narcis Beleuzu ef38cbbda1 Backed out 6 changesets (bug 1626404) for bustages on LocationBase.cpp . CLOSED TREE
Backed out changeset a399dfff2725 (bug 1626404)
Backed out changeset ad3272abd830 (bug 1626404)
Backed out changeset 322c170e8301 (bug 1626404)
Backed out changeset df37f57cfa1d (bug 1626404)
Backed out changeset e255e4c9e665 (bug 1626404)
Backed out changeset 51120d617459 (bug 1626404)
2020-04-04 02:42:18 +03:00
Kris Maglione e041eac79c Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : moz-landing-system : lando
2020-04-03 22:42:25 +00:00
Kris Maglione 9a209ac965 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : moz-landing-system : lando
2020-04-03 22:41:26 +00:00
Tooru Fujisawa 51880be4b3 Bug 1507375 - Restrict the controllability of UI parts visibility with features parameter of window.open. r=smaug
Make the features parameter of window.open just a condition for whether to open
a popup or a new tab.
Also remove dom.disable_window_open_feature.* prefs.

Differential Revision: https://phabricator.services.mozilla.com/D65926

--HG--
extra : moz-landing-system : lando
2020-03-19 09:13:12 +00:00
Noemi Erli db9c35d705 Backed out changeset 6fe5ce050c0d (bug 1507375) for failures in test_transformed_scrolling_repaints_3.html CLOSED TREE 2020-03-19 08:56:17 +02:00
Tooru Fujisawa 4270e3fedf Bug 1507375 - Restrict the controllability of UI parts visibility with features parameter of window.open. r=smaug
Make the features parameter of window.open just a condition for whether to open
a popup or a new tab.
Also remove dom.disable_window_open_feature.* prefs.

Differential Revision: https://phabricator.services.mozilla.com/D65926

--HG--
extra : moz-landing-system : lando
2020-03-19 03:50:25 +00:00
Kashav Madan 41ed32b21b Bug 1578070 - Use nsWindowWatcher::GetBrowsingContextByName in GeckoViewOpenWindow, r=farre
This also removes LaunchObserver, which was only needed for Fennec.

Differential Revision: https://phabricator.services.mozilla.com/D65401

--HG--
extra : moz-landing-system : lando
2020-03-10 20:27:24 +00:00
Simon Giesecke 8ad76c7e47 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in toolkit. r=mossop
Depends on D66008

Differential Revision: https://phabricator.services.mozilla.com/D66010

--HG--
extra : moz-landing-system : lando
2020-03-10 08:48:24 +00:00
Simon Van Accoleyen 3006ffb76d Bug 1619619 - DeCOMtaminate accesses to nsFocusManager r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D65884

--HG--
extra : moz-landing-system : lando
2020-03-09 09:51:46 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
shindli ba71ac519f Backed out changeset 3da713367dfd (bug 1589299) for causing mochitest permafailures in layout/base/tests/test_transformed_scrolling_repaints_3.html CLOSED TREE 2020-03-03 20:43:03 +02:00
Alphan Chen cbf7696246 Bug 1589299 - Force scrollbars flag to be always enabled for new windows. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D64126

--HG--
extra : moz-landing-system : lando
2020-03-03 16:07:09 +00:00
Henri Sivonen 03d47c6678 Bug 1618133 - Remove nsWindowWatcher::SetActiveWindow as dead code. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D64330

--HG--
extra : moz-landing-system : lando
2020-02-27 18:24:07 +00:00
Coroiu Cristina 24486add05 Backed out changeset 4dfd98d37804 (bug 1589299) for Wr failures at css/css-writing-modes/wm-propagation-svg-root-scrollbar.svg on a CLOSED TREE 2020-02-26 18:12:29 +02:00
Alphan Chen 82df008ac9 Bug 1589299 - Force scrollbars flag to be always enabled for new windows. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D64126

--HG--
extra : moz-landing-system : lando
2020-02-26 14:15:57 +00:00
pbz ddd3c608ef Bug 1432856 - Added console logging for DOM fullscreen leave on window raise. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D55813

--HG--
extra : moz-landing-system : lando
2020-01-16 14:39:02 +00:00