Symbols exported from a JSM cannot be nested inside an `if` otherwise `undefined` will be exported. I don't think it's worth filing a bug for that considering bug 1608269 is coming.
Differential Revision: https://phabricator.services.mozilla.com/D58202
--HG--
extra : moz-landing-system : lando
...so that we can correctly declare that we are using sandboxed
library(ies) from our "parent" build, but not check for all the tools to
compile code.
Depends on D59554
Differential Revision: https://phabricator.services.mozilla.com/D59555
--HG--
extra : moz-landing-system : lando
This change eliminates a lot of repetition, and paves the way for the
next change.
Differential Revision: https://phabricator.services.mozilla.com/D59554
--HG--
extra : moz-landing-system : lando
The end of the std::thread at process end didn't seem to release the owned
nsStringBuffer in a way that refcounting liked. So let's copy the nsAString
into an owned String, move it into the thread's closure, and convert it as
necessary to an nsAString when we invoke pingsender.
Not the most efficient, but it doesn't have to be. This is prototype code
that will be removed.
Depends on D58809
Differential Revision: https://phabricator.services.mozilla.com/D59531
--HG--
extra : moz-landing-system : lando
nsIProcess is the tried-and-true method for launching utility subprocesses on
Firefox Desktop's supported platforms. Use that.
Differential Revision: https://phabricator.services.mozilla.com/D58809
--HG--
extra : moz-landing-system : lando
Since we're the only one sending data, and we're doing so infrequently, let's
get the pref value before each ping send instead of building a pref observer
right this second.
Differential Revision: https://phabricator.services.mozilla.com/D57107
--HG--
extra : moz-landing-system : lando
When viewing certificates with certificateviewer that have an authority x509 extension
but do not have an authority key identifier, parsing the certificate fails.
Since the authority key identifier is optional in RFC 5280,
check if it exists before trying to set the key identifier.
Also check that x509 extensions are defined before setting up the critical and unsupported extensions.
Differential Revision: https://phabricator.services.mozilla.com/D59224
--HG--
extra : moz-landing-system : lando
They are timing out, being retried with a longer timeout, and then eventually passing.
Considering all the retries, just test_amazon.js is taking more than 60 minutes...
Differential Revision: https://phabricator.services.mozilla.com/D59432
--HG--
extra : moz-landing-system : lando
This patch is not ideal: if would be better to do the defaulting in
`toolkit/moz.configure`, but doing it there runs into problems with base
toolchain configurations, as the clang there is not new enough. So we
have this, doing everything with environment variables, which is easily
turned on or off, depending on the needs of the specific configuration.
The `mozconfig.no-compile` change is not really needed, as the wasm
sandboxing detection bits are not conditional on
`--enable-compile-environment`. Those bits should be, and I will tackle
doing that after the holidays.
Differential Revision: https://phabricator.services.mozilla.com/D58102
--HG--
extra : moz-landing-system : lando
https://hg.mozilla.org/mozilla-central/rev/234701139a2a61d1262e609c9d8ac42384ecafda
Removed the following CSS rule:
#iconContainer {
-moz-box-pack: center;
min-height: 55px; /* maximum icon height + icon margin */
min-width: 58px; /* maximum icon width + icon margin */
}
Which enforced the size of the icon row.
The icon loads asynchronously, so by the first time we fire DOMContentLoaded it
may not have loaded yet. This means that sizeToContent() will size the window to
an smaller size and stuff will wrap around when it loads.
<image> doesn't block onload so even delaying this wouldn't work.
Restore the wrapper to ensure loading the icon or not doesn't affect layout of
the dialog.
Differential Revision: https://phabricator.services.mozilla.com/D58705
--HG--
extra : moz-landing-system : lando
Also adds tests for checking the search engine lists when falling back to a default region.
Differential Revision: https://phabricator.services.mozilla.com/D59084
--HG--
extra : moz-landing-system : lando
We've already decided when to remove support for DTLS 1.0, so I don't think we
need to track DTLS version anymore. The DTLS and SRTP cipher probes are
intended to track cipher usage so we can remove less secure ciphers over time.
I had a look at the telemetry for these and I don't think there's a clear case
for removal at the moment, so we should renew these for now.
Differential Revision: https://phabricator.services.mozilla.com/D58835
--HG--
extra : moz-landing-system : lando