Terrence Cole
20e03ef2a5
Bug 1105069 - Part 17: Convert xpc_IsGrayGCThing to GCCellPtr; r=mccr8, j=jonco
...
--HG--
extra : rebase_source : 9fdc5ac9ca8de9c12a399532db7e77bc34abb7da
2014-12-05 09:38:34 -08:00
Terrence Cole
a99f92dd64
Bug 1105069 - Part 15: Convert xpc_GCThingIsGrayCCThing to GCCellPtr; r=mccr8, r=jonco
...
--HG--
extra : rebase_source : 096b8eaf5b46afc1c40b0b9e8b233ec13c638c85
2014-12-09 16:22:51 -08:00
Terrence Cole
e4a4d0c7fa
Bug 1105069 - Part 14: Convert NoteJSChild to GCCellPtr; r=mccr8, r=jonco
...
--HG--
extra : rebase_source : 2338e0a57779401f9bc4744bc2fa59a4b31d76bf
2014-12-05 09:38:34 -08:00
Andrew McCreight
9d83b26756
Bug 1052793 - Do per-zone GC for CC_WAITING triggers. r=smaug
2014-12-13 21:17:35 -08:00
Andrew McCreight
0779204bd5
Bug 1097850 - ChildFinder::NoteNativeChild() should call CanSkip(). r=smaug
2014-12-12 13:42:21 -08:00
Andrew McCreight
a6fce3e639
Bug 1110243 - CCGraphBuilder::NoteNativeChild should call CanSkipThis(). r=smaug
2014-12-12 13:42:21 -08:00
Terrence Cole
b3fb25bc3f
Bug 1105069 - Part 10: Convert NoteWeakMapping to GCCellPtr; r=jonco, r=mccr8
...
--HG--
extra : rebase_source : b660a676c03c4a0bbdc521a6401a2a619543aa2a
2014-12-05 09:38:32 -08:00
Nicholas Nethercote
2e23aeecb5
Bug 1102525 (part 3) - Replace SegmentedArray with mozilla::SegmentedVector in the cycle collector. r=smaug.
...
--HG--
extra : rebase_source : fb8b9f52958d6823dc011892b06bf42989a60a75
2014-12-08 14:45:13 -08:00
Olli Pettay
bed81b1fde
Bug 1105089
, try to have shorter ICC slices during animations, r=mccr8
...
--HG--
extra : rebase_source : bfe8cc2825b7cb2ec86f6e8f5ba590593e1c378b
2014-11-27 13:47:51 +02:00
Nicholas Nethercote
6b3fdce6bc
Bug 1096624 - Use a SegmentedArray in nsCycleCollector::CollectWhite. r=smaug.
...
This patch does the following.
- Moves the logic for computing the ideal capacity for a SegmentedArray out of
SnowWhiteKiller into its own class, SegmentedArrayCapacity.
- Replaces the nsTArray in CollectWhite(), which can be very large and is
complicit in ~1% of OOM crashes, with a SegmentedArray.
--HG--
extra : rebase_source : 732743311a08fcc3dfe43a1b308846b93d30e6ed
2014-11-11 16:02:34 -08:00
Andrew McCreight
86f277bb36
Bug 1093278 - Null check in nsPurpleBuffer::VisitEntries. r=smaug
2014-11-03 16:50:00 -05:00
Emanuel Hoogeveen
fbc3e91445
Bug 1084651 - Part 5: Simplify Cycle Collector logic now that SliceBudget makes more sense. r=mccr8
2014-11-06 10:14:00 +01:00
Emanuel Hoogeveen
b7672edb91
Bug 1084651 - Part 2: Clean up SliceBudget and require explicitly choosing between TimeBudget and WorkBudget. r=billm r=mccr8
2014-10-22 14:13:00 +02:00
Nicholas Nethercote
c881cf722e
Bug 1094564 - Used SegmentedArray in SnowWhiteKiller. r=smaug.
...
This patch generalizes SegmentedArray a little, and then uses it instead of
nsTArray in SnowWhiteKiller. This avoids some large (sometimes 1 MiB or more)
allocations which were usually mostly unused.
2014-11-09 14:57:09 -08:00
Carsten "Tomcat" Book
ba5a7941af
Backed out changeset ebdebc9251be (bug 1084651)
2014-11-07 15:30:49 +01:00
Carsten "Tomcat" Book
d87e8af66c
Backed out changeset 77959236fb15 (bug 1084651)
2014-11-07 15:30:16 +01:00
Emanuel Hoogeveen
0d92fda72d
Bug 1084651 - Part 5: Simplify Cycle Collector logic now that SliceBudget makes more sense. r=mccr8
2014-11-06 10:14:00 +01:00
Emanuel Hoogeveen
2efb3493a7
Bug 1084651 - Part 2: Clean up SliceBudget and require explicitly choosing between TimeBudget and WorkBudget. r=wmccloskey r=mccr8
2014-10-22 14:13:00 +02:00
Carsten "Tomcat" Book
13de0f42c9
Backed out 7 changesets (bug 1084651) for ASAN Bustage on a CLOSED TREE
...
Backed out changeset dd2b3e78b425 (bug 1084651)
Backed out changeset 2711fbd91819 (bug 1084651)
Backed out changeset 59a163addd79 (bug 1084651)
Backed out changeset d36f6dbbf925 (bug 1084651)
Backed out changeset 78102b62a4a0 (bug 1084651)
Backed out changeset 06387a2343a0 (bug 1084651)
Backed out changeset 2f8e7c39573e (bug 1084651)
2014-11-05 15:20:25 +01:00
Emanuel Hoogeveen
dd0cdda357
Bug 1084651 - Part 5: Simplify Cycle Collector logic now that SliceBudget makes more sense. r=mccr8
2014-10-21 11:54:00 +02:00
Emanuel Hoogeveen
f6218097c0
Bug 1084651 - Part 2: Clean up SliceBudget and require explicitly choosing between TimeBudget and WorkBudget. r=wmccloskey r=mccr8
2014-10-22 14:13:00 +02:00
Andrew McCreight
526df61329
Bug 1087799, part 3 - Do not include any JS things in the list of white nodes. r=smaug
...
Root() does not actually root JS things, so if some other class's Unlink() method ends
up calling the GC, whiteNodes will end up containing dead pointers. (This is safe right
now because the Unlink and Unroot methods do not do anything to JS things.) It is less
error prone to simply never store those pointers.
Also, add some asserts to enforce that we never call any of the white-object methods
for JS things.
2014-10-24 15:06:56 -07:00
Andrew McCreight
04f4e49d61
Bug 1087799, part 2 - Rename count to numWhiteNodes in nsCycleCollector::CollectWhite(). r=smaug
2014-10-24 15:06:56 -07:00
Andrew McCreight
14343f4a96
Bug 1087799, part 1 - Loosen the invariant in nsCycleCollector::FinishAnyCurrentCollection(). r=smaug
...
If an Unlink() method ends up running JS, it can cause a GC, which will make us reenter the CC,
which will not do anything because we're already in a CC. Therefore, FinishAnyCurrentCollection()
won't finish the CC. This is safe because the CC only touches things it actually holds alive via
the Root() method.
2014-10-24 15:06:55 -07:00
Andrew McCreight
cc506c4751
Bug 727965 - Trigger CC_WAITING GCs based on number of freed JS objects and zones. r=smaug
2014-10-20 10:07:52 -07:00
Nicholas Nethercote
df1c26a45e
Bug 1057912 - Privatize most of PLDHashTable's fields. r=roc.
...
--HG--
extra : rebase_source : 0f55e70b63d9c191fbd9418cb1177ff534deeed9
2014-08-25 16:56:33 -07:00
Birunthan Mohanathas
80ef08ccd8
Bug 1046841 - Fix more style violations in previously touched .cpp files in xpcom/. r=froydnj
2014-08-25 12:17:15 -07:00
Trevor Saunders
fd5e9d1fcc
bug 1047696 - mark a number of classes MOZ_FINAL to get compilers to devirtualize more r=froydnj
2014-08-05 13:33:55 -04:00
Nicholas Nethercote
a7cf4142b4
Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
...
* * *
imported patch rm-dummy-params
--HG--
extra : rebase_source : c25987eb11bae197218d5fc53b77def19afa36ac
2014-08-06 06:31:21 -07:00
Terrence Cole
3718c92afc
Bug 1047120 - PurpleBuffer doesn't actually need to use Heap<T>; r=mccr8,jonco
2014-07-31 14:43:45 -07:00
Ehsan Akhgari
520fd897ed
Bug 1045065 - Fix some bad implicit constructors in xpcom; r=froydnj
2014-07-28 13:19:06 -04:00
Jon Coppeard
c71e29bdb6
Bug 1043888 - Make GetObjetZone() work on nursery objects and rename GetGCThingZone() to GetTenuredGCThingZone() r=terrence
2014-07-28 10:39:36 +01:00
Andrew McCreight
6b5301fe94
Bug 1033654 - Rename GCGraphBuilder to CCGraphBuilder. r=smaug
2014-07-09 21:31:00 +02:00
Benoit Jacob
81effa4bca
Bug 1028588 - Fix dangerous public destructors in xpcom/ - r=bsmedberg,khuey,nfroyd
2014-06-30 18:11:53 -04:00
Andrew McCreight
330696db42
Bug 1023758, part 2 - Dead traversed objects should be treated as incremental roots and colored. r=smaug
2014-06-30 16:18:47 -07:00
Andrew McCreight
9e6d927b37
Bug 1023758, part 1 - Refactor the node scanning loop in nsCycleCollector::ScanIncrementalRoots(). r=smaug
...
This will make it easier to scan for things besides gray JS nodes. It slightly
reorders the tests we do, but it shouldn't really matter.
2014-06-30 16:18:46 -07:00
Wes Kocher
03da42e8b1
Backed out 4 changesets (bug 1028588) for build bustage
...
Backed out changeset 13a8bae671ca (bug 1028588)
Backed out changeset 19a19833f1d6 (bug 1028588)
Backed out changeset d5fae80054de (bug 1028588)
Backed out changeset 5942ad3859b8 (bug 1028588)
2014-06-30 15:50:19 -07:00
Benoit Jacob
522e4724cc
Bug 1028588 - Fix dangerous public destructors in xpcom/ - r=bsmedberg,khuey,nfroyd
2014-06-30 18:11:53 -04:00
Nicholas Nethercote
aaf6fb2124
Bug 1010064 - Allow memory reports to be anonymized. r=bsmedberg.
...
--HG--
extra : rebase_source : 5eb756b17a97e751deb0f47e909fdb35533cb23b
2014-05-20 23:06:54 -07:00
Victor Porof
9ce7e9c089
Bug 1007203 - Always add categories when pushing to the pseudostack, r=djvj
2014-05-23 17:12:29 -04:00
Ehsan Akhgari
5b0272c079
Bug 1013663 - Fix some bad implicit conversion constructors in the JS engine; r=jorendorff,jandem
2014-05-25 21:46:24 -04:00
Andrew McCreight
04c12ad3a0
Bug 1007722 - Add helper methods for gray and black JS in the CC. r=smaug
2014-05-14 09:45:50 -07:00
Andrew McCreight
61c9d86ba3
Bug 1005396 - Finish a long ICC early after graph building has finished. r=smaug
2014-05-14 09:45:50 -07:00
Nicholas Nethercote
cbc884ac7a
Bug 1005836 - Avoid slop NodePool::Block allocations. r=mccr8.
...
--HG--
extra : rebase_source : 2297b22e7a5d6679d8b25679d338f001c7427b60
2014-05-13 20:42:27 -07:00
Jed Davis
e4ced412bb
Bug 973090 - IPC remoting for child GC/CC logging. r=mccr8, r=bent
...
This has a few semi-interdependent pieces:
* Factoring out the file opening/closing/renaming from the GC/CC logging.
* Using IPC to have the child log to files that the parent opened.
* Changing nsIMemoryInfoDumper.dumpGCAndCCLogsToFile to report completion
of child process logging (which was impossible before this, and which is
needed to have a meaningful test case).
* Changing about:memory to dump logs for child processes, matching the
behavior of the "Measure" button, because it can tell the user where
they are now.
* Add a test for multiprocess GC/CC log dumping (only of the XPCOM
interface, not by clicking buttons and scraping the about:memory page,
but done as a chrome mochitest to start remote browsers); based on
test_memoryReporters2.xul in the same directory.
2014-05-13 13:13:00 -04:00
Birunthan Mohanathas
fb371cca99
Bug 995730 - Fix style violations in xpcom/base/. r=froydnj,continuation
2014-05-13 20:41:38 +03:00
Andrew McCreight
cb5234676d
Bug 1005500 - Use a separate linear scan pass to mark nodes white in ScanRoots. r=smaug
...
The existing code for ScanRoots looks at all traversal roots in the graph,
and floods white or black from them. This can take up a large chunk of the
Scan/Unlink slice of ICC, maybe because graph traversal has poor locality.
Outside of a leak, the cycle collector graph is usually only large when
there is a lot of garbage (95% or more of the graph), so we want to
speed up white marking.
To do this, I add a new pass that scans every node and directly sets the
color of any node that should be white, without flooding. This is very
fast. Then a second pass floods black from any remaining grey nodes.
On the page close CC for a real page, I measured a 10x improvement in
ScanRoots() time with this algorithm, from 3ms to 0.3ms.
2014-05-08 11:28:03 -07:00
Andrew McCreight
7076cd497f
Bug 1005975 - Define FloodBlackNode as a convenience function. r=smaug
2014-05-06 17:25:27 -07:00
Andrew McCreight
d72a4c8977
Bug 1006635, part 2 - Add more Checkpoints to the cycle collector. r=smaug
2014-05-06 17:25:27 -07:00
Andrew McCreight
b65df16afa
Bug 1006635, part 1 - Make TimeLog use doubles and reduce the threshold. r=smaug
2014-05-06 17:25:27 -07:00
Andrew McCreight
f5a7b92cdc
Bug 1005232 - Log number of incremental cycle collector slices. r=smaug
2014-05-06 17:25:26 -07:00
Andrew McCreight
0b5a958dcb
Bug 1004017 - Rename CycleCollectedJSRuntime::NeedCollect() and Collect(). r=smaug
2014-05-06 17:25:26 -07:00
Andrew McCreight
b89c24ee20
Bug 958353 - Add finishCC() and ccSlice() methods for testing incremental cycle collection. r=smaug
2014-05-06 17:25:26 -07:00
Birunthan Mohanathas
8f4f3e6fea
Bug 995730 - Change xpcom/base/ to use 2 space indentation
...
This also removes trailing whitespace in reindented files.
2014-05-05 20:30:39 +03:00
Birunthan Mohanathas
5f1fde8824
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
Eric Faust
77529f2044
Bug 1001126 - Allow AllTraces CC logging other than at shutdown. (r=mccr8)
2014-04-24 14:28:49 -07:00
Terrence Cole
6f2d911fe4
Bug 994413 - Make Gecko use the same value marking semantics as SpiderMonkey; r=jonco,mccr8
2014-04-09 12:42:48 -07:00
Ryan VanderMeulen
a14baa39be
Merge inbound to m-c.
2014-03-26 20:58:31 -04:00
Alphan Chen
a0abfdd08c
Bug 964636 - Part 1: Move common classes and functions out of nsMemoryInfoDumper. r=dhylands
2014-03-20 15:29:51 +08:00
Eric Faust
e69bd971ed
Bug 987750 - Add CC logging options for process specifiers. (r=mccr8)
2014-03-26 09:57:38 -07:00
Andrew McCreight
a6b5bb9aa6
Bug 984665 - Change the extra shutdown CC assertion into a warning. r=smaug
2014-03-19 06:05:18 -07:00
Andrew McCreight
1cbf6e74d5
Bug 984685 - Add cycle collector efficiency to COLLECT_TIME_DEBUG logging. r=smaug
2014-03-19 06:05:17 -07:00
Andrew McCreight
b2cea60a4b
Bug 948755 - Log incremental cycle collector roots. r=smaug
2014-03-14 16:07:07 -07:00
Andrew McCreight
c54675a8a9
Bug 981033 - Clear mActivelyCollecting before restarting CC. r=smaug
2014-03-11 07:34:35 -07:00
Bobby Holley
611c847a27
Bug 975419 - Add a JS::TenuredHeap<JSObject*> overload to TraceCallbacks. r=mccr8,terrence
2014-03-03 08:53:42 -08:00
Andrew McCreight
0dbad2da13
Bug 977688 - Get rid of CC_AbortIfNull. r=smaug
2014-02-28 09:56:23 -08:00
Andrew McCreight
0353960345
Bug 962608 - Make PL_DHashTableInit infallible by default. r=briansmith,bsmedberg,ehsan,froydnj,jduell,jfkthame,roc,smaug
2014-02-27 10:04:09 -08:00
Andrew McCreight
833279b6b8
Bug 901597, part 2 - Add environment var to CC log only main or worker threads. r=smaug
2014-02-20 14:27:04 -08:00
Andrew McCreight
915a1940a3
Bug 901597, part 1 - Move CC logging logic into nsCCParams. r=smaug
2014-02-20 14:27:03 -08:00
Andrew McCreight
04756efc8f
Bug 972940 - Rename XPCOM_CC_ env vars to MOZ_CC_. r=smaug,njn
2014-02-20 14:27:03 -08:00
Andrew McCreight
0cc6333124
Backout bug 972940 for valgrind leaks on this CLOSED TREE
2014-02-19 17:20:48 -08:00
Andrew McCreight
3cb3bca6a3
Backout bug 901597 for valgrind leaks
2014-02-19 17:19:17 -08:00
Andrew McCreight
013dd784f5
Backout bug 901597 for valgrind leaks
2014-02-19 17:18:59 -08:00
Andrew McCreight
c47c19f9cd
Bug 901597, part 2 - Add environment var to CC log only main or worker threads. r=smaug
2014-02-19 13:27:15 -08:00
Andrew McCreight
c2269e1629
Bug 901597, part 1 - Move CC logging logic into nsCCParams. r=smaug
2014-02-19 13:27:14 -08:00
Andrew McCreight
3f976fe0cf
Bug 972940 - Rename XPCOM_CC_ env vars to MOZ_CC_. r=smaug
2014-02-19 13:27:14 -08:00
Andrew McCreight
02daa1568c
Bug 966359 - Prevent FreeSnowWhite reentrance. r=smaug
2014-02-11 14:56:44 -08:00
Ehsan Akhgari
d91d200572
Bug 969757 - Remove the dead code in our tree which pretends to support OS/2; r=roc,mcmanus,gps,jorendorf,bsmedberg sr=bsmedberg
2014-02-10 17:57:01 -05:00
Nicholas Nethercote
9c25748c63
Bug 903131 - Add save GC/CC logs buttons to about:memory. r=njn,mccr8.
...
--HG--
extra : rebase_source : 56af9b89675394b5a219f699b96c1d26c00adc38
2014-01-31 14:43:08 -08:00
Olli Pettay
77759a327d
Bug 958315 - Suspect JS things released by dying C++ objects in the next CC, r=mccr8
2014-01-14 22:23:59 +02:00
Andrew McCreight
b0d96345f5
Bug 956080 - Rename BeginCycleCollection to TraverseRoots. r=smaug
2014-01-07 17:33:47 -08:00
Andrew McCreight
91646dadb8
Bug 950959 - Rename scheduled cycle collector stuff to slice. r=smaug
2014-01-01 11:00:35 -08:00
Andrew McCreight
64258f4913
Bug 950949 - Run forgetSkippable per CC not per slice. r=smaug
2014-01-01 11:00:35 -08:00
Andrew McCreight
53e4433905
Bug 937960, part 3 - Pass in a small time budget with ICC. r=smaug
2013-12-22 09:58:19 -05:00
Ryan VanderMeulen
e8e36d08b0
Backed out changesets ccdc3d4f4571, 4dcc91e771e3, 0ae14946314b, and 94d22ab0b17f (bug 937960) for Windows 7 debug xpcshell failures.
2013-12-19 16:57:55 -05:00
Andrew McCreight
03a8a8e082
Bug 937960, part 3 - Pass in a small time budget with ICC. r=smaug
2013-12-18 21:22:55 -08:00
Ryan VanderMeulen
96ec232042
Backed out changesets b03bd1170d1c, 419615a1195d, a1b699b80442, and 524c573fd8a6 (bug 937960) for Win7 debug xpcshell orange.
2013-12-18 19:04:11 -05:00
Andrew McCreight
890aa014bf
Bug 937960, part 3 - Pass in a small time budget with ICC. r=smaug
2013-12-18 11:42:16 -08:00
Andy Wingo
0efae2b21b
Bug 951483 - Add back nsCycleCollector::ShutdownCollect assertion that was mistakenly removed in bug 945813. r=mccr8
2013-12-18 11:01:32 +01:00
Andrew McCreight
11f2c0ea43
Bug 937818, part 4 - Exceeded refcount nodes should already be black. r=smaug
...
Due to graph mutation during an incremental cycle collection, objects in the CC graph
may end up with more things pointing to them than they have a ref count. However, these
objects should never become garbage.
2013-12-17 19:29:57 -08:00
Andrew McCreight
ab69eca538
Bug 937818, part 3 - Add ScanIncrementalRoots(). r=smaug
...
Any object that has been stored away somewhere in the middle of incremental graph
building must be treated as live, because we can't trust that the CC graph has
accurate information about it. If such an object is truly garbage, we'll unlink it
in the next cycle collection instead.
2013-12-17 19:29:57 -08:00
Andrew McCreight
76b4feac36
Bug 937818, part 1 - Add objects to the purple buffer on AddRef. r=smaug
...
ICC uses this to track objects that have been AddRef'd during ICC graph building.
For those objects, we may not have the proper information for them, so treat them
as live.
2013-12-17 19:29:57 -08:00
Carsten "Tomcat" Book
dd80853527
Backed out changeset 261091719842 (bug 937818) for static rooting hazard analysis bustage on a CLOSED TREE
2013-12-17 09:20:51 +01:00
Carsten "Tomcat" Book
f1d19f75cb
Backed out changeset a9715a3b0e13 (bug 937818) for static rooting hazard analysis bustage on a CLOSED TREE
2013-12-17 09:20:31 +01:00
Carsten "Tomcat" Book
ad47674f4c
Backed out changeset ae01d2862600 (bug 937818) for static rooting hazard analysis bustage on a CLOSED TREE
2013-12-17 09:20:10 +01:00
Andrew McCreight
31e4486875
Bug 937818, part 4 - Exceeded refcount nodes should already be black. r=smaug
...
Due to graph mutation during an incremental cycle collection, objects in the CC graph
may end up with more things pointing to them than they have a ref count. However, these
objects should never become garbage.
2013-12-16 21:30:54 -08:00
Andrew McCreight
4b11c4307f
Bug 937818, part 3 - Add ScanIncrementalRoots(). r=smaug
...
Any object that has been stored away somewhere in the middle of incremental graph
building must be treated as live, because we can't trust that the CC graph has
accurate information about it. If such an object is truly garbage, we'll unlink it
in the next cycle collection instead.
2013-12-16 21:30:53 -08:00
Andrew McCreight
3145a6bc8f
Bug 937818, part 1 - Add objects to the purple buffer on AddRef. r=smaug
...
ICC uses this to track objects that have been AddRef'd during ICC graph building.
For those objects, we may not have the proper information for them, so treat them
as live.
2013-12-16 21:30:53 -08:00
Andrew McCreight
4fee07359d
Bug 947719 - Call Checkpoint on every slice in nsCycleCollector::MarkRoots. r=smaug
2013-12-10 08:07:20 -08:00
Nicholas Nethercote
8bbe1e2dc1
Bug 947798 (part 2) - Remove MemoryMultiReporter, because it's no longer helpful. r=mccr8.
...
--HG--
extra : rebase_source : f6f74de69d8c1d79d38b84b19dff5439efc41075
2013-12-07 21:39:47 -08:00
Birunthan Mohanathas
3440613a39
Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
...
--HG--
rename : mfbt/Util.h => mfbt/ArrayUtils.h
2013-12-08 21:52:54 -05:00
Andrew McCreight
cff1ba464d
Bug 937766, part 5 - Implement PrepareForGarbageCollection. r=smaug
...
Running the garbage collector can cause objects in the CC graph to
die, so just finish off an incremental cycle collection when we
start a GC.
2013-12-06 10:17:20 -08:00
Andrew McCreight
c646a8c5ef
Bug 937766, part 4 - Add GCGraph::IsEmpty method. r=smaug
2013-12-06 10:17:20 -08:00
Andrew McCreight
625ea25bce
Bug 937766, part 3 - Add mParticipant null checks. r=smaug
...
When an object dies during an incremental cycle collection, we null out
its mParticipant, so we must add various null checks to avoid crashing
when we reach the CC graph representation of an object that has died.
2013-12-06 10:17:20 -08:00
Andrew McCreight
d1f30059ad
Bug 937766, part 2 - Make SnowWhiteKiller remove dying things from the CC graph. r=smaug
...
If we purge snow white objects while ICC is in progress, we need to
make sure to remove anything from the CC graph to avoid dangling pointers.
We don't need to do that after shutdown.
2013-12-06 10:17:20 -08:00
Andy Wingo
5d9420d02c
Bug 945813 - Paper over cycle collection problem in IndexedDB. r=mccr8, r=khuey
2013-12-04 14:53:25 +01:00
Nicholas Nethercote
b413e441cf
Bug 943660 (part 2) - Remove remnants of Remove nsIMemoryReporter::name.
...
--HG--
extra : rebase_source : 900bd1c641b26623cccf14d952b5387223b489eb
2013-12-03 20:01:24 -08:00
Ryan VanderMeulen
70aeae383f
Backed out changeset 2572592c326d (bug 945813) for Linux64 debug xpcshell crashes.
...
CLOSED TREE
2013-12-03 20:35:03 -05:00
Andy Wingo
a9d2f530d9
Bug 945813 - Paper over cycle collection problem in IndexedDB. r=mccr8, r=khuey
2013-12-03 18:35:04 +01:00
Andrew McCreight
ea3497e170
Bug 937751, part 7 - Incrementalize nsCycleCollector::MarkRoots. r=smaug
...
Now that all of MarkRoots's state is stored on the heap, it can be run
incrementally. Like with Collect, it takes a budget to determine how
long it can run. Any residual budget will be available to the caller.
One difference is that Collect calls checkOverBudget() which always checks
the time, but MarkRoots uses isOverBudget() to determine if there is
any time remaining. This only checks the current time every
kNumNodesBetweenTimeChecks nodes, to reduce the overhead of checking.
2013-12-03 10:47:47 -08:00
Andrew McCreight
bd8bf20017
Bug 937751, part 6 - Allocate the current MarkRoots node on the heap rather than the stack. r=smaug
...
To make nsCycleCollector::MarkRoots incremental, we have to store all of its state on
the heap, so we can resume it. The only remaining state to convert is the NodePool
enumerator.
2013-12-03 10:47:47 -08:00
Andrew McCreight
bbd56bb6f1
Bug 937751, part 5 - Add optional phase logging. r=smaug
...
For debugging purposes, it can be useful to see what ICC is currently
being run.
2013-12-03 10:47:47 -08:00
Andrew McCreight
5e100e7681
Bug 937751, part 4 - Incrementalize nsCycleCollector::Collect. r=smaug
...
This patch makes it so that Collect takes a time budget that describes
how much longer the collection can be run for. Then we run the current phase.
Once this is done, we check whether we have exceeded our time budget or
if we have finished a collection. If neither of those have happened, we
run the cycle collector some more.
If we're a manually triggered CC, and we were in the middle of an ICC when
the CC started, then once the current CC is complete, we start a new CC
immediately. This is needed to ensure that a manually specified listener
is used, and to ensure that any garbage objects the caller expects to be
collected are in fact collected.
Note that in this patch we are always passing in an unlimited budget to
Collect, so cycle collections will always be run to completion.
2013-12-03 10:47:47 -08:00
Andrew McCreight
c77f88b2f3
Bug 937751, part 3 - Protect against reentrancy with when incrementally CCing. r=smaug
...
Cycle collection protects against reentrancy by setting a flag to indicate a collection
is in progress. With synchronous CC, it is okay to set this in BeginCollection, and
clear it in CleanupAfterCollection. With ICC, this must be set and cleared in every
slice, so I moved the fixing of it to Collect. I also changed the name of the variable,
because we can be in the middle of an ICC without the CC being actively running,
and it is only the latter we are worried about here.
2013-12-03 10:47:47 -08:00
Andrew McCreight
33eaf2c4b9
Bug 937751, part 1 - Add and set incremental cycle collection phases. r=smaug
2013-12-03 10:47:46 -08:00
Nicholas Nethercote
39004db706
Bug 936964 (part 7, attempt 2) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
...
* * *
Bug 936964 (part 7b) - Fix a use-after-free found by ASan.
--HG--
extra : rebase_source : d38ab6b63e9d576773baf8e55fa4f7182c33915e
2013-11-07 16:35:30 +11:00
Nicholas Nethercote
80c840bc7e
Bug 936964 (part 3, attempt 2) - Make nsCycleCollector ref-counted. r=mccr8.
...
--HG--
extra : rebase_source : ebda496b8cba0464280eb0dc7bae9aca137e2e25
2013-11-25 15:57:53 -08:00
Ehsan Akhgari
a903aefdc0
Backed out 9 changesets (bug 943660, bug 936964) because of ASAN use-after-free crashes on browser-chrome and mochitest-other
...
Backed out changeset 85486c4aa3d8 (bug 936964)
Backed out changeset 25312eb71998 (bug 936964)
Backed out changeset 6dbb8333960c (bug 936964)
Backed out changeset da6465ad476f (bug 936964)
Backed out changeset a87ffc992f38 (bug 936964)
Backed out changeset 4ae3a61182db (bug 936964)
Backed out changeset 34e9c3137804 (bug 936964)
Backed out changeset fd1459e71585 (bug 936964)
Backed out changeset 3e8a701d8bdc (bug 943660)
Landed on a CLOSED TREE
--HG--
rename : content/canvas/src/WebGLMemoryTracker.h => content/canvas/src/WebGLMemoryReporterWrapper.h
2013-11-27 20:05:00 -05:00
Nicholas Nethercote
bc475c75df
Bug 936964 (part 7) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
...
--HG--
rename : content/canvas/src/WebGLMemoryReporterWrapper.h => content/canvas/src/WebGLMemoryTracker.h
extra : rebase_source : 611e8d35907959b163aeced1c4ffe1d265048fe6
2013-11-07 16:35:30 +11:00
Nicholas Nethercote
49c091bbb1
Bug 936964 (part 3) - Make nsCycleCollector ref-counted. r=mccr8.
...
--HG--
extra : rebase_source : f781c197b20354eda4622d436d5ef3429ce2481b
2013-11-25 15:57:53 -08:00
Andrew McCreight
aecbe64228
Bug 937966 - Clean up scan safe assertion in Suspect. r=smaug
2013-11-26 17:30:46 -05:00
Andrew McCreight
685a29f9b1
Bug 931738 - Remove nsPurpleBufferEntry from nsISupportsImpl.h. r=smaug
2013-11-26 14:29:59 -05:00
Carsten "Tomcat" Book
b696d7931d
merge mozilla-inbound to mozilla-central
2013-11-21 14:20:21 +01:00
Nicholas Nethercote
6ebfdcab7c
Bug 940069 - Backout a temporary debugging printf that runs on --enable-valgrind builds only, because it has served its purpose. r=me.
2013-11-20 00:27:00 -08:00
Andrew McCreight
6663405c37
Bug 935721, part 10 - Separate nsCycleCollector_collect and nsCycleCollector_scheduledCollect. r=smaug
2013-11-20 14:35:17 -08:00
Andrew McCreight
e95cbc0c81
Bug 935721, part 9 - Move mPtrToNodeMap into GCGraph. r=smaug
...
With ICC, we may have to remove things from the graph after we have finished building
the graph, so move the mapping to graph addresses into the graph itself to create a
more self-contained structure.
2013-11-20 14:35:17 -08:00
Andrew McCreight
bb1468458b
Bug 935721, part 8 - Add a reference to the graph to the graph builder. r=smaug
...
This moves towards letting the CC graph outlive the builder.
2013-11-20 14:35:16 -08:00
Andrew McCreight
e684f4cc71
Bug 935721, part 7 - Inline PrepareForCollection into BeginCollection. r=smaug
...
PrepareForCollection is trivial now, so just inline it.
2013-11-20 14:35:16 -08:00
Andrew McCreight
96e1092a51
Bug 935721, part 5 - Invert the control flow of CycleCollectNow's pre- and post-collection work, add CCResults as a field on the CC. r=smaug
...
nsJSEnvironment::CycleCollectNow does work before and after a CC runs. With ICC, nsJSEnv won't
know where in the CC when a CC is about to begin or end, so this patch reorganizes that work
into two separate callback hooks. This requires adding a new struct, CycleCollectorStats, to
hold data nsJSEnv needs between the two calls.
Rather than trying to pass around a pointer to a results structure, this patch just adds
it to the nsCycleCollector struct, and always stores them. The results are passed back
to the end CC callback.
2013-11-20 14:35:16 -08:00
Andrew McCreight
44bb1bc6e4
Bug 935721, part 4 - Allocate white nodes array in CollectWhite. r=smaug
...
The white nodes array is only used in CollectWhite, so just allocate it there.
2013-11-20 14:35:16 -08:00
Andrew McCreight
e4b1a62a1a
Bug 935721, part 3 - Use RAII to set mScanInProgress, hoist out MarkRoots and ScanRoots. r=smaug
...
With ICC, mScanInProgress gets set and cleared a bunch of times so add an RAII class to turn
it on when we're doing stuff and clear it when we're not.
With that in place, we can easily move MarkRoots and ScanRoots out of BeginCollection
in preparation for making them separate phases in ICC.
2013-11-20 14:35:16 -08:00
Andrew McCreight
96d04bb502
Bug 935721, part 2 - Allocate GCGraphBuilder on the heap. r=smaug
...
With ICC, the graph builder must persist across invocations of the CC,
so store it on the heap.
2013-11-20 14:35:15 -08:00
Andrew McCreight
6f67d60423
Bug 935721, part 1 - Store the listener pointer on the nsCycleCollector data structure. r=smaug
...
With ICC, the listener must persist across invocations of the CC, so store it on the CC.
2013-11-20 14:35:15 -08:00
Benjamin Smedberg
8fd1bc7f20
Bug 672843 part C - convert most of XPCOM except for xpcom/tests, r=vdjeric
2013-11-19 16:27:37 -05:00
Nicholas Nethercote
b82ef1a8fa
Bug 940069 - Land a temporary debugging printf that runs on --enable-valgrind builds only, because Valgrind runs aren't available on tryserver. r=me.
2013-11-18 23:13:15 -08:00
Olli Pettay
b1b4cf61fc
Bug 937303 - Make CC logger to pass information about compartments, r=mccr8
2013-11-12 15:53:51 +02:00
Wes Kocher
b4defcfe2f
Backed out changeset 3d769520a0be (bug 937303) for build bustage
2013-11-11 14:50:00 -08:00
Olli Pettay
bdbe7564bf
Bug 937303 - Make CC logger to pass information about compartments, r=mccr8
...
--HG--
extra : rebase_source : 48545d4c83d88f34773ca84e542aa13316ca38c6
2013-11-12 00:12:00 +02:00
Olli Pettay
50f8b65717
Bug 936789 - Faster CC logger, r=mccr8
2013-11-09 23:15:44 +02:00
Andrew McCreight
863ffe2480
Bug 934568 - Don't make ScanRoots CC OOM assertion fatal due to Win7 debug M2 failures. s=smaug
2013-11-06 16:58:13 -08:00
Nicholas Nethercote
3eae0dfea5
Bug 934321 - Add MemoryMultiReporter, a helper class that reduces some boilerplate, and convert all existing multi-reporters to use it. r=wchen.
...
--HG--
extra : rebase_source : a6110c3558c571b7908b63e8cc7ca21103098d0d
2013-11-06 14:58:20 +11:00
Benoit Jacob
00ed7105bd
Bug 934568 - Make cycle collector OOM assertions fatal in debug builds. r=mccr8
2013-10-27 07:51:31 -04:00
Jonas Finnemann Jensen
41edf8980c
Bug 902587 - Part 2A: Refactor late-write-checks as client of IO Interposer. r=BenWa
...
--HG--
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/LateWriteChecks.h
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/PoisonIOInterposer.h
rename : xpcom/build/mozPoisonWriteBase.cpp => xpcom/build/PoisonIOInterposerBase.cpp
rename : xpcom/build/mozPoisonWriteMac.cpp => xpcom/build/PoisonIOInterposerMac.cpp
rename : xpcom/build/mozPoisonWriteWin.cpp => xpcom/build/PoisonIOInterposerWin.cpp
2013-11-05 07:45:20 -05:00
Andrew McCreight
96267f1e9a
Bug 928647 - Remove CycleCollectedRuntime::mObjectToUnlink. r=smaug
2013-10-19 08:59:10 -07:00
Olli Pettay
08cf0e1d70
Bug 927813 - Some micro-optimizations for Suspect, r=mccr8
2013-10-17 17:05:13 +03:00
Birunthan Mohanathas
0244dd58be
Bug 784739 - Switch from NULL to nullptr in xpcom/ (1/3); r=ehsan
2013-10-10 16:41:00 -04:00
Thinker Lee ext:(%2C%20Cervantes%20Yu%20%3Ccyu%40mozilla.com%3E)
f5213d3e66
Bug 771765 - Support template content process, part 6: support re-creation of the threads created in the template process. r=khuey, r=jorendorff
...
The threads that are frozen/recreated include:
* ImageBridgeChildThread.
* Image decoding thread pool.
* IPC thread (checkpointed, but not frozen).
* GC Helper thread.
* XPC runtime watchdog thread.
* Socket transport service thread/thread pool.
* Memory pressure watcher.
* Timer thread.
* DOM promise worker.
2013-06-03 18:14:42 +08:00
Andrew McCreight
69e40bc338
Bug 915488 - Make CC participant's Root, Unroot and Unlink methods infallible. r=smaug
2013-09-11 18:57:53 -07:00
Ehsan Akhgari
83edc15195
Bug 917885 - Minimize the #includes in xpcom/base; r=bsmedberg
2013-09-19 14:29:31 -04:00
Ehsan Akhgari
5b80f8355d
Backed out changeset a8d6973e5743 (bug 917885) because I pushed the wrong patch
2013-09-19 14:27:35 -04:00
Ehsan Akhgari
17ae4f436e
Bug 917885 - Minimize the #includes in xpcom/base; r=bsmedberg
2013-09-19 14:12:56 -04:00
Nicholas Nethercote
7983bb2a7f
Bug 910517 (3rd attempt) - Remove nsIMemoryReporter, and rename nsIMemoryMultiReporter as nsIMemoryReporter. r=mmcr8.
...
--HG--
rename : content/canvas/src/WebGLMemoryMultiReporterWrapper.h => content/canvas/src/WebGLMemoryReporterWrapper.h
extra : rebase_source : 2b2a1b2667d6562fcf803ec48b4a8c10fdd519a3
2013-08-27 16:24:51 -07:00
Andrew McCreight
34c84eb4f1
Bug 913666, part 5 - Rename aListener to aManualListener. r=smaug
...
The name "aListener" is not very descriptive, and with the previous patch, it is only
used to pass in a manually-specified listener that was passed in to CycleCollectNow,
so rename things.
2013-09-10 16:33:41 -07:00
Andrew McCreight
9297f8e56e
Bug 913666, part 4 - Sink free floating code from nsCycleCollector::Collect into BeginCollection. r=smaug
...
The hg diff for this commit is terrible, but all it is doing is taking the code
in nsCycleCollector::Collect from after PrepareForCollection through BeginCollection
and moving it into BeginCollection.
2013-09-10 16:33:41 -07:00
Andrew McCreight
5f53367674
Bug 913666, part 3 - Sink cycle collector listener selection into Collect. r=smaug
...
Move the two places we check global flags to decide if we want to use a listener, even if we
aren't passed in one. A later patch renames aListener to aForcedListener to make it less
confusing.
2013-09-10 16:33:40 -07:00
Andrew McCreight
61fc280328
Bug 913666, part 2 - Log cycle collector garbage at the same time we log roots. r=smaug
...
There's no reason to wait until CollectWhite to record what is garbage, and with incremental CC
we'll get more accurate logging by logging right away, rather than waiting until later when an
object may have gone away for some other reason.
2013-09-10 16:33:40 -07:00
Andrew McCreight
c97621b9aa
Bug 913666, part 1 - Move cycle collector root logging into ScanRoots. r=smaug
2013-09-10 16:33:39 -07:00
Andrew McCreight
946af7a12e
Bug 913881, part 6 - Measure weak map representations in the cycle collector graph. r=njn
...
Contrary to the comment here, I'm pretty sure this needs to be measured. mWeakMaps
is an array of little structs. Of course, in practice I doubt this amounts to anything.
2013-09-10 08:56:36 -07:00
Andrew McCreight
37a96c3566
Bug 913881, part 5 - Assert for freeing snow white during cycle collector scanning. r=smaug
...
If you call FreeSnowWhite when scanning is true, then objects that get released won't be added to the purple buffer, and you can get leaks.
2013-09-10 08:56:36 -07:00
Andrew McCreight
a52d562072
Bug 913881, part 4 - Change nsCycleCollector::ClearGraph to GCGraph::Clear. r=smaug
...
There's no reason I can see to have this in nsCC instead of GCGraph.
2013-09-10 08:56:36 -07:00
Andrew McCreight
ad32530a42
Bug 913881, part 3 - Fix argument name for GCGraphBuilder::AddNode. r=smaug
2013-09-10 08:56:35 -07:00
Andrew McCreight
1ccffa0309
Bug 913881, part 2 - Make a bunch of nsCycleCollector methods private. r=smaug
2013-09-10 08:56:35 -07:00
Andrew McCreight
cf8f801bff
Bug 913881, part 1 - Remove unused method nsCycleCollector::Runtime. r=smaug
2013-09-10 08:56:35 -07:00
Andrew McCreight
35872c70ab
Bug 913527, part 3 - Check for collection in progress in Collect. r=smaug
...
Moving this to the top level simplifies dealing with PrepareForCollection a bit.
2013-09-10 08:56:34 -07:00
Andrew McCreight
7dfdd8f01d
Bug 913527, part 2 - Remove empty CC graph optimization. r=smaug
...
This looks like a dubious optimization to skip most of a CC when the graph
is empty, dating from the dawn of the CC, but I doubt it is ever triggered
nowadays.
2013-09-10 08:56:34 -07:00
Andrew McCreight
efebb04f5b
Bug 913527, part 1 - Get rid of FinishCollection. r=smaug
...
This can just be inlined now, with the cleanup parts moved into CleanupAfterCollection.
2013-09-10 08:56:34 -07:00
Andrew McCreight
1c638d5f5b
Bug 911829 - Separate main thread and worker cycle collector telemetry. r=smaug
2013-09-10 08:29:45 -07:00
Kyle Huey
c6389ea0fa
Bug 911258: Part 4 - Refactor exception implementations. r=bz
2013-09-08 20:28:50 -07:00
Andrew McCreight
0e792ce8b7
Bug 913130, part 4 - Replace body of ShutdownCollect loop with Collect. r=smaug
2013-09-06 16:17:53 -07:00
Andrew McCreight
916cfd2ccd
Bug 913130, part 3 - Run {PrepareFor,CleanupAfter} every iteration of ShutdownCollect. r=smaug
2013-09-06 16:17:03 -07:00
Andrew McCreight
8cfa8b27b2
Bug 913130, part 2 - Give Collect and ShutdownCollect more consistent ordering. r=smaug
2013-09-06 16:16:45 -07:00
Andrew McCreight
a20bc41d54
Bug 913130, part 1 - Modify nsCycleCollector::Collect to allow it to be used at shutdown. r=smaug
2013-09-06 16:15:10 -07:00
Andrew McCreight
4558644828
Bug 913080 - Make GCGraphBuilder's hash table initialization infallible. r=smaug
2013-09-06 13:42:27 -07:00
Andrew McCreight
9b9141a21e
Bug 911233, part 3 - Add more CheckThreadSafety calls to the cycle collector. r=khuey
2013-09-06 13:41:42 -07:00
Andrew McCreight
9ae420c351
Bug 911233, part 2 - Inline SelectPurple. r=smaug
2013-09-06 13:41:11 -07:00
Andrew McCreight
86cac34e69
Bug 911233, part 1 - Minor cycle collector cleanups. r=smaug
2013-09-06 13:40:34 -07:00
Andrew McCreight
01af9297c7
Bug 883920 - use templates for {Hold,Drop}JSObjects. r=peterv
2013-08-16 13:10:17 -07:00
Olli Pettay
fec6e6d8e3
Bug 910797, make Event.isTrusted to work in workers, r=khuey
2013-08-30 12:47:19 +03:00
Landry Breuil
6029fbc82e
Bug 905920 - Fix build on platforms without SPS profiler r=khuey
2013-08-20 13:48:22 +02:00
Andrew McCreight
d45893bf60
Bug 903524 - Rename TestJSHolder to IsJSHolder. r=smaug
2013-08-15 10:29:02 -07:00
Kyle Huey
7ea5a68da2
Bug 901630: Remove support for the cc thread. r=mccr8
2013-08-13 10:45:32 -07:00
Andrew McCreight
eb5f8005c8
Bug 901756 - Fix a few nits in nsCycleCollector.cpp r=khuey
...
Remove an unused forward declaration, and an unused field
2013-08-05 17:04:47 -07:00
Kyle Huey
b0e1508e38
Bug 845545: Part 4 - Create a worker implementation of CycleCollectedJSRuntime. r=mccr8,bent
2013-08-03 16:55:40 -07:00
Kyle Huey
9908c2bd93
Bug 845545: Part 3 - Give the CycleCollectedJSRuntime more control over
...
SnowWhite. r=smaug
2013-08-03 16:55:39 -07:00
Kyle Huey
92d60a1477
Bug 845545: Part 1 - Fix heap dumping to work off the main thread. r=mccr8
2013-08-03 16:55:39 -07:00
Andrew McCreight
d885cfcb46
Bug 887903 - Non-fatally assert when nsDeque fails due to OOM during scanning in CC. r=smaug
2013-05-28 17:42:13 -07:00
Ehsan Akhgari
2824b29025
Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
...
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:
# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.mm" \) | \
xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
modules/libmar/src/mar_private.h \
modules/libmar/src/mar.h
# assert_replacer.py
#!/usr/bin/python
import sys
import re
pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")
def replaceInPlace(fname):
print fname
f = open(fname, "rw+")
lines = f.readlines()
for i in range(0, len(lines)):
while True:
index = re.search(pattern, lines[i])
if index != None:
index = index.start()
lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
for j in range(i + 1, len(lines)):
if lines[j].find(" ", index) == index:
lines[j] = lines[j][0:index] + lines[j][index+4:]
else:
break
else:
break
f.seek(0, 0)
f.truncate()
f.write("".join(lines))
f.close()
argc = len(sys.argv)
for i in range(1, argc):
replaceInPlace(sys.argv[i])
--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00
Ehsan Akhgari
ef4b479714
Bug 872127 - Part 2: Replace mozilla/StandardInteger.h with stdint.h; r=Waldo,ted
2013-07-30 10:25:31 -04:00
Olli Pettay
ae46376c2e
Bug 897433 - Telemetry for SnowWhite and more async SnowWhite freeing (patch v4), r=mccr8
2013-07-27 13:48:45 +03:00
Andrew McCreight
371753028b
Bug 692226 - Record weak map entries in the cycle collector log. r=smaug
2013-07-26 08:12:51 -07:00
Ryan VanderMeulen
496513c7cd
Backed out changeset 300f5b7d72e1 (bug 897433) for intermittent Linux dromaeo crashes.
2013-07-25 21:18:20 -04:00
Olli Pettay
e05c81b4a4
Bug 897433, Telemetry for SnowWhite and more async SnowWhite freeing, r=mccr8
...
--HG--
extra : rebase_source : 487139a95f50e69d6273c2870ed6623f175544e7
2013-07-25 22:56:20 +03:00
Andrew McCreight
1c657bf12f
Bug 895933 - Record if a CC log is AllTraces or not. r=khuey
2013-07-19 10:00:53 -07:00
Olli Pettay
a0d710b2dd
Bug 895578 - Make SnowWhiteKiller to use fallible TArray, r=mccr8
2013-07-19 15:53:16 +03:00
Andrew McCreight
8072ebea00
Bug 888461 - Remove unused field nsCycleCollector::mFollowupCollection. r=smaug
2013-07-14 05:10:30 -07:00
Andrew McCreight
bc21d6169e
Bug 888999 - Remove mObject null checks in the cycle collector. r=smaug
2013-07-18 09:07:28 -07:00
Andrew McCreight
b2b308ac21
Bug 889053 - Remove nsCycleCollectorParams::mDoNothing which does nothing. r=khuey
2013-07-18 09:07:28 -07:00
Olli Pettay
b002b30b2a
bug 789919, (snow-white) make addref/release of CCable objects faster by removing indirect refcnt increase/decrease, r=mccr8, test changes r=ehsan
...
--HG--
extra : rebase_source : 2a3b22425c14d6daedc91d62a652c34431acd2fb
2013-07-09 13:30:58 -04:00
Kyle Huey
ab927a2cc9
Bug 885866: Separate deferred finalization from XPConnect so we can use it off the main thread. r=mccr8, peterv, bsmedberg, jorendorff
2013-07-09 07:28:15 -07:00
Catalin Iacob
6f4758d23e
Bug 798914 (part 5) - Use newly introduced mozilla::MallocSizeOf instead of nsMallocSizeOfFun. r=njn.
...
--HG--
extra : rebase_source : fc472490dd978d165f02f77ed37f07aed6e5bb61
2013-06-23 14:03:39 +02:00
Kyle Huey
7d893e1ec2
Bug 882893: Move observer notifications out of the cycle collector and into the runtime. r=smaug
2013-06-19 14:06:50 -07:00
Andrew McCreight
ca9071a8e2
Bug 884434 - Assert on extra shutdown CCs. r=smaug
2013-06-18 15:57:41 -07:00
Kyle Huey
16244dd73a
Bug 877584: Followup to avoid some crashes during shutdown. r=mccr8
2013-06-18 12:02:16 -07:00
Kyle Huey
66fb46a26e
Bug 882162: Part 9 - Kill nsCycleCollectionJSRuntime. r=mccr8
2013-06-18 12:02:16 -07:00
Kyle Huey
a57dbb3230
Bug 877584: Route JS holding through the cycle collection runtime so it can do different things on different threads. r=mccr8
2013-06-18 12:01:26 -07:00
Andrew McCreight
39cce294b2
Bug 880754 - Remove unused PointerSet typedef. r=khuey
2013-06-10 10:12:17 -07:00
Andrew McCreight
2789f6cab8
Bug 875304, part 2 - Add nonfatal assertions for OOM during CC graph building. r=smaug
2013-05-24 15:00:36 -07:00
Andrew McCreight
2e035bab53
Bug 875304, part 1b - remove pointless AppendElement checks from CC. r=smaug
2013-06-03 10:43:17 -07:00
Andrew McCreight
037c7ef2f2
Bug 875304, part 1 - remove some useless malloc checks. r=smaug
2013-05-24 13:25:20 -07:00
Ed Morley
3bf60a9f11
Backed out changeset 2864e2610800 (bug 877584) for causing bug 881266
2013-06-11 16:11:14 +01:00
Kyle Huey
bbf045f825
Bug 877584: Route JS holding through the cycle collection runtime so it can do different things on different threads. r=mccr8
2013-06-09 16:02:02 -07:00
Kyle Huey
3c18bb93bd
Back out bug 877584 on this CLOSED TREE.
2013-06-06 10:49:09 -07:00
Kyle Huey
a983f728ac
Bug 877584: Route JS holding through the cycle collection runtime so it can do different things on different threads. r=mccr8
2013-06-06 10:23:45 -07:00
Andrew McCreight
682308cad3
Bug 874258 - Warn if we run shutdown CC more than twice. r=smaug
2013-05-24 11:26:09 -07:00
Andrew McCreight
252d3b2eb6
Bug 873764 - Assert when CC runner isn't properly shut down. r=khuey
2013-05-20 10:38:36 -07:00
Phil Ringnalda
24157c7636
Merge m-c to a CLOSED TREE m-i
2013-05-25 20:44:02 -07:00
Phil Ringnalda
ffb2b400a4
Bug 876159 - Remove warnings that overflow maximum log size in CC-during-OOM cases, r=mccr8 CLOSED TREE
2013-05-25 14:40:09 -07:00
Aryeh Gregor
8b16f79037
Bug 867101 - Fix more implicit conversion to already_AddRefed; r=Ms2ger
2013-04-28 14:52:10 +03:00
Andrew McCreight
199fcfca97
Bug 873111 - Statically enforce root/child phase separation in cycle collector graph building. r=smaug
2013-05-20 13:08:11 -07:00
Andrew McCreight
11be5b49cd
Bug 873664 - remove two unused fields from nsCycleCollector.cpp r=smaug
2013-05-17 16:59:34 -07:00
Andrew McCreight
e8995d5110
Bug 866429 - Simplify shutdown cycle collections. r=smaug
2013-04-27 11:45:46 -07:00
Andrew McCreight
8765722e58
Bug 865320 - Move the logic for deciding when to doing a merging CC into the cycle collector. r=smaug
2013-04-29 16:41:41 -07:00
Andrew McCreight
1f8daed795
Bug 867974 - fail more gently when purple buffer count isn't zero. r=smaug
2013-05-09 13:19:00 -07:00
Andrew McCreight
d44ce3612d
Bug 868761 - Remove trailing whitespace from nsCycleCollector.cpp. r=smaug
2013-05-04 08:39:44 -07:00
Andrew McCreight
c88229fdd3
Bug 863085, part 2 - remove NS_CycleCollectorForget2 from some XPCOM glue. r=bsmedberg
2013-05-01 15:36:03 -07:00
Andrew McCreight
b82ff0e35c
Bug 863085, part 1 - Gut NS_CycleCollectorForget2 and rename CC::Suspect2. r=smaug
2013-05-01 15:35:13 -07:00
Andrew McCreight
3a107ba64a
Bug 864344 - Remove unused code for NS_Alloc failures in the cycle collector. r=smaug
2013-04-30 10:41:23 -07:00
Andrew McCreight
dba6cce472
Bug 716716 - Add templated way to iterate over purple buffer entries. r=smaug
2013-04-30 10:41:23 -07:00
Andrew McCreight
3c9c388be6
Bug 866151 - Clean up usage of nsCycleCollector.h and nsCycleCollectorUtils.h. r=smaug,bsmedberg
...
--HG--
rename : xpcom/base/nsCycleCollector.h => xpcom/glue/nsCycleCollectionJSRuntime.h
2013-04-30 10:41:22 -07:00
Andrew McCreight
1905bebe27
Bug 865317 - Allow a useful NodePool::Enumerator to be constructed for an empty CC graph. r=smaug
2013-04-25 08:42:44 -07:00
Andrew McCreight
3a9839780b
Bug 865306 - Add assertions for the initialization of the cycle collector's EdgePool::Iterators. r=smaug
2013-04-25 08:42:44 -07:00
Andrew McCreight
8c5268671e
Bug 837197 - Don't write poison shutdown CC logging. r=smaug
2013-04-25 08:42:44 -07:00
Nicholas Nethercote
1c97315e22
Bug 859657 (part 2) - Remove nsIMemoryMultiReporter.explicitNonHeap because it's more trouble than it's worth; also remove the "explicit" single reporter. r=jlebar.
...
--HG--
extra : rebase_source : a146536a3dd0043082bcb1c26d980c4c6d4c0730
2013-04-11 20:52:32 -07:00
Ehsan Akhgari
da80d7c1bf
Bug 860886 - Make MOZ_CC_LOG_DIRECTORY work again; r=mccr8
2013-04-11 15:39:20 -04:00
Kyle Huey
9c93e2fd41
Bug 839025: Refactor cycle collector thread handling to make it optional. r=mccr8
2013-03-25 14:26:00 -07:00
Benoit Girard
042e2c83ad
Bug 851611 - Part 3: Rename headers. r=jrmuizel
...
--HG--
rename : tools/profiler/sampler.h => tools/profiler/GeckoProfiler.h
rename : tools/profiler/sps_sampler.h => tools/profiler/GeckoProfilerImpl.h
extra : rebase_source : 6ea7c660764a4390cdd8dd91561fff1d7bad6035
2013-03-18 15:25:50 +01:00
Benoit Girard
c47f308258
Bug 851611 - Part 2: Update profiler calls. r=jrmuizel
...
--HG--
extra : rebase_source : f76accc3d3dd86c75cb3e9750734f23ec9c29941
2013-03-16 00:47:02 -04:00
Jon Coppeard
3dcda9b143
Bug 849273 - Investigate splitting the js and JS namespaces r=terrence
...
--HG--
extra : rebase_source : 2b131d0177f02e5f0e89398545481fcacbfde00f
2013-03-19 10:35:41 +00:00
Ed Morley
ab0833645c
Backed out changeset c75481a07302 (bug 851611)
2013-03-18 14:10:35 +00:00
Ed Morley
3091d3e2b6
Backed out changeset d195190adc48 (bug 851611)
...
--HG--
rename : tools/profiler/GeckoProfiler.h => tools/profiler/sampler.h
rename : tools/profiler/GeckoProfilerImpl.h => tools/profiler/sps_sampler.h
2013-03-18 14:10:30 +00:00
Benoit Girard
b03f14270d
Bug 851611 - Part 3: Rename headers. r=jrmuizel
...
--HG--
rename : tools/profiler/sampler.h => tools/profiler/GeckoProfiler.h
rename : tools/profiler/sps_sampler.h => tools/profiler/GeckoProfilerImpl.h
extra : rebase_source : 552fe1d3ff61d15b264aaf86f7c8cb4f4eff69d1
2013-03-18 14:41:02 +01:00
Benoit Girard
919018414b
Bug 851611 - Part 2: Update profiler calls. r=jrmuizel
...
--HG--
extra : rebase_source : 3032aaf7e50cdf9c350da688ec34e50a695fc7ca
2013-03-16 00:47:02 -04:00
Bill McCloskey
c7ddf51a4f
Bug 759585 - Zones (r=jonco,bhackett,njn,dvander,luke,bz,mccr8,bholley)
2013-03-16 20:36:37 -07:00
Igor Bukanov
2b973536e4
Bug 743436 - remove XPCJSRuntime::mJSCycleCollectionContext and related code. r=peterv
...
The patch removes no longer used XPCJSRuntime::mJSCycleCollectionContext,
nsXPConnect::mCycleCollectionContext and related code to create/destroy
contexts. As that made nsCycleCollectionJSRuntime::FinishTraverse() empty
in all cases I removed that method as well.
2013-02-27 11:33:12 -08:00
Kartikaya Gupta
27f16bb571
Bug 845804 - Reuse OpenTempFile from nsMemoryInfoDumper in nsCycleCollector.cpp. r=njn
...
CLOSED TREE
2013-03-01 10:41:17 -05:00
Ed Morley
02245ab6dd
Backed out changeset 1eda65741914 (bug 845804) for xpcshell failures on a CLOSED TREE
2013-03-01 17:31:38 +00:00
Kartikaya Gupta
c1935f174a
Bug 845804 - Reuse OpenTempFile from nsMemoryInfoDumper in nsCycleCollector.cpp. r=njn
2013-03-01 10:41:17 -05:00
Kartikaya Gupta
2e8db46be9
Bug 845342 - Move about:memory and related dump files to the downloads dir on android. r=njn
2013-02-27 08:58:29 -05:00
Kyle Huey
8db92146c6
Bug 845441: Remove DEBUG_CC. r=mccr8
2013-02-26 13:34:32 -08:00
Jonathan Kew
9c8145baf7
backout cset 4ede352670cd (bug 759585) on a CLOSED TREE on suspicion of making windows reftests so slow that they timeout and burn
2013-02-22 09:36:41 +00:00