XUL iframes inside of a privileged XUL document propagate events
between the documents. This breaks React's event model, as React
captures all events at the document level. In the XUL document
containing a XUL iframe, these events end up being dispatched twice.
This fix tricks react into thinking the toolbox.xul document is the only
root document, thus fixing the event system.
MozReview-Commit-ID: B3XF3L6rax1
--HG--
extra : rebase_source : 723d21342dc876a8342882ae066b36c26daf37d2
We were always opening the debugger when clicking on the location link,
which could be wrong since we can have CSS warnings, or logs coming from Scratchpad.
So we add the function to open in StyleEditor and Scratchpad, and copy some mochitests
that where testing the interaction with those links.
MozReview-Commit-ID: 73mQNfy199m
--HG--
rename : devtools/client/webconsole/test/browser_webconsole_bug_766001_JS_Console_in_Debugger.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_debugger_link.js
rename : devtools/client/webconsole/test/browser_webconsole_scratchpad_panel_link.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_scratchpad_link.js
rename : devtools/client/webconsole/test/browser_webconsole_bug_782653_CSS_links_in_Style_Editor.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_styleeditor_link.js
rename : devtools/client/webconsole/test/test-bug-766001-console-log.js => devtools/client/webconsole/new-console-output/test/mochitest/test-location-debugger-link-console-log.js
rename : devtools/client/webconsole/test/test-bug-766001-js-errors.js => devtools/client/webconsole/new-console-output/test/mochitest/test-location-debugger-link-errors.js
rename : devtools/client/webconsole/test/test-bug-766001-js-console-links.html => devtools/client/webconsole/new-console-output/test/mochitest/test-location-debugger-link.html
rename : devtools/client/webconsole/test/test-bug-782653-css-errors-1.css => devtools/client/webconsole/new-console-output/test/mochitest/test-location-styleeditor-link-1.css
rename : devtools/client/webconsole/test/test-bug-782653-css-errors-2.css => devtools/client/webconsole/new-console-output/test/mochitest/test-location-styleeditor-link-2.css
rename : devtools/client/webconsole/test/test-bug-782653-css-errors.html => devtools/client/webconsole/new-console-output/test/mochitest/test-location-styleeditor-link.html
extra : rebase_source : a8494acb5e450f86fa9cddd34515265fc3494d17
DevRel have made it clear that one of the number one complaints they hear is that we are not supporting React in our tools.
So how about we have our event bubbles include React events and allow people to go to the event listener source in the debugger?
I don't believe that any other tool does this so it is totally worth doing... and in time for Christmas as well ;)
Works just fine in development and production versions of React.
It also works in the browser toolbox so it can be used to debug events in our own tools e.g. The Debugger.
The files under devtools/client/inspector/markup/test/ are either test or React library files so they only really need a cursory glance.
This means that you should focus on the following files when reviewing:
- devtools/client/locales/en-US/inspector.properties
- devtools/client/shared/widgets/tooltip/EventTooltipHelper.js
- devtools/server/actors/inspector.js
- devtools/server/event-parsers.js
Now allowed the use of JSX in mochitests and fixed all eslint errors.
MozReview-Commit-ID: AtxhainieQe
--HG--
extra : rebase_source : c57ce476875b19b99ef9e2dcf66df1274809fa54
Pass css-color-4 supporting status from css-property db to OutputParser and SwatchColorPickerTooltip.
MozReview-Commit-ID: N1ffWOlf9f
--HG--
extra : rebase_source : 94b281c2c101d27dc169a6ba6eeca5acf60b8f16
Sometimes (e.g. for window.applicationCache), Reps was shown with a negative number
before the "more..." label. This was due to displaying the children of safeGeterValues
property but not taking them into account for the total number of properties in the object
when displaying the "more..." label.
We fix this and add a test case to make sure we won't have this bug later
MozReview-Commit-ID: 1qBCvehV0Jc
--HG--
extra : rebase_source : 44461f378681407665c6426c0b30be87ae95488a
Add package.json to devtools/client/inspector
Integration with devtools-local-toolbox:
- provides development server
- default webpack config
- landing page to select a tab
In this patch:
- bin/dev-server-js contains the inspector specific routes
- webpack/*-sham.js : inspector dependencies that had to be mocked
ideally, decoupling work should continue and the inspector client
should only ever require files that require no chrome priviledged
APIs.
- toolbox.js contains the interface with devtools-local-toolbox bootstrap
and the inspector panel initialization
- configs/development.json is the inspector config for the devtools-local-toolbox
MozReview-Commit-ID: 7YQLUlgSyDX
--HG--
extra : rebase_source : aba8fac87b66546dbb98f8f8d476cd1557c2659d
Bug 1312236 updated React to v15.3.2 which was making webconsole's mocha test fail.
An error was thrown because the path and export we do in requireHelper to make enzyme
able to call React functions was changed.
We fix the require to ReactDOM by using the react-dom.js file, and we add the similar
react-dom-server.js for ReactDOMServer functions.
Tests now run like they used to.
MozReview-Commit-ID: GXIQJPlqp4A
--HG--
extra : rebase_source : 909bde919dd4d77d8910b4dba7392283f130333a
Add a target property and show the event name (and modifiers if any) in the title.
Minor edit in GripRep to allow to pass a title as a prop.
Edit tests accordingly, and add some to test node highlighting.
MozReview-Commit-ID: JmMidejKS6m
--HG--
extra : rebase_source : 29ad4d398ad7518d752b323a6e6393cd30b18a0a
Ideally we would have used the GUID to join fields to build the compound key but because we show the uniqueId in the tree that would lead to an ugly user experience. As an
alternative we simply use e.g. db1 (default) as the uniqueId. This works as a unique key, is informative for the user and means minimal changes to tests.
MozReview-Commit-ID: I0XxTIoV33p
--HG--
extra : rebase_source : a8a9729ae639f68e849fc8239c36f451496847ad
Check that the `preview` property is not null before using it.
The bug was harmless because we catch it and return an
empty array as the properties of the grip, which is the same
when we don't have anything in the preview prop.
MozReview-Commit-ID: COU8XLATw7x
--HG--
extra : rebase_source : e3b4efbc4957efdeda760917b6b7d22ad02f64ce
Tom Tromey
Ricky Chien
Steve Chung
Jared Wein
Alexandre Poirot
Ryan VanderMeulen
Sébastien Blin
Greg Tatum
Nicolas Chevobbe
Michael Ratcliffe
Wes Kocher
JerryShih
Sebastian Hengst
Tim Nguyen
Julian Descottes
Gabriel Luong
Jarda Snajdr
Carsten "Tomcat" Book
Towkir Ahmed
Ruturaj K. Vartak
Brian Grinstead
Lin Clark
djmdev
Astley Chen