Mats Palmgren
a908f9773e
Bug 410857 part 1 - Traverse overflow lines too so we don't miss some text. r=jfkthame
2017-02-20 17:43:08 +01:00
Daniel Holbert
85f6680212
Bug 1331756 part 5: Drop redundant 'virtual' keyword from method overrides in several frame classes. r=xidorn
...
MozReview-Commit-ID: IwjWBbGe9jo
2017-01-17 16:27:03 -08:00
Mats Palmgren
ed15c70d6d
Bug 1312379 part 1 - [css-align][css-flexbox][css-grid] Introduce nsIFrame methods for calculating baselines per CSS Alignment and CSS2 'vertical-align'. r=dholbert
2016-12-20 23:56:35 +01:00
Ting-Yu Lin
76dba9d5d5
Bug 1291110 Part 2 - Rename availableSpaceHeight to availableSpaceBSize. r=dbaron
...
Rename to make the variable name consistent with the writing-mode
terminology used in PlaceLine().
MozReview-Commit-ID: AvhwHyHz7hV
--HG--
extra : rebase_source : bcec67d9959c1b881b4d287dbbab47dd0d6e0de9
2016-11-08 13:42:14 +08:00
Jeremy Chen
aee90be343
Bug 1286468 followup - Fix naming issues.
...
MozReview-Commit-ID: C2PDA4R5k5F
2016-10-24 15:01:25 +08:00
Jeremy Chen
d11d8fe851
Bug 1286468 - Trim trailing whitspaces in nsBlockFrame.h and nsBlockFrame.cpp. r=TYLin
...
MozReview-Commit-ID: JDgfzmGcb1J
--HG--
extra : rebase_source : 1f4f6dd8a49cfe8ba7829bf09bf20fd06abbc0f5
2016-10-22 19:41:05 +08:00
Jeremy Chen
349eabf2f7
Bug 1286468 - Rename line related functions in nsBlockFrame. r=TYLin
...
1. Rename these functions to agree with Mozilla coding style.
2. Use singular naming instead of plural naming since each of these functions
returns an iterator pointing to a singular line.
3. Rename line() and rline() to BeginLineFrom() and RBeginLineFrom(), which
shall improve the readability.
MozReview-Commit-ID: txZjVnv9Yb
--HG--
extra : rebase_source : b4dae99ab7bf751bd9974616f8f8e6dfe6248fc2
2016-10-22 19:41:05 +08:00
Jeremy Chen
a670e3349a
Bug 1286468 - Rename line related typedefs in nsBlockFrame. r=TYLin
...
MozReview-Commit-ID: Cz9R3D4NzMc
--HG--
extra : rebase_source : 19da1e2a58abedf61fddd9c8e314830cf81a4602
2016-10-22 19:41:04 +08:00
Jeremy Chen
10d4cdde8e
Bug 1286468 - Remove the old vertical alignment coding style. r=TYLin
...
MozReview-Commit-ID: Ocg21HcL9R
--HG--
extra : rebase_source : e36782a703f238722257e7fc989cbc8f7df43792
2016-10-22 19:41:03 +08:00
Xidorn Quan
93217168b7
Bug 1304556 part 1 - Add AutoLineCursorSetup RAII class for local line cursor setup. r=dbaron
...
MozReview-Commit-ID: G5xeCkxsm8N
--HG--
extra : rebase_source : 2da555d2ae07336bedfcc79944b77931748bcc7a
2016-10-21 12:41:52 +11:00
Jeremy Chen
75a2c5a6bf
Bug 1307728 - convert LineReflowStatus to an enum class. r=mats
...
Since we're converting LineReflowStatus to an enum class, the "default:" branch
of LineReflowStatusToString() could be removed as well. In this way, we can add
protection at compile time (warning) instead of runtime (assertion).
MozReview-Commit-ID: 8Ul0eCxqSTR
--HG--
extra : rebase_source : 81cc36bf1ae566d7114466661b7d0db6d63e364f
2016-10-07 00:36:07 +08:00
Jeremy Chen
f210ff2e08
Bug 1307728 - use LineReflowStatusToString to support debugging. r=mats
...
This is a pre-patch that uses LineReflowStatusToString() function instead of
LineReflowStatusNames array to support debugging. With this patch, we could
easily regain debugging support from LineReflowStatusToString() while converting
LineReflowStatus to an enum class.
MozReview-Commit-ID: K2AzZ2zI69p
--HG--
extra : rebase_source : bfbb1221ffb59cd4c27c3fb147a3a3b64e86cf68
2016-10-07 00:36:07 +08:00
Ting-Yu Lin
2884834832
Bug 1301630 - Remove nsBlockFrame::SetFlags(). r=bz
...
Per bug 1299753 comment 20, SetFlags() is designed for flag propagation
to continuations during block reflow. To avoid misuse, I expand
SetFlags() directly in the only reasonable caller nsBlackFrame::Init(),
and replace other usages by AddStateBits().
MozReview-Commit-ID: GsbE2Z0Rps1
--HG--
extra : rebase_source : 72a64e9218870d638f67d1b586f533cd7d16c491
2016-09-09 15:26:57 +08:00
Ting-Yu Lin
13f0d4632f
Bug 1299753 Part 2 - Create block formatting context for DetailsFrame if needed. r=bz
...
nsCSSFrameConstructor::ConstructNonScrollableBlock() has logic to
determine whether to create a block formatting context for a block
frame. I refactor the function to make it reusable by
nsCSSFrameConstructor::ConstructDetailsFrame().
Also, make NS_NewBlockFrame() accept two arguments as other frame
factory functions so that it could be pointed by BlockFrameCreationFunc.
NS_NewBlockFormattingContext is changed accordingly.
The construction for a scrollable DetailsFrame will be further revised
in Part 3.
MozReview-Commit-ID: 8TwG9YMyGva
--HG--
extra : rebase_source : fffdd974df81a809a607491d2534aa8dd2d13ab1
2016-09-07 14:45:42 +08:00
Jeremy Chen
c6d0429830
Bug 1297306 - part6:replace NS_STYLE_CLEAR_* with StyleClear enum class. r=xidorn
...
After using enum class, a switch-case warning in CombineBreakType is caught.
This is one of such kind safty checks that we would like to gain.
Fix it by adding default case for switch-case in CombineBreakType.
MozReview-Commit-ID: BdS3LPN6qzX
--HG--
extra : rebase_source : 17f24a0d482ed6eb51b23e6942d0ac1c87375e0b
2016-09-07 10:20:17 +08:00
Mats Palmgren
68fa5f865f
Bug 1171419 part 4 - Move nsBlockFrame::RenumberLists to nsContainerFrame and generalize it. r=xidorn
2016-09-01 17:36:22 +02:00
Mats Palmgren
6e54c147d1
Bug 1171419 part 2 - Remove useless aPresContext param from RenumberLists. r=xidorn
2016-09-01 17:36:22 +02:00
Mats Palmgren
caa4e63ee5
Bug 1171419 part 1 - Move some list-item numbering code from nsBlockFrame to nsContainerFrame. r=xidorn
...
Drop the aPresContext and aBlockFrame params from RenumberListsInBlock
and rename it RenumberChildFrames. Use 'this' instead of aBlockFrame.
Rename RenumberListsFor to RenumberFrameAndDescendants.
2016-09-01 17:36:22 +02:00
Manish Goregaokar
b756a203ca
Bug 1290813 - Correctly number indirect descendants of <ol reversed>; r=xidorn
...
MozReview-Commit-ID: 6HYtCrgdK13
--HG--
extra : rebase_source : 461d9143cc0775eec2dc6b39f2d13fc5c2fbdf43
2016-08-01 15:54:25 +05:30
Ting-Yu Lin
40fcd21b9a
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
--HG--
extra : rebase_source : c91a2e174a0baec60c1b0111ac7636295004ab35
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
4053c4c028
Bug 1277129 Part 5c - Rename nsHTMLReflowMetrics to ReflowOutput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics" "ReflowOutput"
MozReview-Commit-ID: 2HBb7DkooH5
--HG--
extra : rebase_source : acfa442a6483772fcb5748dc6f5e7072e599032a
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
6111a2de40
Bug 1277129 Part 2c - Rename nsBlockReflowState to BlockReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsBlockReflowState" "BlockReflowInput"
MozReview-Commit-ID: FtjqkQpGfcI
--HG--
extra : rebase_source : c8f678bc47217b778df7f91f0f6cce6c44b04d90
2016-07-21 18:36:36 +08:00
Ting-Yu Lin
4b0284cd0f
Bug 1277129 Part 2a - Move nsBlockReflowState into mozilla namespace. r=dbaron
...
MozReview-Commit-ID: GNEgxqqBDAH
--HG--
extra : rebase_source : d70f52229215111e6d393103c71fb79475353ac0
2016-07-21 18:36:36 +08:00
Ting-Yu Lin
820f88de49
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
--HG--
extra : rebase_source : 623ec822996ba0ea0058dd137acf5a658cdea04a
2016-07-21 18:36:35 +08:00
Mats Palmgren
eeceb11ef1
Bug 1278080 - Make nsContainerFrame::RemoveFrame deal with overflow containers. r=dholbert
2016-06-10 02:56:23 +02:00
Matt Woodrow
47cde44daf
Bug 1243610 - Refactor UpdateOverflow to separate out local overflow from that contributed by descendants. r=dbaron
2016-05-04 12:27:43 +12:00
Ting-Yu Lin
5e10acc738
Bug 1260090 - Remove nsBlockFrameSuper as nsContainerFrame alias. r=dholbert
...
MozReview-Commit-ID: IzI88HCayfi
--HG--
extra : rebase_source : 78393f3396f7387d2d934d704355e397a60e3d99
2016-03-28 14:39:42 +08:00
Xidorn Quan
e2164ce4a4
Bug 1235321 - Enable using line cursor to optimize reflowing absolute frames. r=bz
...
MozReview-Commit-ID: 4tVq5S4eTtS
--HG--
extra : rebase_source : 2162480e3d63c817fd63123d0bb5d299a97fdad6
2016-04-13 13:42:28 +10:00
Cameron McCormack
7c95c39734
Bug 1244068 - Part 4: Use StyleSetHandle instead of concrete style set class in most places. r=dholbert
2016-02-24 18:01:11 +11:00
Boris Chiou
185a769719
Bug 1244049 - Part 1: Define scoped enum for CSSPseudoElement type. r=dbaron
...
--HG--
extra : rebase_source : e53dd269e47fa97eb259ebd9295d012eacbdb612
2016-02-16 23:07:00 +01:00
Ting-Yu Lin
ea65853708
Bug 591737 - Construct details and summary in nsCSSFrameConstructor. r=bz
...
--HG--
extra : commitid : 7tnA5fqdD6L
extra : rebase_source : 452368859fb99183605edcf47fd48ff026bf3a50
2016-02-02 17:39:49 +08:00
Xidorn Quan
00b4af1798
Bug 1230034 part 10 - Convert remaining frame properties to by typed and remove the unsafe declaring macro. r=dbaron
...
--HG--
extra : source : 19140dd4f1640c4600a0f9e0ff790b44f0cd83ca
2016-01-28 14:23:59 +11:00
Nicholas Nethercote
06e901cb9f
Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
...
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.
The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:
- It adds a comment about the null check in
gfxGlyphExtents::GetTightGlyphExtentsAppUnits().
- A couple of functions simply had an unused gfxContext or nsRenderingContext
parameter removed, e.g. SetLineBreaks().
--HG--
extra : rebase_source : 8f56994bb4d254a86788b17ab2864ebc758a7e6b
2015-12-15 13:56:41 -08:00
L. David Baron
9739e1fe6c
Bug 1207157 patch 3 - Don't bother passing around the inline-end margin of replaced elements we consider clearing past floats, since we don't need it any more. r=jfkthame
...
--HG--
extra : commitid : HRqckWRd8My
2015-09-27 02:19:14 -07:00
L. David Baron
e92e2b3d34
Bug 538194 patch 1 - Refactor some code dealing with fitting block formatting contexts around floats into separate functions. r=roc
...
--HG--
extra : commitid : 5GnXOwsYaJA
2015-08-02 21:03:09 -07:00
Jonathan Kew
4e6c40d7ea
Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert
2015-07-16 10:07:57 +01:00
Ehsan Akhgari
c197ee959d
Bug 1174521 - Backout the second part of bug 1143570 to fix the regression; r=roc
2015-06-17 17:45:51 -04:00
Carsten "Tomcat" Book
47a56a31ae
Backed out changeset b857e7a2ab26 (bug 1174521) for timeouts in test_bug1174521.html
2015-06-17 10:12:21 +02:00
Ehsan Akhgari
4dd45d21af
Bug 1174521 - Backout the second part of bug 1143570 to fix the regression; r=roc
2015-06-17 01:34:00 -04:00
Ehsan Akhgari
869988e2ed
Bug 1143570 - Part 2: Update the block frame's line cursor every time that nsBlockInFlowLineIterator's constructor finds a new line; r=roc
2015-06-09 15:58:56 -04:00
Andrea Marchesini
085da9302a
Bug 1156632 - Remove unused forward class declarations - patch 5 - rdf, parser, layout and something else, r=ehsan
2015-04-22 08:29:22 +02:00
Mats Palmgren
2f31bdf840
Bug 1143299 - Make frame insertion methods deal with aPrevFrame being on an overflow list. r=roc a=abillings
2015-04-11 00:21:06 +00:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Jonathan Kew
7bae3d47b2
Bug 1111517 - Use new method UpdateLineContainerWidth instead of SlideLine when finalizing the width of a vertical-rl block. r=smontagu
2014-12-16 09:45:41 +00:00
Jonathan Kew
150a68da5c
Bug 1089388 - Convert nsBlockFrame::SlideLine to use logical coordinates. r=smontagu
2014-11-13 08:58:02 +00:00
Simon Montagu
8d64967541
Bug 1079139: make nsFlowAreaRect.mRect a LogicalRect. r=jfkthame
2014-10-21 15:16:13 -07:00
Simon Montagu
e753ab75a0
Bug 1062963 patch 3: make nsFloatManager's origin a LogicalPoint, adapt GetFlowAreas, AddFloats, ClearFloats, etc. to use it and make nsFloatManager region functions work with logical region. r=jfkthame
2014-10-21 15:16:12 -07:00
Phil Ringnalda
b2eb743d9b
Backed out 4 changesets (bug 1062963, bug 1079139) for failures in 427129-table-caption.html in b2g reftest-6 and Android 2.3 reftest-5
...
Backed out changeset a9672db96a5d (bug 1079139)
Backed out changeset 241c23570a62 (bug 1062963)
Backed out changeset 90172cc0b012 (bug 1062963)
Backed out changeset 71211c4a4acc (bug 1062963)
2014-10-19 18:44:16 -07:00
Simon Montagu
3134a81fca
Bug 1079139: make nsFlowAreaRect.mRect a LogicalRect. r=jfkthame
2014-10-19 12:32:17 -07:00
Simon Montagu
3f0d7f2fcc
Bug 1062963 patch 3: make nsFloatManager's origin a LogicalPoint, adapt GetFlowAreas, AddFloats, ClearFloats, etc. to use it and make nsFloatManager region functions work with logical region. r=jfkthame
2014-10-19 12:32:17 -07:00