Added check in Network.getCookies() to skip duplicate cookies
Also added tests.
Created html files for running tests which set cookies
- remote/cdp/test/browser/network/doc_get_cookies_page.html
- remote/cdp/test/browser/network/doc_get_cookies_frame.html
Added tests to /remote/cdp/test/browser/network/browser_getCookies.js
Updated Puppeteer tests-
- changed Page.setCookie should set secure same-site cookies from a frame spec to PASS
Differential Revision: https://phabricator.services.mozilla.com/D122382
This patch also includes the addition of the Module Registry,
which has been done by Julian Descottes <jdescottes@mozilla.com>.
Differential Revision: https://phabricator.services.mozilla.com/D122018
By implementing the command line handling and the
printing to stderr in the JS module of the Remote
Agent, the Rust implementation is no longer necessary.
This change allows the JS component to hold each detail
about the Remote Agent's status. Also it doesn't
require a full build anymore when changes are needed.
Differential Revision: https://phabricator.services.mozilla.com/D121096
Removed hardcoded product name as firefox in "Browser.getVersion in remote/cdp/domains/parent/Browser.jsm
Also updated tests at:
- remote/cdp/test/browser/browser_cdp.js
- remote/cdp/test/browser/browser_main_target.js
Differential Revision: https://phabricator.services.mozilla.com/D120759
By implementing the command line handling and the
printing to stderr in the JS module of the Remote
Agent, the Rust implementation is no longer necessary.
This change allows the JS component to hold each detail
about the Remote Agent's status. Also it doesn't
require a full build anymore when changes are needed.
Differential Revision: https://phabricator.services.mozilla.com/D121096
By implementing the command line handling and the
printing to stderr in the JS module of the Remote
Agent, the Rust implementation is no longer necessary.
This change allows the JS component to hold each detail
about the Remote Agent's status. Also it doesn't
require a full build anymore when changes are needed.
Differential Revision: https://phabricator.services.mozilla.com/D121096
When a WebSocket upgrade fails we currently do not
send any details of the error. As such it makes
it hard to figure out the real underlying issue.
Further some clients like curl are hanging and do
not immediately exit when the response has been
received. Specifying the Content-Length header
within the response fixes it.
Differential Revision: https://phabricator.services.mozilla.com/D120575
This step removes all the dependencies of mach commands to
having a MachCommandBase as the `self` by using the `command_context`
argument instead. This also removes any remaining statefulness from those
classes that implement mach commands, ultimately making it easier to move
existing commands out of classes in a follow-up.
Differential Revision: https://phabricator.services.mozilla.com/D118058
Previous patches on this bug missed to actually add this file.
As such new WebSocket connections are not possible right now.
Differential Revision: https://phabricator.services.mozilla.com/D120243
This step removes all the dependencies of mach commands to
having a MachCommandBase as the `self` by using the `command_context`
argument instead. This also removes any remaining statefulness from those
classes that implement mach commands, ultimately making it easier to move
existing commands out of classes in a follow-up.
Differential Revision: https://phabricator.services.mozilla.com/D118058
It seems that lazy loading RecommendedPreferences.jsm too late still triggers an error if invoked in CDP::stop
This doesn't relate to a specific code in RecommendedPreferences as even an empty module still triggers the problem.
Therefore it seems mandatory to ensure we don't call stop in CDP.jsm (or WebDriverBiDi.jsm, when implementation will be added there) unless start() was previously called.
Differential Revision: https://phabricator.services.mozilla.com/D119968
Nafees Nehar
Henrik Skupin
Brindusan Cristian
Julian Descottes
Jacek Kuzemczak
Marian-Vasile Laza
James Graham
Noemi Erli
Csoregi Natalia
Christoph Kerschbaumer
Sandor Molnar
Michael Cooper
Alex Lopez
Butkovits Atila