Граф коммитов

4331 Коммитов

Автор SHA1 Сообщение Дата
nelson%bolyard.com a723cfe070 Fix leaks in softoken's argument string parsin. r=rrelyea,alexei.
Bug 339173. Modified Files: pk11db.c pk11pars.h
2006-10-25 18:47:02 +00:00
wtchang%redhat.com 61caebbe8a Bugzilla Bug 351140: handle the case that params->field is an invalid
value.  The patch is by Ryan Jones <sciguyryan+bugzilla@gmail.com>.
r=nelsonb,wtc.
2006-10-24 00:05:43 +00:00
alexei.volkov.bugs%sun.com 966e3934b8 265784: SSL interoperability regression testing. r=nelson
To turn on the feature, set and export env variable
IOPR_HOSTADDR_LIST to space separated interoperability server fqdn list
2006-10-23 23:46:47 +00:00
wtchang%redhat.com 91dfa64226 Bugzilla Bug 341122: it's not necessary to test slot->slotLock because
slot->slotLock cannot be NULL at that point.  The patch is contributed by
Ryan Jones <sciguyryan+bugzilla@gmail.com>. r=nelsonb,wtc.
2006-10-23 22:56:31 +00:00
wtchang%redhat.com c491737eac Bugzilla Bug 339907: fixed the leak of sha1cx. The patch is contributed by
Ryan Jones <sciguyryan+bugzilla@gmail.com>. r=nelsonb,wtc.
2006-10-23 21:24:38 +00:00
wtchang%redhat.com 4c82545467 Bugzilla Bug 351897: Say a != b instead of (! (a == b)). r=jpierre. 2006-10-23 20:46:50 +00:00
wtchang%redhat.com dbb6ae1065 Bugzilla Bug 357015: it turns out the code is correct. it's the comment
that's wrong.
2006-10-18 23:45:32 +00:00
wtchang%redhat.com a9aa5230b7 Bugzilla Bug 357015: added a comment to describe the actual number of files
ReadSystemFiles reads.
2006-10-18 23:05:59 +00:00
slavomir.katuscak%sun.com 951283acfa Fix for previous patch. 2006-10-18 17:59:40 +00:00
wtchang%redhat.com a3c9bc84e3 Bugzilla Bug 356595: noted in the comment that GetCurrentProcess returns
a constant pseudo handle. Added a GetCurrentThreadId call. r=glen.beasley,
neil.williams.
2006-10-17 17:58:06 +00:00
slavomir.katuscak%sun.com 9ed6996ee7 1. Adding timestamps + total time measure for testing subscripts
2. Enables using TESTS variable from system environment (for example TESTS=cert
./all.sh will test only cert tests)
2006-10-17 09:48:17 +00:00
wtchang%redhat.com 7e38c40e38 Bugzilla Bug 355297: changed the way we reseed the RNG so that we modify
all the 256 bits of XKEY. Define struct SHA256ContextStr in the new header
sha256.h so that prng_fips1861.c can use it. r=nelsonb,jpierre.
Modified files: manifest.mn prng_fips1861.c sha512.c
Added file: sha256.h
2006-10-13 16:54:04 +00:00
glen.beasley%sun.com 081ca00a78 355297 rng update checking in wan-tehs patch 2006-10-12 22:48:19 +00:00
glen.beasley%sun.com 390792a63d 356073 C_GetTokenInfo should return CKR_CRYPTOKI_NOT_INITIALIZED if not initialized r=nelson,sr=neil 2006-10-12 22:27:16 +00:00
wtchang%redhat.com 51cd930242 Bugzilla Bug 355297: added new function RNG_SystemRNG, which gets random
bits from the system RNG, and use it for the very first RNG_RandomUpdate
call in rng_init so that we initialize the RNG's XKEY with high quality
entropy. r=jpierre,relyea.
Modified Files:
	os2_rand.c prng_fips1861.c secrng.h unix_rand.c win_rand.c
2006-10-12 02:23:49 +00:00
wtchang%redhat.com ffca628aba Bugzilla Bug 354900: code cleanup -- consolidates some duplicate code,
checks for NULL pointers, and renames the SFTK_IS_SECURE_KEY_OBJECT macro.
r=glen.beasley,relyea.
Modified files: fipsaudt.c fipstokn.c
2006-10-10 22:28:48 +00:00
alexei.volkov.bugs%sun.com 3b9a109d82 353908: klocwork OOM crash in tdcache.c. r=nelson 2006-10-09 22:29:12 +00:00
alexei.volkov.bugs%sun.com a8f4eefb65 353903: klocwork oom crash in softoken/keydb.c. r=nelson 2006-10-09 22:28:07 +00:00
alexei.volkov.bugs%sun.com f4e98c2852 353888: klockwork IDs for ssl3con.c. r=nelson 2006-10-09 22:26:44 +00:00
alexei.volkov.bugs%sun.com 12668703e3 353777: Klocwork Null ptr dereferences in pk11obj.c. r=nelson 2006-10-09 22:25:36 +00:00
alexei.volkov.bugs%sun.com 164d4c2907 353773: klocwork Null ptr dereferences in pk11nobj.c. r=nelson 2006-10-09 22:24:18 +00:00
alexei.volkov.bugs%sun.com 76dff9c91f 353760: klocwork null pointer dereference in p7decode.c. r=nelson 2006-10-09 22:22:33 +00:00
alexei.volkov.bugs%sun.com 4cc26433e6 353742: klocwork null ptr dereferences in pki3hack.c. r=nelson 2006-10-09 22:21:41 +00:00
alexei.volkov.bugs%sun.com c93ff6a5f2 353742: klocwork null ptr dereference in ocsp_DecodeResponseBytes. r=nelson 2006-10-09 22:19:58 +00:00
alexei.volkov.bugs%sun.com 6d632efb6c 353741: klocwork cascading memory leak in mpp_make_prime. r=nelson 2006-10-09 22:18:38 +00:00
alexei.volkov.bugs%sun.com c8c6d0c339 353739: Klocwork Null ptr dereferences in instance.c. r=nelson 2006-10-09 22:16:59 +00:00
alexei.volkov.bugs%sun.com a555a69765 353423: Klocwork bugs in nss/lib/pk11wrap/dev3hack.c. r=nelson 2006-10-09 22:14:04 +00:00
alexei.volkov.bugs%sun.com eb392ed332 353416: Klocwork 76593 null ptr deref in nssCryptokiPrivateKey_SetCertificate. r=nelson 2006-10-09 22:11:44 +00:00
alexei.volkov.bugs%sun.com a168b0dbcc 353375: Klocwork 76513 - Null ptr deref in nssCertificateList_DoCallback. r=nelson 2006-10-09 18:51:55 +00:00
alexei.volkov.bugs%sun.com a7edef3088 353371: Klocwork 91117 - Null Pointer Dereference in CERT_CertChainFromCert. r=nelson 2006-10-09 18:45:02 +00:00
alexei.volkov.bugs%sun.com fc1706cbbb 338226: Core files may be reported in the wrong tests for SSL, or missed. r=neil 2006-10-09 17:42:58 +00:00
wtchang%redhat.com 4d79de55ec Bugzilla Bug 354565: improved an error message as suggested by Neil
Williams.
2006-10-06 23:50:48 +00:00
wtchang%redhat.com 80b56f2e83 Bugzilla Bug 115951: libfreebl3.dylib should be built as a loadable bundle
just like libnssckbi.dylib because it is only dynamically loaded.  We don't
have the import library freebl3.lib on Windows either. r=julien.pierre
2006-10-06 23:45:39 +00:00
wtchang%redhat.com 6f25509ce4 Bugzilla Bug 354900: audit the modifications, accesses, deletions, and
additions of cryptographic keys.  r=glen.beasley,relyea.
Modified files: fipstokn.c manifest.mn pkcs11c.c softoken.h
Added file: fipsaudt.c
2006-10-02 22:48:31 +00:00
wtchang%redhat.com 73f3b25c8c Bugzilla Bug 351482: fail if some of the needed functions don't exist.
r=glen.beasley,relyea.
2006-10-02 22:04:33 +00:00
julien.pierre.bugs%sun.com 81bb832c8f Fix for bug 115951 . Separate BL_Cleanup and BL_Unload . r=wtchang,nelson 2006-10-02 21:15:46 +00:00
nelson%bolyard.com 7c15fcda7a Bug 354384. Fix some (not all) of the reference leaks in vfyserv.
Also, improve usage message.  r=alexei,julien
2006-10-01 05:47:18 +00:00
nelson%bolyard.com d4df5484a3 Bug 354313. Fix leak in STAN_GetCERTCertificateName. r=julien,rrelyea 2006-10-01 05:37:24 +00:00
alexei.volkov.bugs%sun.com 0154446bb1 353413: Klocwork 76541 free uninitialized pointer in CERT_FindCertURLExtension. r=nelson 2006-09-29 20:20:21 +00:00
alexei.volkov.bugs%sun.com 956aaa0068 353374: Klocwork 76494 - Null ptr derefs in CERT_FormatName. r=nelson 2006-09-29 20:18:55 +00:00
alexei.volkov.bugs%sun.com c89f85e085 341114: Coverity 517 SECU_ParseCommandLine leaks optstate. r=nelson 2006-09-29 20:15:47 +00:00
alexei.volkov.bugs%sun.com 2e23193e89 354403:: nssList_CreateIterator returns pointer to a freed memory if the function fails to allocate a lock. r=nelson 2006-09-29 20:13:30 +00:00
alexei.volkov.bugs%sun.com 11e889d320 354008: klocwork bugs in freebl. r=nelson 2006-09-29 20:12:21 +00:00
alexei.volkov.bugs%sun.com 21c4f16a00 321600: SECMOD_LoadPKCS11Module calls to PR_GetLibraryName must use PR_FreeLibraryName. r=wtchang. Patch provided by timeless. 2006-09-29 19:53:07 +00:00
alexei.volkov.bugs%sun.com 3041f905ec 314178: NSS PK11 Module: certificates with unknown AlgorythmIdentifiers make ThunderBird crashed. r=nelson, sr=julien 2006-09-29 19:38:42 +00:00
kaie%kuix.de 4336a5d2a5 Bug 350200, Implement DHMAC based POP (ProofOfPossession)
r=rrelyea, r=nelson
2006-09-28 22:25:55 +00:00
wtchang%redhat.com fd110ec6de Bugzilla Bug 354565: detect SHA tests that are incorrectly configured for
BIT oriented implementations. r=glen.beasley
2006-09-28 16:37:25 +00:00
julien.pierre.bugs%sun.com 24aa200d7b Fix for bug 115951 . Unload freebl dynamic library . Also fix tiny one-time leak of library name . r=nelson,wtchang 2006-09-28 00:40:55 +00:00
julien.pierre.bugs%sun.com fe0ff2999b Fix for bug 353910 . Memory leak in RNG_RNGInit . r=nelson, wtchang 2006-09-26 22:20:18 +00:00
julien.pierre.bugs%sun.com ddd30a01be Fix for bug 351897 . OCSP check should only be skipped for certificateStausResponder usage alone . 2006-09-26 20:18:57 +00:00
kaie%kuix.de 8713ab7b8f Bug 353422, Klocwork bugs in nss/lib/crmf
r=nelson, r=rrelyea
Patch inspired by Nelson
2006-09-26 18:57:28 +00:00
nelson%bolyard.com ff07e960c1 Fix build bustage caused by previous checkin. 2006-09-25 21:46:06 +00:00
julien.pierre.bugs%sun.com 909e463e76 Fix for bug 353896 . Assert at compile time if NSS_ECC_MORE_THAN_SUITE_B is set. For NSS_3_11_BRANCH and tip. r=nelson, alexei 2006-09-25 20:51:11 +00:00
nelson%bolyard.com 2f72927b06 Unifdef USE_MOZ_THREAD (bug 351510) and remove dead code (bug 351443).
Patch contributed by ehsan.akhgari@gmail.com. r=nelson, alexei.volkov
Modified Files: jarint.h jarsign.c jarver.c manifest.mn
Removed Files: jarevil.c jarevil.h
2006-09-25 19:45:40 +00:00
nelson%bolyard.com c33352aa54 Fix leaks in jarfile.c (bug 338453), jarjart.c (bug 351408), and
jarver.c (bug 337361). Patch contributed by ehsan.akhgari@gmail.com
2006-09-25 19:20:37 +00:00
wtchang%redhat.com a326c3f815 Bugzilla Bug 334914: removed a useless null check. Contributed by
Ryan Jones <sciguyryan+bugzilla@gmail.com>.  r=wtc
2006-09-22 19:02:07 +00:00
wtchang%redhat.com 9fb73060ed Bugzilla Bug 353749: for DSA KAT increased the size of P to 1024 bits
used nistK283 binary field curve KAT. Contributed by Glen Beasley of Sun.
r=wtc.
2006-09-22 18:33:25 +00:00
julien.pierre.bugs%sun.com f7ae527571 Fix for bug 353572. Leak in sftk_OpenCertDB . r=alexei,nelson 2006-09-22 00:19:49 +00:00
julien.pierre.bugs%sun.com 172a1a4154 Fix for bug 353608 . NSS_RegisterShutdown may fail, and appData argument is always NULL . r=wtchang,nelson 2006-09-21 20:08:15 +00:00
alexei.volkov.bugs%sun.com d34ae89a56 201139: SSLTap should display plain text for NULL cipher suites. r=nelson 2006-09-20 22:37:35 +00:00
julien.pierre.bugs%sun.com fa847eba0a Fix for bug 352439 - reference leaks in modutil . r=alexei.volkov 2006-09-15 23:10:13 +00:00
wtchang%redhat.com 8dcf31baf6 Added "Basic ECC" and "Extended ECC" to the NSS version string. 2006-09-15 01:04:40 +00:00
wtchang%redhat.com 915932de14 Import NSPR 4.6.3. 2006-09-15 01:01:21 +00:00
kaie%kuix.de 9827ee91b9 Bug 351756, Add 7 new root CA certs to NSS
r=wtchang
2006-09-12 23:38:40 +00:00
wtchang%redhat.com df5d67c889 Change DecryptSigBlock to return the parsed DigestInfo's length, so
the caller can check it.  Fixed a memory leak on error. r=nelson,rrelyea
bug 351848.
2006-09-12 17:13:20 +00:00
julien.pierre.bugs%sun.com 89010b6a94 Fix for bug 352041 . oom in CERT_DecodeDERCrlWithFlags . r=alexei,nelson 2006-09-11 23:12:30 +00:00
glen.beasley%sun.com 62e437574c 351872 mem leak fix for ecdsa powerupselftest r=julien, sr=wan-teh 2006-09-09 00:24:01 +00:00
julien.pierre.bugs%sun.com 29bca86d06 Fix typo in comment. 2006-09-08 21:24:25 +00:00
julien.pierre.bugs%sun.com e76630a134 Fix for bug 332222 . Add support for mixed ECDH RSA SSL cipher suites. Patch contributed by Slavomir Katuscak . r=julien 2006-09-08 21:15:41 +00:00
wtchang%redhat.com f2a1a681f6 Bugzilla Bug 342582: Use the PKCS #11 headers in NSS on Windows, too. 2006-09-08 00:55:03 +00:00
wtchang%redhat.com 19b2578fa2 Bugzilla Bug 342582: removed a space after "PROGRAM = pk11mode", which
broke the Windows build (because the executable name became pk11mode .exe).
Also removed unnecessary variable definitions.
2006-09-08 00:50:09 +00:00
wtchang%redhat.com 0647084026 Bugzilla Bug 351482: Use audit_log_user_message, if available. Otherwise,
fall back on audit_send_user_message, which exists in older versions of
libaudit.so.0. r=glen.beasley,relyea.
2006-09-08 00:16:53 +00:00
julien.pierre.bugs%sun.com db3c2fdfb7 Bug 348198 : trace startup and shutdown time for selfserv. Patch contributed by Slavomir Katuscak. r=julien,alexei 2006-09-07 23:54:07 +00:00
wtchang%redhat.com f382413f1a Bugzilla Bug 342582: include <stdarg.h> instead of "prprf.h" for va_list,
va_start, etc.
2006-09-07 21:09:24 +00:00
wtchang%redhat.com d704ecc250 Bugzilla Bug 342582: improved PKM_CK_RVtoStr: map our vendor-defined error
codes, and return "unknown error" instead of NULL for unknown error codes.
2006-09-07 20:33:43 +00:00
glen.beasley%sun.com 2d5e80463b 342582 changed RSA modulus and public exponent 2006-09-07 18:35:48 +00:00
glen.beasley%sun.com 5b7fb670f0 342582 AIX runtime error and some cleanup 2006-09-07 18:16:52 +00:00
glen.beasley%sun.com 9a0b0a63eb 342582 removed AIX warnings 2006-09-07 06:09:26 +00:00
glen.beasley%sun.com 944520e643 342582 all test passed msg 2006-09-06 21:50:59 +00:00
glen.beasley%sun.com eb966db896 342582 hpux update 2006-09-06 21:19:54 +00:00
julien.pierre.bugs%sun.com f6998636c2 Fix for bug 351270 . Assertion in unix_rand.c . 2006-09-06 21:07:32 +00:00
nelson%bolyard.com 492710966f Improve the validity tests on the AlgorithmID when verifying a PKCS#1 v1.5
RSA signature.  Bug 351079. r=rrelyea,wtchang.
2006-09-05 09:45:46 +00:00
nelson%bolyard.com 135dffb589 Also trace the DH(E) PMS. bug 349966. r=julien.pierre, wtchang 2006-09-02 18:53:54 +00:00
wtchang%redhat.com a52fd375bf Bugzilla bug 342582: this program may use NSPR but it should not link with
any NSS libraries.
2006-09-01 22:23:34 +00:00
wtchang%redhat.com 20531859de Bugzilla bug 342582: need to set slotID. Other minor fixes. 2006-09-01 22:15:37 +00:00
wtchang%redhat.com bd735b0358 Bugzilla bug 342582: MODULE should be nss so we can include NSS headers. 2006-09-01 22:13:20 +00:00
julien.pierre.bugs%sun.com 8382e02245 Fix for bug 182758 . Use only /dev/urandom on Solaris when available . If not, use libkstat . r=nelson, wtchang 2006-09-01 22:08:52 +00:00
wtchang%redhat.com c89e1aadf1 Bugzilla Bug 349609: sftk_MACUpdate only works with multi-part operations.
r=glen.beasley,relyea.
2006-09-01 17:07:59 +00:00
glen.beasley%sun.com 53cbd62fa5 fix warnins on redhat4 2006-08-31 22:26:58 +00:00
glen.beasley%sun.com 7883876093 initial checkin of pk11mode.c FIPS test program work in progress 2006-08-31 17:55:18 +00:00
nelson%bolyard.com 39ed376b7a When verifying a signed digest, ensure that the digest is DER encoded and
that there is no extra stuff after the DER encoded digest.  Bug 350640.
r=julien.pierre,rrelyea
2006-08-31 03:54:48 +00:00
alexei.volkov.bugs%sun.com d64e3427a6 337013: OOM crash [@ nssArena_Destroy - nssTrustDomain_TraverseCertificatesBySubject][@ nssArena_Destroy - nssTrustDomain_TraverseCertificatesByNickname] Dereferencing possibly NULL "tmpArena". r=nelson, sr=julien 2006-08-30 17:57:20 +00:00
glen.beasley%sun.com 4e8368c564 349965 added ECDSA key gen to power up self test r=wtc 2006-08-29 16:57:18 +00:00
nelson%bolyard.com 9b9542f673 Correctly zero-fill columns in weaved array. r=julien,wtchang. Bug 348359. 2006-08-29 02:41:38 +00:00
wtchang%redhat.com 531fe85b65 Bugzilla Bug 349632: made C_Verify work for multi-part mechanisms.
r=glen.beasley,relyea.
2006-08-26 01:49:48 +00:00
alexei.volkov.bugs%sun.com f28d70066b 330056: seckey_put_private_key leaks memory. r=nelson, sr=wtc 2006-08-25 23:04:15 +00:00
alexei.volkov.bugs%sun.com fdc6b5e64b 304361: smime: possible memory corruption when encoding/decoding smime_encryptionkeypref_template. r=nelson, sr=wtc 2006-08-25 22:26:18 +00:00
wtchang%redhat.com 6053e0ef78 Bugzilla bug 336813: do not set the nonstandard flag CKF_THREAD_SAFE. Set
CKF_DUAL_CRYPTO_OPERATIONS and the new v2.10 flag CKF_TOKEN_INITIALIZED.
r=relyea.
2006-08-24 22:52:21 +00:00
nelson%bolyard.com e356cbee97 re-enable SSLTRACE for keys and (pre)master secrets. Bug 349966. r=rrelyea 2006-08-24 22:10:03 +00:00
julien.pierre.bugs%sun.com a4dde368cc Back out Slavo's patch for bug 332222 in ssl.sh because tinderbox fails. 2006-08-24 19:48:08 +00:00
julien.pierre.bugs%sun.com 602921c658 Allow ssl.sh to support mixed ECC/RSA certs. Patch created by Slavomir Katuscak. r=nelson, rrelyea 2006-08-24 17:48:52 +00:00
julien.pierre.bugs%sun.com f333b2e5a9 Fix for bug 332222 . Allow ssl.sh to support mixed ECC/RSA certs. Patch created by Slavomir Katuscak. r=nelson, rrelyea 2006-08-23 23:32:01 +00:00
julien.pierre.bugs%sun.com a1e82132f0 Fix for bug 349920 . Don't optimize freebl libraries in debug build on Sparc . r=nelson, neil.williams 2006-08-23 22:56:20 +00:00
glen.beasley%sun.com 54fe81481a 349632 C_VerifyUpdate HMAC fix r=wtc,sr=bobR 2006-08-23 21:46:23 +00:00
julien.pierre.bugs%sun.com 45f5a763d7 Fix for bug 225525 . Resolve race assigning NSSCertificate fields which leaked memory and slot reference. r=nelson 2006-08-22 22:54:11 +00:00
nelson%bolyard.com 80a2861232 Fix race in CERT_NewTempCertificate. Bug 341323. r=julien,rrelyea 2006-08-22 03:30:14 +00:00
wtchang%redhat.com 98f2c3bf81 Bugzilla Bug 342476: backed out the previous checkin. Not sure if it's a
good idea.
2006-08-18 23:28:10 +00:00
wtchang%redhat.com faf581ad29 Backed out the unnecessary change in the previous checkin. 2006-08-18 22:56:18 +00:00
wtchang%redhat.com 894326bb94 Bugzilla Bug 342476: NSS should set and check the pReserved field in the
(extended) CK_C_INITIALIZE_ARGS structure.  r=nelsonb,relyea.
Modified files: pk11wrap/pk11load.c softoken/pkcs11.c
2006-08-18 22:48:41 +00:00
wtchang%redhat.com 1e8aeab6bb Bugzilla Bug 349011: marked local functions as static. The patch is
contributed by timeless <timeless@bemail.org>. r=wtc.
Modified files: crmfcont.c crmfpop.c crmfreq.c
2006-08-18 22:21:34 +00:00
wtchang%redhat.com 95ac6854cf Bugzilla Bug 53427: Added PORT_ArenaZRelease and change secasn1d.c to zero
our_pool before releasing or freeing it. r=nelsonb,jpierre.
Modified files: secasn1d.c secport.c secport.h
2006-08-15 23:56:01 +00:00
wtchang%redhat.com 3e79aee9fe Bugzilla Bug 53427: passed the correct 'zero' argument to PORT_FreeArena.
Removed dead code. r=nelsonb,relyea.
Modified Files:
	softoken/keydb.c softoken/lowpbe.c softoken/pkcs11c.c
	util/secdig.c
2006-08-15 01:34:38 +00:00
wtchang%redhat.com cf0212dd7a Bugzilla Bug 336813: Improved NSC_GetTokenInfo and FC_GetTokenInfo. Always
set CKF_RNG. Set the utcTime member to 16 zeros "0000000000000000".
Factored out the common flag CKF_RNG and CKF_THREAD_SAFE. r=nelsonb,relyea.
Modified files: fipstokn.c pkcs11.c
2006-08-14 17:52:31 +00:00
wtchang%redhat.com a480328757 Bugzilla Bug 347409: removed the on-demand initiation of the FIPS power-up
self-tests from FC_Login. We now require the user to shut down and restart
the softoken to initiate the power-up tests on demand. r=nelsonb.
2006-08-14 17:05:31 +00:00
wtchang%redhat.com a99d5c47c1 Bugzilla Bug 53427: PORT_FreeArena should zero memory before freeing it if
the 'zero' argument is true. r=nelsonb.
2006-08-14 16:56:39 +00:00
julien.pierre.bugs%sun.com e75f2dc686 Fix for bug 178894 . Unbreak build. 2006-08-07 20:48:04 +00:00
kaie%kuix.de 7b36815896 Bug 346551, init SECItem derTemp in crmf_encode_popoprivkey
r=wtchang
2006-08-07 20:02:59 +00:00
julien.pierre.bugs%sun.com 76317a1b0e Fix for bug 178894 . Quick decoder updates for lib/certdb and lib/certhigh . r=nelson . 2006-08-07 19:09:41 +00:00
julien.pierre.bugs%sun.com 6d267dce80 Fix for bug 177184 . NSS_CMSDecoder_Cancel might have a leak . And this patch might fix it, or not. But this bug needs to be put to rest. 2006-08-05 01:19:23 +00:00
wtchang%redhat.com fed6abf266 Bugzilla Bug 347024: Moved the software integrity test from
nsc_CommonInitialize to the new function sftk_fipsSoftwareIntegrityTest
and have sftk_fipsPowerUpSelfTest call sftk_fipsSoftwareIntegrityTest.
Updated the audit logging code.  Removed an extraneous comma between two
string literals in fipstokn.c. r=relyea,nelsonb.
Modified files: fipstest.c fipstokn.c pkcs11.c
2006-08-03 21:50:51 +00:00
wtchang%redhat.com acaeb20a50 Bugzilla Bug 336509: put the FIPS token in the Error state only when the
continuous RNG test fails.
2006-07-31 18:31:07 +00:00
wtchang%redhat.com 48090e59a8 Bugzilla Bug 336509: check for continuous RNG test failure after direct and
indirect uses of the RNG. r=relyea,nelsonb.
Modified files: fipstokn.c keydb.c pkcs11.c pkcs11c.c pkcs11i.h rsawrapr.c
                softoken.h
2006-07-31 18:10:17 +00:00
wtchang%redhat.com adfb2d0b34 Bugzilla bug 336509: Made prng_GenerateGlobalRandomBytes static because
it's only used in this file. r=neil.williams.
2006-07-29 00:28:12 +00:00
wtchang%redhat.com b843464eb3 Bugzilla Bug 345502: C89 doesn't allow initializing a local array. Fixed
some array sizes.  The patch is contributed by Glen Beasley of Sun. r=wtc.
2006-07-28 20:45:01 +00:00
wtchang%redhat.com 40a16f74c9 Bugzilla Bug 345941: fixed another bug that we might pass uninitialized
'req' to fclose(). Thanks to Wolfgang Rosenauer <mozilla@rosenauer.org> for
reporting the bug and reviewing the patch.
2006-07-28 20:19:02 +00:00
wtchang%redhat.com 97881e483f Bugzilla Bug 345941: fixed the bug that we might pass uninitialized 'req'
to fclose(). r=glen.beasley.  Thanks to Wolfgang Rosenauer
<mozilla@rosenauer.org> for the bug report.
2006-07-27 16:56:56 +00:00
wtchang%redhat.com ee588c0e0d Bugzilla Bug 345775: use SECITEM_FreeItem(..., PR_TRUE) to completely free
the SECItem allocated in getECParams. r=alexei.volkov.
2006-07-27 00:33:23 +00:00
wtchang%redhat.com fcc85009ca Bugzilla Bug 345779: removed two useless assignments and fixed an error in
the comment. r=douglas.stebila.
2006-07-26 23:17:46 +00:00
glen.beasley%sun.com c240d4542b 345502 RNG power up selftest r=wtc 2006-07-24 03:54:09 +00:00
nelson%bolyard.com e923291d6e Correct ifdefs so that non-ECC builds will continue to build correctly.
r=wtchang  bug 341707.
2006-07-20 00:17:23 +00:00
nelson%bolyard.com aa48d36259 Curve-limited clients must not negotiate ECC ciphersuites unless they send the supported curve extension. This means that when they are nogotiating SSL 3.0
and not TLS, they should not negotiate ECC ciphersuites at all.
Bug 341707.  r=rrelyea.
2006-07-19 01:40:17 +00:00
nelson%bolyard.com 7cb9a6798d Workaround bogus assertion failure in MSVC 8 (Express, 2005) RTL by switching
from the old _findfirst, _findnext file enumeration API to the newer
FindFirstFile, FindNextFile API.  Might be slower, but won't crash if it finds
files older than 1970.  Bug 331404. r=julien.pierre
2006-07-19 01:33:41 +00:00
nelson%bolyard.com 916abfcc17 Coverity bug 340217. Fix leak, crash, and failure to set error codes in
CMMF_POPODecKeyChallContDecryptChallenge. r=alexei.volkov
2006-07-19 00:44:02 +00:00
nelson%bolyard.com 4fde45d139 Remove FORTEZZA code from this file. Coverity CID 874. r=rrelyea. 2006-07-19 00:36:38 +00:00
nelson%bolyard.com 29bf58a380 Remove dead function SECU_GetPBEPassword from nss/cmd/lib/secutil.*
Patch contributed by Jon Smirl <jonsmirl@gmail.com>
Coverity CID 516. Bug 337081.  r=nelson@bolyard.com
2006-07-19 00:21:12 +00:00
douglas%stebila.ca 3e2150fc10 Bugzilla Bug 338367: Turn GF2M_POPULATE and GFP_POPULATE macros into functions. r+=wtchang 2006-07-19 00:14:31 +00:00
nelson%bolyard.com 4769c68bf6 Stop using EXTENSION_NOT_FOUND error in OCSP code. r=julien. bug 287850. 2006-07-19 00:08:52 +00:00
wtchang%redhat.com 49af285a1d Bugzilla bug 295291: regenerated using the new certdata.perl script. 2006-07-18 23:38:14 +00:00
alexei.volkov.bugs%sun.com 664d338da2 334459: Variable "(cache)->sharedCache" tracked as NULL was passed to a function that dereferences it. [@ CloseCache - InitCache]. r=nelson 2006-07-17 22:14:48 +00:00
alexei.volkov.bugs%sun.com 9ea0404651 341291: Coverity 689 - potential NULL ptr crash in ssl3_SendCertificate. r=nelson 2006-07-17 22:08:03 +00:00
alexei.volkov.bugs%sun.com 4d331091de 341120: Coverity 541 nss_cms_recipients_traverse leaks "rle". r=nelson 2006-07-17 21:57:35 +00:00
alexei.volkov.bugs%sun.com 8191f90940 341115: Multiple NULL ptr dereferences in nss/lib/base/arena.c. r=nelson 2006-07-17 21:51:32 +00:00
wtchang%redhat.com f656732765 Bugzilla Bug 295291: removed the unused variable 'a' and sort the
definitions of constants in certdata.c. r=nelsonb.
2006-07-17 16:50:45 +00:00
kaie%kuix.de 1ea9ecb85c Bug 343682, crash in libcrmf with ecc
patch=rrelyea, r=kengert, r=nelson
2006-07-13 20:59:51 +00:00
julien.pierre.bugs%sun.com 1bf725b1cb Fix for bug 341708 . Have client send alert if it detects an invalid server key exchange. r=nelson 2006-06-28 21:15:04 +00:00
wtchang%redhat.com 1360e00abe Bugzilla Bug 338798: use PR_FindFunctionSymbol to look up function
symbols. r=alexei.volkov,nelson.
Modified files: freebl/loader.c softoken/dbinit.c
2006-06-26 23:42:59 +00:00
wtchang%redhat.com ab411b37bd Bugzilla Bug 338798: in C89, local struct variables can only be initialized
by constant expressions.  HP C compiler version B.11.11.08 generates
incorrect code silently if the initializers are non-constant expressions.
r=alexei.volkov,julien.pierre.
Modified files: cmd/crmftest/testcrmf.c lib/ssl/ssl3con.c
2006-06-26 23:32:19 +00:00
kaie%kuix.de 189631b3b1 Bug 337486, mismatch between PK11_FindCertFromNickname and FindCerts
r=rrelyea, r=julien.pierre
2006-06-26 23:21:07 +00:00
rrelyea%redhat.com 3f13baf101 bug 335748 ECC support for Mozilla. r=wtc 2006-06-23 17:01:38 +00:00
rrelyea%redhat.com 89fba5eac1 Bug 335748 ECC support for mozilla.
r=wtc
2006-06-23 16:57:43 +00:00
wtchang%redhat.com f25d1d70cd Bugzilla Bug 338798: in C89, local struct variables can only be initialized
by constant expressions.  HP C compiler version B.11.11.08 generates
incorrect code silently if the initializers are non-constant expressions.
r=alexei.volkov,julien.pierre.
2006-06-21 00:40:59 +00:00
wtchang%redhat.com 034af09812 Bugzilla Bug 337034: nested two related tests. r=relyea. 2006-06-17 00:09:59 +00:00
julien.pierre.bugs%sun.com 543d49b730 Workaround (or fix) for bug 341573 . Switch compiler option from -fsimple=2 to -fsimple=1 2006-06-16 04:41:34 +00:00
alexei.volkov.bugs%sun.com 3e699dc0f0 [Bug 337110] OOM Crash and memory leak [@ PK11_CreatePBEParams]. r=julien, sr=nelson 2006-06-16 00:42:46 +00:00
wtchang%redhat.com d3ad378479 Bugzilla Bug 341590: in FIPS mode, softoken should report the more serious
fatalError condition before the !isLoggedIn condition. r=nelson.
2006-06-15 23:55:59 +00:00
christophe.ravel.bugs%sun.com 7d92147b35 Bugzilla 337793: Create a test to check all EC curves
r+ Christophe
Committed on behalf of Nelson.
2006-06-15 19:26:01 +00:00
alexei.volkov.bugs%sun.com d5aa4d29c5 [Bug 337008] OOM crash [@ nssList_Add - STAN_InitTokenForSlotInfo - STAN_LoadDefaultNSS3TrustDomain][@ nssList_Clone - nssList_CreateIterator - STAN_LoadDefaultNSS3TrustDomain] Dereferencing possibly NULL "(td)->tokenList". r=nelson, sr=wtc 2006-06-13 21:36:29 +00:00
wtchang%redhat.com 82930ed07a Bugzilla Bug 341111: added a dummy reference to the SCCS and RCS version
strings so that they won't be optimized away. r=nelsonb.
2006-06-13 17:48:03 +00:00
alexei.volkov.bugs%sun.com 51b89f627d [Bug 337110] OOM Crash [@ PK11_CreatePBEParams]. r=nelson 2006-06-13 17:33:06 +00:00
alexei.volkov.bugs%sun.com 4fe5c22675 [Bug 337099] Crash [@ PK11_ParamFromIV] Variable "iv" tracked as NULL
was dereferenced. r=nelson
2006-06-12 21:16:49 +00:00
alexei.volkov.bugs%sun.com cc3d04b60e [Bug 339886] param leaked at NSS_CMSCipherContext_StartEncrypt(nss/lib/smime/cmscipher.c). r=nelson 2006-06-12 21:05:12 +00:00
nelson%bolyard.com 7d6b311cd3 Don't call nssCKFWToken_Destroy with NULL. Bug 340018. r=alexei.volkov 2006-06-10 22:21:10 +00:00
nelson%bolyard.com 4f4902f94e Fix leak and OOM crash. Bug 338352 and 338356. Coverity.
r=rrelyea, alexei.volkov
2006-06-10 22:13:46 +00:00
julien.pierre.bugs%sun.com e9a0aa7867 Fix for bug 340917 - crlutil should init NSS read-only for list option. r=alexei.volkov 2006-06-09 21:55:11 +00:00
kaie%kuix.de 969191a00e Bug 340183, Add the Netlock Class QA root certificate
Approval for adding CA cert granted by Frank Hecker in bug 313942
Patch by Wan-Teh Chang, r=me
2006-06-09 21:02:16 +00:00
nelson%bolyard.com 5337c5aee0 Fix broken build. 2006-06-09 18:12:50 +00:00
nelson%bolyard.com bae0b415d1 Fix leaks in CERT_DistNamesFromNicknames (bug 339916) and in
CERT_GetCertNicknames (bug 339919). Coverity bugs. r=alexei.volkov
2006-06-09 01:24:39 +00:00
julien.pierre.bugs%sun.com 29a3a59542 Fix for bug 340909 . Add batch command to usage. r=nelson 2006-06-09 01:24:23 +00:00
nelson%bolyard.com 5498c37db3 Fix leak in NSS_CMSEncoder_Start error path. Bug 339914. r=alexei.volkov 2006-06-08 22:01:02 +00:00
nelson%bolyard.com 4c913b0390 Fix leak in sec_asn1d_add_to_subitems. Bug 339913. r=alexei.volkov 2006-06-08 21:40:31 +00:00
glen.beasley%sun.com acfa788133 340734 update ref to 140-1 to 140 r=neilWilliams 2006-06-08 18:19:09 +00:00
nelson%bolyard.com 5b368c8808 Remove dead code. Coverity 506. r=nelson,wtchang. Bug 337027.
Patch by Jon Smirl <jonsmirl@yahoo.com>
2006-06-07 18:36:26 +00:00
nelson%bolyard.com 995213d2df Fix bug 337104 and bug 337105. Don't crash if we run out of memory
in ssl2_ConstructCipherSpecs().  r=Alexei.Volkov  Coverity 442 & 443.
2006-06-07 17:53:19 +00:00
julien.pierre.bugs%sun.com 172c1bdf45 Fix for bug 326637 . Unnecessary request of PKCS11 device password. r=rrelyea 2006-06-07 02:30:27 +00:00
julien.pierre.bugs%sun.com e602259ec8 Fix for bug 340040 - add certutil option to verify an OCSP responder cert. r=nelson 2006-06-06 01:06:23 +00:00
alexei.volkov.bugs%sun.com e70d27d7ba [Bug 339908] 3 NULL ptr crashes when PK11_GetBestSlot returns NULL. r=nelson 2006-06-02 20:34:04 +00:00
wtchang%redhat.com 41c9c343c1 Import NSPR 4.6.2. 2006-06-02 05:18:01 +00:00
wtchang%redhat.com cdd64c7beb Bugzilla bug 338599: added new function SECKEY_SignatureLen and use it
instead of SECKEY_PublicKeyStrength to get ECDSA signature lengths.
Removed the 'type' member from the VFYContextStr structure because that
info is in the 'key->keyType' field.  Set error codes when functions
fail (return 0). r=nelsonb.
Modified Files:
	cryptohi/keyhi.h cryptohi/seckey.c cryptohi/secvfy.c
	nss/nss.def ssl/ssl3con.c
2006-05-31 23:54:52 +00:00
alexei.volkov.bugs%sun.com 72df55c274 [Bug 220380] Add SSL client auth stress tests.
Attachment "auth patch"(#222740). r=nelson
2006-05-31 18:06:02 +00:00
wtchang%redhat.com a07f869b7a Bugzilla Bug 338552: added StartCom CA certificate to NSS. The patch is
contributed by  Eddy Nigg, StartCom Ltd. <eddy_nigg@startcom.org>. r=wtc.
a=hecker.
Modified Files: certdata.c certdata.txt nssckbi.h
2006-05-31 17:18:54 +00:00
julien.pierre.bugs%sun.com ba7825ee28 Fix for bug 336477 . Fix for CERT_UncacheCRL error checking. r=nelson 2006-05-31 01:57:55 +00:00
alexei.volkov.bugs%sun.com 47817668ff [Bug 337014] OOM crash [@ PORT_ArenaAlloc - PK11_PQG_ParamGenSeedLen][@ PORT_ArenaAlloc - PK11_PQG_ParamGenSeedLen] Dereferencing possibly NULL "varena". r=nelson 2006-05-22 23:08:04 +00:00
alexei.volkov.bugs%sun.com 3aa52be061 [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c) [Attachment 222949]. r=nelson 2006-05-22 22:38:56 +00:00
wtchang%redhat.com 3533f0c590 Bugzilla Bug 320336: improved the comments for SECITEM_AllocItem in
secitem.h.  Made SECITEM_AllocItem fail (return NULL) if the allocation of
the buffer fails, as documented. r=nelsonb.
Modified files: secitem.c secitem.h
2006-05-22 22:24:34 +00:00
wtchang%redhat.com 68708d13f4 Bugzilla Bug 298520: moved the RSA maximum size macros from rsa.c to
blapit.h.  Removed an out-of-date comment from blapit.h. r=nelsonb.
Modified files: blapit.h rsa.c
2006-05-22 22:10:40 +00:00
wtchang%redhat.com 06496e21ff Bugzilla Bug 298520: added a comment explain the meaning of the MAX_KEY_LEN
macro. r=nelsonb.
2006-05-22 22:08:40 +00:00
alexei.volkov.bugs%sun.com 7cd142bd9c [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c). r=nelson 2006-05-22 21:46:14 +00:00
wtchang%redhat.com a0ac292413 Bug 236613: change to MPL/LGPL/GPL tri-license. 2006-05-21 21:02:26 +00:00
alexei.volkov.bugs%sun.com 538a18fde0 [Bug 220380] Add SSL client auth stress tests. Attachment #4. r=julien 2006-05-20 18:32:08 +00:00
nelson%bolyard.com 43d0a92ac7 Promote the use of curve secp192r1 for client auth, since it is faster
than most.  Bug 332350.  r=rrelyea.
2006-05-19 03:59:06 +00:00
nelson%bolyard.com 505671ed77 Eliminate a crash and plug a leak in the error path for function
nssSMIMEProfile_Create. Coverity bug 337101. r=alexei.volkov.
2006-05-18 23:29:19 +00:00
nelson%bolyard.com 1eb10c802e Avoid crash if "item" pointer is NULL. Coverity bug 333555.
r=wtchang,alexei.volkov
2006-05-18 21:20:04 +00:00
alexei.volkov.bugs%sun.com e05b17bc20 [Bug 337008] OOM crash [@ nssList_Add - STAN_InitTokenForSlotInfo - STAN_LoadDefaultNSS3TrustDomain][@ nssList_Clone - nssList_CreateIterator - STAN_LoadDefaultNSS3TrustDomain] Dereferencing possibly NULL "(td)->tokenList". r=nelson, sr=wtc 2006-05-18 21:00:58 +00:00
alexei.volkov.bugs%sun.com b0a8ac4918 [Bug 337010] OOM crash [@ NSC_DigestKey] Dereferencing possibly NULL "att". r=ne
lson,wtc
2006-05-18 20:52:50 +00:00
nelson%bolyard.com 08e023d910 Plug leak. Free cache. Coverity bug 338201. r=alexei.volkov 2006-05-18 20:46:19 +00:00
nelson%bolyard.com 5c56ef5776 Fix several Coverity bugs. Bug 336982. NULL ptr check after ptr deref'ed.
Bug 337080.  Dead code.  r=alexei.volkov
2006-05-18 20:39:19 +00:00
nelson%bolyard.com 88c4f3a0b3 Remove dead old FORTEZZA KEA code. Coverity bug 337098. r=rrelyea,wtchang 2006-05-18 20:24:23 +00:00
alexei.volkov.bugs%sun.com 538630b067 [Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. (second patch) r=nelson 2006-05-18 20:21:12 +00:00
nelson%bolyard.com a1423c99e4 Don't dereference a NULL secmodprefix argument. Coverity Bug 336981.
r=alexei.volkov
2006-05-18 19:44:24 +00:00
nelson%bolyard.com 780c599d61 In SEC_PKCS12DecoderGetCerts, don't dereference p12dcx until AFTER it has
been checked for NULL. Coverity bug 336971. r=alexei.volkov
2006-05-18 19:38:59 +00:00
nelson%bolyard.com 0a6525e406 Add 3 assertions to satisfy coverity that tmpt is never NULL in these
places.  Bug 336995. r=akexei.volkov,wtchang
2006-05-18 19:32:44 +00:00
nelson%bolyard.com 68f51af5fe Plug leak. Free "info" in error path. Coverity bug 336475.
r=wtchang,alexei.volkov
2006-05-18 04:35:32 +00:00
nelson%bolyard.com 9dc19d4fe0 Correct the amount returned by ssl_Writev for short writes on non-blocking
sockets.  Bug 338325. patch by Chris Newman <chris.newman@sun.com>
r=nelson
2006-05-18 01:10:21 +00:00
wtchang%redhat.com 5e3f18a4c6 Bugzilla bug 338367: check that the array index params->name is within
bounds before taking an element from the ecCurve_map array.
r=doublas.stebila.
2006-05-17 23:58:18 +00:00
julien.pierre.bugs%sun.com 6f65f3a2dd Fix for bug 222300. r=nelson,wtchang 2006-05-17 22:20:08 +00:00
alexei.volkov.bugs%sun.com e58e3e05ba [Bug 337011] OOM crash [@ sftk_handleKeyObject][@ sftk_handleKeyParameterObject] Dereferencing possibly NULL "attribute". r=nelson 2006-05-17 20:52:16 +00:00
alexei.volkov.bugs%sun.com 5713a8afaf [Bug 337326] Leak in nsslowcert_UpdateSubjectEmailAddr (security/nss/lib/softoken/pcertdb.c). r=nelson 2006-05-17 20:46:47 +00:00
alexei.volkov.bugs%sun.com e1b759198c [Bug 337009] OOM crash [@ nssList_Count - nssTrustDomain_GetCertsFromCache] Dereferencing possibly NULL "certList". r=nelson 2006-05-17 20:38:59 +00:00
alexei.volkov.bugs%sun.com ef6e49c6b2 [Bug 337332] Leak in OpenNewDB (security/nss/lib/softoken/keydb.c). r=nelson 2006-05-17 17:56:32 +00:00
alexei.volkov.bugs%sun.com 4fe8d81c2b [Bug 336485] coverity thinks that nssPKIObject_GetInstances could return null which would lead to a crash [@ listCertsCallback]. r=nelson 2006-05-16 23:47:43 +00:00
julien.pierre.bugs%sun.com b0d4b44133 Fix for bug 335036. certutil tries to shutdown NSS even if it didn't initialize . r=wtchang, nelson 2006-05-16 02:16:25 +00:00
wtchang%redhat.com 844f45261e Bugzilla Bug 337025: removed more unused or trivially used variables.
r=alexei.volkov,nelson.bolyard.
2006-05-16 01:57:04 +00:00
wtchang%redhat.com 942eb77419 Bug 305835: Remove NSS_ENABLE_ECC ifdefs in libssl. r=wtc,nelsonb 2006-05-16 01:14:43 +00:00
wtchang%redhat.com 49a4fc689f Bugzilla Bug 298506: a first cut at Solaris auditing. The patch is
contributed by Glen Beasley of Sun. r=wtc.
Modified Files:
	cmd/platlibs.mk lib/softoken/config.mk lib/softoken/fipstokn.c
2006-05-16 01:04:05 +00:00
julien.pierre.bugs%sun.com 42f2f41bff Fix for bug 335036 . NSS_Shutdown() does not check that NSS is initialized. r=nelson, alexei 2006-05-16 00:10:04 +00:00
julien.pierre.bugs%sun.com 5ea61ffe76 Fix for bug 337789 . PK11_FindKeyByAnyCert doe snot work if softoken is in FIPS140-2 mode. r=wtchang, rrelyea, nelson 2006-05-15 23:51:01 +00:00
alexei.volkov.bugs%sun.com 6b1e6d3bf2 [Bug 336482] crash or hopefully deadcode [@ crmf_copy_poposigningkey]
because Pointer "destPopoSignKey" dereferenced before NULL check. r=nelson
2006-05-15 21:05:13 +00:00
alexei.volkov.bugs%sun.com 5940997e85 Patch contributed by jonsmirl@yahoo.com
[Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. r=wtchang
2006-05-15 20:58:10 +00:00
alexei.volkov.bugs%sun.com 968bb1125f Patch contributed by jonsmirl@yahoo.com
[Bug 337086] Coverity 446, dead code in mozilla/security/nss/lib/certhigh/ocsp.c. r=wtchang
2006-05-15 20:52:01 +00:00
alexei.volkov.bugs%sun.com 7b49a9fc5a Patch contributed by jonsmirl@yahoo.com
[Bug 337085] Coverity 447, dead code in mozilla/security/nss/lib/certhigh/ocsp.c
. r=wtchang
2006-05-15 20:44:46 +00:00
alexei.volkov.bugs%sun.com 02307faea5 Patch contributed by timeless@bemail.org
[Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c. r=nelson
2006-05-15 20:39:38 +00:00
alexei.volkov.bugs%sun.com b2eede4173 Patch contributed by timeless@bemail.org
[Bug 336992] crash [@ pk11_DoKeys] "arg" Pointer dereferenced before NULL check. r=nelson
2006-05-13 00:46:51 +00:00
alexei.volkov.bugs%sun.com 39db992bd1 Patch contributed by timeless@bemail.org
[Bug 336972] OOM crash [@ PK11_ImportDERPrivateKeyInfoAndReturnKey] "pki" Pointer allocated by PORT_NewArena dereferenced without NULL check. r=nelson
2006-05-13 00:41:16 +00:00
alexei.volkov.bugs%sun.com 4176224c5b Patch contributed by timeless@bemail.org
[Bug 336466] oom crash [@ CERT_DecodeAuthKeyID]. r=nelson
2006-05-13 00:33:09 +00:00
alexei.volkov.bugs%sun.com 0d612a798a Patch contributed by jonsmirl@yahoo.com
[Bug 336935] Coverity 172, dead code in mozilla/security/nss/lib/softoken/keydb.c. r=nelson, r=alexei.volkov.bugs
2006-05-13 00:27:22 +00:00
julien.pierre.bugs%sun.com a172cbe397 Fix for bug 336477. Memory leak in CERT_UncacheCRL . r=nelson 2006-05-13 00:27:12 +00:00
alexei.volkov.bugs%sun.com d76295c913 Patch contributed by jonsmirl@yahoo.com
[Bug 336932] Coverity 163, dead code in mozilla/security/nss/lib/ssl/ssl3con.c. r=nelson
2006-05-13 00:15:43 +00:00
alexei.volkov.bugs%sun.com 73626f65a8 Patch contributed by timeless@bemail.org
[Bug 336481] oom crash [@ crmf_copy_cert_req_msg]
2006-05-13 00:03:12 +00:00
nelson%bolyard.com 28a533ac47 Bug 337093. Remove dead code at label loser in function dbs_readBlob
Patch by Jon Smirl <jonsmirl@yahoo.com>, r=wtchang.  Coverity bug
2006-05-12 23:37:58 +00:00
wtchang%redhat.com 2a00f3c4d2 Bugzilla Bug 336521: we should search the build tree (${DIST}/${OBJDIR})
before /bin and /usr/bin. r=slavomir.katuscak
2006-05-12 20:50:53 +00:00
wtchang%redhat.com 68093029ef Bugzilla Bug 336934: removed ununsed variable ck_id. The patch is
contributed by Jon Smirl <jonsmirl@yahoo.com>. r=nelsonb,wtc.
2006-05-12 20:42:13 +00:00
wtchang%redhat.com 4e43ea1d0a Bugzilla Bug 336937: removed a test that is guaranteed to be true. The
patch is contributed by Jon Smirl <jonsmirl@yahoo.com>. r=nelsonb,wtc.
2006-05-12 20:33:47 +00:00
wtchang%redhat.com cddae0bdc9 Bugzilla bug 336938: removed a test that is guaranteed to be false. The
patch is contributed by Jon Smirl <jonsmirl@yahoo.com>. r=wtc.
2006-05-12 16:49:07 +00:00
wtchang%redhat.com 321cb8386e Bugzilla Bug 298506: Do not log the token name (so the declaration of
sftk_getDefTokName in pkcs11i.h and the previous change to sftk_SlotFromID
weren't necessary). Use Linux's audit subsystem if available. r=relyea.
Modified files: fipstokn.c pkcs11.c pkcs11i.h
2006-05-10 21:33:11 +00:00
wtchang%redhat.com 90e7d73574 Bugzilla Bug 298522: implemented ECDSA power-up self-test. The patch was
written by Glen Beasley of Sun. r=wtc.
2006-05-08 18:20:28 +00:00
wtchang%redhat.com 16146af129 Bugzilla Bug 333925: added a comment to paraphrase an obscure if statement. 2006-05-05 23:54:05 +00:00
wtchang%redhat.com 580b97817e Bugzilla Bug 333925: worked around AES test failures of code compiled by
Forte 6 update 2 by using the old optimization flags used in NSS 3.10.
r=relyea.
2006-05-05 23:39:29 +00:00
wtchang%redhat.com 836e0c0b9c Bugzilla Bug 334679: removed a duplicate line in ec_GF2m_validate_point.
r=douglas.stebila.
2006-05-05 23:08:50 +00:00
wtchang%redhat.com 798e8d1bc1 Added/removed blank lines to eliminate the diffs between the trunk and the
NSS_3_11_BRANCH.
Modified files: pkcs11.c pkcs11c.c
2006-05-05 20:31:30 +00:00
wtchang%redhat.com 01891a9574 Bugzilla Bug 298506: implemented FIPS 140-2 Security Level 2 audit
requirements. r=glen.beasley.
Modified Files:
	fipstokn.c pkcs11.c pkcs11c.c pkcs11i.h softoken.h softoknt.h
2006-05-05 20:02:47 +00:00
julien.pierre.bugs%sun.com ba58910b9e Fix for bug 336335 . Plug leak of a temporary bignum in modular exponentiation . r=wtchang 2006-05-05 01:22:59 +00:00
julien.pierre.bugs%sun.com 1964aace2e Fix for bug 336335 - memory leaks in ECC code. r=wtchang 2006-05-04 01:05:04 +00:00
julien.pierre.bugs%sun.com 7015af0983 Fix for bug 219932 . NISCC test script enhancements. Patch submitted by Jason Reid (jason.m.reid@sun.com) . r=slavomir.katuscak@sun.com,julien.pierre@sun.com 2006-05-01 22:52:32 +00:00
julien.pierre.bugs%sun.com d15ad02799 Fix for bug 335021. Add SEC_ASN1_CONSTRUCTED to S/MIME EKP template. r=relyea 2006-04-29 00:18:42 +00:00
rrelyea%redhat.com 5f24a2a77c Attachment #215739: Use SSE2 multiply instructions on intel processors. for bug #326482
r=nelson r=wtc
2006-04-28 17:06:22 +00:00
christophe.ravel.bugs%sun.com a8e64c65ca [Bug 334843] Add rpath for HP-UX on pa-risc
r+ neil.williams.
2006-04-27 23:36:20 +00:00
alexei.volkov.bugs%sun.com 143f21193c [Bug 334274] double free in CRMF_EncryptedKeyGetEncryptedValue. r=nelson 2006-04-27 22:09:28 +00:00
alexei.volkov.bugs%sun.com f5f5d893ff [Bug 334326] DecodeV4DBCertEntry: Variable "(entry)->nickname" tracked as NULL was passed to a function that dereferences it. r=rrelyea 2006-04-27 18:35:24 +00:00
alexei.volkov.bugs%sun.com 20919d892f [Bug 334454] Variable "(key)->pkcs11Slot" tracked as NULL was passed to a function that dereferences it. [@ SECKEY_CopyPrivateKey - SSL_ConfigSecureServer]. r=nelson 2006-04-26 19:40:56 +00:00
alexei.volkov.bugs%sun.com 49cb46e26c [Bug 333389] sftk_NewAttribute should not crash when so is NULL [@ sftk_NewAttribute]. r=nelson 2006-04-26 19:18:00 +00:00
alexei.volkov.bugs%sun.com c353bf9e7b [Bug 334522] pk12util crash in SEC_PKCS12DecoderValidateBags. r=nelson 2006-04-26 06:47:30 +00:00
nelson%bolyard.com b9c189458d Disable AMD64 assembly optimizations. Bug 334057. r=nelson 2006-04-25 05:51:23 +00:00
nelson%bolyard.com 249561bf3b Bug 294537: ssltap should display ASCII CA names from cert request message
r=alexei.volkov
2006-04-25 04:58:45 +00:00
nelson%bolyard.com f02321e973 Backout the last change, undoing the fix for bug 320336 and bug 333405. 2006-04-25 04:39:24 +00:00
alexei.volkov.bugs%sun.com 7fc553fcf8 [Bug 334277] double free in [@ sftk_FreeAttribute - sftk_DeleteAttributeType]. r=relyea 2006-04-25 02:33:58 +00:00
alexei.volkov.bugs%sun.com 97c78b7911 [Bug 334276] double free in [@ SECKEY_CopyPublicKey]. r=nelson 2006-04-25 02:23:52 +00:00
wtchang%redhat.com 085b36691e Bugzilla Bug 320336: SECITEM_AllocItem should return a NULL pointer if the
allocation of its 'data' buffer fails. r=nelson.  This checkin fixed bug
333405 as a byproduct.
Modified files: secitem.c secitem.h
2006-04-24 22:50:13 +00:00
nelson%bolyard.com dbe80e7489 Remove call to printf in ecl/ecp_224.c Bug 334448. r=wtchang 2006-04-24 21:27:38 +00:00
nelson%bolyard.com dafe77ce6c Display TLS hello extensions and alerts. Display ECC cipher suites.
Bug 333600 and bug 334314. r=Alexei.Volkov
2006-04-24 06:11:41 +00:00
nelson%bolyard.com 1930ea6074 Put nss.def file sections in numeric order, and alphabetical order
within sections.
2006-04-24 05:08:04 +00:00
nelson%bolyard.com 0c05899fa2 Bug 323350. sr=rrelyea. This patch makes 3 changes:
1) it adds a new ifdef which enables SSL to limit itself to the 3 Suite B
   curves.
2) it corrects the creation and parsing of the Supported Curve extension to
   conform with the lastest definition, by using 2 bytes to encode the list
   length,
3) it changes the algorithm that picks the curve for ECDHE to choose a curve
   that is at least as strong as the "weakest link", is mutually supported
   by client and server, and is the fastest for its size.
2006-04-23 00:17:18 +00:00
julien.pierre.bugs%sun.com ff004c3373 Fix for bug 335039. Declare nssCKFWCRyptoOperation_UpdateCombo. r=wtchang 2006-04-22 05:30:18 +00:00
julien.pierre.bugs%sun.com 0a709d0578 Fix red tree on Windows. 2006-04-22 05:18:20 +00:00
alexei.volkov.bugs%sun.com fc87dbb2fe [Bug 334183] Double free on error because CERT_FindCertIssuer unexpectedly calls CERT_DestroyCertificate. r=alexei 2006-04-22 02:09:09 +00:00
julien.pierre.bugs%sun.com 1d134e6b56 Fix for bug 331413 . replace signal with sigaction; fix logging. r=wtchang 2006-04-22 01:28:14 +00:00
alexei.volkov.bugs%sun.com 76a9749ba0 Patch contributed by timeless@bemail.org
[Bug 334449] oom Crash in crmf_template_copy_secalg. r=nelson
2006-04-22 01:25:57 +00:00
alexei.volkov.bugs%sun.com d4f39e6449 Patch contributed by timeless@bemail.org
[Bug 334436] nsslowcert_UpdateSubjectEmailAddr doesn't consistently use emailAddrs as a guard of nemailAddrs guarding emailAddrs[0]. r=nelson
2006-04-22 01:19:41 +00:00
alexei.volkov.bugs%sun.com aea5eb0f12 Patch contributed by timeless@bemail.org
[Bug 334328] nsspkcs5_PKCS12PBE: Variable "A" tracked as NULL was dereferenced. r=nelson
2006-04-22 01:13:15 +00:00
alexei.volkov.bugs%sun.com 86494ef39a [Bug 334275] double free in [@ PK11_ListPublicKeysInSlot]. r=nelson 2006-04-22 01:08:17 +00:00
alexei.volkov.bugs%sun.com 9c061b607a [Bug 334273] double free in SECKEY_DecodeDERSubjectPublicKeyInfo. r=nelson 2006-04-22 01:03:18 +00:00
alexei.volkov.bugs%sun.com 5f88dfbdaa [Bug 334240] double free in nsslowkey_ConvertToPublicKey if SECITEM_CopyItem or SECITEM_CopyItem fail. r=nelson 2006-04-22 00:59:13 +00:00
alexei.volkov.bugs%sun.com 8feb62dbd0 [Bug 334236] double free in PK11_ListPrivKeysInSlot if keys allocation fails. r=nelson 2006-04-22 00:55:29 +00:00
wtchang%redhat.com e8b0114d09 Bugzilla Bug 333932: fixed Solaris SPARC GCC build failures.
r=christophe.ravel
2006-04-22 00:13:29 +00:00
alexei.volkov.bugs%sun.com 5f22914b4a [Bug 334234] PK11_NewSlotInfo returns freed objects if lock allocations fail. r=nelson 2006-04-21 23:29:37 +00:00
wtchang%redhat.com 6f1bd4dc40 Bugzilla Bug 334533: in getPQseed we always set the most significant bit of
SEED to 1 to make NIST CMVP's PQG parameter validation tool happy. In
PQG_ParamGenSeedLen we require the length of SEED be at least 20 bytes.
r=nelson.
2006-04-21 17:48:30 +00:00
wtchang%redhat.com 37a7e6c417 Bugzilla Bug 298522: changed RSA modulus size to 1024 bits and added known
answer tests for RSA SHA1, SHA256, SHA384, and SHA512 signatures.  The
patch is written by Glen Beasley. r=wtc.
2006-04-21 17:13:50 +00:00
wtchang%redhat.com d0604ba735 Bugzilla Bug 236245: Use a stack buffer for ec_params.data in
ssl3_SendECDHServerKeyExchange. r=nelson.
2006-04-21 16:19:48 +00:00
wtchang%redhat.com 333657e660 Bugzilla Bug 334553: fixed the comments because mp_digit is actually 64-bit
(unsigned long or unsigned long long). r=nelson.
2006-04-21 16:13:02 +00:00
rrelyea%redhat.com 5cd56974be Performance tests for ec curves. Test's freebl and pkcs11 interfaces. 2006-04-21 01:40:48 +00:00
wtchang%redhat.com 432ccc0173 Bugzilla Bug 326754: checked the change back in. We failed the NIST DSA
PQGGen test for some other reason (bug 334533).
2006-04-20 21:55:24 +00:00
nelson%bolyard.com fe04651c77 Bug 80092: SSL write indicates all data sent when some is buffered.
SSL now follows NSPR socket semantics and never returns a short write
count on a blocking socket.  On a blocking socket, it returns either
the full count or -1 (with an error code set).
For non-blocking sockets, SSL no longer returns a full write count
when some of the data remains buffered in the SSL record layer.
Instead it returns a number is that always at least 1 byte short of a
full write count, so that the caller will  keep retrying until it is done.
SSL makes sure that the first byte sent by the caller in the retry
matches the last byte previously buffered.  r=rrelyea.
Modified Files: ssl3con.c sslcon.c ssldef.c sslimpl.h sslsecur.c
2006-04-20 08:46:34 +00:00
nelson%bolyard.com 43a7c5e950 Fix buffer overflow regression. Bug 236245. sr=wtchang 2006-04-20 06:57:54 +00:00
alexei.volkov.bugs%sun.com b67f75bc05 Patch contributed by timeless@bemail.org
[Bug 334459] Variable "cipherName" tracked as NULL was passed to a
 function that dereferences it. [@ PORT_Strdup - SSL_SecurityStatus]. r=nelson
2006-04-20 00:20:45 +00:00
alexei.volkov.bugs%sun.com 0f639ba66a Patch contributed by timeless@bemail.org
[Bug 334446] oom Crash in nssCKFWFindObjects_Create. r=nelson
2006-04-20 00:03:33 +00:00
alexei.volkov.bugs%sun.com 60674bc568 Patch contributed by timeless@bemail.org
[Bug 334443] oom Crash in nssCKFWSession_Create. r=nelson
2006-04-19 23:50:43 +00:00
alexei.volkov.bugs%sun.com 3a8f586a3c Patch contributed by timeless@bemail.org
[Bug 334438] oom Crash in ReadDBCertEntry. r=nelson
2006-04-19 23:43:10 +00:00
alexei.volkov.bugs%sun.com ff6fa1f51c Patch contributed by timeless@bemail.org
[Bug 334442] Incorrect use of realloc oom Crash in secmod_ReadPermDB;r=nelson
2006-04-19 22:53:45 +00:00
alexei.volkov.bugs%sun.com c501854878 Patch contributed by nelson@bolyard.com.
[Bug 334327] pk11_CreateNewContextInSlot: Variable "(context)->key" tracked as NULL was passed to a function that dereferences it. r=alexei
2006-04-19 22:32:30 +00:00
wtchang%redhat.com fcca57e69e Bugzilla bug 334553: use the ULL suffix with unsigned long long constants.
r=douglas.stebila.
Modified files: ecl/ecp_256.c mpi/mp_gf2m.c
2006-04-19 22:19:09 +00:00
wtchang%redhat.com 2c62bf1d13 Bugzilla bug 334683: removed extraneous semicolons. r=alexei.volkov.
Modified files: cmd/certutil/certutil.c lib/pki/pkistore.h
2006-04-19 19:04:23 +00:00
julien.pierre.bugs%sun.com b41066e368 Fix for bug 331413. Don't set SO_LINGER in the Win95 build to workaround NSPR bug 332348. r=wtchang 2006-04-18 22:56:44 +00:00
wtchang%redhat.com 0a3bf353d3 Bugzilla Bug 333917: the non-x86 code in at least the DES_CBCEn and
DES_EDE3CBCEn functions violates ANSI C's aliasing rules.  So we compile
this file with strict aliasing rules turned off. r=nelsonb.
2006-04-18 17:33:56 +00:00
nelson%bolyard.com fa09229848 Don't add 3 to the user-supplied number of validity months. Bug 333679.
r=neil.williams
2006-04-15 01:00:11 +00:00
julien.pierre.bugs%sun.com 8eb43e8ec2 Fix for bug 262375 . Add clobber_dbm and clobber_nspr targets, as well as nss_clean_all . r=nelson 2006-04-14 22:48:31 +00:00
nelson%bolyard.com b39425fcfa big cleanup of error codes returned by pkcs12 library.
No longer returns SEC_ERROR_NO_MEMORY for every possible error code.
Bug 321584. r=neil.williams
2006-04-14 18:34:44 +00:00
nelson%bolyard.com efdb126901 Fix broken optimized builds, caused by last checkin. Bug 236245. 2006-04-14 00:43:19 +00:00
nelson%bolyard.com c4fb4fa280 Implement TLS Hello extensions for ECC. Bug 236245. r=rrelyea.
This patch has a known problem, choosing ephemeral ECDH curves
according to the wrong (suboptimal, non-FIPS) criteria.
Modified Files: ssl3con.c ssl3ecc.c sslimpl.h
2006-04-13 23:08:18 +00:00
nelson%bolyard.com 1cfdf61890 Add and use new -2 option for strsclnt to disable SSL2 compatible client
hellos, so we can stress test TLS hello extensions.  Bug 333559.
r=julien.pierre,rrelyea
2006-04-13 22:43:31 +00:00
wtchang%redhat.com b95ecf558f Bugzilla Bug 330114: corrected the checks for the PKCS #1 v1.5 padding
string and the length of the data (hash). r=nelsonb,relyea.
2006-04-13 22:12:17 +00:00
julien.pierre.bugs%sun.com 6493a984f5 Fix for 333657 . Increase maximum RSA key size to 8192 bits in freebl. r=nelson 2006-04-12 05:37:52 +00:00