Граф коммитов

6245 Коммитов

Автор SHA1 Сообщение Дата
Sylvestre Ledru 9bce072e44 Bug 1588458 - Replace dxr by searchfox in the rst doc r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D49140
2020-10-08 08:13:15 +00:00
Ryan Kelly b358fe8424 Bug 1647588 - Derive AET ecosystemUserId from kB when the user signs in. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D92319
2020-10-08 02:45:00 +00:00
Razvan Maries 8d6fc2c1ec Backed out changeset f0cbfb83a48e (bug 1647588) for perma failures on test_accounts.js. CLOSED TREE 2020-10-07 09:31:25 +03:00
Ryan Kelly f49b2a8af3 Bug 1647588 - Derive AET ecosystemUserId from kB when the user signs in. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D92319
2020-10-07 02:09:02 +00:00
ffxbld 4acd881913 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=jcristau
Differential Revision: https://phabricator.services.mozilla.com/D92502
2020-10-06 10:21:24 +00:00
Mark Hammond 18d1af1eb5 Bug 1449730 - remove the legacy bookmarks sync engine. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D89083
2020-10-06 01:02:50 +00:00
Mark Hammond c40f795f98 Bug 1662319 - remove the sync 'repairer' concept. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D88935
2020-10-05 00:26:12 +00:00
Tim Giles a0ab1f9aba Bug 1134852 - Update password manager recipes from Remote Settings. r=sfoster,leplatrem,geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D89821
2020-10-02 19:45:03 +00:00
ffxbld 98819106f1 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D92065
2020-10-01 14:37:46 +00:00
Ryan Kelly 08d2c540ec Bug 1661407 - refactor FxA key handling to use "scoped keys". r=markh
Differential Revision: https://phabricator.services.mozilla.com/D90361
2020-10-01 10:06:24 +00:00
ffxbld 0b15308f5d No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D91282
2020-09-24 14:23:18 +00:00
ffxbld 40f2c8cc60 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D90947
2020-09-22 02:55:14 +00:00
Mozilla Releng Treescript 5aa7b6ef9e Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-09-21 14:12:25 +00:00
Sylvestre Ledru fd8b54c40d Bug 1617369 - Reformat recent rust changes with rustfmt r=emilio,necko-reviewers,valentin
# ignore-this-changeset

Depends on D90793

Differential Revision: https://phabricator.services.mozilla.com/D90794
2020-09-20 16:09:26 +00:00
ffxbld 3768ca343e No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D90609
2020-09-17 20:20:07 +00:00
Chris Peterson 68133a2ff8 Bug 1665270 - Replace MOZ_MUST_USE with [[nodiscard]] in IdentityCryptoService. r=keeler
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Depends on D90350

Differential Revision: https://phabricator.services.mozilla.com/D90351
2020-09-16 23:32:01 +00:00
Nan Jiang abe6d1a340 No bug - Delete the onboarding dump as the collection is already retired on RemoteSettings r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D90412
2020-09-16 16:16:37 +00:00
Alexis Beingessner e5dd298d13 Bug 1654807 - update thin-vec to 0.2.1 for potential endianess fix. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D87019
2020-09-14 17:32:40 +00:00
ffxbld 651ca4559b No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D90123
2020-09-14 15:48:22 +00:00
Gijs Kruitbosch 97c97bc82f Bug 1660557 - stop using js_modules to pack builtin and default themes, r=glandium,zombie
This is ultimately less build magic and makes for more meaningful URIs.

This patch paves the way for the second patch in this stack which fixes bug 1655456.

Differential Revision: https://phabricator.services.mozilla.com/D89130
2020-09-11 15:26:24 +00:00
Emilio Cobos Álvarez 98deb161a2 Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=eoger,lina
This prevents us from building with rust beta/nightly.

This is technically a Rust regression, see
https://github.com/rust-lang/rust/issues/76480, though I think that this
should've never worked.

Differential Revision: https://phabricator.services.mozilla.com/D89466
2020-09-08 17:00:08 +00:00
Narcis Beleuzu f820324a61 Backed out changeset 6d73f925b6cf (bug 1663677) for bustages on bridge.rs . CLOSED TREE 2020-09-08 19:01:23 +03:00
Emilio Cobos Álvarez c40d948391 Bug 1663677 - Fix macro hygiene usage in fxaccounts/rust-bridge. r=lina
This prevents us from building with rust beta/nightly.

This is technically a Rust regression, see
https://github.com/rust-lang/rust/issues/76480, though I think that this
should've never worked.

Differential Revision: https://phabricator.services.mozilla.com/D89466
2020-09-08 14:58:02 +00:00
Ryan Kelly 8d21f4598d Bug 1663541 - don't try to write `uid` to storage in `updateUserAccountData`. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D89405
2020-09-08 01:19:56 +00:00
ffxbld 7e7f470965 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D89266
2020-09-03 22:45:48 +00:00
Mark Hammond aa09f5fd42 Bug 1662930 - checked for missed commands when renewing push subscription. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D89229
2020-09-03 01:51:05 +00:00
Magnus Melin cce1abb752 Bug 1612380 - don't verify content signatures for Thunderbird. r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D88541
2020-09-02 14:22:52 +00:00
Butkovits Atila 7b340f9684 Backed out 15 changesets (bug 1612824, bug 1661234, bug 1619926, bug 1612380, bug 1559530, bug 1642990) for Xpc failures. CLOSED TREE
Backed out changeset 426d017d7e46 (bug 1642990)
Backed out changeset 84ab4021d403 (bug 1559530)
Backed out changeset 82a8305543e5 (bug 1559530)
Backed out changeset 38832c1185b8 (bug 1559530)
Backed out changeset f16918c10a6b (bug 1661234)
Backed out changeset 3a13258fbd51 (bug 1661234)
Backed out changeset abf8d8b24845 (bug 1612824)
Backed out changeset 7dfeb065a385 (bug 1619926)
Backed out changeset bc9d3e210fe7 (bug 1619926)
Backed out changeset 786164c461ae (bug 1619926)
Backed out changeset d89793e9d17d (bug 1619926)
Backed out changeset d665885bc912 (bug 1619926)
Backed out changeset 9260b6620943 (bug 1619926)
Backed out changeset af69a4896f2f (bug 1619926)
Backed out changeset b9cd6b7047b9 (bug 1612380)
2020-09-01 21:03:23 +03:00
Magnus Melin f8c4782742 Bug 1612380 - don't verify content signatures for Thunderbird. r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D88541
2020-09-01 12:51:08 +00:00
Mark Hammond 7bd59b04db Bug 1658498 - Untangle bookmark engine tests to make removal of the legacy engine easier. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D86684
2020-08-31 06:39:55 +00:00
Dão Gottwald 635d7c07a5 Bug 1661009 - Implement basic locale filtering for remote top site defaults. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88147
2020-08-25 17:08:06 +00:00
Dão Gottwald cade61bc40 Bug 1660966 - Implement basic region filtering for remote top site defaults. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88120
2020-08-25 09:27:18 +00:00
Dão Gottwald 192654d3bd Bug 1660961 - Remote Settings: Replace "keyword" string attribute with a boolean one. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88114
2020-08-25 08:29:32 +00:00
Mark Hammond b9d69d8d9b Bug 1657260 - ensure we register with a valid FxA device name. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D87837
2020-08-25 01:35:11 +00:00
Cosmin Sabou 3dbaa1483b Merge mozilla-central to autoland. CLOSED TREE 2020-08-25 01:10:32 +03:00
Mozilla Releng Treescript ccbc59dff5 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-08-24 14:18:41 +00:00
Dão Gottwald ef05580c13 Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88041
2020-08-24 20:57:53 +00:00
Mihai Alexandru Michis 03199b0c32 Backed out changeset 555de96d4f49 (bug 1653937) as requested by dao.
CLOSED TREE
2020-08-24 23:50:58 +03:00
Dão Gottwald 1800cee263 Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88041
2020-08-24 17:55:40 +00:00
ffxbld 5e4f839c65 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D87750
2020-08-20 14:26:06 +00:00
lougeniac64 16418eddeb Bug 1657463 - Allow users to delete their data when signing out r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D86065
2020-08-19 04:55:51 +00:00
ffxbld 0d60e704b5 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D86996
2020-08-13 20:33:34 +00:00
ffxbld 0d46e87486 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D86553
2020-08-10 14:20:05 +00:00
Luca Greco e4fa86648a Bug 1656947 - Vendor application-services to import fix on webext-storage component. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D86487
2020-08-10 00:32:24 +00:00
Mark Hammond 8638e3e9b8 Bug 1635659 - Refactor the "pre-account" telemetry ping into the "account-ecosystem" ping. r=chutten,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D83466
2020-08-06 15:58:56 +00:00
ffxbld 8d979b9aee No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D85756
2020-08-03 14:13:18 +00:00
Mark Hammond 5fd387b93f Bug 1656426 - ensure we re-fetch the profile after racing another client. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D85539
2020-07-31 06:53:26 +00:00
Mark Hammond 7b3c825579 Bug 1656420 - Expose a function to indicate whether the production fxa stack is in use. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D85538
2020-07-31 06:53:13 +00:00
Mark Hammond 134274f436 Bug 1656154 - Allow ensureEcosystemAnonId to use a stale cached profile. r=rfkelly
Also ensures only one `ensureEcosystemAnonId()` is in flight at once,
`getEcosystemAnonId()` no longer calls `ensureEcosystemAnonId()` and a minor
fix or 2.

Differential Revision: https://phabricator.services.mozilla.com/D85366
2020-07-30 06:59:05 +00:00
Mark Hammond cd4854dc3a Bug 1377100 - Store sync metadata in the LoginManager. r=lina,MattN
This is done so that if the login manager loses all data sync is "reset",
meaning will do a full reconcile with the server and pull all sync records
down and apply them locally - ie, sync will be ble to recover passwords for
many users.

The sync GUID is stored encrypted, so that even if the login manager data
isn't lost, but the encryption key is, it will still reset and recover.

This will also make restoring an older logins.json a little more reliable for
sync - if an old version is restored then sync should "rewind" itself to the
state it was in the backup.

Differential Revision: https://phabricator.services.mozilla.com/D82663
2020-07-28 04:19:43 +00:00
Ryan Kelly af6a329b2a Bug 1655390 - handle null profileCache in FxAccountsProfile.ensureProfile; r=markh
Differential Revision: https://phabricator.services.mozilla.com/D84952
2020-07-28 00:20:04 +00:00
Brindusan Cristian 5fd82d4d7d Merge mozilla-central to autoland on a CLOSED TREE 2020-07-27 23:34:59 +03:00
Mozilla Releng Treescript e0a22e8714 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-07-27 17:45:43 +00:00
lougeniac64 7456bd946c Bug 1635657 - synthesize placeholder ecosystemAnonId when not present on FxA server r=markh,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D84617
2020-07-27 01:46:50 +00:00
ffxbld faed2506ca No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D84699
2020-07-23 14:25:47 +00:00
Ryan Kelly fae3d55603 Bug 1635656 - add support for storing and fetching FxA ecosystem telemetry ids. r=rfkelly,markh
Differential Revision: https://phabricator.services.mozilla.com/D77762
2020-07-21 23:05:04 +00:00
Mark Banner 3bf5e466a7 Bug 1653988 - Extend the loading of dump fallback for Remote Settings to cover more indexedDB failure areas. r=leplatrem
This extends the current try/catch to cover writing of the dump to the database and reading it back again. It does not cover the verify signature section, as it is expected that it will need to be known if the signature fails.

Differential Revision: https://phabricator.services.mozilla.com/D84234
2020-07-21 08:15:48 +00:00
Doug Thayer 8f54209ef6 Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83413
2020-07-20 16:06:59 +00:00
Ryan Kelly dd1e03304e Bug 1652609 - When generating a JWE, include `kid` of the target key if known. r=m_and_m,lina:m_and_m,:lina
Differential Revision: https://phabricator.services.mozilla.com/D83426
2020-07-20 14:06:50 +00:00
Mark Banner d8bb43d7fe Bug 1651330 - Include Canonical distribution in search engine configuration. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D82764
2020-07-20 16:33:43 +00:00
ffxbld 20a3d243c6 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D84173
2020-07-20 14:26:08 +00:00
ffxbld ec8efdbd5d No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D83814
2020-07-16 17:22:56 +00:00
lougeniac64 5cdf58ff2a Bug 1639843 - Added reason field to command-received telemetry events r=markh,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D82096
2020-07-13 21:46:49 +00:00
Vlad Filippov 6da969dcd2 Bug 1652136 - Change device.name to device.id logging in send tab. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D83188
2020-07-13 01:12:12 +00:00
Kris Maglione 9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
ffxbld 70e23b89d1 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D82904
2020-07-09 14:21:42 +00:00
Mark Hammond e660db877a Bug 1642866 - include details about sending the command in the log. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D82824
2020-07-09 05:12:22 +00:00
Mark Hammond e017fd7a57 Bug 1651285 - Remove bookmarks and history sync ID and last sync duplication logic. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D82645
2020-07-08 17:58:09 +00:00
R. Martinho Fernandes fb3abbefc6 Bug 1270634 - check usages when generating WebCrypto keys r=keeler,jcj
Differential Revision: https://phabricator.services.mozilla.com/D81146
2020-07-08 16:32:19 +00:00
Mathieu Leplatre 98f5dc3ee5 Bug 1649700 - Fallback to dump data if fails to read from IndexedDB r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D81826
2020-07-07 19:37:14 +00:00
ffxbld b1db909e2e No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D82375
2020-07-06 14:28:26 +00:00
ffxbld 079e757071 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D82025
2020-07-02 14:34:09 +00:00
Simon Giesecke cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Vlad Filippov fda2fee4d0 Bug 1642556 - Write a sync log after sending a tab. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D81191
2020-06-30 14:29:11 +00:00
Csoregi Natalia c0c732c1f7 Backed out changeset 0f3b01e74838 (bug 1642556) for failures on test_errorhandler_filelog.js. CLOSED TREE 2020-06-30 07:16:34 +03:00
Ryan Kelly d0b51a1c68 Bug 1642855 - remove flowID from plaintext send-tab payload. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D80793
2020-06-24 16:37:31 +00:00
Vlad Filippov da096351d9 Bug 1642556 - Write a sync log after sending a tab. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D81191
2020-06-30 01:55:09 +00:00
Mozilla Releng Treescript f6180a922b Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-06-29 15:15:46 +00:00
lougeniac64 499048fe86 (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh
Differential Revision: https://phabricator.services.mozilla.com/D80975
2020-06-27 19:15:17 +00:00
Csoregi Natalia 5bb8a015e6 Backed out changeset 8cd7fabbe270 (bug 1635487) for multiple leaks. CLOSED TREE 2020-06-27 10:43:15 +03:00
lougeniac64 bce2c33963 (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh
Differential Revision: https://phabricator.services.mozilla.com/D80975
2020-06-27 06:26:22 +00:00
Razvan Maries eb909a6e55 Backed out changeset fec02fef5e73 (bug 1635487) for Android bustages. CLOSED TREE 2020-06-27 03:05:27 +03:00
lougeniac64 893cb93c43 (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh
Differential Revision: https://phabricator.services.mozilla.com/D80975
2020-06-26 21:19:17 +00:00
Mathieu Leplatre ceaf07c1e6 Bug 1643194 - Do not build sync results if client has no listener r=Gijs
Building the sync event data has an extra cost on large collections. This bypasses iterations or records in case the client has no listener.

Differential Revision: https://phabricator.services.mozilla.com/D81046
2020-06-26 08:56:14 +00:00
Edouard Oger 540f9c18a2 Bug 1639838 - Do not filter the devices list. , markh r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D78568
2020-06-25 02:47:14 +00:00
Mathieu Leplatre a4fabab49a Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-24 10:00:53 +00:00
Mark Hammond 362bde7c7c Bug 1647994 - ensure the sync ping always records the hashed UID if known. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D80816
2020-06-24 10:02:17 +00:00
Mark Banner 07547b40a2 Bug 1647699 - Extend test_distribution to cover Acer distribution fixes. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D80715
2020-06-24 20:26:57 +00:00
Csoregi Natalia aec20399f5 Backed out changeset a0af6d53c082 (bug 1639284) for multiple failures e.g. browser_asrouter_whatsnewpanel.js CLOSED TREE 2020-06-22 12:20:39 +03:00
Mathieu Leplatre 07af99c7f1 Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-22 08:21:40 +00:00
Mark Hammond fdf9770703 Bug 1639781 - record a new 'streamID' guid in sync-tab telemetry. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D80148
2020-06-19 02:23:58 +00:00
Mathieu Leplatre f446e2ad19 Bug 1646315 - Prevent concurrent load of JSON dump with .get() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80162
2020-06-18 09:56:46 +00:00
Cosmin Sabou 17e54eff48 Backed out changeset 7e39d1eed06b (bug 1639284) for xpcshell failures on test_blocklist_severities.js. CLOSED TREE 2020-06-18 17:29:29 +03:00
Mathieu Leplatre 986bc3704b Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-18 09:47:43 +00:00
Mark Hammond 1bb6fb83cf Bug 1644598 - record/extend telemetry about the push state of FxA devices. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D79784
2020-06-18 08:29:09 +00:00
Mihai Alexandru Michis cce0439cc1 Backed out changeset da7cbff78183 (bug 1639284) for causing failures in test_engine_selector_remote_settings.js
CLOSED TREE
2020-06-17 20:51:02 +03:00
Mathieu Leplatre a4d248daf8 Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,extension-reviewers,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-17 15:58:25 +00:00
Vlad Filippov 9aacb4c755 Bug 1645834 - Don't keep trying to send tabs if the server has rate-limited us. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D79774
2020-06-16 14:35:15 +00:00
Mark Hammond a04a30cd9c Bug 1645742 - ensure FxA has a push subscription as well as whether it has expired. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D79783
2020-06-16 05:53:45 +00:00
Vlad Filippov ee97e91066 Bug 1637163 - Redact details in WebChannel errors. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D79563
2020-06-15 15:03:59 +00:00
ffxbld ec8c8c7bde No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D79691
2020-06-15 14:33:28 +00:00
Rob Wu 206ca19c33 Bug 1645598 - Vendor application-services for fix in webext-storage r=lina
To get this fix: https://github.com/mozilla/application-services/pull/3235

Updated as follows:

```
sed -i 's/e8d7530319fa6c20d9de78d031c9398630eca3cd/61dcc364ac0d6d0816ab88a494bbf20d824b009b/g' services/fxaccounts/rust-bridge/firefox-accounts-bridge/Cargo.toml services/sync/golden_gate/Cargo.toml toolkit/components/extensions/storage/webext_storage_bridge/Cargo.toml toolkit/components/glean/Cargo.toml toolkit/library/rust/shared/Cargo.toml
./mach vendor rust
```

Verified by running the new regression test that I added in the bug:

```
./mach test toolkit/components/extensions/test/xpcshell/test_ext_storage_{local,sync,sync_kinto}.js
```

Differential Revision: https://phabricator.services.mozilla.com/D79628
2020-06-15 12:56:58 +00:00
Mark Hammond 0278934973 Bug 1645729 - avoid printing a warning to the console about a log level's preference. r=rfkelly
Specifically:
> Log warning: The log 'Services.Common.RESTRequest' is configured to use the preference 'services.common.log.logger.rest.request' - you must adjust the level by setting this preference, not by using the level setter

This is because the hawkrequest module attempts to explicitly set the level
from the preference value, but these days Log.jsm manages that itself.

Also skips obtaining the log itself until it's needed, as it almost never
actually is.

Differential Revision: https://phabricator.services.mozilla.com/D79633
2020-06-15 04:51:02 +00:00
Mathieu Leplatre 4de2f47682 Bug 1644153 - Fix loading of JSON dump from main-preview r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D79016
2020-06-11 17:39:23 +00:00
ffxbld e1defa0ff0 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D79301
2020-06-11 14:17:03 +00:00
Thom Chiovoloni b3cbb2b28e Bug 1629127 - Add sync telemetry for storage.sync migration r=lina,extension-reviewers,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78573
2020-06-10 22:29:02 +00:00
Thom Chiovoloni 9bea145029 Bug 1629116 - Ensure the sync engine we want telemetry from is actually registered in tests. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D78720
2020-06-08 18:57:59 +00:00
Lina Cambridge 6744c50972 Bug 1643804 - Always resolve the promise if fetching extension storage observer notifications fails. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D78571
2020-06-05 20:38:42 +00:00
Thom Chiovoloni d76d4f4c46 Bug 1629116 - Add an overrideTelemetryName to bridged extension storage. r=markh
Add an overrideTelemetryName to bridged extension storage.

Differential Revision: https://phabricator.services.mozilla.com/D78413
2020-06-05 01:10:10 +00:00
Mathieu Leplatre 337e076cae Bug 1641939 - Flush local DB after retrying r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D78177
2020-06-04 14:16:01 +00:00
ffxbld 765a9c9ca1 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D78285
2020-06-04 14:13:36 +00:00
Mathieu Leplatre 51c76bb2b8 Bug 1640136 - Load main dump when using preview r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D77786
2020-06-04 09:00:31 +00:00
Mark Hammond 350c376c1a Bug 1634615 - flip the pref to enable the rust browser.storage.sync implementation. r=lina,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78171
2020-06-04 06:11:45 +00:00
Dorel Luca 6193cd2270 Backed out changeset b8a2744a115f (bug 1640136) for XPCShell test/unit/test_remote_settings_worker.js. CLOSED TREE 2020-06-04 04:56:10 +03:00
Mathieu Leplatre cc4e7f5130 Bug 1640136 - Load main dump when using preview r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D77786
2020-06-03 14:56:04 +00:00
Dorel Luca 61e47c120c Merge mozilla-cental to autoland. CLOSED TREE 2020-06-01 19:35:58 +03:00
Dorel Luca d6cb4941f9 Merge autoland to mozilla-central. a=merge 2020-06-01 19:20:20 +03:00
Mozilla Releng Treescript a56e4bfdd7 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-06-01 10:15:55 +00:00
Mark Hammond 6abadd577b Bug 1639449 - Vendor new application-services to expose kinto migration and sync change notifications. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D76092
2020-05-30 02:44:07 +00:00
Mark Banner 29c4237245 Bug 1635523 - Remove now unused twitter files and pull in latest config. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D76909
2020-05-29 20:17:57 +00:00
Lina Cambridge 6ac44b30e0 Bug 1641005 - Implement `mozISyncedExtensionStorageArea.fetchPendingSyncChanges()`. r=markh
This new method fetches pending synced changes from the extension
storage store, and passes them to `storage.onChanged` listeners.
This allows extensions that listen for these events to know when a
sync happened, which Kinto supported as well.

To guard against misuse, this method is implemented on a separate
`mozISyncedExtensionStorageArea` interface. To avoid multiple
inheritance (if `mozI{Synced, Configurable}ExtensionStorageArea` both
inherited from `mozIExtensionStorageArea`, which base method is called
when?), both of these internal-ish interfaces now inherit from
`nsISupports` instead.

Finally, because `fetchPendingSyncChanges` can return changes for
multiple extensions, `mozIExtensionStorageListener.onChanged` now takes
the affected extension ID as its first argument.

Differential Revision: https://phabricator.services.mozilla.com/D76976
2020-06-01 06:07:51 +00:00
Bogdan Tara 9d4bc1415b Backed out changeset d6c79e77d6b9 (bug 1641005) for test_StorageSyncService.js failures CLOSED TREE 2020-06-01 04:32:34 +03:00
Lina Cambridge d52843b372 Bug 1641005 - Implement `mozISyncedExtensionStorageArea.fetchPendingSyncChanges()`. r=markh
This new method fetches pending synced changes from the extension
storage store, and passes them to `storage.onChanged` listeners.
This allows extensions that listen for these events to know when a
sync happened, which Kinto supported as well.

To guard against misuse, this method is implemented on a separate
`mozISyncedExtensionStorageArea` interface. To avoid multiple
inheritance (if `mozI{Synced, Configurable}ExtensionStorageArea` both
inherited from `mozIExtensionStorageArea`, which base method is called
when?), both of these internal-ish interfaces now inherit from
`nsISupports` instead.

Finally, because `fetchPendingSyncChanges` can return changes for
multiple extensions, `mozIExtensionStorageListener.onChanged` now takes
the affected extension ID as its first argument.

Differential Revision: https://phabricator.services.mozilla.com/D76976
2020-06-01 00:54:27 +00:00
ffxbld 12faf95015 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D77670
2020-06-01 14:16:14 +00:00
Mathieu Leplatre 1cfe96cf26 Bug 1640023 - Sync on .get() when no metadata r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D77233
2020-05-28 16:02:03 +00:00
Mark Hammond 35a92088a5 Bug 1640791 - Expose allowSkippedRecord to a bridged engine and enable it for extension-storage. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D76785
2020-05-27 02:12:53 +00:00
Rob Wu e7258ec672 Bug 1640291 - Account for last_modified in attachment downloader r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D76963
2020-05-27 11:28:27 +00:00
Rob Wu 0ceb5a55a2 Bug 1640291 - Read RemoteSettings dump before cache, and minimize unnecessary reads r=leplatrem
This commit does the following:

- Feature / Optimization: Check the dump before the cache, instead of
  the reverse. The dump is expected to match the requested attachment in
  the common case, and checking it first helps with ensuring that the
  expected (packaged dump) is used when available.

- Optimization: Defer reading the cached attachment until it's needed.

- Refactor / Feature: Treat a missing `.meta.json` file as a sign that
  the attachment dump does not exist, rather than an error.
  Previously, if an attachment cannot be downloaded from the network,
  that error would be replaced with a generic `DownloadError` (from the
  missing `.meta.json` file). This is mostly relevant for telemetry.

- Refactor / Maintainability: Create helper to manage lazy access to the
  record and attachment, to ensure that the record and attachment is
  only read on demand, and at most once.

- Refactor / Readability: Move the common return value generation logic
  to the helper as `getResult`, to avoid the verbose duplication of the
  logic. Now the return value fits in one line instead of 5-6 lines.

- Fix test: Rename filename-of-dump.meta.json and fix test expectation
  to ensure that the test checks the absence of the file content,
  rather than the absence of the meta data file.

Differential Revision: https://phabricator.services.mozilla.com/D76962
2020-05-27 08:00:43 +00:00
Rob Wu e609ad7d6f Bug 1640291 - Add test coverage for corrupted cache r=leplatrem
In practice, the cache of the attachment downloader can become corrupt
and unusable when IndexedDB breaks. The implementation correctly handled
this case, but there were no tests that verified that it did.

This patch adds test coverage for the scenario of a broken cache,
to ensure that the implementation continues to behave in a sane way.

Differential Revision: https://phabricator.services.mozilla.com/D76961
2020-05-27 07:50:12 +00:00
Rob Wu 680ed7bd7e Bug 1640292 - Move RemoteSettingsWorker.checkContentHash to main thread r=leplatrem
The crypto API does most of its work on the background thread. There is
no benefit in posting the buffer to a worker thread.

Differential Revision: https://phabricator.services.mozilla.com/D76960
2020-05-27 13:54:37 +00:00
Ryan Kelly bc3600def8 Bug 1640765 - only build the rust fxa-client crate on Nightly. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D76771
2020-05-27 05:51:39 +00:00
Bogdan Tara 15858ad28e Backed out changeset 0d3f76ede294 (bug 1640765) for rust related bustage CLOSED TREE 2020-05-27 07:06:35 +03:00
Ryan Kelly 58ccfb0fe7 Bug 1640765 - only build the rust fxa-client crate on Nightly. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D76771
2020-05-27 03:22:15 +00:00
Mark Banner ceba0e848d Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
2020-05-26 19:40:42 +00:00
ffxbld b3c5906f23 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D76710
2020-05-26 14:53:18 +00:00
Mathieu Leplatre 97875bccdd Bug 1637178 - Distinguish local DB hijacks from sign errors in Uptake Telemetry r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D75529
2020-05-26 11:20:03 +00:00
Mihai Alexandru Michis 33899422e7 Backed out 2 changesets (bug 1635235, bug 1635239) for causing Bug 1640583.
CLOSED TREE

Backed out changeset 97ecda13df18 (bug 1635239)
Backed out changeset c9f80397bbec (bug 1635235)
2020-05-25 16:43:03 +03:00
Lina Cambridge 53047a8297 Bug 1640528 - Allow extension storage to be enabled and disabled independently of add-ons. r=markh
By default, toggling the add-ons engine also toggles extension storage.
However, it's also possible to enable extension storage without add-ons
by setting an override pref. If the override pref is set, we'll treat
extension storage as an engine that can be toggled independently. If
it's not set, we'll ignore attempts to toggle the engine separately.

Differential Revision: https://phabricator.services.mozilla.com/D76635
2020-05-25 01:12:16 +00:00
Mark Banner 019b662f87 Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
2020-05-24 21:45:41 +00:00
Rob Wu 8c4c5239e9 Bug 1636158 - Document how to use attachment dumps in RemoteSettings r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D76159
2020-05-22 13:09:50 +00:00
Mathieu Leplatre b25d0ae2e5 Bug 1639224 - Verify signature if local timestamp is in the future r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76249
2020-05-22 00:27:06 +00:00
Mathieu Leplatre 8965849d47 Bug 1639684 - Report server_error on HTTP 5XX when polling for changes r=rdalal
Differential Revision: https://phabricator.services.mozilla.com/D76242
2020-05-21 23:59:58 +00:00
Lina Cambridge 400ff2f682 Bug 1639942 - Correctly register `Extension-Storage` engine alternatives. r=tcsc
Alternative engines are registered using the lowercased version of
the keys in the modules object. But `extension-storage` is hyphenated,
so we need to use `Extension-Storage` (not `ExtensionStorage`) as the
key name, to match the name of the engine and its collection.

Without the hyphen, we'll register the alternative as
`extensionstorage`, so it'll never be used because everything else
expects the engine to be called `extension-storage`.

Differential Revision: https://phabricator.services.mozilla.com/D76355
2020-05-21 18:55:37 +00:00
Sid Stamm 56c4be9954 Bug 1002724 - use resolvable URL in fxaccounts browser chrome tests. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D75086
2020-05-21 17:33:32 +00:00
ffxbld 663946fddd No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D76324
2020-05-21 14:05:50 +00:00
Lina Cambridge efbc79edbd Bug 1639727 - Fix `trackRemainingChanges` in the tabs and prefs Sync engines. r=markh
This commit fixes two issues: moves `trackRemainingChanges` to the
engine, since that's where it defined (not on the store), and skips
setting `modified` if all records have been successfully uploaded.

Differential Revision: https://phabricator.services.mozilla.com/D76270
2020-05-21 07:13:12 +00:00
Vlad Filippov de6e0f725b Bug 1632557 - Add pref and logic for direct use of session tokens to provision OAuth tokens r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D75204
2020-05-20 22:06:35 +00:00
Lina Cambridge faf2fd15e4 Bug 1639018 - Change `TaskRunnable::dispatch` to take owned runnables. r=froydnj
This matches how the `Dispatch(already_AddRefed<nsIRunnable>)`
overloads work in C++: `Dispatch` takes ownership of the runnable, and
leaks it if dispatch fails—because the thread manager is shutting down,
for instance. This avoids a race where a runnable can be released on
either the owning or target thread.

Rust doesn't allow arbitrary `Self` types yet (see
rust-lang/rust#44874), so we need to change `dispatch` and
`dispatch_with_options` to be associated methods.

Differential Revision: https://phabricator.services.mozilla.com/D75858
2020-05-20 20:54:49 +00:00
Florian Quèze 3449d19a7e Bug 1637637 - disable fast shutdown for the test_prefs_store.js and test_prefs_tracker.js tests where it crashes, r=gbrown.
Depends on D72407

Differential Revision: https://phabricator.services.mozilla.com/D76167
2020-05-20 16:35:51 +00:00
Vlad Filippov cf78a3d737 Bug 1635937 - Enable 'identity.sync.useOAuthForSyncToken' pref for Nightly users r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D75130
2020-05-19 21:32:50 +00:00