Building without support for the maintenance service currently does not work because the definitions of EnvHasValue and IsSecureUpdateStatusSucceeded are ifdef'ed out despite being used. This patch fixes this by including those functions, even if compiling without support for the maintenance service.
Differential Revision: https://phabricator.services.mozilla.com/D129722
There are a few slight changes to other properties. These are ridealongs, and a result of UX updating the colors in the Figma spec. Those changes are included in the Figma export, so they get pulled in when I create new manifests with my script. Here are the script changes for this bug: https://github.com/htwyford/create-theme-script/pull/2
Differential Revision: https://phabricator.services.mozilla.com/D126376
Added testing that multiple update downloads per session (Bug 353804) works properly with or without automatic update downloading.
Depends on D126162
Differential Revision: https://phabricator.services.mozilla.com/D126163
I want to be able to check if the update-available notification is fired during testing. The entry point to firing that notification is UpdateService.onCheckComplete, but it currently kicks off its work and does not wait for it to finish. This means that I can wait for the update-available notification to be fired, but I cannot easily wait for it NOT to be fired, which is what I want to be able to test here.
It looks though like it should be easy enough to just convert this interface to an asynchronous one. This will make it much easier to call onCheckComplete and know by the end of it if the update-available notification gets fired or not.
Differential Revision: https://phabricator.services.mozilla.com/D126162
This patch fixes an issue where it is possible to show the update-available prompt to the user for an update that will not ultimately be downloaded. This can result in many unnecessary update-available prompts. The issue is that `AUS.downloadUpdate` makes some checks to ensure that it doesn't download updates if, for example, that exact update has already been downloaded. But the update-available prompt is shown before `AUS.downloadUpdate` is called.
Depends on D126163
Differential Revision: https://phabricator.services.mozilla.com/D126164
This is pretty much impossible to review as-is, so it may be more useful to review the script that made them. The repo is at https://github.com/htwyford/create-theme-script. parse-themes-script.js is the main script. It reads input.json. input.json is pulled from https://github.com/FirefoxUX/themes/blob/main/tokens/color/base.json, with some light edits to fix inconsistencies. The file in the FirefoxUX repo is an export of the colors in the Figma file: https://www.figma.com/file/xaRff6432QsirRftX8NZgb/MR2-Themes?node-id=86%3A17747.
The themes aren't perfect yet. For example, the text color in the Urlbar chiclet is sometimes wrong. They also don't consider the UX spec on badge colors, since UX is still actively updating that part of the spec. Since these themes are behind a pref, I think we should land it and fix the issues in followups. It will make it more clear what is changing when they're not being added en masse like this. Getting them in the tree ASAP also lets UX and QA get a head start on testing them.
Differential Revision: https://phabricator.services.mozilla.com/D125755
This is pretty much impossible to review as-is, so it may be more useful to review the script that made them. The repo is at https://github.com/htwyford/create-theme-script. parse-themes-script.js is the main script. It reads input.json. input.json is pulled from https://github.com/FirefoxUX/themes/blob/main/tokens/color/base.json, with some light edits to fix inconsistencies. The file in the FirefoxUX repo is an export of the colors in the Figma file: https://www.figma.com/file/xaRff6432QsirRftX8NZgb/MR2-Themes?node-id=86%3A17747.
The themes aren't perfect yet. For example, the text color in the Urlbar chiclet is sometimes wrong. They also don't consider the UX spec on badge colors, since UX is still actively updating that part of the spec. Since these themes are behind a pref, I think we should land it and fix the issues in followups. It will make it more clear what is changing when they're not being added en masse like this. Getting them in the tree ASAP also lets UX and QA get a head start on testing them.
Differential Revision: https://phabricator.services.mozilla.com/D125755
Kirk Steuber
Mark Banner
John Bieling
Bryce Seager van Dyk
Narcis Beleuzu
Christoph Kerschbaumer
Cristian Tuns
Mathew Hodson
Geoff Lankow
Evgenia Kotovich
Noemi Erli
Alexandru Michis
amy churchwell
Shane Caraveo
Harry Twyford
Niklas Baumgardner
Csoregi Natalia
Marco Bonardo
Katherine Patenio
Michelle Goossens
Rob Wu
Dan Minor
Butkovits Atila
Junjie Ying
Mike Kaply
Marian-Vasile Laza