Simon Giesecke
55a2f652bc
Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D54321
--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke
bb8fe42e53
Bug 1497007 - Replace custom for loops by range-based for and appropriate algorithms. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46948
--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:53 +00:00
shindli
7c774ed0a3
Backed out 8 changesets (bug 1497007) for causing build bustages in /builds/worker/workspace/build/src/dom/indexedDB/IDBTransaction.cpp CLOSED TREE
...
Backed out changeset 15de0d72f1c4 (bug 1497007)
Backed out changeset 7056932f6422 (bug 1497007)
Backed out changeset 7304fae8c436 (bug 1497007)
Backed out changeset be22a95de04b (bug 1497007)
Backed out changeset 98ac48b5f1ef (bug 1497007)
Backed out changeset 562d3cda9fa3 (bug 1497007)
Backed out changeset 3f96e71be2e3 (bug 1497007)
Backed out changeset 3d9e86698c9f (bug 1497007)
2019-11-08 16:28:53 +02:00
Simon Giesecke
f5146ed829
Bug 1497007 - Replace custom for loops by range-based for and appropriate algorithms. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46948
--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:13 +00:00
Simon Giesecke
3b6471eff2
Bug 1168606 - Fixed some log messages. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D49397
--HG--
extra : moz-landing-system : lando
2019-11-05 16:46:38 +00:00
Simon Giesecke
9804c8f159
Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:37 +00:00
Cosmin Sabou
1211bbc800
Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
...
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
05d088dff7
Bug 1168606 - Fixed some log messages. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D49397
--HG--
extra : moz-landing-system : lando
2019-11-05 12:49:32 +00:00
Simon Giesecke
1db45a09bf
Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:36 +00:00
Simon Giesecke
cd0b6f05a1
Bug 1168606 - Use const where easily possible. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43631
--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:45 +00:00
Oana Pop Rus
cb31d323be
Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
...
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke
3feb8e1ebe
Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
Simon Giesecke
a9cf10ae19
Bug 1168606 - Use const where easily possible. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43631
--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:04 +00:00
Simon Giesecke
bd2e4939bc
Bug 1168606 - Remove duplication in uses of IDB_LOG_MARK. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46576
--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:45 +00:00
Simon Giesecke
95342c2fde
Bug 1168606 - Reduce code duplication for different open cursor variants. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40956
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:24 +00:00
Simon Giesecke
f4cb5f1dee
Bug 1168606 - Change definition of OpenCursorParams subtypes to allow reducing duplicated code r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40955
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:26 +00:00
Mihai Alexandru Michis
b5c83385d6
Backed out 8 changesets (bug 1168606) for failures in idbcursor-continuePrimaryKey.htm
...
Backed out changeset 066bee573945 (bug 1168606)
Backed out changeset 1485cea56f41 (bug 1168606)
Backed out changeset 4858e4e132de (bug 1168606)
Backed out changeset 5be5a3bf0499 (bug 1168606)
Backed out changeset 6078d5a9c010 (bug 1168606)
Backed out changeset f5aee1ae7282 (bug 1168606)
Backed out changeset acae76cea927 (bug 1168606)
Backed out changeset 0133605c6169 (bug 1168606)
--HG--
extra : rebase_source : 27477feb2e52f4149ede2fe5db9d86b5e322046d
2019-09-11 14:36:57 +03:00
Simon Giesecke
4bfd09c089
Bug 1168606 - Reduce code duplication for different open cursor variants. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40956
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:15 +00:00
Simon Giesecke
4a9fe9f0a5
Bug 1168606 - Change definition of OpenCursorParams subtypes to allow reducing duplicated code r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40955
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:09 +00:00
Simon Giesecke
542ab16b7c
Bug 1168606 - Fixed wrong method name in log message. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40953
--HG--
extra : amend_source : 0e3ff248e6585713193bfac7a29ff607c38a6e82
2019-08-21 09:27:20 +02:00
Yaron Tausky
6e39f30075
Bug 1544750 - Part 1: Refactor some IndexedDB code to use ErrorResult r=asuth
...
This is mostly laying the groundwork for further refactoring.
Differential Revision: https://phabricator.services.mozilla.com/D27666
--HG--
extra : moz-landing-system : lando
2019-04-26 16:53:59 +00:00
Andrea Marchesini
da174a4757
Bug 1539407
- Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28
Backed out changeset 98452610cfcc (bug 1539407
) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
...
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b
Bug 1539407
- Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Alex Gaynor
0547854c42
Bug 1535397 - Part 5 - use native Maybe syntax in place of OptionalKeyRange in IDPL; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D23562
--HG--
extra : moz-landing-system : lando
2019-03-15 17:39:59 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Diego Pino Garcia
05039e8e29
Bug 1357636
- Improve IndexedDB error message on deleting an undefined object; r=janv
...
Patch authored by Diego Pino Garcia.
2018-08-15 15:35:58 +02:00
Jeff Gilbert
5b753da289
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Julian Seward
408d24da56
Bug 1382563 - Remove ns*String::AssignWithConversion. r=erahm.
...
This patch replaces four functions of the name AssignWithConversion which
are essentially wrappers around CopyASCIItoUTF16 and LossyCopyUTF16toASCII
with direct calls to the latter two functions. The replaced functions are:
void nsCString::AssignWithConversion( const nsAString& aData )
void nsString::AssignWithConversion( const nsACString& aData )
void nsTString_CharT::AssignWithConversion(
const incompatible_char_type* aData,
int32_t aLength = -1);
The last of the three exists inside the double-included nsTString* world and
so describes two functions, giving four in total.
This has two advantages:
* it removes code
* at the call points, it makes clear (from the replacement name) which
conversion is being carried out. The generic name "AssignWithConversion"
doesn't make that obvious -- one had to infer it from the types.
The patch also removes two commented out lines from
editor/composer/nsComposerCommands.cpp, that appear to be related. They are
at top level, where they would never have compiled. They look like
leftovers from some previous change.
--HG--
extra : rebase_source : fb47bf450771c3c9ee3341dd14520f5da69ec4f5
2017-07-24 19:23:52 +02:00
Jan Varga
c9e62d9e30
Bug 1370519 - Part 1: Add missing includes to fix non-unified builds; r=btseng
2017-06-07 12:36:20 +02:00
Olli Pettay
0364dbc792
Bug 1326507, remove NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS, r=mccr8
...
--HG--
extra : rebase_source : 3ae1207308de120b7299b13ecaa95dd1612b3459
2017-01-03 21:47:55 +02:00
Jon Coppeard
556585c65f
Bug 1297558 - Remove explicit calls to Expose*ToActiveJS r=mccr8
2016-10-18 17:58:19 +01:00
Bevis Tseng
e0e7ead1f0
Bug 1118028 - Allow objectStores and indexes to be renamed. r=khuey
...
--HG--
extra : rebase_source : 4f2d1da2ddafbe786c3908eb46723b4d2f0c48cc
2016-03-30 11:04:56 +08:00
Boris Zbarsky
ede5a13ec4
Bug 1257725 part 5. Get rid of ThreadsafeAutoJSContext usage in IDBRequest::CaptureCaller. r=khuey
2016-03-23 11:02:57 -04:00
Andrew McCreight
b80e656e9e
Bug 1247679, part 3 - Replace NS_IMPL_CYCLE_COLLECTION_TRACE_JSVAL_MEMBER_CALLBACK with JS_MEMBER. r=smaug
2016-02-22 10:11:02 -08:00
Kyle Huey
31dabb4558
Bug 1247117: De-namespace much of IndexedDB. r=baku
2016-02-16 13:46:08 -08:00
Kyle Huey
91efc5a86c
Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug
2016-01-30 09:05:36 -08:00
Nathan Froyd
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Reuben Morais
e493377d61
Bug 871846 - API changes for locale aware indexes. r=janv r=sicking
2015-09-04 16:12:29 -03:00
Birunthan Mohanathas
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Ben Turner
dbe52fd678
Bug 1149815 - Guard against using deleted IDBObjectStore and IDBIndex objects, r=janv.
2015-06-20 09:08:23 -07:00
Andrew McCreight
9e8f4b219e
Bug 1152551, part 2 - Fix mode lines in dom/. r=jst
2015-05-03 15:32:37 -04:00
Boris Zbarsky
dc24477d79
Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
...
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp. The
rest of this diff was generated by running the following commands:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Ben Turner
aba0f06823
Bug 1143885 - Fix transaction handling when requests are killed prematurely, r=khuey.
2015-03-18 14:20:59 -07:00
Ms2ger
b83d21c58c
Bug 914067 - Remove JSVAL_VOID from dom/; r=jst
2015-01-14 08:59:06 +01:00
Ben Turner
9a1f2f231f
Bug 1092311 - Fix IndexedDB profiler markers and logging, r=khuey.
2014-10-15 21:56:52 -07:00
Peter Van der Beken
dcda2ba9bb
Bug 1078744 - Replace SetIsDOMBinding with SetIsNonDOMBinding, remove nsWrapperCache::SetIsDOMBinding. r=bz.
...
--HG--
extra : rebase_source : 89c476cd9436530b2df5acc903909e34188417a0
2014-10-07 11:44:49 +02:00
Ben Turner
d081140cb0
Bug 994190 - 'Modify main-thread IndexedDB to use PBackground', r=khuey.
2014-09-26 16:21:57 -07:00
Ben Turner
46d101f40c
Backout bug 994190 and merge over some stuff that landed afterwards on a CLOSED TREE.
2014-09-17 19:36:01 -04:00