Logic for displaying addon installation confirmation prompts that
was previously in the Installer helper class is now rolled into the
prompts that are issued from AddonInstall.
MozReview-Commit-ID: HGZTqDZMgNQ
--HG--
extra : rebase_source : a7caaee24ffb0557b00c192fe01357a1ac2417bf
extra : source : 73440e18fc824662390fee130aab4a86cf6af60d
Logic for displaying addon installation confirmation prompts that
was previously in the Installer helper class is now rolled into the
prompts that are issued from AddonInstall.
MozReview-Commit-ID: HGZTqDZMgNQ
--HG--
extra : rebase_source : 960a0a33795ff3578e3ee9365670f6a47e351e5c
extra : source : 73440e18fc824662390fee130aab4a86cf6af60d
We used to need explicit names for functions to make stack traces display
properly. The JS engine is smarter now so doesn't need them and they just
make the code messy and redundant.
--HG--
extra : commitid : 4FEIiQYhRQu
extra : rebase_source : 26689d5417f592d0f327f32076245cb4f154229a
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
Florian Quèze
Andrew Swan
Sebastian Hengst
Jared Wein
Wes Kocher
Dave Townsend
Jim Blandy
Irving Reid
Atul Jangra
Marcos S
Devdatta Akhawe
Neil Rashbrook
Ed Morley
Gervase Markham