Граф коммитов

8218 Коммитов

Автор SHA1 Сообщение Дата
pbz e118843a3a Bug 1615588 - Updated prompt tests. r=marionette-reviewers,johannh,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D66450
2020-04-16 14:44:56 +00:00
Eitan Isaacson 14c42949a0 Bug 1629162 - Scrollability changed should fire accessible FOCUSABLE changes. r=morgan,Jamie
When an element with overflow:auto becomes scrollable, either by a style change or growing children, it should become focusable and fire a state change. Same in the inverse.

Differential Revision: https://phabricator.services.mozilla.com/D70561

--HG--
extra : moz-landing-system : lando
2020-04-15 22:33:55 +00:00
Eitan Isaacson d5a790643e Bug 1629162 - Attribute changes should cause FOCUSABLE state change events. r=morgan,Jamie
Changes to attributes such as disabled, contenteditable, and tabindex should cause FOCUSABLE
state changes to be fired when indeed the accessible gains or loses focusability.

Differential Revision: https://phabricator.services.mozilla.com/D70560

--HG--
extra : moz-landing-system : lando
2020-04-15 22:33:48 +00:00
Eitan Isaacson a0e9e925ab Bug 1629771 - When collapsed caret moves in focusable element, don't pivot to it. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D71109

--HG--
extra : moz-landing-system : lando
2020-04-15 22:16:34 +00:00
Eitan Isaacson d09e5861c1 Bug 1628922 - Support landmark navigation in GeckoView. r=Jamie
Added a traversal rule and piped through xml-roles as role descriptions.

Differential Revision: https://phabricator.services.mozilla.com/D70950

--HG--
extra : moz-landing-system : lando
2020-04-15 22:12:37 +00:00
Stefan Hindli fb36126f61 Backed out 15 changesets (bug 1607984) for causing very frequent reftest faiures CLOSED TREE
Backed out changeset 5497c90b03de (bug 1607984)
Backed out changeset 71dffa590c10 (bug 1607984)
Backed out changeset fdacabac2c54 (bug 1607984)
Backed out changeset 5f9fe17e46b8 (bug 1607984)
Backed out changeset 8f9058eb821d (bug 1607984)
Backed out changeset 025af7792f2a (bug 1607984)
Backed out changeset c7edd070b2f3 (bug 1607984)
Backed out changeset 8e7c95d322e8 (bug 1607984)
Backed out changeset e51f6b7a745c (bug 1607984)
Backed out changeset 979d99eb12d1 (bug 1607984)
Backed out changeset f554d4ce6718 (bug 1607984)
Backed out changeset fe84e5c64b4e (bug 1607984)
Backed out changeset 05d2032060db (bug 1607984)
Backed out changeset 07ce7b11fee9 (bug 1607984)
Backed out changeset 718d89be09d2 (bug 1607984)
2020-04-15 18:33:24 +03:00
Jean-Yves Avenard 3270a01575 Bug 1607984 - P15. Wait for the load to start before setting the event handler. r=Jamie
addA11yLoadEvent gets the contentWindow and wait for the document from that window to fire the load event.

Enabling the DocumentChannel for parent process load (or here in non-e10s mode) we have one extra event loop before the load starts.
So the window passed to addA11yLoadEvent would have been of the about:blank page.

The current code was based on an observable behaviour which was that the load was occuring synchronously.

DocumentChannel broke that assumption.

Differential Revision: https://phabricator.services.mozilla.com/D70799

--HG--
extra : moz-landing-system : lando
2020-04-15 08:57:31 +00:00
aarushivij 5a709f46e1 Bug 1519099 - removeFromDb parameter of nsIAutoCompleteResult::RemoveValueAt is always true r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70704

--HG--
extra : moz-landing-system : lando
2020-04-15 10:05:12 +00:00
Yura Zenevich a9bdb68e38 Bug 1595979 - add zoom text hittest b-c test. Implement OffsetAtPoint for XPCOM on Windows with e10s. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D69824

--HG--
extra : moz-landing-system : lando
2020-04-14 23:57:42 +00:00
Yura Zenevich fa747c2765 Bug 1595979 - add hittest b-c tests (general, shadowroot, zoom). Fix an e10s bug where must prune check was done on the parent side instead of deferring to childAtPoint method. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D69823

--HG--
extra : moz-landing-system : lando
2020-04-14 23:57:34 +00:00
Yura Zenevich bf4f49a410 Bug 1595979 - migtate browser and canvas hittest tests to b-c that test e10s and fission. Fix a bug with incorrect ID returned for document accessibles when getting a child at point over IPC. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D69822

--HG--
extra : moz-landing-system : lando
2020-04-14 23:57:26 +00:00
Yura Zenevich e05c569d5b Bug 1595979 - move common utilities into shared-head and remove unsused ones. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D69821

--HG--
extra : moz-landing-system : lando
2020-04-14 23:57:19 +00:00
Emilio Cobos Álvarez 60fdfe51e1 Bug 1629838 - Don't flush reentrantly from XUL a11y construction. r=Jamie
This code has pretty much always been broken, we've started to flush
more because we fixed a bug that was not looking at XUL trees inside
shadow DOM in bug 1625991.

We cannot flush layout from a11y tree construction.

Differential Revision: https://phabricator.services.mozilla.com/D70917

--HG--
extra : moz-landing-system : lando
2020-04-15 01:01:12 +00:00
Eitan Isaacson 2edb3fea1a Bug 1619752 - Use AXSelected=false to tell VoiceOver about link groups. r=morgan
I really don't understand why this is what VoiceOver needs, but it seems to do the trick.

Differential Revision: https://phabricator.services.mozilla.com/D70776

--HG--
extra : moz-landing-system : lando
2020-04-14 17:15:07 +00:00
Chris Peterson 086922958e Bug 1629316 - Replace MOZ_MUST_USE with [[nodiscard]] in accessible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D70630

--HG--
extra : moz-landing-system : lando
2020-04-14 03:09:06 +00:00
Morgan Reschenberg 8e22125381 Bug 1629167: Use PlaceTestUtils instead of manually visiting site to wipe history after runs. r=eeejay
Depends on D70095

Differential Revision: https://phabricator.services.mozilla.com/D70710

--HG--
extra : moz-landing-system : lando
2020-04-13 20:20:03 +00:00
Noemi Erli 28f02fa444 Bug 1627765 - Fix lint failure r=fix 2020-04-11 00:02:56 +03:00
Eitan Isaacson 295f35f3f8 Bug 1627832 - Prune all invisible children of root window accessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69881

--HG--
extra : moz-landing-system : lando
2020-04-09 23:19:55 +00:00
Eitan Isaacson ca37dab5ab Bug 1627765 - Remove mac heirarchy cache. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69880

--HG--
extra : moz-landing-system : lando
2020-04-10 17:52:58 +00:00
Eitan Isaacson 8f333badf3 Bug 1627765 - Use REORDER event to invalidate table column accessibles. r=morgan
We need to do this because we can't rely on the main children cache invalidation.
Also, I don't think this really worked before with cell additions to a row, since only
the row's children would be invalidated, and the table's children would remain untouched.

Differential Revision: https://phabricator.services.mozilla.com/D69879

--HG--
extra : moz-landing-system : lando
2020-04-10 17:53:41 +00:00
Eitan Isaacson 17f84615a2 Bug 1627765 - Rename firePlatformEvent to handleAccessibleEvent. r=morgan
The latter seems more accurate to what that method does, since we don't necessarily
forward that event to the OS, but might instead use it to update cached properties.

Differential Revision: https://phabricator.services.mozilla.com/D69878

--HG--
extra : moz-landing-system : lando
2020-04-09 22:57:47 +00:00
Csoregi Natalia 954b969608 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)

--HG--
extra : rebase_source : 41ed149c97382bc1cf823abc56811b382cae0207
2020-04-10 21:19:15 +03:00
Morgan Reschenberg 2e7598ddac Bug 1624964: Add visited attribute to links, state caching for TRAVERSED. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D70095

--HG--
extra : moz-landing-system : lando
2020-04-10 15:54:15 +00:00
pbz b296ec16c4 Bug 1615588 - Updated prompt tests. r=marionette-reviewers,johannh,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D66450

--HG--
extra : moz-landing-system : lando
2020-04-10 16:45:36 +00:00
James Teh 47aa8b6b4d Bug 1619506 part 2: Don't expose NODE_CHILD_OF relation for OOP iframe documents. r=yzen
For OOP iframe documents, we can't support NODE_CHILD_OF in the usual way, since the iframe resides in a different process.
Previously, we incorrectly returned the application accessible.
This was breaking focus ancestry walking for JAWS.
Instead, don't expose NODE_CHILD_OF at all in this case.
This is fine because the client will then request the parent instead, which will be correctly handled by platform/AccessibleOrProxy code.

Differential Revision: https://phabricator.services.mozilla.com/D70163

--HG--
extra : moz-landing-system : lando
2020-04-08 18:30:01 +00:00
James Teh fa30324c84 Bug 1619506 part 1: Implement QueryService to SID_IAccessibleContentDocument for OOP iframes. r=yzen
For OOP iframes, the top level document lives in a different process.
Previously, we incorrectly returned the top level document in the same process.
This was causing JAWS to incorrectly identify OOP iframe documents as separate tab documents.
To fix this, we must send the real top level document down from the parent process and return that when requested in the content process.

Differential Revision: https://phabricator.services.mozilla.com/D70162

--HG--
extra : moz-landing-system : lando
2020-04-08 18:28:08 +00:00
Tim Nguyen f4024ef912 Bug 1624482 - Adapt menupopup accessible to query the correct parent element when slotted. r=emilio
D67954 starts using shadow DOM for menulist and slots the menulist children. This causes GetFlattenedTreeParent to return the slot instead of the parent menulist. This patch fixes it.

Differential Revision: https://phabricator.services.mozilla.com/D70234

--HG--
extra : moz-landing-system : lando
2020-04-08 19:48:30 +00:00
Eitan Isaacson 5d8f189fab Bug 1627899 - Focus selected tatb only if nott already focused. r=MarcoZ
Not sure how this could happen, but perhaps the tab is already focused so waiting
for a focus change event causes a timeout.

Differential Revision: https://phabricator.services.mozilla.com/D70059

--HG--
extra : moz-landing-system : lando
2020-04-08 04:51:22 +00:00
Morgan Reschenberg 883afead1b Bug 1627763: Adjust coordinates of layout point for launching context menu. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D69874

--HG--
extra : moz-landing-system : lando
2020-04-06 22:07:25 +00:00
Morgan Reschenberg 945f2ee931 Bug 1618705: Construct column containers and list them as children of our table accessible. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67900

--HG--
extra : moz-landing-system : lando
2020-04-06 16:51:11 +00:00
Morgan Reschenberg 1407b0c42b Bug 1627311: Remove actions from mozLinkAccessible to avoid duplication in mozAccessible. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D69601

--HG--
extra : moz-landing-system : lando
2020-04-03 21:58:01 +00:00
Sylvestre Ledru 0aa6f03cf3 Bug 1519636 - Reformat recent changes to the Google coding style r=jgilbert
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D67574

--HG--
extra : moz-landing-system : lando
2020-04-05 13:34:58 +00:00
Eric Rahm 357069ff58 Bug 1626455 - Remove nsAutoPtr usage from accessible/. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D69126

--HG--
extra : moz-landing-system : lando
2020-04-03 21:05:35 +00:00
Eitan Isaacson 99fcfa7336 Bug 1626638 - Add subrole of AXTabButtton to page tabs. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69212

--HG--
extra : moz-landing-system : lando
2020-04-02 05:47:52 +00:00
Eitan Isaacson cd6b27feeb Bug 1626036 - Cache SELECTED state in Mac. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69133

--HG--
extra : moz-landing-system : lando
2020-04-02 16:44:33 +00:00
Eitan Isaacson 9d0aad6f8b Bug 1626036 - Cache CURRENT state in Mac. r=morgan
This allows us to not pull in attributes for every accessible.

Differential Revision: https://phabricator.services.mozilla.com/D69132

--HG--
extra : moz-landing-system : lando
2020-04-02 16:44:24 +00:00
Eitan Isaacson df0924d72a Bug 1626036 - Initial Mac state caching. r=morgan
Here I added caching for all the toggle states, and expanded.

Differential Revision: https://phabricator.services.mozilla.com/D69131

--HG--
extra : moz-landing-system : lando
2020-04-02 16:42:46 +00:00
Eitan Isaacson df6032b2ba Bug 1626036 - Add a stateWithMask method to mozAccessible. r=morgan
Having this kind of method will let us know what the states of interest are.
If all the states are cached we can return them without inquiring the full state.

Differential Revision: https://phabricator.services.mozilla.com/D69130

--HG--
extra : moz-landing-system : lando
2020-04-02 05:47:43 +00:00
Eitan Isaacson fdedd0e534 Bug 1626639 - Use mozCheckboxAccessible class for radio buttons. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D69215

--HG--
extra : moz-landing-system : lando
2020-04-02 20:28:06 +00:00
Eitan Isaacson b2c4484df1 Bug 1626036 - Introduce more mochitests for mac accessibility. r=morgan
In this patch set I'll introduce state caching, so I thought it's a good idea
to first add a bunch of tests to features that will be touched.

Differential Revision: https://phabricator.services.mozilla.com/D69129

--HG--
extra : moz-landing-system : lando
2020-04-02 16:41:43 +00:00
Morgan Reschenberg bb48588461 Bug 1625832: Feed mouse synthesizer gecko coordinates instead of Mac coordinates. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D69035

--HG--
extra : moz-landing-system : lando
2020-04-01 05:07:53 +00:00
James Teh 5d7440007c Bug 1626802 part 2: Implement HandlerProvider::IsInterfaceMaybeSupported for a11y. r=aklotz,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D69286

--HG--
extra : moz-landing-system : lando
2020-04-02 04:09:20 +00:00
Christoph Kerschbaumer 4b9c5814af Bug 1571461 - Change accessibility of search widget to look for all event handlers and remove hack to hide.r=surkov,MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D68023

--HG--
extra : moz-landing-system : lando
2020-03-31 11:06:38 +00:00
Marco Zehe 038d0f0c06 Bug 1626137 - Account for tables that are display:block; when looking for the table of a row accessible, r=Jamie
When checking if a parent of a table row counts for a table, take into account that a table might be an ARIAGridAccessible, which remains a generic hyperText, but is still a valid table. Tables with display: block; are such candidates.

Differential Revision: https://phabricator.services.mozilla.com/D68955

--HG--
extra : moz-landing-system : lando
2020-03-31 06:32:15 +00:00
James Teh 979d04b401 Bug 1625396: AccessibleOrProxy::ChildAtPoint: Accessible::ChildAtPoint can return null, so don't try to check for a remote child doc in that case. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D68739

--HG--
extra : moz-landing-system : lando
2020-03-30 13:19:15 +00:00
Tim Nguyen 66d337e655 Bug 1625314 - Follow up: Temporarily hack around search-textbox a11y failures. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D68899

--HG--
extra : amend_source : 61e287fc550a40c6cbce2dc34205f7abf9cb2003
2020-03-30 21:34:38 +00:00
Botond Ballo 672a7de4ff Bug 1626021 - Remove non-ASCII characters from comments in Accessible.cpp. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D68847

--HG--
extra : moz-landing-system : lando
2020-03-30 17:33:19 +00:00
Morgan Reschenberg 48fa33b966 Bug 1618706: Adjust role of grid cells from group to table-cell. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D68618

--HG--
extra : moz-landing-system : lando
2020-03-27 20:37:24 +00:00
James Teh c48bee7775 Bug 1598299 part 2: Remove ProxyAccessible::AccessibleAtPoint. r=yzen,nika
This wasn't useful cross-platform.
ATK was the only consumer of this and it now uses ProxyAccessible::ChildAtPoint.
This also means the related aNeedsScreenCoords functionality in PDocAccessible::AccessibleAtPoint is no longer needed and has thus been removed.
Finally, this renames PDocAccessible::AccessibleAtPoint to PDocAccessible::ChildAtPoint for consistency with Accessible::ChildAtPoint now that the functionality is mirrored.

Differential Revision: https://phabricator.services.mozilla.com/D67987

--HG--
extra : moz-landing-system : lando
2020-03-29 23:08:44 +00:00
James Teh ef9d9e1d06 Bug 1598299 part 1: Make atk_component_ref_accessible_at_point return the deepest child instead of the direct child. r=yzen
This changes the ATK code to use AccessibleOrProxy::ChildAtPoint, since that already handles walking into OuterDocAccessibles appropriately.
Previously, atk_component_ref_accessible_at_point didn't work at all on OuterDocAccessibles.
Also, for ProxyAccessibles, we no longer adjust the coordinates for ATK_XY_WINDOW in the content process, as this depends on stuff that doesn't exist cross-platform and thus can't be used with AccessibleOrProxy.
Instead, we now handle this in the parent process before making the IPC call.

Differential Revision: https://phabricator.services.mozilla.com/D67986

--HG--
extra : moz-landing-system : lando
2020-03-26 15:27:45 +00:00