Note that this patch also updates the setReactFriendlyInputValue function in
head.js, as it was not working for selects.
Differential Revision: https://phabricator.services.mozilla.com/D65151
--HG--
extra : moz-landing-system : lando
This race condition is really only exposed in automated testing, but it
was making the DevTools performance-new mochitests intermittent.
The race looks like this:
* stopProfilerAndDiscardProfiler() request
* perf actor process the request
* The gecko profiler sends an event notifying that the profiler stopped
* DevTools updates the UI upon receiving the event
* The test suite sees the UI update, and triggers a close of DevTools
* Error: Connection closed, pending request
* stopProfilerAndDiscardProfiler still hasn't sent the response yet
This patch fixes it by not throwing an error if the panel is already destroyed.
Differential Revision: https://phabricator.services.mozilla.com/D65150
--HG--
extra : moz-landing-system : lando
The browser chrome tests previously only tested the performance-new client
from a unit testing perspective. I originally wrote them this way so that
they would be fast, and not flaky, as the client actually runs the profiler
and full browser infrastructure. However, these tests haven't been really
great at catching bugs, and the tests break pretty easy to due implementation
changes for the client.
The new browser tests have been proving fast, reliable, and great at catching
regressions. This patch moves all of the about:profiling related tests to be
exclusively mochitests.
Differential Revision: https://phabricator.services.mozilla.com/D65149
--HG--
extra : moz-landing-system : lando
Currently the preferences for remote profiling are stored on the debuggee. This leads
to a negative user experience, as oftentimes phones do not persist the preferences.
This patch changes the strategy to store one set of preferences for local profiling,
and a second set of preferences for remote profiling.
Differential Revision: https://phabricator.services.mozilla.com/D65148
--HG--
extra : moz-landing-system : lando
DevTools and about:profiling will both use them, so place them in a shared utils
folder, and put the type definition in a shared location.
Differential Revision: https://phabricator.services.mozilla.com/D65145
--HG--
extra : moz-landing-system : lando
Added 'jumpToDefinitionButton' to the function preview with a title containing target source + location.
The button is not rendered for ignored source urls similarly like in the console.
Differential Revision: https://phabricator.services.mozilla.com/D62591
--HG--
extra : moz-landing-system : lando
This prevents the popup to cover the eager evaluation result.
In order for the popup to be able to appear outside of the
toolbox, we pass the useXulWrapper option to the HTMLTooltip.
Differential Revision: https://phabricator.services.mozilla.com/D62431
--HG--
extra : moz-landing-system : lando
If the XUL wrapper was opened and a consumer called show again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using `_moveXulWrapperTo`.
With this change in place, we can remove the updateContainerBounds methods,
as it has the same arguments and is only used in one place.
Differential Revision: https://phabricator.services.mozilla.com/D63488
--HG--
extra : moz-landing-system : lando
This should be less confusing. This is not supported outside of chrome:// or
user-agent stylesheets so we can name this however we want.
Differential Revision: https://phabricator.services.mozilla.com/D65605
--HG--
extra : moz-landing-system : lando
These already work in py3. I either missed them in bug 1616630, or they
were dependent on other scripts that have since been converted.
Differential Revision: https://phabricator.services.mozilla.com/D65375
--HG--
extra : moz-landing-system : lando
Treating as many realms as we can as debuggee makes us much less likely to
accidentally cause side-effects during eager-evaluation of code in the console.
Differential Revision: https://phabricator.services.mozilla.com/D65445
--HG--
extra : source : 9e09d30270d6cc660fabb406e132e2e09db870a5
Alexandre Poirot
Hubert Boma Manilla
Jason Laster
Micah Tigley
Noemi Erli
Bryan Kok
Greg Tatum
Belén Albeza
Kriti Singh
Uday
Mihai Alexandru Michis
Mark Banner
Boris Zbarsky
Emma Malysz
Arthur Iakab
Stepan Stava
Logan Smyth
Yura Zenevich
manishsahani1351111
Andreea Pavel
Nicolas Chevobbe
Sebastian Hengst
Julian Descottes
Emilio Cobos Álvarez
Mike Shal