Граф коммитов

4580 Коммитов

Автор SHA1 Сообщение Дата
Edouard Oger 682b54d712 Bug 1339861 - Mark Sync clients as stale if not in the FxA device list. r=markh
MozReview-Commit-ID: 84Tl3QTHInO

--HG--
extra : rebase_source : c05a5462be71b9eb0bc1bddc6a6a74f1b13088b7
2017-02-28 16:35:01 -05:00
Ethan Glasser-Camp db142ded6a Bug 1329069: Upgrade kinto-http-client.js to v4.0.0, r=MattN
Version 4.0.0 removes the default five-second timeout for all HTTP
requests. This should hopefully fix bug 1329069, bug 1335519, and bug
1333677. It should also make us more robust "in the wild" against
laggy connections or slow servers. We don't need to worry too much
about instituting our own timeout because Necko will impose a timeout
for us according to the preferences network.http.response.timeout and
network.http.keep-alive.timeout.

Version 3.0.0 updates some dependencies and changes some polyfills
around. See https://github.com/Kinto/kinto-http.js/pull/158 for more
details.

MozReview-Commit-ID: 4eAwghOpqfE

--HG--
extra : rebase_source : 9657c3b3f9f0e905845933c123fe099c4408dd29
2017-03-02 17:44:18 -05:00
BharatR123 56b41b115e Bug 1345009 - remove _migratePrefs() function and related test and references in xpcshell.ini r=markh
MozReview-Commit-ID: CbXXPLNXUet

--HG--
extra : rebase_source : 81ace434bc1ecdff3a84b9c8a978343d052ad1ea
2017-03-07 14:41:46 +05:30
Kit Cambridge 35e400d22b Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync. r=tcsc
Some of our tests call `Svc.Prefs.resetBranch("")` or
`Service.startOver()`, which resets the validation prefs to their
default values. This patch makes it a bit more explicit which tests
perform a full sync, and should run validation.

MozReview-Commit-ID: 7a0wR8nuJeW

--HG--
extra : rebase_source : 18ff025671c9dd5e2e30d441940f5c2fb804cae3
2017-03-06 11:29:19 -08:00
Florian Quèze 7f1b926f29 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws.
--HG--
extra : rebase_source : 4da1e10b87ac37de19e0ca6f79996e8a12492db9
2017-03-07 15:29:48 +01:00
Florian Quèze cd762cc83c Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws.
--HG--
extra : rebase_source : c6e20e6e79b0ca5de751c52712d96cbea9432d26
2017-03-07 15:29:48 +01:00
Carsten "Tomcat" Book 11a63f44ea merge autoland to mozilla-central a=merge 2017-03-07 15:04:48 +01:00
ffxbld cce942762c Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
MozReview-Commit-ID: GEyM0F1O4hP
2017-03-06 23:53:55 +01:00
Carsten "Tomcat" Book 1bc7720a43 Backed out changeset 0bd17b868a31 (bug 1335877) for causing regression bug 1344760 2017-03-06 17:03:11 +01:00
Edouard Oger 69b317e280 Bug 1321119 - Allow to Sync more tabs and reduce tabs history to 5. r=markh
MozReview-Commit-ID: 7kRg4XQeT4C

--HG--
extra : rebase_source : 7558c92cc3fefe1ade2359008df9102f5ba72322
2017-03-01 13:47:20 -05:00
Zibi Braniecki 4b7b3d4092 Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman
MozReview-Commit-ID: M7V6JS5myy

--HG--
extra : rebase_source : a47d739d3dd67ce563088aaf9fab5421de376cd7
2017-03-02 15:26:53 -08:00
Mark Hammond b86ff30666 Bug 1317223 (part 7) - disable tests on ASAN due to bug 1344085. r=kitcambridge
MozReview-Commit-ID: 6L72ACMcDBq
2017-03-03 10:54:45 +11:00
Mark Hammond 5712360194 Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r=tcsc
A poor start, but at least it's something.

MozReview-Commit-ID: 8us4v6Y21oM
2017-03-01 23:17:05 +11:00
Mark Hammond 9b6693b8ee Bug 1317223 (part 5) - a bookmark repair responder. r=kitcambridge
This is the "repair responder" - it handles a "repairRequest" command sent
by another client and attempts to take the list of IDs that client lists as
missing and upload whatever records are necessary such that the requesting
client would then be likely to find a complete and valid tree on the server.

MozReview-Commit-ID: 4xw19nH6EfL
2017-02-28 15:34:37 +11:00
Kit Cambridge 46e87ef366 Bug 1317223 (part 4) - formalize weak tracking in `BookmarksChangeset`. r=markh
MozReview-Commit-ID: C6otrtSuhZH
2017-02-06 10:19:27 -08:00
Mark Hammond 8c4e55d022 Bug 1317223 (part 3) - a bookmark repair requestor. r=markh,tcsc
The bookmark repair requestor takes the validation results and possibly
initiates a bookmark repair.

MozReview-Commit-ID: 7rRNbBx8Vo3
2017-03-02 19:21:53 +11:00
Mark Hammond de20e8f357 Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r=tcsc
This patch defines the concept of a "doctor" for collections. The doctor is
responsible for running all validators and deciding whether or not to initiate
a repair request based on the validation results.

MozReview-Commit-ID: 6NLRE6L0OpA
2017-03-02 17:14:31 +11:00
Mark Hammond fdeace22db Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman
This creates a collection_repair module, somewhat analogous to the existing
collection_validator module. This defines the public interface to request a
new repair and respond to a remote repair request, and also includes changes
to clients.js to call this public interface.

MozReview-Commit-ID: 9JPpRrLgFoR
2017-03-02 16:14:51 +11:00
Mark Hammond 79d7981ee8 Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman
MozReview-Commit-ID: 2jtCsl3sy3X

--HG--
extra : rebase_source : f0d24ca1a990abd8499f7f07eb7561840441dd1a
2017-02-27 12:44:12 +11:00
Joel Maher 5708b8f058 Bug 1345556 - add BUG_COMPONENT to services/* files. r=rfkelly, kit
MozReview-Commit-ID: 3QzgxUDL5xa
2017-03-09 05:33:31 -05:00
Zibi Braniecki 100766fec4 Bug 1335877 - Remove resource://services-common/stringbundle.js from gecko. r=gandalf
MozReview-Commit-ID: FNoj7XH71E4

--HG--
extra : rebase_source : 294d3e425ca60e2aac6149998da7f39f62864ae5
2017-03-06 09:39:52 -08:00
Thom Chiovoloni 25c588b7f3 Bug 1321740 - Avoid a full sync after signing in due to fxa reauthentication. r=markh
MozReview-Commit-ID: 8wVq1RYojUS

--HG--
extra : rebase_source : d0ba2c635d1de121476e8f8a1f9d570d7f4dc48a
2017-02-21 16:18:43 -05:00
Kris Maglione 1d0cefff4a Bug 1345345: Fix preference observers reporting changes to arbitrary sub-branches. r=rhelmer
MozReview-Commit-ID: CrGHoTiw4kz

--HG--
extra : rebase_source : b0259975f6f857eb3155e4fcc2b5cc889201384d
2017-03-07 20:10:42 -08:00
Edouard Oger fe217294a0 Bug 1346136 - Add more leeway in backoff testing. r=markh
MozReview-Commit-ID: 4M86B9BVbq9

--HG--
extra : rebase_source : 726bf645306864410f18bac78c3484e347e9ff7d
2017-03-10 15:39:41 -05:00
Wes Kocher 7c2b508df2 Backed out changeset cfe8ab5f1c08 (bug 1269277) for failures in browser_aboutAccounts.js a=backout
MozReview-Commit-ID: FgcSoHPCnoH
2017-03-10 16:55:36 -08:00
Edouard Oger 036a984325 Bug 745410 - Remove microsummary support from Sync. r=kitcambridge
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 1049da5ecc1a61ef6a042f67ab37b619118eb45a
2017-03-10 15:03:07 -05:00
Edouard Oger 812a782093 Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : e5ace2f6dfd828c14edfd3f3d84da2b5043361b2
2017-03-09 15:53:08 -05:00
Mathieu Leplatre 0d98f89e16 Bug 1343216 - Add blocklist tags in xpcshell tests r=kmag
MozReview-Commit-ID: 8HDgdSSFxyU

--HG--
extra : rebase_source : 49a73ffcd60ea9f770ad7bc600512be19551fe5e
2017-03-02 11:23:24 +01:00
Wes Kocher 0cca2c83d5 Backed out changeset 9c8eac7852f6 (bug 745410) for build failures a=backout
MozReview-Commit-ID: JY6fS63iCwJ
2017-03-10 13:19:34 -08:00
Edouard Oger 5e9bd0d28b Bug 745410 - Remove microsummary support from Sync. r=kitcambridge
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 184b254f3299209f98cfc50f6630050a2ca29ab1
2017-03-10 15:03:07 -05:00
Wes Kocher 4894923a57 Backed out changeset 805da5d5567f (bug 1269277) for failures in browser_device_connected.js and browser_aboutAccounts.js a=backout
MozReview-Commit-ID: 1xafqaoxNWG
2017-03-10 12:31:13 -08:00
Edouard Oger a28ba6f4da Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : 048e6b5ede97b4908a65997cb674153c5e34c21d
2017-03-09 15:53:08 -05:00
Thom Chiovoloni 577f26289e Bug 676563 - Add dateAdded field to synced bookmarks r=markh,rnewman
MozReview-Commit-ID: 5dxoTGrypqm

--HG--
extra : rebase_source : 94af07afc4c0ae2faccc33247fa8f2df91683cce
2017-01-17 14:45:08 -05:00
Edouard Oger baba07044d Bug 1317667 - Use dates further in the future in test_bookmark_duping. r=kitcambridge
MozReview-Commit-ID: 3R3tbbzio2I

--HG--
extra : rebase_source : f87d2261859ff7195e795e2e2ba4c5285536e6cf
2017-02-27 11:44:22 -05:00
Gijs Kruitbosch b0f2da2a20 Bug 1341097 - part 3: don't dispatch oodles of titlechanged notifications for new history entries, r=mak
MozReview-Commit-ID: 7jHOcCQ5ZBb

--HG--
extra : rebase_source : 6dff335e78857e7c860ebe7ec6ea415fe0f9e3f6
2017-02-27 18:26:21 +00:00
Masatoshi Kimura 7be7b11a1c Bug 1342144 - Remove version parameter from the type attribute of script elements. r=jmaher
This patch is generated by the following sed script:
find . ! -wholename '*/.hg*' -type f \( -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \) -exec sed -i -e 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;

MozReview-Commit-ID: AzhtdwJwVNg

--HG--
extra : rebase_source : e8f90249454c0779d926f87777f457352961748d
2017-02-23 06:10:07 +09:00
Jorg K d3e766737e Bug 1341983 - Skip test_blocklist_certificates.js for Thunderbird. r=leplatrem
--HG--
extra : rebase_source : c8f43e08a21c0f071170834dbba7448c906fe17d
2017-02-22 22:28:00 -05:00
Kit Cambridge ffd9158f97 Bug 1335752 - Disable persistence and clean up after `RotaryEngine` in tests. r=markh
MozReview-Commit-ID: 8feE9O6Dv3W

--HG--
extra : rebase_source : c01eed08e72fd4ff654b3afed0472cb5185aec4e
2017-02-13 13:48:08 -08:00
Kit Cambridge a0eae5b8e4 Bug 1335752 - Remove all observers when finalizing the tracker. r=markh
MozReview-Commit-ID: CKc19VAO9WW

--HG--
extra : rebase_source : 804897e8a18e740483fa96e980ee63a76fa2616a
2017-02-13 13:16:30 -08:00
Thom Chiovoloni c396116b69 Bug 1337993 - Ensure we mark all current bookmarks for reupload when bookmark engine enabled state changes. r=kitcambridge
MozReview-Commit-ID: 4gOmqrzUr77

--HG--
extra : rebase_source : ee645449c2bb08cc13a6b9040a0bbdd506d5c0a3
2017-02-13 14:28:06 -05:00
Edouard Oger 54ace62c98 Bug 1244622 - Add "Show More/All" (tabs) buttons in the Synced Tabs menu. r=markh
MozReview-Commit-ID: 7z9fTVCDGgF

--HG--
extra : rebase_source : 99afed681759d8f65605f6c11a8b0c72e8012888
2017-02-06 16:31:31 -05:00
Thom Chiovoloni 7586d15716 Bug 1336186 - Check separator position in sync bookmark validator. r=markh
This reverts bug 1276152.

MozReview-Commit-ID: Cdv4XPYl4cp

--HG--
extra : rebase_source : 985e68e3908ed2abe080e7d0d9ae0c1ce338f5fe
2017-02-15 16:30:59 -05:00
Mathieu Leplatre 8e621b659c Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
MozReview-Commit-ID: D53xoTa0PZu

--HG--
extra : rebase_source : a4aa143c627df0f70c15fd3589cde7a49e30d80d
2016-12-11 14:37:22 -10:00
Ethan Glasser-Camp bf7f47db2b Bug 1328974: Record metrics for chrome.storage.sync usage, r=bsmedberg,kmag
MozReview-Commit-ID: 7c2CHLuXxS6

--HG--
extra : rebase_source : f56bf58bfdf2f3ecb7fb5dbe8ee22d3a3569ae34
extra : source : c48083c4b41537af44a38722e64d8e10987ba199
2017-01-17 13:25:02 -05:00
Carsten "Tomcat" Book 9857d2af8e merge mozilla-inbound to mozilla-central a=merge 2017-02-20 14:05:25 +01:00
Mark Hammond 7b4704dcc1 Bug 1319972 - write a session ID to sync logs. r=tcsc
MozReview-Commit-ID: GY8tvMVJ0p1

--HG--
extra : rebase_source : 757c31ada9c14633076fc0d4bfac59234913f1b6
2017-02-17 15:38:11 +11:00
Mark Hammond cd73a70071 Bug 1340357 - remove all special eslint rules in services/. r=eoger
MozReview-Commit-ID: 6zMOBoWLOhJ

--HG--
extra : rebase_source : cf546abd9a52230746c0c05f7bb716cae42815bf
2017-02-17 12:34:45 +11:00
Edouard Oger 1f7391754c Bug 1337244 - Delete previous device registration when setting-up a new FxA user. r=markh
MozReview-Commit-ID: wp4OJ1nwKH

--HG--
extra : rebase_source : 31cc6e6c40c9f0b0e6efa76032a5ae5c75281306
2017-02-14 20:07:36 +01:00
Carsten "Tomcat" Book b218b4c6ae merge mozilla-inbound to mozilla-central a=merge 2017-02-16 13:15:55 +01:00
Wes Kocher 0240235e36 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 2KYT7x0b6I1
2017-02-15 19:17:03 -08:00
Phil Ringnalda 8f2ba061cd Backed out changeset 63d0ef447e81 (bug 1224528) for Android permaorange in test_blocklist_certificates.js 2017-02-15 19:07:26 -08:00
Wes Kocher 3797956aa6 Merge m-c to inbound a=merge
MozReview-Commit-ID: BemR756HJnR
2017-02-15 16:33:03 -08:00
Mayank Srivastav dcffae55e6 Bug 1337188 - Remove unused return statement from EngineManager::register. r=kit
--HG--
extra : rebase_source : a8eea63dc3b2c208ed8ffc3ac6d0ae36e8ec8489
2017-02-15 00:42:10 +05:30
Wes Kocher ed4e580ba8 Merge m-c to autoland, a=merge
MozReview-Commit-ID: LcH4J3J7fcL
2017-02-15 19:17:26 -08:00
Ethan Glasser-Camp b228d5b47d Bug 1321570 - use dependency injection for fxAccounts, r=kmag
Get rid of the ugly hack where test code monkeypatches a singleton to
convince the rest of the ExtensionStorageSync code that a fake user is
logged in. Instead, take a handle to the fxAccounts service at
construction time. Test code can provide any kind of fxAccounts it
wants, including one that has a hard-coded user.

This provokes a bunch of changes:

- ExtensionStorageSync is now no longer a singleton, but a class. You
  have to instantiate it in order to do anything with it. A global
  instance extensionStorageSync is provided for use by Sync code as
  well as WebExtension code.

- CryptoCollection is now also a class, and each ExtensionStorageSync
  instance has its own CryptoCollection. This dependency should maybe
  also be injected, but for the time being it doesn't provide us any
  value to do so.

- Converting singletons with asynchronous methods to classes is a pain
  in the neck. We convert async method foo from `foo:
  Task.async(....)` to `async foo() { .... }`. While we're here,
  convert KeyRingEncryptionRemoteTransformer#decode to async/await to
  eliminate a need for `let self = this`.

- Update Sync code and WebExtension code to use extensionStorageSync.

- There's a cyclic dependency where CryptoCollection#sync depends on
  ExtensionStorageSync#_syncCollection which depends on
  CryptoCollection#getKeyRing. As a short-term hack, we now require an
  ExtensionStorageSync argument to CryptoCollection#sync.

- KeyRingEncryptionRemoteTransformer now takes a handle to fxAccounts
  on construction time as well. Because this is the only
  EncryptionRemoteTransformer subclass that accesses fxAccounts, we
  can get rid of the hack where the tests monkeypatch something in the
  EncryptionRemoteTransformer prototype.

- CollectionKeyEncryptionRemoteTransformer now takes a handle to a
  CryptoCollection, rather than relying on a global one.

- A bunch of methods that previously assumed access to fxAccounts now
  check if fxAccounts is present (i.e. if we're on Android). Strictly
  speaking, this isn't required by this change, but it helps make
  certain kinds of failure a little easier to diagnose.

- Update tests, including extracting a domain-specific helper method
  to hide the use of CollectionKeyEncryptionRemoteTransformer. We now
  no longer monkeypatch in our mock fxaService, but pass it to the
  test so that it can do whatever it wants with it. We also provide an
  ExtensionStorageSync instance for convenience. Access to the global
  cryptoCollection is now done through an ExtensionStorageSync
  instance.

To summarize, we've gone from a situation where a bunch of singletons
had implicit dependencies on other singletons in a shared global
namespace, to a situation where dependencies are provided explicitly
using method/constructor arguments. This highlights some of the
dependencies present:

- ExtensionStorageSync depends on CryptoCollection and fxAccounts if
  it needs to sync

- Every collection created via openCollection needs a handle to
  CryptoCollection so it can correctly create its remote transformers

- CryptoCollection needs a handle to fxAccounts so it can create its
  own remote transformer for its special collection

Most of this is only possible, or at least much easier, because we no
longer try to juggle Sqlite connections but just keep one around
forever.

However, please note:

- CryptoCollection needs a handle to ExtensionStorageSync to actually
  perform syncing logic because that's where we foolishly put the
  logic to make requests

- There's still a backing Sqlite store which is shared by everything

- There's still a singleton tracking contexts that opened extensions
  which we manage to try to clean contexts up correctly

MozReview-Commit-ID: DGIzyRTdYZ1

--HG--
extra : rebase_source : 305a98b8e1ece3ae7a5e8a2fdb5c58d8e7c496d9
2017-01-10 16:44:01 -05:00
Ethan Glasser-Camp 4f7afb05a6 Bug 1321570 - Move ExtensionStorageSync crypto out of services/sync, r=kmag
Since services/sync doesn't ship on Android, this meant
conditionally-defining some variables such as `cryptoCollection` and
`CollectionKeyEncryptionRemoteTransformer` depending on whether or not
we were on Android. However, none of these definitions really rely on
functionality that isn't present on Android (although you can't really
use them yet either). Move the dependency together with the dependant
code so we can simplify a bit. This lets us remove conditional uses of
`cryptoCollection` and `CollectionKeyEncryptionRemoteTransformer`.

Because the WebExtensions source directory has more stringent eslint
rules, we end up reformatting and commenting a bit in addition to
moving.

MozReview-Commit-ID: 2ddDeymYFNi

--HG--
rename : services/sync/tests/unit/test_extension_storage_crypto.js => toolkit/components/extensions/test/xpcshell/test_ext_storage_sync_crypto.js
extra : rebase_source : f84c0810b6a447f2104f96c9dc9d6139743f269c
2017-02-13 15:06:02 -05:00
Jonathan Hao ef8f78b212 Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
--HG--
extra : rebase_source : e4a69e18154adf22e045c820ae2b3fd8a77877a6
2017-02-08 11:17:29 +08:00
Mathieu Leplatre 870ef630b6 Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
MozReview-Commit-ID: D53xoTa0PZu

--HG--
extra : rebase_source : 48481994fc4aa6afcd7ef46ac62861fc1ad6b281
2016-12-11 14:37:22 -10:00
Wes Kocher 3e40dccbed Backed out changeset 174570c9ca6b (bug 1321740) for browser_sanitizeDialog.js failures a=backout
MozReview-Commit-ID: 8zmWz4JBCVk
2017-02-15 15:02:59 -08:00
Thom Chiovoloni f38291dc93 Bug 1321740 - Avoid a full sync after signing in due to fxa reauthentication. r=markh
MozReview-Commit-ID: 8wVq1RYojUS

--HG--
extra : rebase_source : 1ed0c32fa992c7248b096bdd05e9c255930f3746
2017-02-08 16:35:00 -05:00
Phil Ringnalda aa72959f4e Bug 1338439 followup, placate eslint 2017-02-12 20:50:46 -08:00
Mark Hammond e23f30ffed Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands. r=tcsc
MozReview-Commit-ID: 7a6qjRUswGL

--HG--
extra : rebase_source : a6112f4fb8762f3cde4a85aaa5ef4a8d11b15947
2017-02-10 16:49:33 +11:00
Kit Cambridge e73b9cdef7 Bug 1338668 - Ignore tag query folder IDs when comparing client and server bookmark records. r=tcsc
MozReview-Commit-ID: 2Mz9fTsTou5

--HG--
extra : rebase_source : e2030c91a20356d61677a212fa57f88d680bfb90
2017-02-10 15:03:34 -08:00
Ethan Glasser-Camp 3a3e213b7d Bug 1333810: Hash record IDs during encryption, r=kmag,rnewman
This does a sha256 of record IDs, the same way we do for collection
IDs, during encryption.

The way we compute the new ID (using an overridden method) is a little
bit of a hack, but we use the new ID as part of the HMAC. This also
invalidates a previous assumption, which is that we kept record IDs
the same during decryption.

MozReview-Commit-ID: Gbzlo9OE1he

--HG--
extra : rebase_source : 3a303cce50e60ecf0cd709da4ebef5ff98bff314
extra : intermediate-source : 033163eeac84466553d4f9636093c3b824d7cf2b
extra : source : c5c115baff4a729b064e74e87821f7ee3b9d3edb
2017-01-31 13:09:38 -05:00
Ethan Glasser-Camp e9fb891837 Bug 1333810: Encrypt record deletes, r=kmag,rnewman
Camouflage deletes as updates, according to the rules given by the new
RemoteTransformer contract.

MozReview-Commit-ID: CwVJSs2jOil

--HG--
extra : rebase_source : 88f8e1b4db0b6b7aea4ae5dcfc67af906cb01009
2017-01-27 19:27:10 -05:00
Ethan Glasser-Camp 6128dd8aef Bug 1333810: Update kinto.js version to 8.0.0, r=MattN
This allows us to transform deletes. See
https://github.com/Kinto/kinto.js/pull/640/.

MozReview-Commit-ID: 3EWcxW4Ny6s

--HG--
extra : rebase_source : 67cd78dcde8a220c7939486599f315c93b9092dc
2017-01-27 19:23:05 -05:00
Phil Ringnalda b5acb9b812 Backed out 2 changesets (bug 1336867) for (at least) eslint failures
CLOSED TREE

Backed out changeset 0a4f283638cb (bug 1336867)
Backed out changeset 837766805d75 (bug 1336867)

--HG--
rename : security/manager/ssl/tests/unit/test_sts_parser.js => security/manager/ssl/tests/gtest/STSParserTest.cpp
2017-02-09 19:02:32 -08:00
Jonathan Hao e28cb314a8 Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
--HG--
extra : rebase_source : 3b14ddfcb4107eeeb15ba5498d0b516310847c58
2017-02-08 11:17:29 +08:00
Wes Kocher 30d9ef4d29 Merge m-c to autoland, a=merge
MozReview-Commit-ID: D76dMYwFRUQ
2017-02-09 17:06:59 -08:00
Aman Dwivedi 8596d20f5f Bug 876002 - Remove nsIFormHistory2 so no synchronous form history code remains, r=markh.
MozReview-Commit-ID: 4hNAqttRddP

--HG--
extra : rebase_source : a206e30f11e8a625c29898f04498e2da628c2b91
2017-02-08 22:50:00 +01:00
Wes Kocher 6ff8201ffe Merge inbound to central, a=merge
MozReview-Commit-ID: 4mN7daXzULJ
2017-02-08 16:08:42 -08:00
Edouard Oger 5aba6580c8 Bug 1332556 - Set correct passwords' timestamps on first Sync. r=markh
MozReview-Commit-ID: Izg9sIeGNJo

--HG--
extra : rebase_source : 079f73e0e09bf9969989bb72d82736291dbe83dc
2017-02-07 12:56:56 -05:00
Ahsan 39fbeac36e Bug 1336282 - Moved bookmark frecency query into `PlacesSyncUtils`. r=kitcambridge
MozReview-Commit-ID: 4DDXOUQ2C8N

--HG--
extra : rebase_source : b4d1785e126b87672fc064dee329a791977b1372
2017-02-09 12:28:26 -08:00
Mayank Srivastav ccf5a4ca8d Bug 1333431 - Fixed ERROR_PARSE thrown on 304 response when fetching profile. r=eoger
MozReview-Commit-ID: KJPvZeU10xP

--HG--
extra : rebase_source : faaa2f7bc49d0aefd85e0f0846076290f71998c8
2017-02-07 23:25:01 +05:30
Phil Ringnalda 3063243dfc Bug 1323867 followup, placate eslint 2017-02-07 16:20:31 -08:00
Kit Cambridge 1e92ba873d Bug 1323867 - Bump bookmark validation threshold to 1k. r=tcsc
This patch also refactors `compareServerWithClient` and
`inspectServerRecords` to periodically yield back to the main thread,
since validating a large number of bookmarks in a tight loop causes
jank. Yielding every 50 records for 50ms is somewhat arbitrary, but
keeps things snappy for my profile (2947 records).

MozReview-Commit-ID: 99DJtNvNeHI

--HG--
extra : rebase_source : cc0991106c17ce906b8779afbe9eced0e27cc4b4
2017-01-12 14:02:45 -07:00
Kit Cambridge 912d625cf7 Bug 1325523 - Persist tracked IDs on finalization, and don't persist IDs in Sync tests. r=markh
MozReview-Commit-ID: CpQP2aM1DO

--HG--
extra : rebase_source : 02fa555cc44bd9d94a6c3beedf00fa1746f0c637
2017-02-07 11:51:06 -08:00
Sebastian Hengst 0264cdf6be Bug 1336311 - Change code comments with http://hg.mozilla.org to https://. r=gps
For components also referencing it in code, see the blockers of bug 1336311.

MozReview-Commit-ID: 4tUZ24HKBWy

--HG--
extra : rebase_source : ec16149f525b9b7eaca7f96f1369929d21497121
2017-02-07 17:52:56 +01:00
Mark Hammond f02fca824e Bug 1310065 - use more reliable preferences for calculating the client count in the sync scheduler. r=eoger
This patch switches to using preferences written by the clients engine to
determine the number of clients so it's correct before the first sync for
a browser session.

It also fixes another bug I discovered - if a mobile device dropped from the
client list, the preference for the number of mobile devices would remain at
1 rather than resetting to zero.

MozReview-Commit-ID: IPythSQcorx

--HG--
extra : rebase_source : 4ce465e3958d037f90312553a0c353cdc161c0fe
2017-01-25 18:11:05 +11:00
Edouard Oger 809b455084 Bug 1332858 - Alternate wording for Sync new device connected notification when device name missing. r=markh
MozReview-Commit-ID: DdwrRGjwI3

--HG--
extra : rebase_source : 9740cd1fb21fd411c73d8a29e5c3ae31bf11bcb0
2017-02-02 15:49:03 -05:00
Mathieu Leplatre 7c91ae078a Bug 1331629 - Handle Backoff header in blocklist updater (r=mossop)
MozReview-Commit-ID: 21KOLxvCC4W

--HG--
extra : rebase_source : fec6948ea0f2cbb18be1fe5f799353ec09e4aa33
2017-01-19 15:40:26 +01:00
Mathieu Leplatre 0291baa3c0 Bug 1331629 - Reuse the same kinto client instance accross syncs (r=mgoodwin)
MozReview-Commit-ID: F8Fhy9TzPTG

--HG--
extra : rebase_source : 039b099e3c6d1a7f312e3cd209e8cea317f58a32
2017-02-06 10:35:26 +01:00
Edouard Oger cfc8f37c1b Bug 1317667 - Use async bookmark methods in test_bookmark_duping. r=kitcambridge
MozReview-Commit-ID: CpvcDXKkfcl

--HG--
extra : rebase_source : 4d143bdf9af7727933a74a9f05c7a56baa5c321b
2017-02-03 13:52:39 -05:00
stefanh@inbox.com 3e60e56c26 Bug 1333485 - Remove LogUtils.jsm from services/crypto/modules/. r=markh. 2017-02-01 20:55:09 +01:00
Edouard Oger f7e895d911 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : 71c2a627bd0291fa2b9448710e6b0eb1fae36719
2017-01-24 17:05:12 -05:00
Sebastian Hengst 573326d526 Backed out changeset 20863de3b8f4 (bug 1329850) for eslint failure: redeclaration of collection in deeper scope in test_syncengine_sync.js. r=backout 2017-01-31 18:46:39 +01:00
Edouard Oger ecdeb55693 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : bce1d12bf1fdb7867ac0f290fdfe4e6b5d761bcc
2017-01-24 17:05:12 -05:00
Mark Banner 8cf0d4744c Bug 1333044 - Enable no-undef eslint rule for services/. r=markh
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 72df6ddc457431ae77f953a00712462e4902b5f1
2017-01-23 15:15:05 +00:00
Mark Banner df3fdf012f Bug 1333044 - Fix no-shadow issues in services/. r=markh
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : b93a673073045ddfec6e4b4b347b4e8494425310
2017-01-23 14:07:55 +00:00
Mark Banner 2ecc79b536 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : c4b19fe3714b19b445011ae1c413ca0e624cb46e
2017-01-17 12:25:43 +00:00
Wes Kocher 7cd28f7e5d Merge inbound to central, a=merge
MozReview-Commit-ID: HvoljuLV6Gj
2017-01-27 16:37:18 -08:00
Edouard Oger 1d38375171 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh
MozReview-Commit-ID: E4S5xYTNDIH
2017-01-27 13:31:58 -05:00
Edouard Oger ffa8a4f046 Bug 1296767 part 12 - Remove Weave.fxAccountsEnabled. r=markh
MozReview-Commit-ID: L4dM9xN2ELp
2017-01-27 13:31:58 -05:00
Edouard Oger ad36606986 Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh
MozReview-Commit-ID: Kmsxn10sA2X
2017-01-27 13:31:58 -05:00
Edouard Oger 7314dabc8c Bug 1296767 part 10 - Remove FxA Migration code. r=markh
MozReview-Commit-ID: DamrbblcMmZ
2017-01-27 13:31:58 -05:00
Edouard Oger 3844e92a36 Bug 1296767 part 8 - Remove legacy Sync in-content pref screens. r=markh
MozReview-Commit-ID: Blpdd3jeeww
2017-01-27 13:31:58 -05:00
Edouard Oger f5eb6dc494 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1
2017-01-27 13:31:57 -05:00
Edouard Oger ea99e4442d Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh
MozReview-Commit-ID: 7YDYTCRiKZa
2017-01-27 13:30:48 -05:00
Edouard Oger cdce850c10 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh
MozReview-Commit-ID: 12pP01IHRyp
2017-01-27 13:30:48 -05:00
Edouard Oger df80e282e9 Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh
MozReview-Commit-ID: AFRyZFW6xZU
2017-01-27 13:30:48 -05:00
Edouard Oger bf4dae4e25 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh
MozReview-Commit-ID: IC7kRjgtPp8
2017-01-27 13:30:47 -05:00
Edouard Oger c94655827a Bug 1296767 part 2 - Remove Sync UserApi. r=markh
MozReview-Commit-ID: CdgLxCN52Os
2017-01-27 13:30:47 -05:00
Edouard Oger bb525e4654 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh
MozReview-Commit-ID: iD4OJv436i
2017-01-27 13:30:47 -05:00
Florian Quèze b11907c7aa Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Florian Quèze 0cb03c69e1 Bug 1334156 - replace ownerDocument.defaultView usages by hand in a few places, r=jaws. 2017-01-27 10:51:02 +01:00
Phil Ringnalda 39e57631eb Merge m-c to m-i 2017-01-25 20:48:39 -08:00
Kit Cambridge 009412ee92 Bug 1332024 - Finalize tracker storage and consolidate cleanup logic in engine tests. r=markh
MozReview-Commit-ID: 8t9bXFrLA1Z

--HG--
extra : rebase_source : 51e15f6cc8fd44947f42cc59be413df6775291b0
2017-01-24 09:59:09 -08:00
Edouard Oger 8561ffa3a2 Bug 1319433 - Bump tabs engine TTL to 21 days. r=markh
MozReview-Commit-ID: GdEZkQEdZMD

--HG--
extra : rebase_source : 949e172445996b71271788d11cf136bef95254f8
2017-01-23 11:05:41 -05:00
Carsten "Tomcat" Book aaafcb0f0a Backed out changeset f8b29e24280b (bug 1333044) for perma failures in test_load_modules.js
--HG--
extra : rebase_source : ef649da0bb1acaabcb55a42e5df4164f1cf8b6d4
2017-01-25 15:29:53 +01:00
Carsten "Tomcat" Book f868542f9b Backed out changeset 06a658a93aab (bug 1333044)
--HG--
extra : rebase_source : 554fed79a1c36ce418ab95952cde9669a3297cb6
2017-01-25 15:29:35 +01:00
Carsten "Tomcat" Book a6178c3af9 Backed out changeset 9c6b98edac72 (bug 1333044)
--HG--
extra : rebase_source : e81a05f7fa7ffca19ced3e0aca62ada7bde935b2
2017-01-25 15:29:33 +01:00
Carsten "Tomcat" Book 514a5e3a68 Backed out changeset d1f3d30546a1 (bug 1333044)
--HG--
extra : rebase_source : 272f382a06733b065cec30d2bdcec282ef847297
2017-01-25 15:29:31 +01:00
Mark Banner 605ae8736f Bug 1333044 - "Enable eslint no-undef for services/" a=tomcat 2017-01-25 05:09:00 +01:00
Carsten "Tomcat" Book ff34e66ec7 Merge mozilla-central to autoland 2017-01-25 13:52:18 +01:00
Florian Quèze 0e0865f4fc Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Mark Banner eb102a103e Bug 1333044 - Enable no-undef eslint rule for services/. r=markh
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 19e5895756579ecf88d5be70e8aaaf8c3166ada1
2017-01-23 15:15:05 +00:00
Mark Banner caa2f51ce1 Bug 1333044 - Fix no-shadow issues in services/. r=markh
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : 32511d0a015fe57f0b8262b0faa28dbd4bd7a623
2017-01-23 14:07:55 +00:00
Mark Banner 33c00194c2 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : 9b5edc75897af35754433b6fccfcecf83293c62b
2017-01-17 12:25:43 +00:00
Phil Ringnalda bf98cd4315 Merge m-i to m-c, a=merge 2017-01-24 18:53:29 -08:00
stefanh@inbox.com caff960805 Bug 1313045 - Remove toolkit/identity, part2: Move used files/bits to services/crypto and remove remaining files in toolkit/identity. r=MattN.
--HG--
rename : toolkit/identity/IdentityCryptoService.cpp => services/crypto/component/IdentityCryptoService.cpp
rename : toolkit/identity/nsIIdentityCryptoService.idl => services/crypto/component/nsIIdentityCryptoService.idl
rename : toolkit/identity/LogUtils.jsm => services/crypto/modules/LogUtils.jsm
rename : toolkit/identity/jwcrypto.jsm => services/crypto/modules/jwcrypto.jsm
rename : toolkit/identity/tests/unit/test_crypto_service.js => services/crypto/tests/unit/test_crypto_service.js
rename : toolkit/identity/tests/unit/test_jwcrypto.js => services/crypto/tests/unit/test_jwcrypto.js
2017-01-23 20:43:35 +01:00
stefanh@inbox.com f28e3f1e0d Bug 1313045 - Remove toolkit/identity, part1: Remove unneeded files/bits. r=MattN. 2017-01-23 20:20:54 +01:00
Phil Ringnalda 8a8c8d9816 Merge autoland to m-c, a=merge 2017-01-23 18:42:45 -08:00
ffxbld ed04f7a449 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2017-01-23 15:38:06 +00:00
Thom Chiovoloni c197835bcf Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh
MozReview-Commit-ID: 3ybnskOID1O

--HG--
extra : rebase_source : 3faec9e53939626dc89c039706aaa2f003571d18
2017-01-17 13:15:49 -05:00
Edouard Oger d22c7ab8ed Bug 1332993 - Do not write logs on FxA profile 304 response. r=markh
MozReview-Commit-ID: Hf5d6rz8HNQ

--HG--
extra : rebase_source : f51a3a9b1fb0c4f5e6c56114e289f67ee99b315f
2017-01-23 11:25:04 -05:00
Sebastian Hengst 461878052c Backed out changeset ccc602619a07 (bug 1332993) for failing xpcshell test test_accounts.js at least on Linux. r=backout on a CLOSED TREE 2017-01-24 18:34:08 +01:00
Edouard Oger 274682c188 Bug 1332993 - Do not write logs on FxA profile 304 response. r=markh
MozReview-Commit-ID: Hf5d6rz8HNQ

--HG--
extra : rebase_source : 5861ee29ff229b44f999119d95a94ba673f22e2e
2017-01-23 11:25:04 -05:00
aleth 05bfbf26be Bug 1333692 - Disable nsIIdentityCryptoService and jwcrypto tests for TB as these modules are only used by FxAccounts. r=MattN. 2017-01-25 18:47:57 +01:00
Wes Kocher c3cc3b6407 Backed out 13 changesets (bug 1296767) for xpcshell failures a=backout CLOSED TREE
Backed out changeset 41ed77788333 (bug 1296767)
Backed out changeset 1c0c9289b532 (bug 1296767)
Backed out changeset 50294db1d871 (bug 1296767)
Backed out changeset 26c065f79c54 (bug 1296767)
Backed out changeset 0362a78d6978 (bug 1296767)
Backed out changeset 4e71cf94e4ee (bug 1296767)
Backed out changeset f6f59447d22a (bug 1296767)
Backed out changeset 6c9b792cc296 (bug 1296767)
Backed out changeset 46a52b10a868 (bug 1296767)
Backed out changeset 5d70d87d2a8f (bug 1296767)
Backed out changeset 8219686be6a2 (bug 1296767)
Backed out changeset 0a989b0cea67 (bug 1296767)
Backed out changeset 9f59a0b75c1f (bug 1296767)

MozReview-Commit-ID: 2XBNsd8JrZL

--HG--
extra : amend_source : 1afafaa8127fcebac31ce1d7743dc16872fa0522
2017-01-26 11:16:12 -08:00
Edouard Oger 1595b78c75 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh
MozReview-Commit-ID: E4S5xYTNDIH

--HG--
extra : rebase_source : 6a98b9503183bbf679622b00073d162fd3e4f5e4
2017-01-23 15:19:04 -05:00
Edouard Oger b0e947451a Bug 1296767 part 12 - Remove Weave.fxAccountsEnabled. r=markh
MozReview-Commit-ID: L4dM9xN2ELp

--HG--
extra : rebase_source : deec727f4fe7c2bc5858e7bfb6f0fecee7b2c45c
2017-01-19 14:53:37 -05:00
Edouard Oger f49ecb465d Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh
MozReview-Commit-ID: Kmsxn10sA2X

--HG--
extra : rebase_source : 87bebd2abc19a6b62647d4bcb48193765a3622e2
2017-01-19 13:19:33 -05:00
Edouard Oger 775061c90e Bug 1296767 part 10 - Remove FxA Migration code. r=markh
MozReview-Commit-ID: DamrbblcMmZ

--HG--
extra : rebase_source : 7356a6a99005ae702e90eb5d5e2f0cbee35ff861
2017-01-19 13:03:38 -05:00
Edouard Oger 0de554147f Bug 1296767 part 8 - Remove legacy Sync in-content pref screens. r=markh
MozReview-Commit-ID: Blpdd3jeeww

--HG--
extra : rebase_source : c22ba5c1924b3dba15803f0adbf4026c72b47d68
2017-01-19 11:52:37 -05:00
Edouard Oger b41402ea7b Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1

--HG--
extra : rebase_source : b7113c37a486f88ae1138c54e314bb0ff07ef1af
2017-01-18 17:39:11 -05:00
Edouard Oger 17b83cde16 Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh
MozReview-Commit-ID: 7YDYTCRiKZa

--HG--
extra : rebase_source : 41574e70bd92ee2abe6f92a799c57e1f5910f8b4
2017-01-18 16:30:38 -05:00
Edouard Oger 9050cab070 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh
MozReview-Commit-ID: 12pP01IHRyp

--HG--
extra : rebase_source : 2c5af253df77ed08dd8bdf0c7645ed98e6a96c9a
2017-01-18 15:52:47 -05:00
Edouard Oger cfef81983f Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh
MozReview-Commit-ID: AFRyZFW6xZU

--HG--
extra : rebase_source : 6110e19a51d6d3375b47f785c8f644ee879fb924
2017-01-13 15:59:32 -05:00
Edouard Oger 49552f7919 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh
MozReview-Commit-ID: IC7kRjgtPp8

--HG--
extra : rebase_source : ec10c24400afa4b1c1fd3840f31a9d57d498ec8a
2017-01-13 15:02:21 -05:00
Edouard Oger eb0c42bf7a Bug 1296767 part 2 - Remove Sync UserApi. r=markh
MozReview-Commit-ID: CdgLxCN52Os

--HG--
extra : rebase_source : c270d7dfbaf621c1eb8f440009b361212969a8bc
2017-01-13 15:54:46 -05:00
Edouard Oger 0c915a6f46 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh
MozReview-Commit-ID: iD4OJv436i

--HG--
extra : rebase_source : 1653284a3b2e014719a7eb37588f99df868e2060
2017-01-10 13:47:24 -05:00
Valentin Gosu fd0c022031 Bug 1275746 - Fix tests that assume a HTTP url without a hostname is valid r=bz,MattN,jdm,markh
MozReview-Commit-ID: DzRenakrcAG
2016-07-07 16:20:47 +03:00
Phil Ringnalda 68b37a46e8 Merge m-i to m-c, a=merge 2017-01-20 19:00:04 -08:00
Jared Wein a1b9179389 Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh
MozReview-Commit-ID: 65EsZGCJPMD

--HG--
extra : rebase_source : 4dc9dddaa26d1c10f859dc7a08b64168a1d0fdd5
2017-01-12 18:28:48 -05:00
Jared Wein 95fba3cca3 Bug 1330791 - Enable the no-ex-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh
MozReview-Commit-ID: 8AsaN1gyjkm

--HG--
extra : rebase_source : 7f35d170620ce24fff5920d9376f46fc02e3817e
2017-01-12 18:27:39 -05:00
Jared Wein 02c3be3118 Bug 1330791 - Enable the no-cond-assign rule for eslint in /services. There are no associated errors with enabling this rule. r=markh
MozReview-Commit-ID: BM83kDZJpZ3

--HG--
extra : rebase_source : 3769dc72cfe5d0b328926d94bd7d45fc4d02a215
2017-01-12 18:27:00 -05:00
Jared Wein 285bebb13e Bug 1330791 - Enable the brace-style rule for eslint in /services and fix the associated errors. r=markh
MozReview-Commit-ID: Ebl3bODX14z

--HG--
extra : rebase_source : 20fe1d8043b04c53b9521bc0ad30b72ebf253062
2017-01-12 18:24:52 -05:00
Jared Wein bcf58381e1 Bug 1330791 - Enable the no-octal rule for eslint and fix the associated error. r=markh
MozReview-Commit-ID: LLYKmP7HOei

--HG--
extra : rebase_source : 7c4dbf5fa57f7ef38460a9bc071475a6ad70f18d
2017-01-12 18:21:43 -05:00
Jared Wein 516a926c6e Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh
MozReview-Commit-ID: 7ADLmPB4eSu

--HG--
extra : rebase_source : 94a966d6cbc5c2b6b6097355fc3aa84dd50e27f5
2017-01-12 18:19:47 -05:00
Jared Wein 49ca473486 Bug 1330791 - Enable the no-unreachable rule for eslint in /services and fix the associated errors. r=markh
MozReview-Commit-ID: e60hfjiUmS

--HG--
extra : rebase_source : 3a8687fcfe76687581dd8a43f3e7fc7089c5553a
2017-01-12 18:18:31 -05:00