Automatic update from web-platform-tests
Make a WPT for renameSync fail if renameSync is not implemented.
As a missing function gives a TypeError, one of the WPTs for renameSync
would pass when renameSync is not implemented, which is
counterintuitive.
Bug: 914488
Change-Id: I4c16cf55723b772b0cba5c5c3acd376165e25591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310531
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Richard Stotz <rstz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790754}
--
wpt-commits: c77e3a8040b5a2b09d0931f752077b3f14a3cb7e
wpt-pr: 24686
Automatic update from web-platform-tests
[NativeFS] Update async iterable API to match spec.
Matching the changes from https://github.com/WICG/native-file-system/pull/177
Since the bindings layer doesn't support async iterables yet, this CL
does this in a bit of a hacky way, that isn't entirely web-idl
compliant. It is much closer to the desired API than what we had though,
so seems an improvement until bindings properly support async iterables.
Bug: 1011539, 1087157
Change-Id: I2eb0a3b1d6383149b769a9961bf890eaf6956b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248414
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790486}
--
wpt-commits: 6dd4527974f68f3c904efb3910899ef641358c2e
wpt-pr: 24219
Automatic update from web-platform-tests
[FlexNG] Use block % resolution size when finding image preferred widths
Flex uses image preferred widths as flex-basis. When an image has
max-height:blah%, that can affect its preferred width. FlexNG wasn't
passing the percent resolution height to legacy for this calculation,
and the % max-height was being treated as auto.
ComputeMinAndMaxContentContribution was already doing this for replaced
elements, so piggy-back on that code.
Bug: 1107604
Change-Id: Icecb312ce8aee22cad6e4b1925aab77ecbd3c2ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309048
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790439}
--
wpt-commits: 29d3cd461ae5de247d09d945dfc275b1c82e2370
wpt-pr: 24676
Automatic update from web-platform-tests
NativeIO: Added a missing await in the WPT for rename.
Bug: 1097126
Change-Id: I3775c97543b4603e910f5cf4ec1f5a7207fd7276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308420
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Richard Stotz <rstz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790382}
--
wpt-commits: 9504f3a0aeef4c3a92b0e7aed3b54da3e2336e99
wpt-pr: 24684
Automatic update from web-platform-tests
When SVGGeometryElement.getPointAtLength is called with with non-rendered, throw exception
getPointAtLength[1] on SVGGeometryElement should throw InvalidStateError
for with non-rendered, so this patch throws InvalidStateError if there is no LayoutObject on the target element.
[1] https://svgwg.org/svg2-draft/types.html#__svg__SVGGeometryElement__getPointAtLength
Bug: 972979
Change-Id: I26eb5330127ebbca9fbf55d796ce8159a09bfcb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147168
Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790367}
--
wpt-commits: c04dcf9876cb706a3b25ff95c2ca104c8454112a
wpt-pr: 24013
Automatic update from web-platform-tests
Python 3: Use byte type for content (#24656)
In Python 3, strings are unicode. for non-ASCII characters it prepends
0xc2 for range[0x80, 0xbf] and 0xc3 for range[0xc0, 0xff]. This fix
is to use byte type for content to support both Python2 and Python 3.
--
wpt-commits: c3dd41faf41f5bbc3c5f6a5b001d5c3a056c831f
wpt-pr: 24656
Automatic update from web-platform-tests
Run sRGB Blob tests with multiple image formats
Run the sRGB Blob tests with multiple image file formats, not just PNG.
Change-Id: Ie404c85c2267e6f6bea888e205f180bc9c9a11d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305216
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#790206}
--
wpt-commits: d62995e62ca8653b4cf565e61c309471b544fab8
wpt-pr: 24652
Automatic update from web-platform-tests
Fix executor.html path in property.https.html
After the refactoring:
https://chromium-review.googlesource.com/c/chromium/src/+/2251999
The path for executor.html from property.https.html was incorrect. This
patch fixes it.
Bug: chromium:1090273
Change-Id: Ie6384ff1cd8d5227e65130ff6ab291f1c09769b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306098
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790041}
--
wpt-commits: 9a68a82ca3e679951c20e504cdf26113575f6952
wpt-pr: 24667
Automatic update from web-platform-tests
[wpt] Clean up --channel flag
Unify the two definitions of the --channel flag into one.
Drive-by: use logger in wpt.install isntead of print or sys.stdout.write
--
Remove the special case for FirefoxAndroid
There is no need to delay FirefoxAndroid.install() now that channel is
available to install().
Fix the definition of the Browser base class and update some docs. Also
add a test to make sure all subclasses are not abstract.
--
Update tools/wpt/tests/test_browser.py
Co-authored-by: Robert Ma <robertma@chromium.org>
--
wpt-commits: 9ddfd3cfc4239d82a429aed9c8aff6afb6035d36, 11787031d1257d4aea42d6506e90573298ab6b70, f85bd5cce97f04d357a361395750b3ce9149656d
wpt-pr: 24651
Automatic update from web-platform-tests
WebShare: Introduce web-share feature policy
share() requests fail with a rejected promise if the 'web-share'
feature is not enabled.
We define 'self' as the default feature policy for web-share.
The spec has been updated
https://github.com/w3c/web-share/pull/166
Intent to Ship
https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ
Bug: 1079104
Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789872}
--
wpt-commits: 1bd9297b8aa6870267c0c0ad1fa445f897ddecd7
wpt-pr: 24628
Automatic update from web-platform-tests
Fix mpadded-002.html baseline mismatch (#24663)
The previous change added baseline2, however it
was not correctly used in all places, this
fixes that.
--
wpt-commits: bcae2503904688ee1443c41746358d9620d45a31
wpt-pr: 24663
Automatic update from web-platform-tests
[fetch] Expose Request.body property.
This CL implements https://fetch.spec.whatwg.org/#body-mixin:
"""
Request includes Body;
The body attribute’s getter must return null if body is null and body’s stream otherwise.
"""
Since this feature is required for fetch upload streaming, this CL makes
it under the flag FetchUploadStreaming.
Fixed: 1105704
Change-Id: I334d9e1a3494ff4ba31efc9dc8b319294d2e19d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297035
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789852}
--
wpt-commits: 91723858b23e75cb18ddd58758b5c9cb54dd6db5
wpt-pr: 24644
Automatic update from web-platform-tests
Enable FontPreloadingDelaysRendering by default on trunk
According to the finch results on M83 Stable and the discussion, all
launch blockers of this feature have been cleared.
This patch first enables it on trunk. A followup internal CL will enable
it in other channels via finch configurations.
Bug: 1040632
Change-Id: Icd9ab4a85c9d755072310c1be4fc4e524133d6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296280
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789825}
--
wpt-commits: 8ef40c4007d5da834b25e79197cb8cb4c0a86a42
wpt-pr: 24638
Automatic update from web-platform-tests
[css-flexbox] Don't always reuse cached layout for row flex containers
CalculateSizeBasedLayoutCacheStatusWithGeometry checks if the cached
layout information can be reused. The problem was that, if a flex
container had a percentage height, and the size of its containing block
changed, a new layout would only be performed in case it was a column
flex container. For row flex containers, the cached layout would be
reused.
However, row containers may also need a new layout in some cases.
This patch removes the check for column flex containers, so that row
ones can be included too.
Bug: 1103592
TEST=external/wpt/css/css-flexbox/height-percentage-with-dynamic-container-size.html
Change-Id: Ib2c119febdfa56b31f5524be3df85c9749dd1f6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302997
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789788}
--
wpt-commits: 29ba1e01865ce5fb8ca21f37a0f13d394428de84
wpt-pr: 24653
Automatic update from web-platform-tests
Add @hoch as a suggested reviewer for webaudio/ (#24629)
--
wpt-commits: 669d0f3cdf71cc0fc2a338a91891565e493a5695
wpt-pr: 24629
Automatic update from web-platform-tests
Add in more references for css-color tests
--
wpt-commits: b47352d6c9860ff13c014fda37f35f88e8d935cb
wpt-pr: 8715
Automatic update from web-platform-tests
[PTZ] Put zoom behind the permission on Desktop
This CL makes sure zoom is put behind the panTiltZoom permission like
pan and tilt. The only exception is on Android where zoom is granted
automatically.
This CL also adds proper PTZ camera support on Android so that web
developers who specifically ask for zoom on an Android camera that does
not support it (e.g. infrared) get an OverConstrainedError.
Change-Id: I80a37e75d6eec7ab134b9296c222a6d450f26078
Bug: 1104080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279898
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#789756}
--
wpt-commits: 5934bd3aca20a07917ad46fe7cebe10c68d5e497
wpt-pr: 24449
Automatic update from web-platform-tests
Reland "[LayoutNG] Move relative position calculation into NG."
This reverts commit d73ae868f77e2589c7a563147722c9771bc91717.
The issue which caused the bot failures was due to a difference in
logic between 32bit, and 64bit arch. See:
https://chromium-review.googlesource.com/c/chromium/src/+/2304143
This patch has remained unchanged except for part which landed before
to fix another unrelated issue. See:
https://chromium-review.googlesource.com/c/chromium/src/+/2304659
Original change's description:
> Revert "[LayoutNG] Move relative position calculation into NG."
>
> This reverts commit 27880cb4012f7a84f7921c1bc3f023211eb032ea.
>
> Reason for revert:
>
> Suspect of blink_web_tests failures in a lot of bots, like this one:
>
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/70261
>
> Unexpected Failures:
> * fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
> * fast/css/relative-positioned-block-nested-with-inline-parent.html
> * paint/invalidation/compositing/composited-float-under-composited-inline-individual.html
> * paint/invalidation/compositing/composited-float-under-composited-inline.html
> * paint/invalidation/compositing/stacked-float-under-composited-inline.html
>
> Original change's description:
> > [LayoutNG] Move relative position calculation into NG.
> >
> > This patch moves the relative position calculation into NG. Previously
> > we needed to manually account for the relative position of an object
> > in many different places, overflow calculation, geometry APIs etc.
> >
> > This patch directly updates the child's offset (relative to its parent)
> > to directly incorporate this additional offset.
> >
> > This calculation occurs within the NGBoxFragmentBuilder, and if an
> > object is *placed* by LayoutNG...
> > ...LayoutBoxModelObject::RelativePositionOffset returns an empty offset.
> >
> > This fixes a few small issues where previously we didn't resolve
> > percentages against the correct available size when contained within
> > an anonymous block.
> >
> > Bug: 1070822, 1058690
> > Change-Id: I2c623b02cc5a4605d310596f5c60353a21236bff
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214608
> > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> > Reviewed-by: Koji Ishii <kojii@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#787991}
>
> TBR=yosin@chromium.org,wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,yosin@google.com,mstensho@chromium.org
>
> Change-Id: I5ca67701222509693d3020fa068c279cef39ecbb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1070822, 1058690
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296628
> Reviewed-by: Jian Li <jianli@chromium.org>
> Commit-Queue: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788228}
Bug: 1070822, 1058690
Change-Id: I85a51c06d47c9eb451e8e7b77418913e288b7758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300667
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789685}
--
wpt-commits: 421cc5ec61be5d407336a446b4da473c889ce518
wpt-pr: 24648
Automatic update from web-platform-tests
Apply |PostLayout| to |LayoutBox| instead of |LayoutBlockFlow|
|PostLayout| was limited to |LayoutBlockFlow| because
crbug.com/965639 could happen only to|LayoutBlockFlow|,
but following conditions have changed:
* Only |LayoutBlockFlow| could be relayout boundary, until
r772560 <crrev.com/c/2219312>.
* Only |LayoutBlockFlow| was laid out by LayoutNG, until
|LayoutNGFlexibleBox| inherits from |LayoutBlock|.
This patch changes |PostLayout| to work for |LayoutBox|.
In doing so, two changes were made:
1. |CurrentFragment| is replaced with |GetPhysicalFragment|
because the former is not available for |LayoutBox|.
2. Stopped checking |IsRelayoutBoundary|. Though it is the
only case crbug.com/965639 can happen as far as we're
aware of, checking |NGPhysicalFragment| is more
essential and sufficient.
The change 1 also helps <crbug.com/1061423>, but we may need
different approach to support block fragmentation.
Bug: 1102151, 965639
Change-Id: Id83be614066392a4c58c8b03bd16ee57ad82e145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302984
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789656}
--
wpt-commits: f140180e49e4f8aed5960855947c4273bbefd9eb
wpt-pr: 24646
Automatic update from web-platform-tests
Dynamically test javascript URL string return values in frames (#24589)
Test javascript URL string return values in direct and indirect (target) frame contexts.
--
wpt-commits: 75e2f5ed99d4da9ead4eda71b78bfe1ec17bad9f
wpt-pr: 24589
Automatic update from web-platform-tests
Make sure all methods have a correct name.
Adds an assertion to idlharness to check the name attribute of
methods, and fixes the bindings code to make sure we actually set the
name correctly.
Bug: 1106097, 1097814
Change-Id: I73dea7b96a94a9b2925c23156e6ef8146291cbc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300824
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789135}
--
wpt-commits: 0416c1f1ba812f28cf227830a692fd1c68b6e072
wpt-pr: 24621
Automatic update from web-platform-tests
[Sheriff] Revert "Deflake preservesPitch tests"
This reverts commit 7b6c4007896853f91f32bd69b2c770f0210c66e5.
Reason for revert:
Post this change, preservesPitch seems to consistently fail.
https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests
Original change's description:
> Deflake preservesPitch tests
>
> This CL changes preservesPitch tests to wait until the audioElement's
> currentTime is at least 0.5 seconds before trying to detect the pitch.
> Without this check, the test can try to detect the pitch before the
> audio has played enough, which can return a dominant frequency of 0Hz
> and fail the test.
>
> The CL also makes a few stylistic changes, and fixes an off-by-one error
> in the number of increments used to calculate frequencies.
>
> Bug: 1096238
> Change-Id: I6e98e172862a47bea1c4026737138293914f7906
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298281
> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788535}
TBR=tguilbert@chromium.org,foolip@chromium.org
Change-Id: I0042f73ca9c5de7d82be1200794c45b46a003f9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1096238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299183
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788626}
--
Reland preservesPitch test deflake, fix timeouts
This CL relands "Deflake preservesPitch tests", which was reverted by:
commit f19f3404371bba3cac38bf1bcf672ef5f3e96558.
It also attempts to incorporate some of the WPT changes made upstream,
but not yet landed, in:
https://github.com/web-platform-tests/wpt/pull/24599
Specifically, it fixes typos in the Safari prefixes, and explicitly
starts the audio context. However, it is different from the PR, since
it reuses the same Audio element, MediaElementAudioSourceNode and
AudioContext. This is an attempt to cut down on overhead costs and
fix test timeouts. We instead reset the audio.currentTime to 0, and
only create a new analyser node for each test.
Bug: 1105877, 1096238
Change-Id: Ie528ec0b7c38d9df59fcb04696c810e6d1c232f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300929
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789262}
--
wpt-commits: 9abf97af00b4a3f55ecba875bf1cdbecb4a1a1ee, 9a67b791ec7d9c6538411430677ac25eb6ef60b0
wpt-pr: 24606
Automatic update from web-platform-tests
[Trusted Types] JS event tracking for policy creation
Add a new event listener `beforecreatepolicy` to
TrustedTypePolicyFactory::createPolicy which allow
people to track or block the creation process for
Trusted Types.
Bug: 1075601
Change-Id: Ib885e7adc740999ba0e39037b7f4a90af6ff6aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260594
Commit-Queue: Yifan Luo <lyf@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789409}
--
wpt-commits: f037132d3a3332a873a34926ced24933a49251c0
wpt-pr: 24321