Automatic update from web-platform-tests
[LayoutNG] Only apply block-end margins where the block actually ends.
If we reached the end of a block in an earlier fragmentainer, but
there's overflowing content, we'll revisit this block in subsequent
fragmentainers as long as child content needs it. Repeating the
block-end margins in these fragmentainers would be wrong, though.
Use AdjustForFragmentation() only for margins, and rename it to
AdjustMarginsForFragmentation().
The fieldset layout algorithm was using this one for borders/padding,
while block and multicol layout called
AdjustBorderScrollbarPaddingForFragmentation() in container_builder_.
Become more uniform by calling that method for all in
SetupFragmentBuilderForFragmentation() (via the base layout algorithm
constructor). Since this depends on the initial fragment geometry being
set, also do that in the base layout algorithm constructor.
Bug: 829028
Change-Id: I6808d023e4e79ab489bdb3a48e3c6c47cf9db6c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287313
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786791}
--
wpt-commits: 931e5b7e2fe9818a7e15caa6378fabb00dbbca6a
wpt-pr: 24522
Automatic update from web-platform-tests
[WPT] Introduce a test-only-api helper script
including a helper function to load Mojo JS bindings. This will enable
us to have better control over loading of *.mojom.js (notably disable
automatic dependency loading) and reduce code duplication.
Refactor WebXR tests to use this helper script, and add missing
dependencies that were previously auto loaded. (WebUSB & WebBluetooth
changes to follow.)
Note that upstream WPT still does not have *.mojom.js available so tests
will continue to fail there (but with a clearer error). Test results on
Chromium waterfall should not change.
Bug: 1094512
Change-Id: If660c4788c185bc7baf9ce6edbb691333e509d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276652
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786746}
--
wpt-commits: 8d7104310d9fdb1b2eb6995219c31489d25010b5
wpt-pr: 24400
Automatic update from web-platform-tests
Actually remove six from Dockerfile
With #24484 removing the dependency on system six, we are now able to
remove it from the Docker image, which was introduced in #23733.
Removing this has the benefit of avoiding introducing accidental
dependency.
--
wpt-commits: dea212bda34384982165966b6085dc9f4ec20858
wpt-pr: 24514
Automatic update from web-platform-tests
Remove inaccurate assert (#24530)
The test and its title are right, but the assert doesn't describe it
well. Dropping it.
--
wpt-commits: 40ef02d00e6e4209a8c48d59f56952ad7654731c
wpt-pr: 24530
Automatic update from web-platform-tests
[css-text-3] Add letter-spacing tests written last October (#24516)
r=frivoal
--
wpt-commits: 3e6a569c8126d6782193ffec32fd501aa038c408
wpt-pr: 24516
Automatic update from web-platform-tests
Fix CSS typed OM CSSSkewX and CSSSkewY toMatrix method to use degrees instead of radians.
The toMatrix method of a CSSTransformComponent should return a DOMMatrix
representing the object transformation.
https://www.w3.org/TR/css-typed-om-1/#dom-csstransformcomponent-tomatrix
The skewXSelf and skewYSelf methods used to apply a transformation on a
matrix must be provided with an angle parameter expressed in degrees.
https://www.w3.org/TR/geometry-1/#dom-dommatrix-skewxselfhttps://www.w3.org/TR/geometry-1/#dom-dommatrix-skewyself
Since the angles passed to the skewXSelf and skewYSelf were in radians,
DOMMatrix returned by the toMatrix method of those two components was incorrect.
R=alancutter@chromium.org
Change-Id: I5edc1cdf1493184584154723508c6e20c212ac92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242008
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786632}
--
wpt-commits: f8d07d1a6788da6efee2913d5768528de28c9b57
wpt-pr: 24418
Automatic update from web-platform-tests
Revert "Do not expose media devices before a successful getUserMedia()"
This reverts commit d64e736aa8c7976b12b33f92472f7950bf0215b9.
Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680
Original change's description:
> Do not expose media devices before a successful getUserMedia()
>
> This is a spec-compliance change.
>
> This CL also adds some improvements to the blink MediaDevices unit test.
>
> Bug: 1101860
> Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786253}
TBR=hta@chromium.org,guidou@chromium.org
Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786615}
--
wpt-commits: 66a61640ed3a93fa0ddaf2aabe07193a17066b82
wpt-pr: 24528
Automatic update from web-platform-tests
Revert "Abstract portal activation handling to avoid hack of making a fake promise."
This reverts commit fdc228c7acab87083507a1276f9d8f786966f5d6.
Reason for revert: portal-activate-default.html test timeout failure
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/55803
Original change's description:
> Abstract portal activation handling to avoid hack of making a fake promise.
>
> This is somewhat verbose, but allows us to avoid the unhandled rejection
> being visible to script without having to make this hack even worse.
>
> Instead of actually calling activate(), this mirrors the spec structure
> by simply calling to underlying logic, passing a resolver where it makes
> sense and not (in this case, passing a substitute object) where it
> doesn't.
>
> Bug: 1102081
> Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Commit-Queue: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786480}
TBR=jbroman@chromium.org,adithyas@chromium.org
Change-Id: I00da9eee8625ca5da3a09efb7078e22a277dbfd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1102081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288712
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786596}
--
wpt-commits: 3c4df6d40bcb03edae052d0a37dc14291706c6a7
wpt-pr: 24526
Now that each driver supports the new window command, we can make use of it
as replacement for the create_window fixture.
Given that there is no need to check the type of the new window,
this implementation doesn't add a check for that.
Differential Revision: https://phabricator.services.mozilla.com/D83800
Forgot to follow up on these two remaining non-standard values that may have
been being used to reset a <meter> or <input type=number> back to its
original appearance, but which telemetry showed no usage of.
Differential Revision: https://phabricator.services.mozilla.com/D83598
This includes all of the <compat-auto> values, plus menulist-button,
which doesn't behave any differently from menulist currently.
Differential Revision: https://phabricator.services.mozilla.com/D83436
Uses of `-moz-appearance: none` are changed to `appearance: none`.
Uses of other values that are simply reverting the appearance back to
its default are changed to `appearance: auto`.
Uses of values in UA sheets that are defining the inherent appearance of
widgets are changed to:
appearance: auto;
-moz-default-appearance: <value>;
since those values are either no longer supported on (-moz-)appearance,
or are still supported but only in some limited form.
There are some uses of `-moz-appearance: textfield` on <input
type=number> elements that are renamed to `appearance: textfield`.
Differential Revision: https://phabricator.services.mozilla.com/D83430
It's possible that the dialog is closed while we are processing
the request, and we'd deferencing a null pointer for such case.
Differential Revision: https://phabricator.services.mozilla.com/D83531
dom.reporting.enabled is only set to true in Nightly. idlharness.any.worker.html is already set to fail across branches.
Differential Revision: https://phabricator.services.mozilla.com/D83273
Top layer / fullscreen should work in shadow dom. This check is off
compared to literally every other fullscreen check.
The test is pretty gross, but not my fault, see the comment in there :)
Differential Revision: https://phabricator.services.mozilla.com/D83198
We get a small amount of antialiasing-related "fuzz" on some platforms,
so those are noted in the corresponding .ini files.
Differential Revision: https://phabricator.services.mozilla.com/D82893
We get a small amount of antialiasing-related "fuzz" on some platforms,
so those are noted in the corresponding .ini files.
Differential Revision: https://phabricator.services.mozilla.com/D82893
Automatic update from web-platform-tests
Deduplicate and sort font-variation-settings when computing style.
Make interpolation type always run CSSValues through the converter for
this property.
Update remaining WPT tests to use order-invariant comparison (as most
tests for this property already use).
spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def
If the same axis name appears more than once, the value associated with
the last appearance supersedes any previous value for that axis. This
deduplication is observable by accessing the computed value of this
property.
resolution https://github.com/w3c/csswg-drafts/issues/1959
RESOLVED: For both font-variation-settings and font-feature-settings,
the computed value is a map (and thus specified dupes are removed)
Bug: 1005355
Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786564}
--
wpt-commits: 80883e4b131fc9d75959417deadcceba1bce1b59
wpt-pr: 24246
Automatic update from web-platform-tests
Remove containerName truncation, switch to use atomicString
As mentioned in Bug 1030396, the containerName attribute was first added in https://codereview.chromium.org/2515993002/ and it was truncated to 100 chars. The spec does not mention this truncation anywhere, see https://w3c.github.io/longtasks/.
In this PR, we removed undocumented containerName truncation, and changed member variables to use
atomicString instead of String.
Bug: 1030396
Change-Id: Ie1e7e6d7d1878ca16091a5f4db316d9c59368be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276680
Commit-Queue: Qiaofei Ye <qiaye@microsoft.com>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786484}
--
wpt-commits: 1378543f15bedb0365455795053c3b5cd1f08581
wpt-pr: 24508
Automatic update from web-platform-tests
[COOP] Make the failed output of reporting tests more stable in order to use expectations
Make the failed output of Coop reporting tests more stable in order to use expectations
Bug: 1099208
Change-Id: Ib1b516bc03295eb243d2db3c33ee4bc9db8b89df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279819
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786317}
--
wpt-commits: 724344fd9d5ff97b17b8ad5ff662c0abde2e818a
wpt-pr: 24435
Automatic update from web-platform-tests
Abstract portal activation handling to avoid hack of making a fake promise.
This is somewhat verbose, but allows us to avoid the unhandled rejection
being visible to script without having to make this hack even worse.
Instead of actually calling activate(), this mirrors the spec structure
by simply calling to underlying logic, passing a resolver where it makes
sense and not (in this case, passing a substitute object) where it
doesn't.
Bug: 1102081
Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786480}
--
wpt-commits: e96eb9029a884da59f3acf268dd589bc974a316a
wpt-pr: 24513
Automatic update from web-platform-tests
Finalize XRSpace.NativeFromMojo
All XRSpaces, except for XRReferenceSpaces, implement MojoFromNative and
their NativeFromMojo method is simply a wrapper to invert the other
method. Because the StageParameters's standing_transform property was
floor_from_mojo instead of mojo_from_floor, XRReferenceSpaces used
NativeFromMojo and MojoFromNative was the inverter.
This change renames (and inverts) StageParameters's standing_transform
to mojo_from_floor. This removes the need for child classes of XRSpace
to implement NativeFromMojo. XRSpace still implements this as a
(non-virtual) helper method, because some math operations require it,
and this provides a convenience wrapper around the inversion.
As noted, this does invert the existing meaning of standing transform,
so the runtimes needed to be updated.
Fixed: 1031598
Change-Id: Ia36fe21ea2c179acb4a0d1a7096c7e5271d7a3a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278317
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786454}
--
wpt-commits: 39ff1c92ab4bc0635e219069d6539036e7f96391
wpt-pr: 24503
Automatic update from web-platform-tests
Serialize delegatesFocus in getInnerHTML()
Prior to this CL, the getInnerHTML() call with includeShadowRoots=true
would not return markup with the shadowrootdelegatesfocus attribute.
Now, it does, and testing has been added to verify this behavior.
Bug: 1042130
Change-Id: Ibd859af110328b965e4c9a0074095a5a1e5251b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285288
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786393}
--
wpt-commits: e4a45e87eb85d4659b3c4d98340cc0befa901858
wpt-pr: 24500
Automatic update from web-platform-tests
Make system color keywords compute to themselves
Prior to this change, system color keywords would be resolved to RGBA
values at computed-value time. With this change, we defer resolution
until resolved-value time, to align with css-color-4.
The kernel of the change is in StyleBuilderConverter which allows for
storing an unresolved system color keyword, and in StyleColor which can
now be constructed from a system color keyword and requires a
WebColorScheme value to resolve colors. The remainder of the change
consists of updates at call sites to plumb in the used color scheme.
Bug: 1081945
Change-Id: I3b704cdf38c72b5284ad61a20e28825ee3e8e9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253198
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#786380}
--
wpt-commits: 1ebdb4d2bf1fd490e9f34b9e22cd10c44cd4db8e
wpt-pr: 24478
Automatic update from web-platform-tests
Python 3: port tests in service-workers [part 3]
--
Use random.random() instead of time.clock() for script updates
--
wpt-commits: af86bff8b2ab50c1f41b7f01ad82c6a16da5c337, dcc2ecf8e3abe1563894de9963c1479b802ca2fa
wpt-pr: 24336
Automatic update from web-platform-tests
Do not expose media devices before a successful getUserMedia()
This is a spec-compliance change.
This CL also adds some improvements to the blink MediaDevices unit test.
Bug: 1101860
Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786253}
--
wpt-commits: 8fa47b5a0f0a2fad2eb671ee4f3566e63f949357
wpt-pr: 24489
Automatic update from web-platform-tests
Python 3: port some recently added new tests
--
wpt-commits: 0c4d6a54c685a70aac30cf102370313a2cfeb9f5
wpt-pr: 24510
Automatic update from web-platform-tests
Remove anonymous block wrapper when inline continuation is removed.
Keeping empty anonymous blocks around is bad. The only known actual
problem is in multicol (but it may cause other issues too). Based on the
layout object tree, multicol creates anonymous LayoutMultiColumnSet and
LayoutMultiColumnSpannerPlaceholder objects, to keep track of what is
regular column content and what are spanners. Leaving a
LayoutMultiColumnSet around just for the sake of an empty anonymous
block (which may get cleaned up without notifying the multicol code)
will confuse multicol layout.
Bug: 1102137
Change-Id: Ibfb46d0dc173ecfdb2e7903efee5a49de3da3ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283355
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786197}
--
wpt-commits: 8c6f41fa15eb924017192255e06d2ecad1c17c92
wpt-pr: 24491
Automatic update from web-platform-tests
[css-grid-1] Add test for percentage gaps in shrinkwrap width / content-based height using float.
--
wpt-commits: a08ab9c0e8a60d8d554a872411940f9adc5e178d
wpt-pr: 24499
Automatic update from web-platform-tests
[NativeFS] Add some assertions for the locked state of streams.
https://github.com/WICG/native-file-system/issues/194 suggests there
might be something weird going here, so add assertions to the tests to
make sure locked has the value we expect it to have.
Change-Id: Ia13251aeeb16734047a2f5abe7e61d7fd4bbeb0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285293
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786059}
--
wpt-commits: d40dbb507b4b7bcc061e811fb03aa6afba111a05
wpt-pr: 24505
Automatic update from web-platform-tests
[FlexNG] Remove a DCHECK in SimplifiedLayout
The test includes some variants of the crash repro as evidence that the
crash was harmless.
Bug: 1018439
Fixed: 1091588
Change-Id: I879d4ce879d9fafb86b26a21609141b2fcfc5a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265100
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786031}
--
wpt-commits: 6466242987765ee8d72aa9b349ec81bc6e06730d
wpt-pr: 24347
Automatic update from web-platform-tests
Add logging of target_commitish to manifest_build.py (#24494)
Co-authored-by: Robert Ma <robertma@chromium.org>
--
wpt-commits: cef93b58e7cf31f1d47ccb0db4f376951192ee54
wpt-pr: 24494
Automatic update from web-platform-tests
Portals: Support default click-to-activate.
This adds a default behavior whereby clicking (or equivalent) will cause
the portal to immediately activate, unless the click or DOMActivate
event has preventDefault called by a listener.
This is guarded by a new runtime enabled feature so that this does not
affect the behavior in the current origin trial.
Bug: 1102081
Change-Id: I6a6c2409b0123f95d5068c54a423ac2f29e3e968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281308
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785812}
--
wpt-commits: 03d89c92bba52de611854f29373ba2c062ea0729
wpt-pr: 24458
Automatic update from web-platform-tests
Upstream and update foreignObject isolation tests
https://crrev.com/544756 ("Make <foreignObject> a stacking context")
added svg-isolation-foreign-isolation.html which had an incorrect
expectation. ForeignObject should create a stacking context [1] and
everything that creates a stacking context is an 'isolated' group [2],
so foreignObject should isolate. Our implementation is correct for html
content in foreignObject but has a bug for svg content in foreignObject.
This patch creates WPT tests for these two scenarios, and marks the svg
variant as failing.
[1] https://svgwg.org/svg2-draft/single-page.html#render-EstablishingStackingContex
[2] https://drafts.fxtf.org/compositing-2/#csscompositingrules_CSS
Bug: 1102803, 1101002
Change-Id: Ia5baceccab0be09eeec5e4682f16247a2881509b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284631
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#785765}
--
wpt-commits: db03cd2af9e67ab194dabd28f2a9384223d9e706
wpt-pr: 24486
Automatic update from web-platform-tests
Allow hiding test state for first-contentful-paint tests (#24170)
Some tests are sensitive to the content of the document, thus
show_status may interfere the test results.
We add a new setup property to allow hiding the test state output.
--
wpt-commits: ec9f61df8671488160d20a560ee7579126f8a24d
wpt-pr: 24170
Automatic update from web-platform-tests
Update picture-in-picture idlharness test (#24235)
The actual idl update already happened in
1449b69c39,
but the associated test was not updated.
Closes https://github.com/web-platform-tests/wpt/pull/24226
--
wpt-commits: b70f4c4663087bd441962e54ee6d062d39fc2ab5
wpt-pr: 24235
Automatic update from web-platform-tests
Python 3: port some tests in common and infrastructure (#24482)
--
wpt-commits: 924cdb5f242893239b3835a5c78a5a7a8deec240
wpt-pr: 24482
Automatic update from web-platform-tests
[NativeFS] Stop marking WPT tests as tentative.
All these tests test what is in the spec, so these shouldn't be marked
as tentative anymore.
Bug: none
Change-Id: Ib494c57b3c258e9a7e80ac3fd2a4df25abc4783a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283735
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785593}
--
wpt-commits: ff124a192986ad53d0af652f99b277e3019701ad
wpt-pr: 24472
Automatic update from web-platform-tests
Switch WPT to use Taskcluster Checks integration (#24151)
See https://github.com/web-platform-tests/wpt/issues/14846; this should
only be landed once wpt.fyi is ready to receive check_suite events.
Co-authored-by: Robert Ma <robertma@chromium.org>
--
wpt-commits: 972cc74af2d621fb45e5097350f4ee7d3b7c6ef4
wpt-pr: 24151
Automatic update from web-platform-tests
Move six import after path is set (#24484)
Co-authored-by: Stephen McGruer <smcgruer@chromium.org>
--
wpt-commits: 47821bc96914cfb6a42832490c987e16408e58be
wpt-pr: 24484
Automatic update from web-platform-tests
Move sourcefile construction to the manifest update function
Instead of having the tree iterator return either paths or constructed
sourcefiles, just have it always return paths, and construct the
sourcefiles in the caller. This has the advantage that we can better
handle some error conditions that may be caused by having an invalid
cache. It is also somewhat clearer since we don't end up with an
iterator that can return quite different types depending on whether it
thinks the file was updated or not.
--
Fix a bunch of Python 3 issues in the manifest code
The goal here is to get mypy passing in Python 3; prior to this patch
there were a lot of cases where Python 3 behaviour was broken but not
picked up by the tests (e.g. because it only happened when updating
the manifest or with certain caches or similar). Many of these issues
were seen by mypy, but that had been disabled for Py3 specfically to
avoid having to fix all the issues at the time the annotations were
added. But now we do need that support.
The general approach here is to use the same types for Py 2 and Py
3. In particular we use Text where possible (with a couple of
exceptions where it was easier not to), rather than bytes. The native
str type is avoided wherever possible since this introduces difficult
to debug differences between Python versions.
The preference for Text includes paths, which means we no longer
support running in non-unicode directories (in practice it is likely
to be broken if the path isn't UTF-8 compatible on Unix or UTF-16
compatible on Windows).
--
Fix passing arguments from wpt to Python 3
--
Update six in docker image
--
Run pip3 when installing in Python 3
--
Ensure deps are installed for py3
--
Update vendored six to latest
--
Use pip2 rather than just pip
Seems like bare pip started defaulting to python 3
--
Ensure that html5lib test build uses Python 2
--
Make canvas tests use python2 for build
--
wpt-commits: b923853fec706d8d448010caab33583026ae4749, 6539f1e3433e77e23a33e293007f2da993c96abc, cbe30a2fb78294ae530856d5174a47065b4f1958, 4e07dbd21b1ef0bf749bd38f3b8ea2e954abdf27, 96ea8bb0f93a29a09dfa181a65eebe871d5b6d95, da9f11f0610f1ab52f2d85f40a8b58ecd72571d7, 394d3fb5f647fa2416a95d105fb82f9269f73586, 40a49406d70c9d3bb73f38e2e0576efd301d75a4, 76a0eee0d2b697a4bcc599b4f7ad0522ade4d0e8, 6a531642611c81e83bed58421fdc555e2db1f77a
wpt-pr: 23733
Automatic update from web-platform-tests
[css-grid] Check that 'align-self: last baseline' does not interfere with baseline alignment in first row. https://github.com/w3c/csswg-drafts/issues/5293
--
wpt-commits: e3698c7bb3c309df69134e9bc0a375f00535e226
wpt-pr: 24477
Automatic update from web-platform-tests
[css-grid] Test autorepeat with max,min. https://github.com/w3c/csswg-drafts/issues/4043
--
[css-grid] Use background vs. background-color consistently. (editorial/lint)
--
wpt-commits: 9520e0643c5171ff97157469ec342636f0f1cf88, 7f77bdd0d1a3d7ae933026b74342ee0de1afed46
wpt-pr: 24470
Automatic update from web-platform-tests
Reland "Don't reset computed 'float' for flex and grid items"
This is a reland of 906abd41e4f6c786a1927f6edd69d6926e20317b
Original change :
https://chromium-review.googlesource.com/c/chromium/src/+/2157889
Revert of original change :
https://chromium-review.googlesource.com/c/chromium/src/+/2256772
-----
The original change was reverted due to a DCHECK being triggered. See
the following CRBug for more details:
https://bugs.chromium.org/p/chromium/issues/detail?id=1097595
The original change no longer adjusted the ComputedStyle for floats
based on whether or not it was a flex/grid item. This adjustment was
left for the LayoutBox to handle. However, there was code on the layout
side that depended on IsFloating() getting adjusted for the style, as
well. This resulted in the DCHEK mentioned above getting hit.
To fix this, I updated all cases that used the style's IsFloating()
function and either updated it to also take the style's
IsFlexOrGridItem() function into account or updated the code to use
LayoutObject's IsFloating() function instead.
-----
Original change's description:
> Don't reset computed 'float' for flex and grid items
>
> Floated flex and grid items have their 'float' incorrectly computed to
> "none". This change fixes this by adjusting IsFloating() for flex and
> grid items inside LayoutBox::UpdateFromStyle() instead of inside
> StyleAdjuster::AdjustStyleForDisplay().
>
> Beyond this, legend elements are not allowed to be rendered legends
> if they are floating. However, if legends are flex items, we
> adjust IsFloating() to be false. This causes legends to be
> used as rendered legends when they are flex items, even if they
> were styled as a float.
>
> This is fixed by checking ComputedStyle::IsFloating() instead
> of LayoutObject::IsFloating() when finding the rendered legend in
> order to get its non-adjusted floating value.
>
> Bug: 875235,350505
> Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: Alison Maher <almaher@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#763988}
Bug: 875235, 350505
Change-Id: I915e045db7fda94d99cfdae33911d8b5f6df26de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261412
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#785456}
--
wpt-commits: d33bc572d46eab7d3db2f67c24ab7e132344e22f
wpt-pr: 24316
Automatic update from web-platform-tests
Add another variant that explicitly uses minmax(0, 1fr), rather than relying on the auto size. (#24464)
--
wpt-commits: 1f53c57f1b474d7877184d45b32b583b88b5c6af
wpt-pr: 24464
Automatic update from web-platform-tests
[FragmentItem] Clear inline fragment for positioned objects
This is a refix of r784685 <crrev.com/c/2275820>.
When floating objects become positioned, |NGFragmentItems|
can no longer track further changes or destructions. r784685
<crrev.com/c/1101277> fixed this in pre-layout, but it is
possible that changes can occur before next layout cycle.
This patch marks |NGFragmentItem| as moved and clears the
index in |LayoutBox::StyleWillChange| instead.
Logically speaking, this could happen to non-floating objects
such as inline-block. Our current code reattaches when non-
floating objects become positioned, so only floating objects
can cause this after r784297 <crrev.com/c/2275373>.
Bug: 1101818, 1101986, 1101277
Change-Id: I56e53aaf4e0b6b5b0ef78c3f75eaf3ffd3568596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279425
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785453}
--
wpt-commits: bc36542dc6e20d502f593295a989895e7cbc1960
wpt-pr: 24442
Automatic update from web-platform-tests
Unify most clip-path code paths of pre-CAP and CAP
Previously in pre-CAP, because we always created a composited mask
layer for any mask and/or clip-path (either path-based or mask-based)
if the object needed to be composited, we needed to handle clip-path
differently in pre-CAP and CAP,
Now always apply path-based clip-path after paint. No longer create
a mask layer for path-based clip-path in pre-CAP.
Rename ClipPath to ClipPathMask to make it clear that this effect node
is for the mask created for a mask-based clip-path.
If there are both mask and mask-based clip-path, always let ClipPathMask
effect node be the child of the Mask effect node. This is required by
pre-CAP (unchanged) to apply the clip-path in the mask layer, but also
works in CAP (previously both Mask ClipPathMask were directly under
Effect) because:
DstIn(DstIn(A, Mask), ClipPathMask)
== DstIn(A, DstIn(Mask, ClipPathMask)
where ClipPathMask is black-and-white.
If there is only a mask-based clip-path, we'll only create ClipPathMask
for both pre-CAP (now no Mask and MaskClip nodes) and CAP (unchanged).
The pre-CAP mask layer will use ClipPathMask as the effect state, which
avoids the need of filling a black mask before applying the clip path
mask.
Now the only difference between pre-CAP and CAP about clip-path is that
that when a LayerObject with mask-based clip-path is composited, pre-CAP
creates a GraphicsLayer for the clip-path mask before paint, while CAP
creates a cc::Layer for the mask after paint.
Bug: 1100224
Change-Id: I243e463b3c94e09b64ed3c171ece12145c9deec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274177
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785435}
--
wpt-commits: 3d92704499a679683fb03500ceeeaef6ad652676
wpt-pr: 24440
Automatic update from web-platform-tests
Duplicate -001, but with the item getting its size from a child rather than explicitly. (#24463)
* Duplicate -001, but with the item getting its size from a child rather than explicitly.
* Whoops, remove the <base> I was using for testing.
--
wpt-commits: e8401319ee32642fa1fd77b50f097ee9c5199487
wpt-pr: 24463
Automatic update from web-platform-tests
Add metadata to preserve-fragment.html WPT test
Adds a long timeout since the single file tests hundreds of combinations
which timesout when manually run on mobile devices and cuts it close on
some desktop browsers.
Also added help links that refer to relevant spec text as well as bugs
that motivated this test.
Bug: 1055455
Change-Id: I8923bdd8201818dddb066ccd6d40790b416db16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281223
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785433}
--
wpt-commits: 08c4b3cb1535fedc32a7ced2aef987d3d797b3fc
wpt-pr: 24439
Automatic update from web-platform-tests
Remove .tentative flag from Split Cache Web Platform Test
Now that the spec for HTTP cache partitioning is about to be landed,
this flag must be correspondingly removed.
Bug: 1064765
Change-Id: I4ee646b4e3a48c33ed6a025132d4e9a10940f675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238349
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785405}
--
wpt-commits: b785f83c799379ac64c8d0836e56caa350ff95f8
wpt-pr: 24070
Automatic update from web-platform-tests
Use the style being computed as rem base for root element.
If we are resolving style for the root element, return the style being
built as the root style. That style is not available at the point we are
initialising the root style in ElementResolveContext.
Bug: 918480
Change-Id: If04aa2db7de9f74b9089b29cfda2e20c43762d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279802
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785359}
--
wpt-commits: c269b86af5e687cc6e9df00a96b64d9165c22ba0
wpt-pr: 24443
Automatic update from web-platform-tests
[FragmentItem] Limit reusing cached lines only when top-level child is clean
This patch simplifies |DirtyLinesFromNeedsLayout| to check
|NeedsLayout| of top-level children only.
The previous code tried to reuse more lines, e.g.:
<div><span>many lines of text</span></div>
Most lines are reusable when appending to the end of "text".
But supporting this case complicates the logic, especially
when culled inline is involved.
The new logic can't reuse lines in the above case, but still
can reuse liens if the `<span>` does not exist, and should
cover most common cases.
Bug: 1102083
Change-Id: I4f76e154b834c8c00e5ce04ab251c4f1fcdabab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282821
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785345}
--
wpt-commits: eae9c1b62560eedbccc8efa3a1f6b6ce1ba97b30
wpt-pr: 24453
Automatic update from web-platform-tests
[FragmentItem] Fix DirtyLinesFromNeedsLayout
This patch fixes a case where |DirtyLinesFromNeedsLayout|
fails to mark items dirty for reusing cached lines.
When searching for |LayoutObject| needing layout, checking
|NormalChildNeedsLayout| and |PosChildNeedsLayout| were not
enough. In some specific cases, only
|NeedsSimplifiedNormalFlowLayout| was set for the parent
inline box.
This patch changes the condition to check descendants to
|NeedsLayout|.
Bug: 1101883
Change-Id: Ia73ace058c9ea1ebaaffdaff793b56d68099cd5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281781
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785287}
--
wpt-commits: aef9da08fe2fa0b9fa473e2e126cb3cf29fae43e
wpt-pr: 24444
Automatic update from web-platform-tests
[TablesNG] New test suite: colspan redistribution
Investigation into how cells with colspan > 1
redistribute their min/max/% widths.
Browsers often disagree, and spec allows for variations.
Bug: 958381
Change-Id: I588053d1392e00e9d199cdd1095b93a148101fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219093
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785260}
--
wpt-commits: 6f5097d7cb5bcedef39dcdd5331064eadfdd0283
wpt-pr: 23807
Automatic update from web-platform-tests
[COOP] Report-only navigation tests (#24379)
This adds basic tests of the report-only features for the navigation
case, where the report-only headers would cause a browsing context
group switch.
Bug: 1099208
Change-Id: Ia5261d5d1ddac4a83943e0a48b5ef5f2cdb47b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266000
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785021}
Co-authored-by: Pâris MEULEMAN <pmeuleman@chromium.org>
--
wpt-commits: b7938227eacdc8d6d475c5a7bff061724d6ebd3f
wpt-pr: 24379
Automatic update from web-platform-tests
Test media features that are false in the negative range (#24433)
See https://github.com/w3c/csswg-drafts/issues/1454
--
wpt-commits: 6b786f18589c7407b7b804c883b5d5cbf254c086
wpt-pr: 24433
Automatic update from web-platform-tests
Add a @page margins test for print-reftests
This ensures that the 0.5" margin can be overriden when using a
print-reftest.
--
wpt-commits: 1ddd94983862011804dac3271eebd69160bee52b
wpt-pr: 24342
This ensures that you can't observe an inconsistent state while we go
through the list.
It should also be marginally better as we don't build an array with all
the media queries unconditionally.
Differential Revision: https://phabricator.services.mozilla.com/D82260
Re-enabling after 2 years of being disabled. If the underlying issue hasn't been
resolved, it'd be good to at least get updated logs for the intermittent failure.
The logs linked to on the bug comments are all too old to view anymore.
Differential Revision: https://phabricator.services.mozilla.com/D82488
Comment 14 on the bug seems to be obsolete, and the subtest hasn't failed
recently on different platforms. So if the issue causing the failures isn't
fixed, re-enabling should at least give some updated logs of what's happening.
Differential Revision: https://phabricator.services.mozilla.com/D82477
Automatic update from web-platform-tests
[CSP] Add WPT tests for inheritance with window.open.
There are WPT tests about CSP inheritance when opening local-scheme.
This is tested for iframe. Testing for iframes is good, testing for
both iframes and opened window is better.
Initially, I wanted to reproduce bug 1073126, but failed to do so. I
still want to keep the tests.
Bug: chromium:1073126
Change-Id: I4c363037d556bf93f37d43dd5b84a1da608d5e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274602
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785017}
--
wpt-commits: 51f124152f8d1771382f4b2a8e4d386dd573755d
wpt-pr: 24395
Automatic update from web-platform-tests
Test that deprecated media types don't match (#24432)
Relates to https://github.com/w3c/csswg-drafts/issues/1751
--
wpt-commits: e422c23288d1d4d61f7a5ee0d0c919ac6834a627
wpt-pr: 24432
Automatic update from web-platform-tests
Add metadata to mediaquery case insensitivity test (#24431)
See https://github.com/w3c/csswg-drafts/issues/2727
--
wpt-commits: 9bb4de40c0c6d46fd44e7f6c0001b760dd9c8eb8
wpt-pr: 24431
Automatic update from web-platform-tests
Streams: remove obsolete test for @@asyncIterator === values (#24427)
As noted in #24266, this Streams test is now covered by the new async
iterable tests from the WebIDL harness. Therefore, we can remove the
Streams-specific test.
--
wpt-commits: 67a169be0bd98bfdb645a8218fdfb0bc2efe0f18
wpt-pr: 24427
`Scrub()` does remove leading white-spaces and trailing white-spaces if
there is. So, it does not require `WSFragment` anymore.
Differential Revision: https://phabricator.services.mozilla.com/D82275
This can happen because we don't have a nice mechanism to update the
validity bits in all cases where the computed "language" changes.
That's not really a regression, and I'm on PTO, so for now we just deal
with it. The "bad input" message seems appropriate for this case rather
than returning garbage numbers.
Differential Revision: https://phabricator.services.mozilla.com/D82402
Fixed breakages with clipped areas disjoint to image
Fixed text case that didn't expect exception
Fixed coding style
Removed expectation of web platform failure test
Differential Revision: https://phabricator.services.mozilla.com/D31048
By the time we get to iterate over the longhands of a shorthand, we've
already advanced the range iterator, so we look at the next duration and
such, which causes this bug.
I'm seriously baffled that no existing test caught this when it
landed, neither in our internal test suite nor wpt... :/
Differential Revision: https://phabricator.services.mozilla.com/D82396
This adds some WPTs for testing how to treat invisible leading and/or trailing
white-spaces in block elements. I think that they should be removed as far
as possible because they may become visible suddenly if browsers fail to handle
them with their bugs. However, it's acceptable if the result keeps white-
spaces as invisible. Therefore, this makes some new tests allow multiple
results.
Differential Revision: https://phabricator.services.mozilla.com/D82268
In bug 1562932, we disabled a number of appearance reftests on Windows,
since they are intermittent given the animated appearance of <progress>.
This patch disables some other tests that were missed.
This also removes the fuzziness from Android for these tests, which
seems to be no longer needed (probably since the switch to the non-
native theme on Android), and removing Windows Vista disabling
conditions that are superseded by the new all Windows disabling one.
Differential Revision: https://phabricator.services.mozilla.com/D82123
Automatic update from web-platform-tests
Python 3: port tests of range, stale-while-revalidate in fetch (#24423)
* Python 3: port tests of range, stale-while-revalidate in fetch
* Remove unnecessary prefix and use bytes type for content_range
--
wpt-commits: b13c1d42b3aaf52a4e7b0b18795aeefb17a62eb6
wpt-pr: 24423
Automatic update from web-platform-tests
Implement CSPEE Blanket Enforcement logic out-of-blink
This changes adds to the AncestorThrottle a check for the step
"Does response allow blanket enforcement of policy from request" of
Content Security Policy: Embedded Enforcement:
https://w3c.github.io/webappsec-cspee/#origin-allowed Behind the flag
This is one of the steps of moving CSPEE out-of-blink and is hidden
under the flag network::features::kOutOfBlinkCSPEE.
Change-Id: Id3092322134e055810d4006e63e6974ee64315be
Bug: 1094909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218019
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784753}
--
wpt-commits: 8a3698a69e785aefc5c83ea2e348fd3350bfa43a
wpt-pr: 24311
Automatic update from web-platform-tests
Move asserts inside the test (#24421)
Failing one of these asserts would otherwise result in a harness error.
--
wpt-commits: f5c167568d5f5c02ef9a3b3131c64f3a254c2296
wpt-pr: 24421
Automatic update from web-platform-tests
Update bug references in docs and comments: s/891872/1098938/.
Even though https://crbug.com/891872 is fixed (and
blink::Platform::CreateDefaultURLLoaderFactory removed),
|request_initiator_site_lock| might still be a base::nullopt in some
URLLoaderFactory objects vended to renderer processes. Such remaining
cases are tracked in https://crbug.com/1098938 - this CL updates
bug references in docs and comments to match.
Bug: 891872, 1098938
Change-Id: I64f21f2495514ba72bfcc3c39910151322b176eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274188
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784738}
--
wpt-commits: 3ecff280b727451096f3e3a8b0e9af301ec84263
wpt-pr: 24388
Automatic update from web-platform-tests
Add a test to verify finding fragment id in non UTF8 document (#24412)
--
wpt-commits: 7e6dcb93c97da79840977f0f7b3aff6bf15da3eb
wpt-pr: 24412
Automatic update from web-platform-tests
[FragmentItem] Clear inline fragment index for positioned objects
When once laid out floating object is changed to a positioned
object, it may have |FirstInlineFragmentItemIndex| set, but
positioned objects should not have the index because they do
not produce |NGFragmentIem|. This patch makes sure the index
is cleared for positioned objects.
Also this patch turns DCHECK in |NGInlineCursor::MoveTo| to
NOTREACHED + return to avoid such case could result in crash.
This is a regression in r784297 <crrev.com/c/2275373>, which
started to index floating objects.
Bug: 1101277
Change-Id: I21a75440c3aa77a8d66b1e002d05ff2b252e6b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275820
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784685}
--
wpt-commits: 99a09c73e7f1d7b19ec4be2eb8ce2d3bebf52245
wpt-pr: 24416
Automatic update from web-platform-tests
Display type of ::first-line pseudo-elements
According to the spec, the display property should not be applied
to ::first-line or ::first-letter pseudo-elements.
https://www.w3.org/TR/css-display-3/#placement
This has already been handled for ::first-letter, so this change
similarly adjusts the display property style for ::first-line. I've
tested the behavior in FireFox and legacy Edge, and this change
aligns with the behavior in other browsers.
Bug: 685925
Change-Id: Idaa299c90e20c69902491837b53e7988da7759c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278321
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#784655}
--
wpt-commits: 97361605eaf811be5120d97ddf807c735e9a8d22
wpt-pr: 24420
Automatic update from web-platform-tests
WebXR - anchors WPTs - update to account for test API changes
WebXR Test API PR with changes to the API:
https://github.com/immersive-web/webxr-test-api/pull/69
Change-Id: I9a9833e7850eb8b2c464161042a467b031208b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268578
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784593}
--
wpt-commits: bbda80e3e9964567acedd8537f5318b40896ac85
wpt-pr: 24349
Automatic update from web-platform-tests
[AspectRatio] Add test for computing inline size with constrained block size
This tests the behavior as specced in
https://github.com/w3c/csswg-drafts/issues/5257R=ikilpatrick@chromium.org
Bug: 1045668
Change-Id: I75b945a008b9039b751fc7de54da86cbf399a7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274255
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784523}
--
wpt-commits: b363daeddf3374072306c4f9ccf919261489aa13
wpt-pr: 24391
Automatic update from web-platform-tests
Add iframe lazy load event semantics test
This CL adds WPTs asserting that in-viewport loading=lazy iframes do not
block the outer window load event.
The test accompanies the spec change made at:
https://github.com/whatwg/html/pull/5579.
R=sclittle@chromium.org
Bug: 1101175
Change-Id: I5e337f6c87c8198e8e5bae5a32263698fb3daf28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277384
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784381}
--
wpt-commits: 54eb49dcb97c59910f8b6d9830d73ea11366b7e5
wpt-pr: 24410
Automatic update from web-platform-tests
Python 3: Port tests in fetch/corb, fetch/cross-origin-resource-policy and fetch/nosniff (#24195)
--
wpt-commits: 71df9d040dfb23a381cab1a1d64ca380316c8a28
wpt-pr: 24195
Automatic update from web-platform-tests
[LayoutNG] Fix anonymous-block child-available-size.
The logic introduced for CalculateChildAvailableSize was designed to
have the correct value for an element with:
"<div style="position: relative; left: 50%; top: 50%;></div>"
E.g. the percentage based left/top would resolve against the available
size. However this broke text alignment within anonymous-blocks which
require the child-available-size to be based on the actual inline-size.
This patch uses the actual inline-size in the inline direction, but
keeps the logic for block direction.
This will mean that for postiion:relative calculations we'll use
the Percentage inline-size, and Available block-size for resolving
percentages.
Bug: 1100203
Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784323}
--
wpt-commits: 13b2394002dc74717d528a0f94c9a38d944fc578
wpt-pr: 24396
Automatic update from web-platform-tests
Augment iframe lazyload tests for srcdoc
This CL augments the existing iframe lazyload test for srcdoc lazyload
support. Chrome currently does not implement this.
The test accompanies the spec change made at:
https://github.com/whatwg/html/pull/5579.
R=sclittle@chromium.org
Bug: 1101170
Change-Id: I5c5790c5d2eca3efbb01c5470e2267f2265858f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276624
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784331}
--
wpt-commits: 36c3b7dbdcb6f955ef2d64aad14efb13c80e4c67
wpt-pr: 24407
Automatic update from web-platform-tests
[FragmentItem] Include floats in associated LayoutObject
This patch changes to associate floating |LayoutObject|s to
|NGFragmentItem| using |FirstInlineFragmentItemIndex|.
The index is used for many purposes, but one of them is to
mark destroyed or moved |LayoutObject| in |NGFragmentItem|.
Because floating objects are stored in |NGFragmentItem|,
they need to be indexed to mark correctly.
Also changes |LayoutBlockFlow::
SetShouldDoFullPaintInvalidationForFirstLine| to skip items
for destroyed or moved |LayoutObject| because it may be
called on dirty tree.
Bug: 1100900
Change-Id: If35bf2c77b9a46a9ba598e6785926f6b0e1c5455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275373
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784297}
--
wpt-commits: e5fea0ad9e468165aba081d71880ec2b67832df6
wpt-pr: 24399
Automatic update from web-platform-tests
[PaintTiming] Let videos trigger FCP
This CL adds a call to SetImagePainted() so that FCP fires when there we
paint a video.
Bug: 1071450
Change-Id: I9590517fd3355226096fd62079a3a4aa6eb50735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276244
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784189}
--
wpt-commits: 17f0e364e3584535436669a490887e723f3f61e6
wpt-pr: 24402
Automatic update from web-platform-tests
Named pages should only have an effect when paginated.
Need to check if page breaks are applicable before applying them.
Bug: 1100308, 1053768
Change-Id: I987bf4ce42f7d0f5128cb01c30824214d9c12ea8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276432
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784139}
--
wpt-commits: 046463806888ea0f241f4df19c1bcc23b3d8e50c
wpt-pr: 24401
Automatic update from web-platform-tests
Accept Permissions-Policy header
This CL does the necessary plumbing so that permissions policy
header can be properly parsed and merged with existing init
procedure of feature policy.
A few wpt tests are added to verify that the plumbing is working
as expected.
Change-Id: I64b956f55fc36e372c23d6f1df92af54e268d92c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246981
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#784064}
--
wpt-commits: af272845618c79b04d7fdcf9687e9ab9b543b6d7
wpt-pr: 24344
Automatic update from web-platform-tests
Fix clip state of synthetic effect for non-backdrop effects
This fixes a regression caused by crrev.com/c/2183198.
We should move the effect's clip to the outer synthetic effects
for backdrop effects only. For non-backdrop effect we don't move effect
up into the synthetic effect and can share the synthetic effect with
other effects, so we should not move up the clip.
Bug: 1099234
Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784097}
--
wpt-commits: 716a3224e9a754234c2fc1166ca6757154a445c0
wpt-pr: 24398
Automatic update from web-platform-tests
client hints: Rework how persistent settings are communicated to renderer
Before this CL, the entire settings map was sent to the renderer,
it then parsed accept-ch, and sent IPCs to the browser to persist
settings.
This has following downsides:
1) client-hint settings map can leak history to render (I don't know
if there are other sources of that, probably, so maybe not such a
big deal)
2) If this becomes popular, map size would be a performance risk
3) This requires trusting renderer to update client hint settings.
Instead, this uses existing network service hook to parse accept-ch
(which was needed for navigation redirects), and the browser persists
the results and sends the relevant client hint configuration to the
renderer with CommitParams. The IPC for renderer to write config
is therefore removed.
This required teaching the browser code to behave more consistently
with some flags (lang, accept-ch-lifetime support).
Change-Id: I421b3c07d4644e179a0f6a26088e44c55f68f7d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081628
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784031}
--
wpt-commits: db1baf1ad1b70d9343284bab7d55dd4f7ba1e07b
wpt-pr: 24134
Automatic update from web-platform-tests
Partially revert "Add another https port (#24016)" (#24394)
This reverts the change to common/get-host-info.sub.js in commit
95cdf1f.
Adding another HTTPS port broke there broke the Chromium WPT
Importer (as the pinned tooling failed to sub common/get-host-info.sub.js
due to indexing out of bounds).
--
wpt-commits: c9d349e49b3140029e4682761d5af5189ae75138
wpt-pr: 24394
Automatic update from web-platform-tests
[WPT] Fix external/wpt/css/css-backgrounds/border-image-shorthand-001.htm
The test file and it's reference differed by having a "." inside
or outside the <strong>. Fix it.
TBR: pdr@chromium.org
Bug: 1099732
Change-Id: Ia70fc06fa216bd5494187f18be27e46fa9e1dd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274786
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783938}
--
wpt-commits: 7fbf0a9b035b850016885c4b27d267265de615f6
wpt-pr: 24390
Automatic update from web-platform-tests
Python 3: port tests in service-workers [part 5] (#24338)
Use random.random() instead of time.clock() for script updates
--
wpt-commits: a9e30a86cdcc6121a23512ea9178f80fba8fd233
wpt-pr: 24338
Automatic update from web-platform-tests
Fix wpt/html/coep/require-corp-about-{blank,srcdoc}.html
- platform/mac-mac10.13/.../require-corp-about-blank-expected.txt
is redundant - it's same as the base expectation.
- platform/mac-mac10.14/.../require-corp-about-blank-expected.txt
is wrong - the test always fails on the platform (and the failures
are suppressed by TestExpectations).
- wpt/html/coep/require-corp-about-blank.html always fails because
COEP is only effective on secure contexts
(https://github.com/whatwg/html/issues/4930). Rename it to
wpt/html/coep/require-corp-about-blank.https.html
- wpt/html/coep/require-corp-about-srcdoc.html always fails because
COEP is only effective on secure contexts
(https://github.com/whatwg/html/issues/4930). Rename it to
wpt/html/coep/require-corp-about-srcdoc.https.html
- Remove redundant TestExpectations entries.
Bug: 1086065, 626703
Change-Id: I5573dd4446f482acdde828404e0a88893897ce09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783875}
--
wpt-commits: f911e6744606f48835f3296fab56e40d8185121c
wpt-pr: 24392
Automatic update from web-platform-tests
[appmanifest] Test `orientation` member (#24378)
* [appmanifest] Add orientation member test
* [appmanifest] add portrait orientation test
--
wpt-commits: 1cb9daef513ee0c7e82a6689a6248946d0c580c0
wpt-pr: 24378
Automatic update from web-platform-tests
Indexed DB: Use correct range upper limit for index iteration
When iterating a forwards, comparisons are done between each record
found and the range's bound to know when to stop. There's an special
case for reverse cursors where a starting key is needed at the upper
end of the range, so the uppermost key in the range is looked up as
the starting cursor position.
The code to do this for indexes was not guarded by a check for the
cursor direction, though. This was harmless for most forward
iterations as the uppermost actual key would match the upper bound
anyway. But when iterating a cursor over a range in an index, records
can change their index keys and thus appear again in the iteration.
This would lead to the cursor stopping at what was no longer the
actual uppermost key in the range, missing records in the iteration.
Add the missing check, and a WPT to verify this behavior.
(The code dates back to before 2013, so this is not a recent regression.)
Bug: 1091731
Change-Id: I23336ba03d31607607d496fc7e18c28bcf644cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274085
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783792}
--
wpt-commits: 93caf8cf824c75e47a68af9d3000e297139c4974
wpt-pr: 24386
Automatic update from web-platform-tests
Fix calculation of before change style for CSS transitions
This patch performs a lazy calculation of the before change style once
it has been determined that a transition is being retargeted. In doing
so, the current position is correctly updated to reflect changes made
via the web-animation API. The path also addresses a bug in the
calculation of current time, in the case of a paused or play-pending
animation.
Bug: 1082401, 888661, 547609
Change-Id: I4b76879d840b482da8ebf23c1aad41b881fafce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220263
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783675}
--
wpt-commits: ebe69e97a1ea77b2eb30d7b40ffef2d67455a805
wpt-pr: 23860
Morten Stenshorne
Robert Ma
Ziran Sun
autofoolip
Florian Rivoal
moz-wptsync-bot
fantasai
Chany Arpin-Plante
Mohsen Izadi
Keishi Hattori
Nate Chapin
Narcis Beleuzu
Bob Clary
Erik Nordin
Henrik Skupin
Cameron McCormack
Mihai Alexandru Michis
alwu
Ms2ger
James Graham
Simon Giesecke
Dorel Luca
Tom Tung
aardgoose
Sean Feng
Emilio Cobos Álvarez
Sebastian Hengst
Razvan Maries
Andreea Pavel
Jonathan Kew
Cosmin Sabou
George Steel
Marijn Kruisselbrink
Qiaofei Ye
Pâris MEULEMAN
Jeremy Roman
Alexander Cooper
Mason Freed
Kevin Babbitt
Guido Urdaneta
Blink WPT Bot
David Grogan
Domenic Denicola
Stephen McGruer
Philip Rogers
Tab Atkins Jr
Simon Pieters
Alison Maher
Koji Ishii
Xianzhu Wang
David Bokan
pyup.io bot
Alex Turner
Frédéric Wang
Rune Lillesveen
Aleks Totic
Tom Prince
Perry Jiang
Byron Campen [:bwc]
R. Martinho Fernandes
arthursonzogni
Alexey Shvayka
Mattias Buelens
Masayuki Nakano
Hiroyuki Ikezoe
Nika Layzell
Jeff Muizelaar
Corentin Arnould
Antonio Sartori
Philip Jägenstedt
Christian Liebel
Lukasz Anforowicz
Rob Buis
Piotr Bialecki
Christian Biesinger
Dominic Farolino
Ian Kilpatrick
Nicolás Peña Moreno
Charlie Hu
Maks Orlovich
Stephen Chenney
Yutaka Hirano
Joshua Bell
Kevin Ellis