Andrew McCreight
09ab49e463
Bug 1410471 - Remove StartupCacheWrapper and friends. r=froydnj
...
This class was needed for testing, but no longer.
MozReview-Commit-ID: AIk0kKlbScs
--HG--
extra : rebase_source : 35eed188e44dc4c9899479b35882461dd2cf4624
2017-10-20 10:40:50 -07:00
Andrew McCreight
5738242a26
Bug 1408017 - Clear gStartupCacheWrapper in the dtor. r=froydnj
2017-10-26 16:47:27 -04:00
Kris Maglione
257d9118dc
Bug 1409249: Require singleton constructors to return explicit already_AddRefed. r=froydnj
...
Right now, NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR expects singleton
constructors to return already-addrefed raw pointers, and while it accepts
constructors that return already_AddRefed, most existing don't do so.
Meanwhile, the convention elsewhere is that a raw pointer return value is
owned by the callee, and that the caller needs to addref it if it wants to
keep its own reference to it.
The difference in convention makes it easy to leak (I've definitely caused
more than one shutdown leak this way), so it would be better if we required
the singleton getters to return an explicit already_AddRefed, which would
behave the same for all callers.
This also cleans up several singleton constructors that left a dangling
pointer to their singletons when their initialization methods failed, when
they released their references without clearing their global raw pointers.
MozReview-Commit-ID: 9peyG4pRYcr
--HG--
extra : rebase_source : 2f5bd89c17cb554541be38444672a827c1392f3f
2017-10-16 21:08:42 -07:00
Sylvestre Ledru
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Benjamin Smedberg
067ef5e9f7
Bug 1314378 part B - port TestStartupCache to gtest, r=froydnj
...
MozReview-Commit-ID: LTz4slzIkjH
--HG--
extra : rebase_source : 852ca996bd042d9c363b79bf47a037f83f3cf804
extra : source : 4585a7b6f3ce8c8dc7b7e043e0fae86f8e5ee392
2016-11-11 11:57:08 -05:00
Benjamin Smedberg
d3f7e3065e
Bug 1314378 part A - remove startupcache telemetry of dubious value. r=froydnj
...
MozReview-Commit-ID: J1cLTvO4ecC
--HG--
extra : rebase_source : f6c504a8279fd2a74e97d544a3812fbb43c93b4d
extra : source : 419e1a311337ecdf208f5474f182d1f88102cc9f
2016-11-01 15:21:53 -04:00
Iris Hsiao
0ae29a8978
Backed out changeset 419e1a311337 (bug 1314378)
2016-11-16 15:30:57 +08:00
Iris Hsiao
d4c39fd92a
Backed out changeset 4585a7b6f3ce (bug 1314378)
2016-11-16 15:30:52 +08:00
Benjamin Smedberg
a4623c11eb
Bug 1314378 part B - port TestStartupCache to gtest, r=froydnj
...
MozReview-Commit-ID: LTz4slzIkjH
--HG--
extra : rebase_source : 004f3809de2a527f7577e9935221304bb9e6edc2
2016-11-11 11:57:08 -05:00
Benjamin Smedberg
6fc90f28ee
Bug 1314378 part A - remove startupcache telemetry of dubious value. r=froydnj
...
MozReview-Commit-ID: J1cLTvO4ecC
--HG--
extra : rebase_source : 9bbdb3b305f68057199f9c7dc505ecee09a808bf
2016-11-01 15:21:53 -04:00
Nathan Froyd
060b90466d
Bug 1249389 - part 5 - use UniquePtr instead of nsAutoArrayPtr in mozilla::scache::CacheEntry; r=erahm
2016-02-18 14:14:28 -05:00
Nathan Froyd
12d9670a60
Bug 1249389 - part 4 - make StartupCache::GetBuffer take a UniquePtr outparam; r=erahm
...
This change eliminates a number of nsAutoArrayPtr usages, as well as
making the pattern GetBuffer() -> NewObjectInputStreamFromBuffer more
pleasant.
2016-02-18 12:26:28 -05:00
Nathan Froyd
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Nicholas Nethercote
d98d14fa1e
Bug 1189156 (part 4) - Don't use enumeration style for nsBaseHashtable::SizeOf{In,Ex}cludingThis(). r=erahm,jfkthame.
...
After this change, we have ShallowSizeOf{In,Ex}cludingThis(), which don't do
anything to measure children. (They can be combined with iteration to measure
children.)
--HG--
extra : rebase_source : f98420176f50990bbc5a25e35788328154cfeb00
2015-07-30 21:19:57 -07:00
Birunthan Mohanathas
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Jim Chen
e7cd5b6cab
Bug 1163719 - Store startup cache entries in loading order; r=nfroyd
2015-05-22 16:29:51 -04:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Birunthan Mohanathas
5c73bc7757
Bug 1045289 - Rename nsXPComInit.cpp to XPCOMInit.cpp. r=froydnj
...
--HG--
rename : xpcom/build/nsXPComInit.cpp => xpcom/build/XPCOMInit.cpp
2014-09-26 07:20:23 +03:00
Benoit Jacob
dd08a67adb
Bug 1028588 - Fix dangerous public destructors in miscellaneous places - r=ehsan
2014-06-23 18:40:03 -04:00
Nicholas Nethercote
8bbe1e2dc1
Bug 947798 (part 2) - Remove MemoryMultiReporter, because it's no longer helpful. r=mccr8.
...
--HG--
extra : rebase_source : f6f74de69d8c1d79d38b84b19dff5439efc41075
2013-12-07 21:39:47 -08:00
Nicholas Nethercote
39004db706
Bug 936964 (part 7, attempt 2) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
...
* * *
Bug 936964 (part 7b) - Fix a use-after-free found by ASan.
--HG--
extra : rebase_source : d38ab6b63e9d576773baf8e55fa4f7182c33915e
2013-11-07 16:35:30 +11:00
Nicholas Nethercote
794c4b6457
Bug 936964 (part 1, attempt 2) - Make StartupCache ref-counted. r=aklotz.
...
--HG--
extra : rebase_source : d04b799a861c155b89b8dcf9f328ef7a9bfef097
2013-11-25 15:57:40 -08:00
Ehsan Akhgari
a903aefdc0
Backed out 9 changesets (bug 943660, bug 936964) because of ASAN use-after-free crashes on browser-chrome and mochitest-other
...
Backed out changeset 85486c4aa3d8 (bug 936964)
Backed out changeset 25312eb71998 (bug 936964)
Backed out changeset 6dbb8333960c (bug 936964)
Backed out changeset da6465ad476f (bug 936964)
Backed out changeset a87ffc992f38 (bug 936964)
Backed out changeset 4ae3a61182db (bug 936964)
Backed out changeset 34e9c3137804 (bug 936964)
Backed out changeset fd1459e71585 (bug 936964)
Backed out changeset 3e8a701d8bdc (bug 943660)
Landed on a CLOSED TREE
--HG--
rename : content/canvas/src/WebGLMemoryTracker.h => content/canvas/src/WebGLMemoryReporterWrapper.h
2013-11-27 20:05:00 -05:00
Nicholas Nethercote
bc475c75df
Bug 936964 (part 7) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
...
--HG--
rename : content/canvas/src/WebGLMemoryReporterWrapper.h => content/canvas/src/WebGLMemoryTracker.h
extra : rebase_source : 611e8d35907959b163aeced1c4ffe1d265048fe6
2013-11-07 16:35:30 +11:00
Nicholas Nethercote
7b367571d4
Bug 936964 (part 1) - Make StartupCache ref-counted. r=aklotz.
...
--HG--
extra : rebase_source : 8693264a4347938dde6532730a5bc730384edf51
2013-11-25 15:57:40 -08:00
Nicholas Nethercote
5d24bdca75
Bug 831193 (part 8) - Don't use NS_MEMORY_REPORTER_IMPLEMENT in StartupCache.cpp. r=nfroyd.
...
--HG--
extra : rebase_source : 76623535a2667d0b8448b245c345d7290b61f86f
2013-01-17 16:45:11 -08:00
Joshua Cranmer
8c0bca8e57
Bug 884061 - Part 3t: Use NS_DECL_THREADSAFE_ISUPPORTS in startupcache/, r=mwu
...
--HG--
extra : rebase_source : 8a990b22d5b98b2b25f26530fe1f88ac388ae788
2013-07-18 21:24:14 -05:00
Catalin Iacob
6f4758d23e
Bug 798914 (part 5) - Use newly introduced mozilla::MallocSizeOf instead of nsMallocSizeOfFun. r=njn.
...
--HG--
extra : rebase_source : fc472490dd978d165f02f77ed37f07aed6e5bb61
2013-06-23 14:03:39 +02:00
Chris Peterson
de411b5fd0
Bug 829685 - Remove #include "prtypes.h" from some files that no longer use PR types. r=ehsan
2013-01-10 08:19:36 -08:00
Graeme McCutcheon
75b6269d53
Bug 724513 - Part 1 - Add StartupCache method for disregarding disk file. r=mwu
2012-10-11 09:17:15 +01:00
Ehsan Akhgari
59dacf4015
Backed out 3 changesets (bug 724513) for a 20-30% Ts regression across the board
...
Backed out changeset 006eb98e9d6f (bug 724513)
Backed out changeset f418d97d12ac (bug 724513)
Backed out changeset 1baac3f2334c (bug 724513)
--HG--
extra : rebase_source : e361496807916c968524446d32d3eb1d6af346eb
2012-10-31 11:28:21 -04:00
Graeme McCutcheon
34d7a161c5
Bug 724513 - Part 1 - Add StartupCache method for disregarding disk file. r=mwu
2012-10-11 09:17:15 +01:00
Ehsan Akhgari
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
Ehsan Akhgari
d0798fee41
Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (startupcache parts); r=jrmuizel
2012-06-19 23:45:32 -04:00
Geoff Lankow
5cefea8480
Bug 749930 - Replace uses of nsILocalFile with nsIFile (compiled code only); r=bsmedberg
2012-06-06 14:08:30 +12:00
Gervase Markham
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Nathan Froyd
512a941bbe
Bug 711297 - add recordAgesAlways method to nsIStartupCache; r=mwu
2012-02-22 14:07:18 -05:00
Nathan Froyd
5a474e9e60
Bug 711297 - report age of startup cache via telemetry; r=taras
2012-02-22 14:03:52 -05:00
Vladan Djeric
54ef9cac4b
Backed out aef22bc75f1f (bug 711297) - wrong comment in commit
2012-02-22 14:02:02 -05:00
Nathan Froyd
8440bcee3d
Bug 711297 - add recordAgesAlways method to nsIStartupCache; r=mwu
2012-02-22 13:45:56 -05:00
Nicholas Nethercote
7559a70a04
Bug 715453 - Remove computedSize from nsMallocSizeOfFun. r=jlebar,bhackett.
...
--HG--
extra : rebase_source : a65039a407daab45360a5b375b53cbf1bc05b7f6
2012-01-25 00:52:51 -08:00
Nicholas Nethercote
9dc2c72bd7
Bug 697335 - Another memory reporter for the startup cache. r=taras.
2011-12-18 16:20:36 -08:00
Mike Hommey
cd155f464b
Bug 695843 part 1 - Add Refcounting on nsZipArchives. r=mwu
2011-12-08 11:03:36 +01:00
Nicholas Nethercote
0ee9052aba
Bug 696690 - Memory reporter for the startup cache. r=tglek.
2011-10-24 17:50:47 -07:00
Michael Wu
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
Taras Glek
76cf7b4738
Bug 586859: Move startup cache writing off main thread r=cjones a=blocking-final
2011-01-07 10:56:15 -08:00
Taras Glek
79248ff22d
Bug 586859: prepare startup cache for off-main thread writing r=dwitte a=blocking-final
2011-01-07 10:55:14 -08:00
bhsieh@mozilla.com
df2049724f
bug 520309, startupcache core r=dwitte sr=bsmedberg a=bsmedberg
2010-08-12 12:37:44 -07:00