Граф коммитов

173 Коммитов

Автор SHA1 Сообщение Дата
Edgar Chen 4e8ea293f3 Bug 1092941 - Settings lock in parent isn't finialized when receiving 'child-process-shutdown'. r=lissyx, a=me 2014-11-03 15:15:12 +08:00
Alexandre Lissy 127bb2dc72 Bug 1092384 - Use undefined windowID for service locks r=bent
Service locks for settings are locks created from chrome code and not
attached to any window. Since the windowID is used in other cases for
the Settings:CreateLock message, we should at least pass an undefined
value to avoid unneccessary JS warning.
2014-11-04 15:08:37 -08:00
Alexandre Lissy 7413aa0cdc Bug 1082001 - Cleanup settings lock from parent itself. r=bent
From bug 1065128 SettingsManager has been changed to listen the
dom-window-destroyed event for its cleanup. However, when running Gaia
in Mulet, a race condition is exposed. For B2G, when loading a page,
about:blank is first used. This means that window destroyed events will
be triggered. However, from the dom-window-destroyed event we cannot
distinguish whether this is about:blank or a legit application being
closed. SettingsManager gets initialized (i.e., init() called) when the
application makes use of navigator.mozSettings. So the chain of event is
that we have a SettingsManager living because System app did some
request. At this time, about:blank is being unloaded and triggers a
dom-window-destroyed event. This makes SettingsManager doing its
cleanup, especially freeing the window reference. Then in the meantime,
we have the navigator.mozSettings use that is progressing. At some
point, SettingsManager has no more window to send messages to, and Gaia
is not able to even start.

SettingsRequestManager lives on the parent process and SettingsManager
lives on the child side. Part of the cleanup performed by
SettingsManager was to ensure pending locks on the parent process would
be forced to finalize to make sure those are being properly committed.
We move this cleanup to SettingsRequestManager and we augment the lock
informations with the proper inner window id. This way we can track
which lock is attached to which inner window when the lock gets created.
And thus we can listen on inner-window-destroyed from
SettingsRequestManager to be able to force finalize on any pending lock.
Impacted code path are those were we are not running out of process.
When we are running out of process, SettingsRequestManager already
listens on the child-process-shutdown event to perform the lock
finalization.
2014-10-29 02:36:00 -04:00
Gregor Wagner 119c8d2cb4 Bug 1080847 - [Settings] No need to export SettingsRequestManager r=baku 2014-10-21 13:48:42 -07:00
Alexandre Lissy 2373f7c83f Bug 1076597 - Fix Settings API shutdown race condition. r=bent
When child message manager dies, it sends a child-process-shutdown
message to the SettingsRequestManager. This would just close the locks
and tasks of this message manager. The race happens when some
applications can shutdown quickly: settings requests will never be
committed to the database. One example is the callscreen. The fix,
provided by qDot, simply put those tasks in a finalize state to make
sure they are properly executed and committed.
2014-10-09 05:12:00 -04:00
Ryan VanderMeulen 67e6833bd6 Backed out changeset 69866036d793 (bug 1076597) for being the wrong patch that landed. 2014-10-21 10:12:56 -04:00
Kyle Machulis 5fbfd60a9d Bug 1073259 - Print more descriptive errors when SettingsManager tries to make a request with an invalid window. r=bent 2014-10-17 05:24:00 -04:00
Alexandre Lissy 343378644a Bug 1076597 - Fix Settings API shutdown race condition. r=bent 2014-10-07 06:35:00 -04:00
Andrea Marchesini 7491bee8c3 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-08 17:15:22 +01:00
Ryan VanderMeulen cd3e8a6f73 Backed out 7 changesets (bug 1047483, bug 1079301, bug 1079335) for webplatform test failures.
Backed out changeset 7d06b68c44d0 (bug 1079335)
Backed out changeset 92030169528e (bug 1079301)
Backed out changeset c09d7f95554a (bug 1047483)
Backed out changeset c199f1057d7e (bug 1047483)
Backed out changeset 18830d07884c (bug 1047483)
Backed out changeset e087289ccfbb (bug 1047483)
Backed out changeset 6238ff5d3ed0 (bug 1047483)

CLOSED TREE

--HG--
rename : content/base/public/File.h => content/base/public/nsDOMFile.h
rename : content/base/src/MultipartFileImpl.cpp => content/base/src/nsDOMBlobBuilder.cpp
rename : content/base/src/MultipartFileImpl.h => content/base/src/nsDOMBlobBuilder.h
rename : content/base/src/File.cpp => content/base/src/nsDOMFile.cpp
2014-10-07 13:16:11 -04:00
Andrea Marchesini d272279126 Bug 1047483 - patch 1 - Porting DOMFile/DOMBlob to WebIDL, r=bz, r=bkelly, r=bholley 2014-10-07 15:20:52 +01:00
Ting-Yu Chou 149aa09b67 Bug 1064800 - Catch exception from sending message to prevent interrupting execution. r=khuey 2014-10-02 10:57:48 +08:00
Mike Habicher c0376bc34a Bug 1053966 - move mozsettings-changed Observer info from aSubject to aData, r=bz,qDot 2014-09-16 13:15:16 -04:00
Kyle Machulis 0b5f5b17f3 Bug 1071721 - Call destroyDOMRequestHelper on SettingsLock after transaction ends; r=bent 2014-09-23 13:13:50 -07:00
Kyle Machulis 4cb996a29c Bug 1069605 - Make sure settings lock exists before trying to remove it; r=bent 2014-09-18 17:23:27 -07:00
Kyle Machulis abed0464a7 Bug 1069605 - Only send messages in SettingsLocks when window is live; r=bent 2014-09-18 17:23:00 -07:00
Kyle Machulis e752fcb527 Bug 1068962 - Fix task cleanup on settings locks where finalize has already been called; r=bent
--HG--
extra : rebase_source : 18992e6c2e0277d2866fe92048b52a0a55a55ee6
2014-09-18 13:43:40 -07:00
Kyle Machulis f52164c1b5 Bug 1068962 - Fix settings lock ownership array splice; r=bent
--HG--
extra : rebase_source : 0374ddeaffe0936ac7bb78aff0fc5b3a467c3bd1
2014-09-18 10:08:36 -07:00
Ryan VanderMeulen d3fce43e7e Backed out changeset ed586ca080c0 (bug 1053966) for the same Mnw permafails it was backed out for previously. 2014-09-16 16:54:25 -04:00
Mike Habicher e9ff4e12a0 Bug 1053966 - move mozsettings-changed Observer info from aSubject to aData, r=bz,qDot 2014-09-16 13:15:16 -04:00
Kyle Machulis ce3b825689 Bug 1065128 - Fix SettingsRequestManager storage of MessageManager Principals; r=bent 2014-09-15 13:39:20 -07:00
Kyle Machulis 10c38bbb14 Bug 1065128 - Make SettingsManager use dom-window-destroyed for shutdown; r=bent 2014-09-15 13:39:20 -07:00
Kyle Machulis b979b13529 Bug 1061805 - Make sure Settings API only calls finalize once; r=bent 2014-09-15 09:29:29 -07:00
Kyle Machulis ac100d8a06 Bug 1062087 - Fix undefined variable error messages in Settings API; r=bent 2014-09-05 18:39:54 -07:00
Kyle Machulis 086f4f8e2b Bug 1061510 - Make settings api always check principals for permissions; r=bent
--HG--
extra : rebase_source : ece6c6808f391f5dd0661cb3c7acbc942d8bb4ac
2014-09-04 11:15:10 -07:00
Kevin Grandon 85f5f1661a Bug 1061902 - [SettingsDB] Bump version number. r=gwagner 2014-09-02 13:40:00 +02:00
Kyle Machulis 37040d9da2 Bug 1060934 - Remove SettingsQueue.jsm file; r=fabrice a=2.1 2014-08-31 14:42:47 -07:00
Kyle Machulis d135eae513 Bug 1060691 - Fix error message comparison test; a=kwierso 2014-08-29 18:09:46 -07:00
Kyle Machulis 54c4948e67 Bug 1060691 - Clean up settings api debug messages; r=gwagner a=2.1 2014-08-29 16:36:02 -07:00
Kyle Machulis 672ec602c2 Bug 1015518 - Update SettingsService mochitests; r=bent 2014-08-27 21:01:31 -07:00
Kyle Machulis 8ae0266d8f Bug 1015518 - Use SettingsRequestManager as SettingsService Backend; r=bent 2014-08-27 21:01:31 -07:00
Kyle Machulis 1a050f739f Bug 900551 - Mochitests for settings permissions; r=bent r=ehsan 2014-08-27 21:01:30 -07:00
Kyle Machulis 7d5df891b8 bug 900551 - Settings API OOP; r=bent 2014-08-27 21:01:29 -07:00
Kyle Machulis 5738eae835 Bug 846200 - Update mochitests to use new settings-api permissions; r=bent
--HG--
extra : rebase_source : edf9accf26a49a541c2f87847c2fe89c42a20fd6
2014-08-27 21:01:29 -07:00
Kyle Machulis 93c0c45ea9 Bug 846200 - Support for granting settings permissions on a per-permission basis; r=bent
--HG--
extra : rebase_source : 941bc56c900d6eb96a49af80be2b328155c0ea45
2014-08-27 21:01:29 -07:00
Ryan VanderMeulen a408d636f2 Backed out 11 changesets (bug 1059079, bug 1015518, bug 900551, bug 846200) for Gaia UI test failures on a CLOSED TREE.
Backed out changeset d85b4e48b3b4 (bug 1015518)
Backed out changeset 663b73ba69ec (bug 1015518)
Backed out changeset 5cf1cb5fa022 (bug 900551)
Backed out changeset b953dd5bfdaa (bug 900551)
Backed out changeset a2b6d7c84100 (bug 900551)
Backed out changeset ceb79fe83d15 (bug 900551)
Backed out changeset f6acf344fbf0 (bug 900551)
Backed out changeset fa269ea53937 (bug 846200)
Backed out changeset b89c84a850f9 (bug 846200)
Backed out changeset b7a7dfbe4e3f (bug 846200)
Backed out changeset c6f54d821c11 (bug 1059079)
2014-08-28 12:49:49 -04:00
Kyle Machulis 5fb64db8dc Bug 1015518 - Update SettingsService mochitests; r=bent 2014-08-27 21:01:31 -07:00
Kyle Machulis 2efdf70b95 Bug 1015518 - Use SettingsRequestManager as SettingsService Backend; r=bent 2014-08-27 21:01:31 -07:00
Kyle Machulis b73343a4d7 Bug 900551 - Mochitests for settings permissions; r=bent r=ehsan 2014-08-27 21:01:30 -07:00
Kyle Machulis 91d2336a9b Bug 900551 - Settings API OOP; r=bent 2014-08-27 21:01:29 -07:00
Kyle Machulis 4c6ba3bb66 Bug 846200 - Update mochitests to use new settings-api permissions; r=bent 2014-08-27 21:01:29 -07:00
Kyle Machulis e82cbad302 Bug 846200 - Support for granting settings permissions on a per-permission basis; r=bent 2014-08-27 21:01:29 -07:00
Edgar Chen d4208bc2a3 Bug 1053733 - SettingsManager sends register message to SettingsChangeNotifier again when receives Settings:Notifier:Init:OK. r=qdot 2014-08-14 12:17:39 +08:00
Kyle Machulis 32f44dc609 Backing out b5d49f1885af as it wasn't properly backed out in 0611006cc095
--HG--
extra : rebase_source : 22687deeeee7abd76e424b21bec8fc59fb6f7515
2014-08-20 13:37:55 -07:00
Kyle Machulis de2e16fbcc Backed out d71120161e89 b5d49f1885af (bug 846200) due to missing xpc shell test fix patch 2014-08-20 12:01:18 -07:00
Kyle Machulis 8314f89f2a Bug 846200 - Update mochitests to use new settings-api permissions 2014-08-20 10:40:40 -07:00
Kyle Machulis 86a6d3c36d Bug 846200 - Support for granting settings permissions on a per-permission basis 2014-08-20 10:40:37 -07:00
Ed Morley 0f03572425 Backed out changeset a880d4e0d656 (bug 846200) for xpcshell failures in test_bug808734.js; CLOSED TREE 2014-08-19 09:17:30 +01:00
Ed Morley 152097bf8e Backed out changeset b01c7abafbdf (bug 846200) 2014-08-19 09:17:06 +01:00
Kyle Machulis 403e7ddfa5 Bug 846200 - Update mochitests to use new settings-api permissions; r=bent 2014-08-18 22:06:59 -07:00