f704cd46d3
Bug 1563370 - Eliminate GetPrevInFlowVirtual() and GetNextInFlowVirtual(). r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D36829
--HG--
extra : moz-landing-system : lando
2019-07-03 21:37:14 +00:00
3a4933eb98
Bug 1549267 Part 1 - Remove NS_INTRINSICSIZE and NS_AUTOHEIGHT. r=mats
...
This patch is generated by the following steps.
1) Manually delete NS_INTRINSICSIZE and NS_AUTOHEIGHT in LayoutConstants.
2) Run the following script.
```
#!/bin/bash
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename NS_INTRINSICSIZE NS_UNCONSTRAINEDSIZE
rename NS_AUTOHEIGHT NS_UNCONSTRAINEDSIZE
```
3) ./mach clang-format
Differential Revision: https://phabricator.services.mozilla.com/D31696
--HG--
extra : moz-landing-system : lando
2019-06-04 23:41:20 +00:00
12867b1a3f
Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt
...
Differential Revision: https://phabricator.services.mozilla.com/D18734
2019-02-07 11:15:36 +01:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
1d9848a22a
Bug 916972 - Eliminate nsIFrame::GetSplittableType() completely. r=mats,dholbert
...
Currently, GetSplittableType() is called only in
nsCSSFrameConstructor::CreateContinuingFrame(). The splittable concrete frames
should inherit from nsSplittableFrame, and must explicitly create continuing
frame in CreateContinuingFrame(). Thus, no need to maintain GetSplittableType().
Differential Revision: https://phabricator.services.mozilla.com/D10798
--HG--
extra : moz-landing-system : lando
2018-11-05 19:11:12 +00:00
017ca214c1
Bug 1488684 - Made some layout methods 'final' or non-virtual - r=dbaron
...
Some methods were not overrides and were never overridden, so they could simply
be non-virtual.
Others were overrides but were not overridden, so they could benefit from being
final to hopefully lead to devirtualized calls.
Though some of these are not strictly necessary because they are inside 'final'
classes, I think they're worth adding anyway, because:
- The 'final' keyword becomes more obvious when looking at methods without the
wider context in sight (e.g., in reviews or searchfox).
- If one day any of these classes becomes non-final, it would keep the final
attribute on these methods by default, and force the programmer to explicitly
reflect before removing 'final' from the methods that need to be overridden.
Depends on D5020
Differential Revision: https://phabricator.services.mozilla.com/D5021
--HG--
extra : moz-landing-system : lando
2018-09-06 01:23:49 +00:00
e341b20ec4
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
5dd797f154
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
ca5ac79cca
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
25cd0c37f7
Bug 1400618 part 1 - Collect NAC / generated content and call DestroyAnonymousContent / UnbindFromTree on those after the frames are destroyed. r=bz
...
MozReview-Commit-ID: 2trDgeJPw25
2017-11-07 01:20:33 +01:00
680815cd6e
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
41e56eef86
Bug 1405875 - Remove old dump/compare regression data methods on frames, and nsIFrameUtil interface and implementation. r=mats
...
These became unused as a result of the removal of nsRegressionTester and
the removal of the printing debug file mechanism, earlier in this patch
sequence.
MozReview-Commit-ID: 9Tftf2AjpPb
2017-10-05 11:15:57 -07:00
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
a254b64145
Bug 1364805 part 4 - Remove the now unused LayoutFrameType values from the ctors. r=jfkthame
...
MozReview-Commit-ID: 1RSDoc3pQXf
2017-05-26 12:11:11 +02:00
1242172259
Bug 1364805 part 2 - Add a nsIFrame::mClass field and propagate the concrete class' value up the ctor chain. r=jfkthame
...
nsIFrame::mClass is of type enum class nsQueryFrame::ClassID which is
a strict subset of the nsQueryFrame::FrameIID values. For a concrete
frame class, its FrameIID is the same numeric value as its ClassID.
MozReview-Commit-ID: 1N0AkCGo1ol
2017-05-26 12:11:11 +02:00
23bce99ae1
Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
...
This avoids conflicts with mozilla::dom::FrameType.
MozReview-Commit-ID: 7aEMbHRaTFk
--HG--
extra : rebase_source : 2d01321f5ce0ec8c0e3f70984674f82678034b3c
2017-05-01 19:32:52 +02:00
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
4cb897b943
Bug 1232194 part 2 - [writing-mode] Make ConsumedBSize() return the block-axis size, not the physical height. r=dholbert
2017-01-04 00:56:19 +01:00
10150aa1b7
Bug 1232194 part 1 - [writing-mode] Drop "Get" from GetConsumedBSize() and add a WritingMode param. r=dholbert
2017-01-04 00:56:19 +01:00
2a625e574c
Bug 1316556 - Remove zeroing allocation in class nsIPresShell. r=dbaron.
...
--HG--
extra : rebase_source : 203c4848cf0fe321b429c78ddf71acd662755e6d
2016-12-01 09:06:50 +01:00
40fcd21b9a
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
--HG--
extra : rebase_source : c91a2e174a0baec60c1b0111ac7636295004ab35
2016-07-21 18:36:39 +08:00
820f88de49
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
--HG--
extra : rebase_source : 623ec822996ba0ea0058dd137acf5a658cdea04a
2016-07-21 18:36:35 +08:00
29fbc46336
Bug 1144096 part 15 - [css-grid] Compute our pre-reflow logical skip sides and cache the result of ComputedLogicalBorderPadding() with that applied. r=dholbert
...
Our "pre-reflow logical skip sides" assumes each fragment will be
the last and have a block-end border. We then skip the block-end
side at the end of Reflow if we're INCOMPLETE. This simplifies
the logic that checks how many rows fits in this fragment.
2016-03-11 17:39:26 +01:00
a1dd9fc19e
Bug 1216332 - Remove framearena helpers from abstract frame classes and stop them from being instantiated. r=dbaron
...
--HG--
extra : source : 9f59591f02706190e56db8ad89ff5a769b5c47dd
2015-11-04 20:57:35 +11:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
2b84010cb8
Bug 1048246 - Fix more bad implicit constructors in layout; r=roc
...
--HG--
extra : rebase_source : ed828993139bc70232508364a9f046e38b7d3e06
2014-08-07 19:48:38 -04:00
3ffa9baecc
Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc
2014-06-28 10:13:13 +00:00
811c3783d4
Back out 5 changesets (bug 1028460, bug 1031444) for somehow breaking asmjscache/test/test_cachingBasic.html on Android 2.2
...
Backed out changeset 0b5918ec6521 (bug 1031444)
Backed out changeset 663ff18cd4a1 (bug 1028460)
Backed out changeset ae01b3919c8c (bug 1028460)
Backed out changeset 316c8dfeca9b (bug 1028460)
Backed out changeset e237b2c61ea2 (bug 1028460)
2014-06-28 22:01:28 -07:00
4e879335f7
Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc
2014-06-28 10:13:13 +00:00
3e13115cf3
Bug 1025669 - part 0, Add BaseMargin::ApplySkipSides, remove nsIFrame::Apply*SkipSides, and change call sites to use the former. r=roc
2014-06-24 17:52:19 +00:00
82f2df73ba
Bug 789096 patch 8: use logical coordinates in nsBlockReflowState. r=jfkthame
2014-06-20 02:55:35 -07:00
399be41768
Bug 508665 - part 5, Make nsIFrame::Init require a nsContainerFrame* for the parent frame param. r=roc
2014-05-24 22:20:40 +00:00
e10e094099
Use logical text layout API for GetSkipSides, bug 789096, r=jfkthame
2014-03-13 00:39:33 -07:00
ea10325852
Backed out changeset 534a0efe7d3d (bug 789096)
2014-03-11 09:22:48 +01:00
e7b593f84c
Use logical text layout API for GetSkipSides. Bug 789096, r=jfkthame
2014-03-10 22:19:03 -07:00
a127266e74
Bug 974687 - Part 1: Add about 300 MOZ_OVERRIDE in layout/. r=dholbert
2014-02-24 09:41:56 -05:00
aa859ecb8b
Bug 919813 part 1: Remove never-checked return value from frame methods SetPrevInFlow, SetNextInFlow, SetPrevContinuation, SetNextContinuation. r=mats
2013-09-25 10:54:55 -07:00
4974add798
Bug 919318 - Drop the Get prefix on the frame methods GetFirstContinuation, GetLastContinuation, GetFirstInFlow, GetLastInFlow and also on nsLayoutUtils::GetLastContinuationWithChild, because they never return null. r=dholbert
2013-09-25 11:42:34 +00:00
a1817949ef
Bug 743402, Part 4: Refactor ApplySkipSides() and GetSkipSides() to return the correct value during reflow by adding an optional nsHTMLReflowState parameter. [r=roc]
2013-07-25 10:34:27 -05:00
b806b3e3c9
Bug 743402, Part 2: Pull GetEffectiveComputedHeight() into nsSplittableFrame and refactor it to utilize consumed height for paginated content. [r=roc]
2013-07-25 10:34:16 -05:00
997046b750
Bug 743402, Part 1: Add a GetConsumedHeight() function to nsSplittableFrame in order to retrieve the portion of the computed height that was consumed by previous-in-flows. [r=roc]
2013-07-25 10:34:12 -05:00
6e81109389
Backed out 6 changesets (bug 743402) for reftest failures on a CLOSED TREE.
...
Backed out changeset 19848fff857e (bug 743402)
Backed out changeset 049168537ae0 (bug 743402)
Backed out changeset 3098fea37f2d (bug 743402)
Backed out changeset ada93e976dca (bug 743402)
Backed out changeset c7907c54187f (bug 743402)
Backed out changeset 2edbbf6440c4 (bug 743402)
2013-07-24 15:14:04 -04:00
e963713207
Bug 743402, Part 4: Refactor ApplySkipSides() and GetSkipSides() to return the correct value during reflow by adding an optional nsHTMLReflowState parameter. [r=roc]
2013-07-24 12:47:17 -05:00
21103de30a
Bug 743402, Part 2: Pull GetEffectiveComputedHeight() into nsSplittableFrame and refactor it to utilize consumed height for paginated content. [r=roc]
2013-07-24 12:47:06 -05:00
528cb9f1bf
Bug 743402, Part 1: Add a GetConsumedHeight() function to nsSplittableFrame in order to retrieve the portion of the computed height that was consumed by previous-in-flows. [r=roc]
2013-07-24 12:47:01 -05:00
623d2ed378
Bug 870516: Annotate ~600 more methods with MOZ_OVERRIDE in /layout r=dholbert
2013-05-14 09:33:23 -07:00
7f102d7f2d
Bug 852428 part 2. Make nsIFrame::Init infallible. r=dholbert
2013-03-19 21:47:48 -04:00
a84a1b22ad
Bug 733186: Annotate ~1000 methods with MOZ_OVERRIDE in /layout r=dholbert r=dbaron
2012-09-14 09:10:08 -07:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Ting-Yu Lin
Emilio Cobos Álvarez
Sylvestre Ledru
Gerald Squelart
Mats Palmgren
Daniel Holbert
L. David Baron
Julian Seward
Xidorn Quan
Ehsan Akhgari
Phil Ringnalda
Simon Montagu
Mats Palmgren
Carsten "Tomcat" Book
Arnaud Sourioux
Scott Johnson
Ryan VanderMeulen
Boris Zbarsky
Gervase Markham