c8e0f87391
Bug 1519636 - First reformat with clang-format 13.0.0. r=firefox-build-system-reviewers,sylvestre,mhentges
...
Updated with clang-format version 13.0.0 (taskcluster-OgjH5lasS5K_fvefdRcJVg)
Depends on D131114
Differential Revision: https://phabricator.services.mozilla.com/D129119
2021-11-16 08:07:30 +00:00
f9387365a0
Bug 1728279 - Use MOZ_WIDGET_ANDROID instead of ANDROID in GraphDriver.cpp. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D124043
2021-08-31 11:38:48 +00:00
cd9af3411c
Bug 1724997 - Add tracing markers for more MediaTrackGraph events. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D122739
2021-08-26 09:15:40 +00:00
a7b4d10bbb
Bug 1724994 - Promote GraphRunner to higher priority on Android. r=agi,pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D123346
2021-08-24 15:13:31 +00:00
3f7ea18b28
Bug 1727311 - Fix four clang-tidy warnings in GraphRunner.cpp. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D123443
2021-08-24 14:07:17 +00:00
1e9929f09f
Bug 1666116 - Account for fallback in NotifyWhenGraphStarted. r=padenot
...
Unittests using GoFaster mode may start iterating the audio driver faster before
its fallback has completed handover to the audio callback. This causes the
preSilenceSamples check to spike and the test fails.
Waiting for the fallback to finish handing over fixes this.
To accomodate this, this patch also constifies some methods as needed to check
InIteration() when const.
Differential Revision: https://phabricator.services.mozilla.com/D97413
2020-11-30 14:16:57 +00:00
74a8690e5f
Bug 1605134 - Rename StateComputedEnd to StateComputedTime. r=padenot
...
StateComputedEnd was likely a typo back in the day. The member in the graph is
mStateComputedTime, so let's center around that.
Differential Revision: https://phabricator.services.mozilla.com/D97404
2020-11-30 14:16:31 +00:00
011cf4e1e0
Backed out 21 changesets (bug 1666116, bug 1605134) for build bustage at checkouts/gecko/dom/media/gtest/WaitFor.h on a CLOSED TREE
...
Backed out changeset fedcb7e94929 (bug 1666116)
Backed out changeset 506522ae896e (bug 1666116)
Backed out changeset 351419be5c0d (bug 1666116)
Backed out changeset 93aef991a475 (bug 1666116)
Backed out changeset 9e2a2c13ef60 (bug 1666116)
Backed out changeset 81d82ce7eecd (bug 1605134)
Backed out changeset 18ca27b07da3 (bug 1605134)
Backed out changeset addf9298c4fe (bug 1605134)
Backed out changeset c3cf634bffb3 (bug 1605134)
Backed out changeset 2747068f6397 (bug 1605134)
Backed out changeset ac23d3b40f2d (bug 1605134)
Backed out changeset c010356d4a48 (bug 1605134)
Backed out changeset ce6924b1f900 (bug 1605134)
Backed out changeset e88bb30c3221 (bug 1605134)
Backed out changeset efa10675b86d (bug 1605134)
Backed out changeset 3c5d3f8baf28 (bug 1605134)
Backed out changeset bffa738ccb6f (bug 1605134)
Backed out changeset c8143eab62d2 (bug 1605134)
Backed out changeset 7dfb915d51ef (bug 1605134)
Backed out changeset 9bce7dcae91c (bug 1605134)
Backed out changeset 3714fa7460ce (bug 1605134)
2020-11-30 16:12:25 +02:00
b46912a84d
Bug 1666116 - Account for fallback in NotifyWhenGraphStarted. r=padenot
...
Unittests using GoFaster mode may start iterating the audio driver faster before
its fallback has completed handover to the audio callback. This causes the
preSilenceSamples check to spike and the test fails.
Waiting for the fallback to finish handing over fixes this.
To accomodate this, this patch also constifies some methods as needed to check
InIteration() when const.
Differential Revision: https://phabricator.services.mozilla.com/D97413
2020-11-21 01:21:23 +00:00
7bc4c2f650
Bug 1605134 - Rename StateComputedEnd to StateComputedTime. r=padenot
...
StateComputedEnd was likely a typo back in the day. The member in the graph is
mStateComputedTime, so let's center around that.
Differential Revision: https://phabricator.services.mozilla.com/D97404
2020-11-21 01:19:48 +00:00
61193c6032
Backed out 16 changesets (bug 1666116, bug 1605134) for GTest failures on TestAudioTrackGraph . CLOSED TREE
...
Backed out changeset dba15089f5d3 (bug 1666116)
Backed out changeset c529b6732b08 (bug 1666116)
Backed out changeset 3225cdc96f82 (bug 1666116)
Backed out changeset 06ced7ee7c2c (bug 1666116)
Backed out changeset f65dbe0c4c64 (bug 1605134)
Backed out changeset dda7d98d3da7 (bug 1605134)
Backed out changeset 6fed7e4730c5 (bug 1605134)
Backed out changeset 9859d35abce6 (bug 1605134)
Backed out changeset e5fb448bbadf (bug 1605134)
Backed out changeset 3ef7199a547a (bug 1605134)
Backed out changeset c24bff49f331 (bug 1605134)
Backed out changeset f8612b562aa7 (bug 1605134)
Backed out changeset 0ba16e1f73ae (bug 1605134)
Backed out changeset 0736167ed294 (bug 1605134)
Backed out changeset 56ead9091c47 (bug 1605134)
Backed out changeset 841eedd33424 (bug 1605134)
2020-11-19 22:09:39 +02:00
ea27597884
Bug 1666116 - Account for fallback in NotifyWhenGraphStarted. r=padenot
...
Unittests using GoFaster mode may start iterating the audio driver faster before
its fallback has completed handover to the audio callback. This causes the
preSilenceSamples check to spike and the test fails.
Waiting for the fallback to finish handing over fixes this.
To accomodate this, this patch also constifies some methods as needed to check
InIteration() when const. It also waits for audio drivers to start per the above
in TestCrossGraphTrack as that test may otherwise exhibit this bug with bug
1605314 applied.
Differential Revision: https://phabricator.services.mozilla.com/D97413
2020-11-19 15:50:24 +00:00
db42f60835
Bug 1605134 - Rename StateComputedEnd to StateComputedTime. r=padenot
...
StateComputedEnd was likely a typo back in the day. The member in the graph is
mStateComputedTime, so let's center around that.
Differential Revision: https://phabricator.services.mozilla.com/D97404
2020-11-19 15:48:59 +00:00
31c90d555d
Bug 1653667 don't attempt to promote GraphRunner thread on Linux r=padenot
...
This usually fails due to sandbox policy.
When the sandbox is disabled, the realtime promotion can result in SIGKILL
if/when script runs too long. This can be re-introduced when thread demotion
is moved to a thread that is not blocked on script, which may be part of
the solution to https://bugzilla.mozilla.org/show_bug.cgi?id=1628198 .
Depends on D84941
Differential Revision: https://phabricator.services.mozilla.com/D84942
2020-07-27 14:47:51 +00:00
0a1151e126
Bug 1625372 request interrupt of AudioWorklet JS on force shutdown r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D71915
2020-05-15 08:24:06 +00:00
0da2867bf2
Backed out 5 changesets (bug 1625372) for assertion failures on GraphDriver.cpp. CLOSED TREE
...
Backed out changeset b9feee4f447c (bug 1625372)
Backed out changeset d86f066bd68b (bug 1625372)
Backed out changeset 7a38398623f8 (bug 1625372)
Backed out changeset 6e9928fb37d1 (bug 1625372)
Backed out changeset ca93e9921c05 (bug 1625372)
2020-05-13 13:09:22 +03:00
53bf89e445
Bug 1625372 request interrupt of AudioWorklet JS on force shutdown r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D71915
2020-05-12 07:10:51 +00:00
88b8c3cca3
Bug 1626319 - Change async callback logger to log per thread-id. r=padenot
...
TRACE_AUDIO_CALLBACK() and TRACE_AUDIO_CALLBACK_COMMENT(aFmt, ...) log to a hardcoded thread id number. This creates confusion when more than one MTG is running because logs from different threads are depicted to the same thread line and overlapping each other. Those logging commands have been removed and the TRACE* command is used that it logs per thread-id.
Differential Revision: https://phabricator.services.mozilla.com/D69031
--HG--
extra : moz-landing-system : lando
2020-04-07 10:45:52 +00:00
09a00207a1
Bug 1596655 Wake up MediaTrackGraph thread on MessagePort messages r=padenot
...
Depends on D65071
Differential Revision: https://phabricator.services.mozilla.com/D65072
--HG--
extra : moz-landing-system : lando
2020-03-03 18:16:54 +00:00
a4fbb9b878
Bug 1586370 - Pass IterationEnd up to the graph rather than back-querying the driver. r=padenot
...
This makes it simpler to maintain state in the GraphDriver in more complex
cases, such as when an AudioCallbackDriver is backed by a fallback driver.
Differential Revision: https://phabricator.services.mozilla.com/D57553
--HG--
extra : moz-landing-system : lando
2019-12-18 22:52:24 +00:00
7502376eec
Bug 1586370 - Rename GraphDriver::OnGraphThread to InIteration. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D56081
--HG--
extra : moz-landing-system : lando
2019-12-18 22:51:45 +00:00
a9ee750781
Bug 1586370 - Return a flexible object from OneIteration. r=padenot
...
This will let us get rid of such GraphDriver dependencies on MediaTrackGraphImpl
as SignalMainThreadCleanup and SetCurrentDriver.
Differential Revision: https://phabricator.services.mozilla.com/D56076
--HG--
extra : moz-landing-system : lando
2019-12-18 22:51:05 +00:00
179e64799a
Bug 1586370 - Move AudioMixer from MTG to AudioCallbackDriver. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D56070
--HG--
extra : moz-landing-system : lando
2019-12-18 22:50:00 +00:00
086fa3ac13
Bug 1565956 use an nsThread for GraphRunner to support MessagePort r=pehrsons
...
MessagePort::Dispatch(), for example, uses NS_DispatchToCurrentThread(), which
assumes nsThread.
Differential Revision: https://phabricator.services.mozilla.com/D53128
--HG--
extra : moz-landing-system : lando
2019-11-25 21:55:36 +00:00
23ebd10305
Backed out 3 changesets (bug 1565956) for crashes complaining about MediaTrackGraphImpl CLOSED TREE
...
Backed out changeset 15e4c2726222 (bug 1565956)
Backed out changeset 4b18de79a6e3 (bug 1565956)
Backed out changeset 1e45f56e21fb (bug 1565956)
2019-11-21 09:19:51 +02:00
2d353c6d2c
Bug 1565956 use an nsThread for GraphRunner to support MessagePort r=pehrsons
...
MessagePort::Dispatch(), for example, uses NS_DispatchToCurrentThread(), which
assumes nsThread.
Differential Revision: https://phabricator.services.mozilla.com/D53128
--HG--
extra : moz-landing-system : lando
2019-11-20 23:52:49 +00:00
1bdb34c6ec
Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug
...
This renames the following (in alphabetical order, non-exhaustive):
AudioCaptureStream -> AudioCaptureTrack
AudioNodeStream -> AudioNodeTrack
AudioNodeExternalInputStream -> AudioNodeExternalInputTrack
DirectMediaStreamTrackListener -> DirectMediaTrackListener
MediaStream -> MediaTrack
- Note that there's also dom::MediaTrack. Namespaces differentiate them.
MediaStreamGraph -> MediaTrackGraph
MediaStreamTrackListener -> MediaTrackListener
MSG -> MTG (in comments)
ProcessedMediaStream -> ProcessedMediaTrack
SharedDummyStream -> SharedDummyTrack
SourceMediaStream -> SourceMediaTrack
StreamTime -> TrackTime
TrackUnionStream -> ForwardedInputTrack
- Because this no longer takes a union of anything, but only a single track
as input.
Other minor classes, members and comments have been updated to reflect these
name changes.
Differential Revision: https://phabricator.services.mozilla.com/D46146
--HG--
rename : dom/media/AudioCaptureStream.cpp => dom/media/AudioCaptureTrack.cpp
rename : dom/media/AudioCaptureStream.h => dom/media/AudioCaptureTrack.h
rename : dom/media/TrackUnionStream.cpp => dom/media/ForwardedInputTrack.cpp
rename : dom/media/TrackUnionStream.h => dom/media/ForwardedInputTrack.h
rename : dom/media/MediaStreamGraph.cpp => dom/media/MediaTrackGraph.cpp
rename : dom/media/MediaStreamGraph.h => dom/media/MediaTrackGraph.h
rename : dom/media/MediaStreamGraphImpl.h => dom/media/MediaTrackGraphImpl.h
rename : dom/media/MediaStreamListener.cpp => dom/media/MediaTrackListener.cpp
rename : dom/media/MediaStreamListener.h => dom/media/MediaTrackListener.h
rename : dom/media/webaudio/AudioNodeExternalInputStream.cpp => dom/media/webaudio/AudioNodeExternalInputTrack.cpp
rename : dom/media/webaudio/AudioNodeExternalInputStream.h => dom/media/webaudio/AudioNodeExternalInputTrack.h
rename : dom/media/webaudio/AudioNodeStream.cpp => dom/media/webaudio/AudioNodeTrack.cpp
rename : dom/media/webaudio/AudioNodeStream.h => dom/media/webaudio/AudioNodeTrack.h
extra : moz-landing-system : lando
2019-10-02 10:23:02 +00:00
40dae37e00
Backed out 7 changesets (bug 1454998) for build bustages at MediaTrackGraph.h on a CLOSED TREE.
...
Backed out changeset 80417bdfa721 (bug 1454998)
Backed out changeset 8ff03f2f4ca2 (bug 1454998)
Backed out changeset ae6056b748d1 (bug 1454998)
Backed out changeset ab721cb2066b (bug 1454998)
Backed out changeset d0e8d413cd1c (bug 1454998)
Backed out changeset 3ce4dc7e9ae2 (bug 1454998)
Backed out changeset 6105a4176729 (bug 1454998)
--HG--
rename : dom/media/AudioCaptureTrack.cpp => dom/media/AudioCaptureStream.cpp
rename : dom/media/AudioCaptureTrack.h => dom/media/AudioCaptureStream.h
rename : dom/media/MediaTrackGraph.cpp => dom/media/MediaStreamGraph.cpp
rename : dom/media/MediaTrackGraph.h => dom/media/MediaStreamGraph.h
rename : dom/media/MediaTrackGraphImpl.h => dom/media/MediaStreamGraphImpl.h
rename : dom/media/MediaTrackListener.cpp => dom/media/MediaStreamListener.cpp
rename : dom/media/MediaTrackListener.h => dom/media/MediaStreamListener.h
rename : dom/media/ForwardedInputTrack.cpp => dom/media/TrackUnionStream.cpp
rename : dom/media/ForwardedInputTrack.h => dom/media/TrackUnionStream.h
rename : dom/media/webaudio/AudioNodeExternalInputTrack.cpp => dom/media/webaudio/AudioNodeExternalInputStream.cpp
rename : dom/media/webaudio/AudioNodeExternalInputTrack.h => dom/media/webaudio/AudioNodeExternalInputStream.h
rename : dom/media/webaudio/AudioNodeTrack.cpp => dom/media/webaudio/AudioNodeStream.cpp
rename : dom/media/webaudio/AudioNodeTrack.h => dom/media/webaudio/AudioNodeStream.h
2019-10-02 11:46:23 +03:00
36d89d91c8
Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug
...
This renames the following (in alphabetical order, non-exhaustive):
AudioCaptureStream -> AudioCaptureTrack
AudioNodeStream -> AudioNodeTrack
AudioNodeExternalInputStream -> AudioNodeExternalInputTrack
DirectMediaStreamTrackListener -> DirectMediaTrackListener
MediaStream -> MediaTrack
- Note that there's also dom::MediaTrack. Namespaces differentiate them.
MediaStreamGraph -> MediaTrackGraph
MediaStreamTrackListener -> MediaTrackListener
MSG -> MTG (in comments)
ProcessedMediaStream -> ProcessedMediaTrack
SharedDummyStream -> SharedDummyTrack
SourceMediaStream -> SourceMediaTrack
StreamTime -> TrackTime
TrackUnionStream -> ForwardedInputTrack
- Because this no longer takes a union of anything, but only a single track
as input.
Other minor classes, members and comments have been updated to reflect these
name changes.
Differential Revision: https://phabricator.services.mozilla.com/D46146
--HG--
rename : dom/media/AudioCaptureStream.cpp => dom/media/AudioCaptureTrack.cpp
rename : dom/media/AudioCaptureStream.h => dom/media/AudioCaptureTrack.h
rename : dom/media/TrackUnionStream.cpp => dom/media/ForwardedInputTrack.cpp
rename : dom/media/TrackUnionStream.h => dom/media/ForwardedInputTrack.h
rename : dom/media/MediaStreamGraph.cpp => dom/media/MediaTrackGraph.cpp
rename : dom/media/MediaStreamGraph.h => dom/media/MediaTrackGraph.h
rename : dom/media/MediaStreamGraphImpl.h => dom/media/MediaTrackGraphImpl.h
rename : dom/media/MediaStreamListener.cpp => dom/media/MediaTrackListener.cpp
rename : dom/media/MediaStreamListener.h => dom/media/MediaTrackListener.h
rename : dom/media/webaudio/AudioNodeExternalInputStream.cpp => dom/media/webaudio/AudioNodeExternalInputTrack.cpp
rename : dom/media/webaudio/AudioNodeExternalInputStream.h => dom/media/webaudio/AudioNodeExternalInputTrack.h
rename : dom/media/webaudio/AudioNodeStream.cpp => dom/media/webaudio/AudioNodeTrack.cpp
rename : dom/media/webaudio/AudioNodeStream.h => dom/media/webaudio/AudioNodeTrack.h
extra : moz-landing-system : lando
2019-10-02 08:18:16 +00:00
356d945008
Bug 1429847 - Promote the GraphRunner thread. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D32499
--HG--
extra : moz-landing-system : lando
2019-06-21 19:51:22 +00:00
c10664f1c1
Bug 1533675 - Name all threads in Firefox r=Ehsan
...
This patch adds thread names where they are missing
Differential Revision: https://phabricator.services.mozilla.com/D33839
--HG--
extra : moz-landing-system : lando
2019-06-06 21:07:29 +00:00
fd627991c1
Bug 1538640 wait for GraphRunner thread shutdown r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D24673
--HG--
extra : moz-landing-system : lando
2019-03-26 00:13:55 +00:00
faa25fa90f
bug 1538630 Check a predicate when waiting on condition variables in GraphRunner r=pehrsons
...
so as to respond appropriately to spurious wakeups.
Checking the predicate before the first wait in Run() makes the mStarted
notification unnecessary.
Differential Revision: https://phabricator.services.mozilla.com/D24672
--HG--
extra : moz-landing-system : lando
2019-03-25 22:49:02 +00:00
7c60fdd3a1
Bug 1535214 run AudioWorklet for realtime AudioContext on GraphRunner thread r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D23445
--HG--
extra : moz-landing-system : lando
2019-03-14 13:40:07 +00:00
43f191c096
Bug 1534238 - Initialize GraphRunner::mThread last. r=padenot
...
The thread may pre-empt the thread running the ctor and launch GraphRunner::Run
with uninitialized members. This patch ensures they are initialized first.
Differential Revision: https://phabricator.services.mozilla.com/D22963
--HG--
extra : moz-landing-system : lando
2019-03-11 13:18:04 +00:00
acf9d0ab88
Bug 1473469 - Make MediaStreamGraph run on a single thread with AudioWorklets enabled. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D20828
--HG--
extra : moz-landing-system : lando
2019-03-06 20:12:25 +00:00
9d67bf069c
Backed out changeset 45c838c4137d (bug 1473469) for various dom/worklet/ failures. CLOSED TREE
2019-03-01 19:39:32 +02:00
1b78f72fe7
Bug 1473469 - Make MediaStreamGraph run on a single thread with AudioWorklets enabled. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D20828
--HG--
extra : moz-landing-system : lando
2019-03-01 10:11:16 +00:00
Andi-Bogdan Postelnicu
Paul Adenot
Andreas Pehrson
Cristina Coroiu
Narcis Beleuzu
Karl Tomlinson
Csoregi Natalia
Alex Chronopoulos
Bogdan Tara
Gurzau Raul
Tarek Ziadé