Граф коммитов

179 Коммитов

Автор SHA1 Сообщение Дата
Olli Pettay 206bc2b3f9 Bug 1513547, ensure selection objects created for autocopy are cleared as soon as possible, r=ehsan
--HG--
extra : rebase_source : 75b4aef031526d6f7c1517305f560bf60ca26b3f
2018-12-13 15:07:19 +02:00
Sylvestre Ledru 265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Emilio Cobos Álvarez aa3d33ef4e Bug 1509989 - Make sure that CutContents doesn't remove nodes that isn't supposed to remove. r=mats
Depends on D13071

Differential Revision: https://phabricator.services.mozilla.com/D13072

--HG--
extra : moz-landing-system : lando
2018-11-27 18:02:17 +00:00
Emilio Cobos Álvarez a40dd78966 Bug 1509989 - Make sure the start container is safe to access in nsRange::InsertNode. r=mats
Depends on D13070

Differential Revision: https://phabricator.services.mozilla.com/D13071

--HG--
extra : moz-landing-system : lando
2018-11-27 16:56:26 +00:00
Emilio Cobos Álvarez 365e75f46d Bug 1509989 - Remove a useless null-check. r=mats
If startTextNode is null we unconditionally dereference tStartContainer.

Depends on D13069

Differential Revision: https://phabricator.services.mozilla.com/D13070

--HG--
extra : moz-landing-system : lando
2018-11-27 16:54:57 +00:00
Emilio Cobos Álvarez c10bb786b1 Bug 1509989 - Factor out nsRange security checks. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D13069

--HG--
extra : moz-landing-system : lando
2018-11-27 16:54:34 +00:00
Matt Woodrow 35496b0e2c Bug 1464632 - Add the option to explicitly cache the internal results of nsContentUtils::ComparePoints since nsRange::IsNodeSelected calls it repeatedly with the same value and we don't want to pollute the internal caching of nsINode... r=mats
...::ComputeIndexOf. r?mats

MozReview-Commit-ID: HKFmy1QeCs6

Differential Revision: https://phabricator.services.mozilla.com/D10138

--HG--
extra : moz-landing-system : lando
2018-10-30 22:28:34 +00:00
Simon Pieters 50b54a512b Bug 1322096 - Don't special-case rp in innerText. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D7420

--HG--
extra : moz-landing-system : lando
2018-10-03 12:20:32 +00:00
Andreea Pavel ee31a1dc8d Backed out changeset 7da26bb326de (bug 1322096) for build bustages at /src/dom/base/nsRange.cpp on a CLOSED TREE 2018-10-03 11:47:11 +03:00
Simon Pieters 2ead129ff7 Bug 1322096 - Don't special-case rp in innerText. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D7420

--HG--
extra : moz-landing-system : lando
2018-10-03 08:12:08 +00:00
Andrew McCreight 837f0af066 Bug 1493737 - Fix many trivial calls to do_QueryInterface r=smaug
If class A is derived from class B, then an instance of class A can be
converted to B via a static cast, so a slower QI is not needed.

Differential Revision: https://phabricator.services.mozilla.com/D6861

--HG--
extra : moz-landing-system : lando
2018-10-01 21:38:01 +00:00
Jonathan Kew f72a100c9b Bug 1473314 - Make nsRange::GetUsedFontFaces accumulate font faces in the order they are encountered in the document. r=xidorn 2018-09-27 11:33:25 +01:00
Edgar Chen 683dc6fccc Bug 1480618 - Cloning node for Range APIs should be in tree order; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D3216

--HG--
extra : moz-landing-system : lando
2018-08-14 14:01:35 +00:00
Adrian Wielgosik be0c1a4f55 Bug 1481645 - Remove some redundant uses of do_QueryInterface. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D2893

--HG--
extra : moz-landing-system : lando
2018-08-13 09:05:19 +00:00
Masayuki Nakano 2651346286 Bug 1479972 - nsRange should ignore mutations of the DOM tree while it's cached by Selection r=smaug
Selection caches an nsRange instance for saving re-allocation cost and AddMutationObserver() and RemoveMutationObserver()'s cost when its RemoveAllRangesTemporarily() is called.

Then, the instance is detached from the Selection but still referring editing point. E.g., the only text node in TextEditor when its value is set. Therefore, it'll receive character data change notification and need to check whether the point is still valid with new text.  However, the range will be always set new position later, i.e., immediately before going back to a part of Selection. Therefore, even if the point becomes invalid, nobody must not have any problems.

This patch makes Selection make the cached range not positioned, and makes nsRange ignore any mutations when it's not positioned.

Differential Revision: https://phabricator.services.mozilla.com/D2587

--HG--
extra : moz-landing-system : lando
2018-08-01 12:25:25 +00:00
Emilio Cobos Álvarez b678852e07 Bug 1455891: Remove nsRange::mMaySpanAnonymousSubtrees. r=mats
MozReview-Commit-ID: GhChQy7i690
2018-07-06 06:53:22 +02:00
Olli Pettay fc03dffd3c Bug 1472421 - nsRange should use composeddoc so that it works in shadow DOM, r=mrbkap 2018-07-03 21:15:32 +03:00
Noemi Erli a56e695e87 Backed out changeset 2d12737168b1 (bug 1472421) for mochitest failures on test_range_bounds 2018-07-03 19:11:04 +03:00
Olli Pettay 7c2962923a Bug 1472421 - nsRange should use composeddoc so that it works in shadow DOM, r=mrbkap
--HG--
extra : rebase_source : 4c9d60f3f1ceeede2fc4e9caa438cd340afd9c91
2018-07-03 17:26:40 +03:00
Jeff Gilbert 5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Jonathan Kew ad2647f459 Bug 1463115 - Try to skip irrelevant (collapsed/trimmed) whitespace when collecting used font faces for devtools inspector. r=jwatt 2018-05-24 14:44:09 +01:00
Jonathan Kew 6e425cf382 Backed out changeset 36687c035662 (bug 1463115) for frequent mochitest failures on Linux-debug 2018-06-01 18:03:13 +01:00
Jonathan Kew ca7c5f1e17 Bug 1463115 - Try to skip irrelevant (collapsed/trimmed) whitespace when collecting used font faces for devtools inspector. r=jwatt 2018-05-24 14:44:09 +01:00
Emilio Cobos Álvarez fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Boris Zbarsky bea3100e53 Bug 1455676 part 14. Remove most use of nsIDOMNode in dom/. r=qdot 2018-05-29 22:58:49 -04:00
Boris Zbarsky 6cecfe655d Bug 1377980 part 4. Remove nsIDOMRange. r=mccr8 2018-05-17 12:01:38 -04:00
Chris Peterson 71422dcaa9 Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L

--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez 1f9cbf532c Bug 1454251: Remove nsINode::eATTRIBUTE. r=bz
MozReview-Commit-ID: 7HeUbcG6szy
2018-04-20 09:52:26 +02:00
Emilio Cobos Álvarez d8e55e4596 Bug 1454236: Remove nsINode::eDOCUMENT_FRAGMENT. r=bz
MozReview-Commit-ID: D2F3LbQ1pvw
2018-04-20 01:30:12 +02:00
Emilio Cobos Álvarez 83fd987aec Bug 1454233: Remove nsINode::eDOCUMENT. r=bz
MozReview-Commit-ID: ItjdI79zme7
2018-04-20 01:30:11 +02:00
Boris Zbarsky a517e45add Bug 1452183 part 4. Remove nsIDOMDocumentFragment. r=mccr8 2018-04-17 21:13:03 -04:00
Andrew McCreight 3f7472aec1 Bug 1449670, part 1 - Convert IsNodeOfType(nsINode::eTEXT) to IsText(). r=bz
This method is not a virtual call, and also looks nicer.

This patch was mostly generated by a Python script, but I manually
cleaned up the code in a few places where statements didn't need to be
split across multiple lines any more.

MozReview-Commit-ID: 8JExxqSRc59

--HG--
extra : rebase_source : df6330a89e8d65dfe7a6fda0c8cb9f9732302efc
2018-04-12 15:41:00 -07:00
Brad Werth 19d279bd7d Bug 1450208: Change nsRange::ExtractRectFromOffset to use simpler, hopefully safer logic to determine whether text is vertical. r=bz
Instead of checking nsIFrame::IsTextFrame() and then casting to nsTextFrame,
the new code just checks the writing mode of the frame. Less casts; less
chance of pointer errors.

MozReview-Commit-ID: LrtthZjwYq6

--HG--
extra : rebase_source : 487ed4de272f514fe1f495ed1c2ddb9c8574d0a2
2018-03-30 08:52:53 -07:00
Brad Werth 7c79deb615 Bug 1437509 Part 1: Expand nsRange::ExtractRectFromOffset to correctly generate rects from vertical text runs. r=bz
MozReview-Commit-ID: 2n9SCn0eu9B

--HG--
extra : rebase_source : c68c0b8c55e6a177627b48ee1f2e1b6f2ce67aa4
2018-03-08 14:07:54 -08:00
Boris Zbarsky 74e28b0d19 Bug 1447890 part 2. Remove nsISelection::RemoveRange. r=mystor
MozReview-Commit-ID: JXq5FYNNXPJ
2018-03-27 00:35:22 -04:00
Boris Zbarsky f803b0085b Bug 1447889 part 13. Remove unused nsIDOMRange bits. r=mystor
MozReview-Commit-ID: CjtfHTtcviJ
2018-03-27 00:35:22 -04:00
Boris Zbarsky 2367e5d3ff Bug 1447889 part 12. Remove nsIDOMRange::ToString. r=mystor
MozReview-Commit-ID: 8TDYC3f4ENn
2018-03-27 00:35:22 -04:00
Boris Zbarsky cffc291dfc Bug 1447889 part 11. Remove nsIDOMRange::CloneRange. r=mystor
The GetSelection changes are so we have a Selection that we can get an nsRange
from via GetRangeAt, so we can call nsRange::CloneRange.

MozReview-Commit-ID: 6rqdJ29Yyuc
2018-03-27 00:35:21 -04:00
Boris Zbarsky 86c4629290 Bug 1447889 part 10. Remove nsIDOMRange::DeleteContents. r=mystor
MozReview-Commit-ID: IoXz0pS6zAa
2018-03-27 00:35:21 -04:00
Boris Zbarsky 1731f12f9d Bug 1447889 part 9. Remove nsIDOMRange::CompareBoundaryPoints. r=mystor
MozReview-Commit-ID: 29swD9AoqoF
2018-03-27 00:35:21 -04:00
Boris Zbarsky 3906df8d57 Bug 1447889 part 8. Remove nsIDOMRange::SelectNode/SelectNodeContents. r=mystor
MozReview-Commit-ID: 2hbF6pT31Xd
2018-03-27 00:35:21 -04:00
Boris Zbarsky 6a7475413e Bug 1447889 part 7. Remove nsIDOMRange::Collapse. r=mystor
MozReview-Commit-ID: LLiXK8IpUdY
2018-03-27 00:35:21 -04:00
Boris Zbarsky b94366962a Bug 1447889 part 6. Remove nsIDOMRange::SetStart/End. r=mystor
MozReview-Commit-ID: 8yOZMWBexsN
2018-03-27 00:35:21 -04:00
Boris Zbarsky d03d46b01e Bug 1447889 part 5. Remove nsIDOMRange::GetCommonAncestorContainer. r=mystor
MozReview-Commit-ID: 18bnPYjRld5
2018-03-27 00:35:21 -04:00
Boris Zbarsky 696d273ef4 Bug 1447889 part 4. Remove nsIDOMRange::GetStart/EndContainer/Offset. r=mystor
I got a bit carried away with fixing up consumers to use nsINode...  But as a
result removing these methods all together made sense.

MozReview-Commit-ID: 2z9Q6D7GY92
2018-03-27 00:35:21 -04:00
Emilio Cobos Álvarez e341b20ec4 Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez 5dd797f154 Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.

MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez ca5ac79cca Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Boris Zbarsky 29d232e53f Bug 1447098 part 1. Rename FromContent on various DOM classes to FromNode. r=mystor
MozReview-Commit-ID: 202nkbmkwfR
2018-03-21 17:39:04 -04:00
Boris Zbarsky 8dfe726ebb Bug 1446533 part 11. Remove remaining nsIDOMCharacterData uses in range code. r=mystor
MozReview-Commit-ID: 8YLea3SmQQU
2018-03-19 15:45:58 -04:00