Changes and notes:
- Created `devtools/client/shared/test/telemetry-test-helpers.js`, which
contains test helpers to aid in creating and running telemetry tests.
- Removed any telemetry monkeypatching as it is not dependable and no longer
needed (there is some left in GCLI but the test is now disabled because
we are removing GCLI soon anyhow).
- Because `telemetry-test-helpers.js` is imported by `shared-head.js` I
have had to make it available everywhere that shared-head.js is used.
- All telemetry tests have been rewritten to use the new helper.
- shared-head.js cannot be imported by tests inside
`devtools/client/performance/test/` because perf have custom `once` and
`waitFor` implementations that act differently from the ones inside
`shared-head.js`. This means I had to import the telemetry helpers into
`devtools/client/performance/test/head.js`
- Created `devtools/client/shared/test/browser_telemetry_misc.js` to be sure
to catch `DEVTOOLS_SCREEN_RESOLUTION_ENUMERATED_PER_USER` (we catch a few
others to be thorough).
- Disabled `browser_inspector_menu-02-copy-items.js`, which was failing to
test some expired scalars. I also corrected the way the scalars are logged
because it was completely wrong.
MozReview-Commit-ID: JjQEGM6hT61
--HG--
extra : rebase_source : cd1214d01bd11908f69167839975cd93ecb83421
This causes various changes to properties-db.js and also many devtools
tests get updated.
There are two changes affect multiple tests:
* `calc` gets removed from everywhere. We never have it listed in all
properties which deserve it, and doing so without much false positive
(i.e. properties don't deserve but get it) can be pretty tricky.
So they are just removed for now.
* The complete color keyword list is no longer included, and instead,
"COLOR" is prepended to the list directly. We can probably remove
the related code which replaces color keywords with "COLOR" from
devtools. Note that, with stylo enabled, the list is already unrelated
to what the parsing code uses. We should eventually re-enable the
disabled test here after we can get the color list from cssparser
in bug 1456715.
Other changes to properties-db.js seem to be valid, some of them also
affect tests:
* `{-webkit-,}align-{content,items,self}` get `first baseline`, `safe`,
`unsafe`, and lose `left` and `right`.
* `{-moz-,-webkit-,}{animation,transition}{,-timing-function}` has a
new `frame` keyword which is a function value in `<timing-function>`.
* `{background,{-webkit-,}mask}-position-x` lose `top` and `bottom`, and
correspondingly `{background,{-webkit-,}mask}-position-y` lose `left`
and `right`. They don't deserve those values.
* `{background,{-webkit-,}mask}{,-size}` get `auto`.
* `border` shorthand loses `<image>` values as well as other keyword
values for `border-image-*` subproperties, because they aren't parsed
on the shorthand.
* `{-moz-,}border-image{,-width}` get `auto`.
* `-moz-context-properties` gets `none`.
* `cursor` get some -moz-prefixed values as well as `url`.
* `fill` and `stroke` get the color keywords.
* `{-webkit-,}filter` get the keywords and function names.
* `font` shorthand loses values from many of `font-variant-*` properties
because they are not parsed there.
* `font-variant` and `font-variant-alternates` get function values of
the longhand.
* `font-variant-{east-asian,ligatures,numeric}` get `normal`, and
`font-variant-ligatures` in addition gets `none`.
`font-{feature,variation}-settings` also get `normal`.
* `grid` and `grid-template-{areas,columns,rows}` get `none`.
* `grid`, `grid-template`, and `grid-template-{columns,rows}` get
`auto`, `fit-content`, `minmax`, and `repeat`.
* `grid-auto-{columns,rows}` get `auto`, `fit-content` and `minmax`.
* `-moz-image-region` gets `auto` and `rect`.
* `{-webkit-,}justify-content` lose `baseline`, `last baseline`, and
get `safe` and `unsafe`.
* `{justify,place}-items` get `first baseline`, `legacy`, `safe`,
`unsafe` and lose `auto`.
* `{justify,place}-self` and `place-content` get `first baseline`,
`safe`, and `unsafe`.
* `outline{,-style}` get `hidden`.
* `scroll-snap-coordinate` gets `none`, and `scroll-snap-points-{x,y}`
gets `none` and `repeat`.
* `shape-outside`, `text-emphasis{,-style}` get all the keyword values
and function names they deserve.
* `stroke-dasharray` gets `none`.
* `text-combine-upright` drops `digits` which we never implemented.
* `{-moz-,-webkit-,}transform` and `-moz-window-transform` get their
transform function list. `accumulatematrix` and `interpolatematrix`
aren't real CSS value but they have `#[css(function)]` specified.
We should probably remove them at some point.
* `will-change` gets `auto`.
* All properties accept `<image>` value now gets -webkit-prefixed
gradient function names, including
* `background{,-image}`,
* `{-moz-,-webkit-,}border-image{,-source}`, and
* `{-webkit-,}mask{,-image}`.
MozReview-Commit-ID: E7Y0CFUFYgW
--HG--
extra : source : bab732c8c531cfca1bcd233f769c25bb2e373773
Take into account node offsets in browser_webconsole_object_inspector_local_session_storage.js.
MozReview-Commit-ID: 73waFejjsF0
--HG--
extra : rebase_source : d34e26c280f777e266ab7f014cfb9b41e07c9a5e
As far as I am aware, we can't create tests to detect whether an error has been thrown... especially if the error has no side affects.
If we really need a test for these simple four fixes you can always insist but I don't think we do.
MozReview-Commit-ID: 7j9N1X4jTHY
--HG--
extra : rebase_source : 95ce1cb4322fad250757db36a57272ccb328897d
This is confusing for some people and does not bring
much value. Let's remove it both in the frame component
and in the Error rep stacktrace.
MozReview-Commit-ID: Jy1jEJG4pRa
--HG--
extra : rebase_source : ee266d2c26be9733d9ec6dbddcb8e61a256bf9c5
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
This is pretty simple... finding the best locations for the probes was the
struggle here.
In order to land these probes before the freeze the test for these events will
be created as part of bug 1456073.
MozReview-Commit-ID: 7hIfbD3wQ1I
--HG--
extra : rebase_source : 990e69e0816742fc306b9313bd113f2d71f00b72
There are some extra hoops here because devtools has a lint to prevent Cu.importGlobalProperties, which is the normal way one would import a WebIDL constructor.
MozReview-Commit-ID: 2mdNI6N1z5B
Change disabledFocus to focusable as it changed in the ObjectInspector.
MozReview-Commit-ID: CDHotb0d4sL
--HG--
extra : rebase_source : 3390cf6aa1d79ef24f98b74cdece50cae36b937b
This was done using the script at:
bc5629735d/processors/add-task-async.jsm?at=default&fileviewer=file-view-default
MozReview-Commit-ID: KxuS9Cen87
--HG--
extra : rebase_source : c0028e0cd55ba1643610cd30c55c6f4bca7d6e58
extra : histedit_source : ebc84fdec9c2db6176632d62de4e7bdad2a7829d
Changes:
1. The change in telemetry.js avoids an issue with overwriting pending properties.
2. The test in telemetry.md has been updated now that we have a working test.
3. Added the actual toolbox.close telemetry event and test.
MozReview-Commit-ID: 9fOCkwCCwDx
--HG--
extra : rebase_source : 55028edf836af62c25ae603675de0b3f5189f43e
This patch adds some unit tests for the common Unicode-URL related functions
defined in Part 1.
MozReview-Commit-ID: 2juTaanghnN
--HG--
extra : rebase_source : 25449943d2091cbdb9cfaa00024577254ad2e280
The Punycode-encoded international domain names and URI-encoded filenames are
human-unreadable, so they should be displayed as human-readable Unicode text.
This commit decodes this kind of names in the Web Console.
MozReview-Commit-ID: 8AVLkdaQOh6
--HG--
extra : rebase_source : 947c126f1d0d86efc6bba71447cf54ef486e2fdc
This patch defines some common functions for getting a Unicode URL or a Unicode
URL component.
These functions are not only intended to be used by future patches for this bug,
but also intended to be the common functions for any future patches which need
to reuse such functionalities.
MozReview-Commit-ID: DZBYoKv9Fmx
--HG--
extra : rebase_source : 4dd684a5c43fa49b3f07fce8bb162ab6f277b6b6
Jason Laster
Gurzau Raul
Gabriel Luong
Michael Ratcliffe
Zhang Junzhi
Jan Odvarko
Julian Descottes
Cosmin Sabou
Andreea Pavel
Ciure Andrei
Xidorn Quan
Boris Zbarsky
Nicolas Chevobbe
Kris Maglione
Brian Grinstead
Fred Lin
Daisuke Akatsuka
Dorel Luca
Yura Zenevich
Alexandre Poirot
arthur.iakab
Margareta Eliza Balazs
Erica Wright