The height of the subview being opened was supposedly calculated using an off-screen container independent from the currently displayed views, but this didn't work as expected because of the incorrect box alignment. This is now fixed and the correct minimum and maximum heights are set on the container separately, also preventing the current view from flickering before the transition in case the subview was taller.
With this issue fixed, the height can now be recalculated each time the subview is opened, without the caching that caused incorrect results when the same view was reopened with different elements or text.
Jumping could also occur because of a border applied only during the transition, which could influence the subview height in the presence of wrapping text.
MozReview-Commit-ID: EWHs1hFKXT4
--HG--
extra : rebase_source : 5b0bc4e5d4d2d10d684c2c2bf94a9030aadd09bd
In order to display the Library view sooner, the Recent Highlights section is populated asynchronously after the view is shown. When the Library button is moved to the overflow menu, this prevents the view height animation from including this section.
This can be worked around after the first time the view is opened, and is currently done by reusing the last known height. This logic causes issues with other subviews, but to fix this the Library view has to be changed to keep the existing highlight items while fetching the new ones.
MozReview-Commit-ID: AGs7nh4CsYE
--HG--
extra : rebase_source : ee2876f45ac16dc6c58d3373dfd2e3cc847dd593
The problem reported in this bug is that the newTab button moves to an invalid position when
there's only 1 tab in a window and you try to move it to the end of the tab strip via tabs.move.
This may be caused by a bug in tabbrowser, which is being investigated separately, but it
brought to light the fact that we're trying to move a tab when it's the only tab in a
window, and that just doesn't make sense.
This patch updates the code so we don't try to move a tab if it's the only tab in the
window.
MozReview-Commit-ID: 1oBs0OHnvxi
--HG--
extra : rebase_source : 2fde9ffdac4a2f2e290b51f0f73dd877db60f009
This patch moves us from using an old pref `general.useragent.locale`combined
with `intl.locale.matchOS` for retrieving user requested locale, to use a new
preference `intl.locale.requested` which stores a list of well-formed BCP47
language tags. If set to empty, the OS locales are used. If not set at all,
default locale is used.
We are also adding a piece of code to migrate from old to new system.
MozReview-Commit-ID: 854yQ1kC6Ee
--HG--
extra : rebase_source : c4a7171bc026f857f7878ee83d973ec01b536a84
addonsInstalled and addonsInstalledNeedsRestart currently abuse
plural forms, using the singular form to expose the name of the add-on.
While the first form is singular for English, it's used for other numbers
in other languages, and in others there's only one form available,
making these strings impossible to translate.
MozReview-Commit-ID: 6hVJnaqTGtc
--HG--
extra : rebase_source : b9f616eb816e364008d5ce3419ec521c5acbb979
This also ensures that we consider certificate error pages in frames as well as top-level.
MozReview-Commit-ID: IA4vT8yZnuN
--HG--
extra : rebase_source : c8825d4fc3e4a3ca018f27b2ada3a6bba2685a65
Also remove related code that was only used from here including
stuff related to marketplace purchases, etc.
MozReview-Commit-ID: ESX78tVQK7M
--HG--
extra : rebase_source : 56d956168f75cdc40fd3df057e41493f80733352
Also consolidated the two .ini files in toolkit/mozapps/extension/test/browser
since we only run these tests in tabs now.
MozReview-Commit-ID: HHwM4Q1K5C8
--HG--
extra : rebase_source : 6db3527ee6973946d188fa70dc8af1c008094d49
exe_7z_archive.py runs during the MinGW build L10N check step, and
hardcodes 7z as the 7zip executable. This works on Windows, but not
Linux. We need to pass it the correct executable for 7zip, which is
located during configure.
However, repacks (repackage-winXX-nightly) don't do configure, and
don't have the tools to do configure. So we leave the default
command in the python script if one is not supplied.
MozReview-Commit-ID: B7GEKRYEJTD
--HG--
extra : rebase_source : 10ec7e688d53341625217306e88f2e647195ce8d
I can do the hacky thing like `caption menulist label` or what not, except it'd
be clobbered by the :not() rule.
Instead clean the negatives a bit avoiding :not, and do the (imo) cleaner fix.
This makes it look closer to how it looked before my patch, modulo the "Fonts
for" text, which now has the same size as the other label in the dialog, which I
think is nice.
MozReview-Commit-ID: 1EKjJCGTckm
--HG--
extra : rebase_source : aa9208aec0c0e2cf2b343d59f68b876f8ec811c3
This patch adds a |ForceUpdates| API in listmanager so when we change Safe Browsing tables,
we can use this API to force an update to ensure new tables are downloaded immediately.
If the update fails for any reason (Server is down for example), then the new tables will have
to wait until next update time.
MozReview-Commit-ID: 3Zh1pU8XaYo
--HG--
extra : rebase_source : 215cd2f4484b07663566024bfa5e182ee3807d4e
This updates browserSettings so that calling set and clear return false, rather than undefined,
for read-only settings. It also returns "not_controllable" rather than "controllable_by_this_extension"
for levelOfControl from calls to get for read-only settings.
MozReview-Commit-ID: 9c0bKDaYIC7
--HG--
extra : rebase_source : c47c97bcc19095bf1945e111e13e2a8f02e98799
This introduces a new property to WindowTracker (on desktop only) called topNormalWindow
which returns the topmost window which is not a popup window. That property is then used
by tabs.create to identify the top "normal" window when a windowId is not passed to it.
Bug 1421709 has been filed to look for other opportunities to use topNormalWindow
in place of topWindow in our codebase.
MozReview-Commit-ID: DcV93wO6FoV
--HG--
extra : rebase_source : 7c7be7c364cc627d385929a2c9fd2dee757bf835
When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.
MozReview-Commit-ID: FjNJ1n8foGi
--HG--
extra : rebase_source : c9de8a2a4d4dcf191281fead320acc2ddc1321d6
Use logical properties for offset and float to avoid rtl-specific rules.
Note: background-position and transition property don't support logical
properties, so those rtl-specific rules must be kept for now.
MozReview-Commit-ID: BEiAcufOYAX
--HG--
extra : rebase_source : 0e2d3d83f9be09f2a62cb62e217cb4a0a64eae59
The recent failures all seem to be on the assertion that lastAccessed of tab 1 is
later than the test start time. It's possible that things happen so quickly that
lastAccessed of tab 1 is the same as the start time, so this patch changes the
comparison to be a <=.
MozReview-Commit-ID: 67CVQPj1ShM
--HG--
extra : rebase_source : c370422f3c9e54bbae8b4e7827c671c5a784ce7b
Implement basic validation for new table events and columns, report the incorrect fields.
The change is protected by NEW_TABLE flag so not effect the current telemetry.
MozReview-Commit-ID: 78K551g0nRj
--HG--
extra : rebase_source : 318c3f30154b7e58be17a16d8f8ddf7ad6045143
This sets the hardcoded favicon paths before painting the tab or window
to ensure they're painted right away.
MozReview-Commit-ID: 5V3gQP7XkNP
--HG--
extra : rebase_source : 1c887d035d031b5f2367d4599d18d4066282bbd5
This patch adds a |ForceUpdates| API in listmanager so when we change Safe Browsing tables,
we can use this API to force an update to ensure new tables are downloaded immediately.
If the update fails for any reason (Server is down for example), then the new tables will have
to wait until next update time.
MozReview-Commit-ID: 3Zh1pU8XaYo
--HG--
extra : rebase_source : 65ff9de561e21cfb0b80be0f62335351e612cc01
Also adds new & updated test cases to browser_screenshots_cropping.js and browser_boundingbox.js
MozReview-Commit-ID: 46RSMb7DRg5
--HG--
extra : rebase_source : 43783e2c11d7b0e7f0cd2534a5b2cf18ff6780b8
The new heuristic for requested locales in LocaleService makes the
intl.locale.requested an override to the default locale.
This patch removes the hardcoded setting of the pref to the build time locale,
allowing LocaleService to pick the default locale by default.
MozReview-Commit-ID: 3iaZYuHTxih
--HG--
extra : rebase_source : c3bb701de4716ae132d2a5ee5f2c3e2054e4a3c1
On nightly and aurora we have supplemental strings about Telemetry in the About
dialog/section. However, we already open the data policy tab (Desktop) and
notification (Mobile) on nightly, aurora, -and beta- to more accurately tell
users about our data policies.
So let's remove the inconsistently-applied semi-hard-to-find strings.
MozReview-Commit-ID: 3zjXQwi9r7v
--HG--
extra : rebase_source : af9728dd1ff2161ff028f85ebf7f93c22eae0181
This also fixes the vertical offset because we take the correct branch in the yDiff if block lower down.
MozReview-Commit-ID: KbHkRx1575X
--HG--
extra : rebase_source : ed9189c10dd00badb4bce9982a7ba20b647cef98
This assumption also mirrors how non-remote browsers have their docShells active by default.
In order to do this, I also have to increase the initial epoch's for the TabParent and TabChild,
as if a RenderLayers has been called. Originally, since the epochs initted at 0, and the epochs
stored by the [Layer|WebRender]TransactionParent were also initted at 0, we'd hit this branch:
https://searchfox.org/mozilla-central/rev/c633ffa4c4611f202ca11270dcddb7b29edddff8/gfx/layers/ipc/LayerTransactionParent.cpp#703
and then we'd never alert the TabParent about the layer upload.
MozReview-Commit-ID: 6PP1eCnisYK
--HG--
extra : rebase_source : da736415d6b60208fa54bc25fe449cc261e856d8
This is necessary because sometimes the async tab switcher will instantiate when
there already exists some background tabs that are rendering via print preview. When
that happens, it's important for the state to be set correctly for them so that we
don't accidentally treat them as still loading, and wait (forever) for them to report
having finished loading.
MozReview-Commit-ID: 2dwo5WlXlgJ
--HG--
extra : rebase_source : 7d3def56bf6ba12bb6110b60bb3d79329bfc0abd
Jared Wein
Michael Kaply
Ted Mielczarek
Sebastian Hengst
Bogdan Tara
Christian Holler
Scott Wu
Joel Maher
Florian Quèze
Tim Taubert
Jessica Jong
Csoregi Natalia
Jonathan Kingston
Paolo Amadini
Tooru Fujisawa
Marco Castelluccio
Gurzau Raul
Thomas Nguyen
Narcis Beleuzu
Christian Sadilek
Andreea Pavel
Ed Lee
Bob Silverberg
Mike Cooper
Mark Banner
Zibi Braniecki
Francesco Lodolo (:flod)
Tim Nguyen
Brindusan Cristian
Johann Hofmann
Andrew Swan
Sylvestre Ledru
Tom Ritter
Ryan VanderMeulen
shindli
Stephen A Pohl
ffxbld
Dorel Luca
Tiberius Oros
Mike Hommey
Edouard Oger
Jesse Schwartzentruber
Emilio Cobos Álvarez
Ray Lin
arthur.iakab
Valentin Gosu
Chung-Sheng Fu
steveck-chung
Noemi Erli
Mike Conley
Margareta Eliza Balazs
Luke Chang
DimiL
Gijs Kruitbosch
tushararora
Andrea Marchesini
Tawny Hoover
Luke Crouch
Marco Bonardo
Ryan Leake
Fred Lin
Mark Striemer
Cosmin Sabou
grenewode
Matthew Noorenberghe
Chris H-C
Tom Prince
Matt Howell
Dão Gottwald
Ciure Andrei