5d8eb750cd
Bug 1615130 - Fix uninitialized data. r=padenot
...
Values are set to 0 by default rather than uninitialized. It is useful when JSContext is null.
Differential Revision: https://phabricator.services.mozilla.com/D79986
2020-06-22 10:21:40 +00:00
209a34c2b7
Bug 1642849 shut down MediaTrackGraph from AudioContext when window will be destroyed r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D74814
2020-06-12 03:53:34 +00:00
f426576017
Bug 1644647 reject promises for Close AudioContextOperations run after forced graph shutdown r=padenot
...
and re-enable OnStateChanged() transition assertions.
Rejecting the promise avoids having AudioContextOperation promises resolve out
of order when AudioContextOperationControlMessage::RunDuringShutdown()
resolves a Close operation shortly after Run() for a previous operation has
queued its update via mUpdateRunnables. mUpdateRunnables are run after
controlMessagesToRunDuringShutdown.
https://searchfox.org/mozilla-central/rev/ea7f70dac1c5fd18400f6d2a92679777d4b21492/dom/media/MediaTrackGraph.cpp#1793,1803
AudioContext::Shutdown() takes care of rejecting JS Promises when the window
is being destroyed.
Differential Revision: https://phabricator.services.mozilla.com/D79055
2020-06-12 02:38:35 +00:00
632dfeb6cc
Bug 1638243 reject promises for Resume AudioContextOperations that have not run by graph shutdown r=padenot
...
The promises are rejected before shutting down threads so that they don't need
to wait for nested event loops to exit.
Differential Revision: https://phabricator.services.mozilla.com/D76807
2020-06-12 01:12:56 +00:00
9f36b6849d
Bug 1644647 use AudioContextOperation::Resume to start realtime AudioNodeTracks r=padenot
...
This provides that a new track does not start processing before existing
tracks in the AudioContext, which may not be resumed until an
AudioCallbackDriver is running.
Depends on D79048
Differential Revision: https://phabricator.services.mozilla.com/D79049
2020-06-12 00:50:34 +00:00
8ebfa90f03
Bug 1644647 use the same mechanism for the first suspended->running transition as for others r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D79048
2020-06-11 08:51:17 +00:00
32c6cac7db
Bug 1644647 - Bug 1285290 use strong pointers for tracks in ApplyAudioContextOperation() r=padenot
...
This will be helpful when delaying resumption of tracks until there is an AudioCallbackDriver.
The memory for the array is also transferred to the callee to save an allocation.
Differential Revision: https://phabricator.services.mozilla.com/D76801
2020-06-12 01:02:18 +00:00
82dc9b2271
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 10:46:14 +00:00
e3dce68834
Backed out 3 changesets (bug 1643289, bug 1642949) for causing failure at test_headless_screenshot.html. CLOSED TREE
...
Backed out changeset 98c420f73380 (bug 1643289)
Backed out changeset 9447ea8910aa (bug 1643289)
Backed out changeset 0c827da9d847 (bug 1642949)
2020-06-10 10:07:23 +03:00
d419f0ff08
Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78027
2020-06-10 05:49:28 +00:00
ca2d0aaa68
Bug 1644403 - Fix inconsistent uses of CopyableAutoTArray and Clone. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78893
2020-06-09 14:27:20 +00:00
ebbc7ae838
Bug 1642989 - Use RemoveLastElements instead of RemoveElementsAt where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D78049
2020-06-08 08:50:15 +00:00
4e78ffdefb
Bug 1641161 - Bug 1285290 alias move() to std::move() in MediaTrackGraph.cpp and AudioContext.cpp r=padenot
...
Depends on D76799
Differential Revision: https://phabricator.services.mozilla.com/D76800
2020-05-27 08:36:18 +00:00
cd4aaf8433
Bug 1641161 - Bug 1285290 don't add destroyed tracks to graph from Increment/DecrementSuspendCount r=padenot
...
Tracks remove themselves from the graph after DestroyImpl() and so should not
be added again after this.
These methods are now invoked only on the MediaTrack removing the possibility
of calling the wrong method.
Depends on D76797
Differential Revision: https://phabricator.services.mozilla.com/D76798
2020-05-27 08:34:13 +00:00
9c7a29b17e
Bug 1531851 - Make WebAudio GC tests more reliable. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D76590
2020-05-25 18:04:58 +00:00
781a32b68c
Bug 1607781 - Consistently use a fixed sample-rate when resisting fingerprinting. r=jib
...
Differential Revision: https://phabricator.services.mozilla.com/D75937
2020-05-19 12:50:30 +00:00
dc85ea650c
Bug 1625372 permit ForceShutDown() on a realtime graph r=padenot
...
Depends on D74812
Differential Revision: https://phabricator.services.mozilla.com/D74813
2020-05-15 08:22:31 +00:00
e8ab6c7193
Bug 1625372 remove unnecessary DestroyNonRealtimeInstance() call from AudioDestinationNode::DestroyMediaTrack() r=padenot
...
DestroyMediaTrack() is called only on Unlink or destruction of the AudioDestinationNode.
If there are no references to the AudioDestinationNode, then the graph's last stream
will be destroyed and the graph will shut down itself.
Differential Revision: https://phabricator.services.mozilla.com/D74812
2020-05-13 10:13:19 +00:00
0a1151e126
Bug 1625372 request interrupt of AudioWorklet JS on force shutdown r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D71915
2020-05-15 08:24:06 +00:00
3581879481
Bug 1509933 - part3 : use the new pref in tests. r=padenot
...
This patch will do :
- replace the old pref with the new pref
The advantage of doing so :
- to ensure those tests can still use the correct blocking autoplay policy
Differential Revision: https://phabricator.services.mozilla.com/D73973
2020-05-15 02:51:18 +00:00
68c900462b
Backed out 3 changesets (bug 1509933) for Linting failure in gecko/mobile/android/app/mobile.js. CLOSED TREE
...
Backed out changeset c15ecdcd5d13 (bug 1509933)
Backed out changeset 951ea1d0f42a (bug 1509933)
Backed out changeset 3abb24d6dfc9 (bug 1509933)
2020-05-15 05:02:07 +03:00
1c6be41aa9
Bug 1509933 - part3 : use the new pref in tests. r=padenot
...
This patch will do :
- replace the old pref with the new pref
The advantage of doing so :
- to ensure those tests can still use the correct blocking autoplay policy
Differential Revision: https://phabricator.services.mozilla.com/D73973
2020-05-07 13:05:22 +00:00
62c2076a1b
Bug 1637159 remove now-unused public DOMEventTargetHelper::BindToOwner() rebind methods r=smaug
...
The virtual is no longer required since
https://hg.mozilla.org/mozilla-central/rev/a01586b62cf5#l1.92
Differential Revision: https://phabricator.services.mozilla.com/D75042
2020-05-14 05:29:49 +00:00
f93330de3e
Bug 1629293 - Expose js::ErrorReport in public API. r=evilpie
...
Renames it to JS::ErrorReportBuilder, since it is used to 'build' a
JSErrorReport object.
Differential Revision: https://phabricator.services.mozilla.com/D73521
2020-05-14 04:44:15 +00:00
a12e8bbd08
Backed out 5 changesets (bug 1505129, bug 1506323, bug 1629293) for bustages on testPrintError.cpp . CLOSED TREE
...
Backed out changeset ad1ccad76686 (bug 1629293)
Backed out changeset 452e9ab721bd (bug 1629293)
Backed out changeset 72a63e290177 (bug 1629293)
Backed out changeset faeed99f813e (bug 1505129)
Backed out changeset 7bd84a644d2b (bug 1506323)
2020-05-13 21:23:59 +03:00
5606c63575
Bug 1629293 - Expose js::ErrorReport in public API. r=evilpie
...
Renames it to JS::ErrorReportBuilder, since it is used to 'build' a
JSErrorReport object.
Differential Revision: https://phabricator.services.mozilla.com/D73521
2020-05-13 16:10:39 +00:00
0da2867bf2
Backed out 5 changesets (bug 1625372) for assertion failures on GraphDriver.cpp. CLOSED TREE
...
Backed out changeset b9feee4f447c (bug 1625372)
Backed out changeset d86f066bd68b (bug 1625372)
Backed out changeset 7a38398623f8 (bug 1625372)
Backed out changeset 6e9928fb37d1 (bug 1625372)
Backed out changeset ca93e9921c05 (bug 1625372)
2020-05-13 13:09:22 +03:00
ef208899b1
Bug 1625372 shut down MediaTrackGraph from AudioContext when window will be destroyed r=padenot
...
Depends on D74813
Differential Revision: https://phabricator.services.mozilla.com/D74814
2020-05-12 08:44:46 +00:00
989d1fc6db
Bug 1625372 permit ForceShutDown() on a realtime graph r=padenot
...
Depends on D74812
Differential Revision: https://phabricator.services.mozilla.com/D74813
2020-05-12 08:43:11 +00:00
3e139c32e0
Bug 1625372 remove unnecessary DestroyNonRealtimeInstance() call from AudioDestinationNode::DestroyMediaTrack() r=padenot
...
DestroyMediaTrack() is called only on Unlink or destruction of the AudioDestinationNode.
If there are no references to the AudioDestinationNode, then the graph's last stream
will be destroyed and the graph will shut down itself.
Differential Revision: https://phabricator.services.mozilla.com/D74812
2020-05-12 08:42:38 +00:00
53bf89e445
Bug 1625372 request interrupt of AudioWorklet JS on force shutdown r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D71915
2020-05-12 07:10:51 +00:00
34c6fd1e8c
Bug 1636838 - Undef CurrentTime and define X11CurrentTime instead. r=boris
...
Differential Revision: https://phabricator.services.mozilla.com/D74585
2020-05-11 19:34:02 +00:00
1854f52b7c
Bug 1626753 - WaveShaperNode.cpp : removed else after return. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D74741
2020-05-11 21:17:24 +00:00
f7f5462a4b
Bug 1626570 - Improve handling of copying arrays in dom/media/. r=bryce
...
Differential Revision: https://phabricator.services.mozilla.com/D73627
2020-05-05 11:38:10 +00:00
052b46021c
Bug 1633747 - Flush NaNs to zeros before handing back the audio output buffer to the OS. r=karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D72927
2020-05-01 23:57:30 +00:00
684a5d3947
Bug 1624266 - Use IsSharedMemoryAllowed to decide whether should the CTOR SharedArrayBuffer be defined for Worklets; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D71536
2020-05-01 11:36:08 +00:00
3f634118d6
Bug 1634098 - Fix a few clang-tidy warnings in AudioNodeEngine.cpp and vector sibling files. r=karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D73087
2020-04-29 22:39:15 +00:00
d8873bd7de
Bug 1594529 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/media/webaudio. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D72565
2020-04-27 11:46:32 +00:00
34acbb653a
Bug 1619165 - Reformat recent changes to the Google coding style r=andi
...
First reformat with clang-format 10
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D68802
2020-04-25 09:40:08 +00:00
68f59c15f7
Bug 1626382 - r=karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D72144
2020-04-24 01:57:47 +00:00
bbddb266a3
Bug 1611622 - Add a decode test for an OGG Vorbis file with a nil packet at EOS. r=bryce
...
The test file was created using VLC, that has a muxer that does this.
Differential Revision: https://phabricator.services.mozilla.com/D71351
2020-04-21 09:30:57 +00:00
2ff258c252
Bug 1611622 - Allow testing for a decode success without checking the file. r=bryce
...
Useful to test the demuxer in the web audio case.
Differential Revision: https://phabricator.services.mozilla.com/D71350
2020-04-21 09:30:40 +00:00
22429adf2a
Bug 1611622 - Add some logging to MediaBufferDecoder.cpp. r=bryce
...
Differential Revision: https://phabricator.services.mozilla.com/D70894
2020-04-21 09:30:00 +00:00
0e5b704353
Backed out 5 changesets (bug 1611622) for causing failures in test_mediaDecoding.html CLOSED TREE
...
Backed out changeset f4a83f3ac965 (bug 1611622)
Backed out changeset 87254fc7b777 (bug 1611622)
Backed out changeset 1177ae3a0ef3 (bug 1611622)
Backed out changeset daf821043996 (bug 1611622)
Backed out changeset adab60e7e9c5 (bug 1611622)
2020-04-20 22:50:35 +03:00
ea156f7bf4
Bug 1611622 - Add a decode test for an OGG Vorbis file with a nil packet at EOS. r=bryce
...
The test file was created using VLC, that has a muxer that does this.
Differential Revision: https://phabricator.services.mozilla.com/D71351
2020-04-20 18:36:48 +00:00
571e9f80af
Bug 1611622 - Allow testing for a decode success without checking the file. r=bryce
...
Useful to test the demuxer in the web audio case.
Differential Revision: https://phabricator.services.mozilla.com/D71350
2020-04-20 18:36:41 +00:00
010795c79b
Bug 1611622 - Add some logging to MediaBufferDecoder.cpp. r=bryce
...
Differential Revision: https://phabricator.services.mozilla.com/D70894
2020-04-20 18:36:20 +00:00
1ad47078f4
Backed out 5 changesets (bug 1611622) for causing bustages.
...
CLOSED TREE
Backed out changeset 8be308a0ff7d (bug 1611622)
Backed out changeset e6286802e8b5 (bug 1611622)
Backed out changeset ca1198a5d65c (bug 1611622)
Backed out changeset 7f14a871f69e (bug 1611622)
Backed out changeset 1db1f7da1215 (bug 1611622)
2020-04-17 21:17:37 +03:00
88b9f51e9b
Bug 1611622 - Add a decode test for an OGG Vorbis file with a nil packet at EOS. r=bryce
...
The test file was created using VLC, that has a muxer that does this.
Differential Revision: https://phabricator.services.mozilla.com/D71351
2020-04-17 17:56:45 +00:00
d4b4cd9dee
Bug 1611622 - Allow testing for a decode success without checking the file. r=bryce
...
Useful to test the demuxer in the web audio case.
Differential Revision: https://phabricator.services.mozilla.com/D71350
2020-04-17 17:56:25 +00:00
Corentin Arnould
Karl Tomlinson
Simon Giesecke
Butkovits Atila
Masatoshi Kimura
Paul Adenot
alwu
Dorel Luca
Philip Chimento
Narcis Beleuzu
Csoregi Natalia
Hiroyuki Ikezoe
Benoît Chauvet
Tom Tung
Chris Peterson
Sylvestre Ledru
Noemi Erli
Mihai Alexandru Michis