<!-- Please describe your changes on the following line: -->
Little proposals
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 320cfeb2909ff061552194f02147f4b50b6a1450
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ebf83c8688036f5c995e6801c95665dbbf3c389c
With a reminder that you may still need to do a full build if you want to run it.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2766529c2450ba3fac1b7669c195869a0f7e341b
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ebb4360dd02f68da6781efa4afd68e3912da2e09
<!-- Please describe your changes on the following line: -->
This is a follow-up to #16468.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because we no longer support MinGW/MSYS
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 485a4de729e196d1baca2ffe01518bbd4b0d1afa
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 0b7ead6826a132a8b393c3770fabb9243808a294
**NOTE: This PR is a fix to the README and did not update any code, so I haven't tested the changes.**
Hey @jdm, I used my time yesterday to set up Servo and get comfortable with git. I've made a minor change to the readme, just to help make the project more accessible to complete newcomers.
The line "./mach run [url]" can be confusing as there are many ways of thinking of a URL and some people don't think of including the protocol. Which is why I thought this was worth adding.
I also had trouble installing OpenSSL with the command provided. I had to disable the System Integrity protection on Mac OS and manually link the OpenSSL at reboot as brew force install didn’t work either. Can this also be noted?
Source-Repo: https://github.com/servo/servo
Source-Revision: 686df84d77e6c058fe137229526eeedac5ad9f1d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 908b08113ba6ffef84e93ff4c2dac1f9775108df
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 9ea46920ffc3c521d5afe1dec4f2f8aad8984321
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 9de1b7b98d792b50b730878d1eb6025c907df223
i made some changes to Windows instruction, more unified.
Also removed freetype dependencies on Windows, by forcing to build harfbuzz from source, which is also dependent on freetype.
cc @larsbergstrom @metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: e8d677f9c5caed7e8c750fad7b4fb2eae4744c93
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 31c8180d9cdb7888b32c61389b6940b9364b4aec
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _non-functional changes_
Source-Repo: https://github.com/servo/servo
Source-Revision: 94e3c900294372fd4bc95e694668b2b07aa1c93a
Thanks for coming on the show @metajack! We've added this badge to the README to share your episode with your community. 💚
Links to: https://changelog.com/podcast/228
- [x] These changes do not require tests because they only update the README
Source-Repo: https://github.com/servo/servo
Source-Revision: 44d3eec88b935810d889db05522f1b59a2f23c39
<!-- Please describe your changes on the following line: -->
In addition to minor changes for Windows, this forces Windows Python to
be used for all Windows builds (instead of using Windows Python only for
pc-windows-msvc builds).
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because testing the tests is too meta for me
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 17bf6aed21cb966c52382e7cef23d2bd66144874
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix#13788 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Fixes#13788
Source-Repo: https://github.com/servo/servo
Source-Revision: c8321edc27ed7125181262e0341e66825951f634
I ignored these instructions because it said `<=`, but this should be the other way around! 🙇♀️
---
- (n/a) `./mach build -d` does not report any errors
- (n/a) `./mach test-tidy` does not report any errors
<!-- I'm literally the one fixing GitHub's Markdown parser so this comment won't be necessary to divide the two lists. Soon! -->
- [ ] There are tests for these changes
- [x] These changes do not require tests because they're only to `README.md`
Source-Repo: https://github.com/servo/servo
Source-Revision: f4ed2c6875e4f766b4de93263a25431424215f73
<!-- Please describe your changes on the following line: -->
Adding instructions to build using the MSVC toolchain.
r? @vvuk
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x ] `./mach build -d` does not report any errors
- [x ] `./mach test-tidy` does not report any errors
- [x ] These changes fix#13206 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: a90d207c468a9a8a99cfafa301fed3f48eee5ba3
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [X] These changes fix#13542 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because only updating README.md
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
My apologies, on my machine I had glu-devel installed previously for another project and didn't realize this also needed it.
Source-Repo: https://github.com/servo/servo
Source-Revision: ce79e0464487ff640d7c1d0f58f74ef28c36b481
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the only file changed is the README.md to include openSUSE dependencies
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 34fa38fd2dd75b0278002db847c392e0bb5b3d25
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because they only change documentation
Source-Repo: https://github.com/servo/servo
Source-Revision: e97eba188858283510235b8a91858f1d025d934d
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it only changes documentation
Source-Repo: https://github.com/servo/servo
Source-Revision: d9f53cb14df4467de714e61f9a5ab4b4a510f5f5
force linking doesn't work anymore and setting the environment variables is the recommended way of linking to non system openssl. sorry for not including everything on the same pull request but I wasn't sure before that this always happens.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [x] These changes do not require tests because its a documentation change
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
force linking doesn't work anymore and setting the environment variables is the recommended way of linking to non system openssl.
Source-Repo: https://github.com/servo/servo
Source-Revision: 821797d6f7728b512ffd8f59053f9040744e2c53
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because its a documentation change
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
the location of openssl might have changed, but it reads as of now:
```sh
$ brew link --force openssl
Warning: Refusing to link: openssl
Linking keg-only openssl means you may end up linking against the insecure,
deprecated system OpenSSL while using the headers from Homebrew's openssl.
Instead, pass the full include/library paths to your compiler e.g.:
-I/usr/local/opt/openssl/include -L/usr/local/opt/openssl/lib
```
Source-Repo: https://github.com/servo/servo
Source-Revision: 1f1e92aca347a165ea46d9d0e8b86c43ba245823
<!-- Please describe your changes on the following line: -->
r? @larsbergstrom
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: fb7cb92076b42caf3e66b46391e79f551bf4ba88
<!-- Please describe your changes on the following line: -->
It is really an improvement to make room for a commit that links contributors to https://janitor.technology
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 17df3c276b5ac56645e5acf3b09ae684d732631f
Sometimes building with openssl requires major intervention of pointing the include path to the local installation of openssl, when the brew link refuses to link.
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it’s a documentation change
Source-Repo: https://github.com/servo/servo
Source-Revision: 490a2acac9a1da4b2a4466ed48ed30e3666734ca
<!-- Please describe your changes on the following line: -->
Just updates the README.md on how to get libavformat to link correctly on OS X for some systems.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ X] `./mach build -d` does not report any errors
- [ X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ X] These changes do not require tests because it's a readme.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: fab2ab8b9e2c7f7a200f11a2b0ead259beac97df
<!-- Please describe your changes on the following line: -->
This is based on the awesome work by @UK992 in #12573.
Basically, it downgrades GCC on Windows to 5.4 within the mingw environment. This is a stopgap until #11756 is completed and we no longer need mingw.
Fixes#12512
r? @metajack
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 521f8c013524b64daefc9c34c46263868f902de4
<!-- Please describe your changes on the following line: -->
Just some added developer documentation that was useful for me while starting to develop servo.
This adds the documentation about running ./mach clean with a partially built servo but before linking openssl.
It also adds the -Z flag under command line flags for debugging help.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X ] `./mach build -d` does not report any errors
- [ X] `./mach test-tidy` does not report any errors
- [ X] These changes fix#12396 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a documentation update only.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: 20b1764d71a967ee4a355cd1b55e4250fe5f59a9
Backspace and Shift-Backspace are no longer used to go backwards and forwards through history.
Instead, Alt+Left Arrow and Alt+Right Arrow are used now.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
Source-Repo: https://github.com/servo/servo
Source-Revision: 8d81ee77a877f07e2d4f2779aa252f5f3bb98c7c
<!-- Please describe your changes on the following line: -->
Add pkg-config to readme.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this is an edit to the readme.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Without this package, I get this error:
```
Compiling servo-freetype-sys v2.4.11
Build failed, waiting for other jobs to finish...
error: failed to run custom build command for `dbus v0.3.3`
Process didn't exit successfully: `/dsk/src/servo/target/release/build/dbus-7f7af798babde0c1/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Failed to run `\"pkg-config\" \"--libs\" \"--cflags\" \"dbus-1\"`: No such file or directory (os error 2)"', ../src/libcore/result.rs:785
note: Run with `RUST_BACKTRACE=1` for a backtrace.
[Warning] Could not generate notification! Optional Python module 'dbus' is not installed.
Build completed in 0:05:27
```
Source-Repo: https://github.com/servo/servo
Source-Revision: 81ebde63319e3bf927655f8fa84500294152c122
<!-- Please describe your changes on the following line: -->
This removes the code and support infrastructure for the gonk port.
r? @metajack
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x ] `./mach build -d` does not report any errors
- [x ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ x] These changes do not require tests because there are no tests
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: e3b2d6aef0bbf96cc55f1235461d757cf685f0e0
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because README-only change.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This is required through devices -> blurz -> dbus.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7040e2a5f7c71699fcb7d48016ee8f1ab7bef73c
The Android build instructions haven't been updated for a while in the README;
instead of `cd ports/android && ANDROID_SDK=/path/to/sdk make install`, we have `./mach package --release` now.
Source-Repo: https://github.com/servo/servo
Source-Revision: e18bf819059e4439d276b02083a60f6353aaa359
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it is only Markdown documentation.
Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.
----
I feel it would make sense to make mention of this here, especially since Browser.html is part of the [road map](https://github.com/servo/servo/wiki/Roadmap) for what we aim to achieve during the year.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8b82eb6a04d80298e083b0c74d2db8cacb340f34
Build failed without it on my Ubuntu 14.04 machine. I can't confirm whether or not other OSes need it.
Source-Repo: https://github.com/servo/servo
Source-Revision: e52b9884d19b81dfc0e51986b1bbb89a227bfc4a
https://github.com/servo/servo/wiki/Glossary is really easy to overlook, so I want to move it in-tree. This also allows us to build a self-perpetuating system where people who are confused by something are encouraged to make a pull request that lets us know about this fact.
Also, I have suspicions that a `docs/` directory is easier to notice than various markdown files scattered around the repository root.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6509cdea95343615cfd569ade769efac6d177e41
--HG--
rename : servo/HACKING_QUICKSTART.md => servo/docs/HACKING_QUICKSTART.md
rename : servo/ORGANIZATION.md => servo/docs/ORGANIZATION.md
I think "El Capitan" is a lot clearer than 10.11 – I had to look up which version that was. Thoughts?
Source-Repo: https://github.com/servo/servo
Source-Revision: 0a6c2568730bc85b6b98c6c1a5eccd3b4ba9a541
I tried to get started on Servo development but realised that a clean build of Ubuntu did not come with git out of the box. I had to manually install this before moving on with the next steps (clone and build).
Source-Repo: https://github.com/servo/servo
Source-Revision: f2b48d2764c88970d9fbf654e59fe135b6c79629
Added dependency for Fedora, mesa-libEGL-devel.
mesa-libEGL-devel was necessary on Centos 7 and likely on Fedora distos as well.
Fixes#6483
Source-Repo: https://github.com/servo/servo
Source-Revision: 7c249b1d539c37ab54e9fabfaf0442a5ac0243a9
This is discovered here: #9262
Particularly `make` needs to be available.
Usually on developer workstation `build-essential` is already installed. That is why it wasn't there in requirements.
It occurs that if you use minimal ubuntu image for some kind of automated build, it doesn't have `build-essential` by default. So would be nice to still have `build-essential` there in the command.
--
Kind Regards,
Oleksii
--
/cc @jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 64b0e47c27e70e7f9010060f12a60f64c11c9684
`autoheader` from `autoconf` was necessary for the build on my system.
Source-Repo: https://github.com/servo/servo
Source-Revision: b7a3906664dfd2f09ab675d8edb252973eb4dba1
Since Debian Jessie (current stable), the executable is in a `virtualenv` package.
Source-Repo: https://github.com/servo/servo
Source-Revision: b8fd8d9991a779854a66ed4099a19b9bceaf4435
Darío Hereñú
Simon Sapin
Aneesh Agrawal
Paul Rouget
Prajna
Tobias Markus
Anthony Ramine
UK992
Andreas Tolfsen
Jerod Santo
Jack Moffitt
Emilio Cobos Álvarez
Yuki Izumi
Lars Bergstrom
j-koreth
Brandon Fairchild
Leonardo Santagada
Patrick Trottier
msreckovic
Mason Chang
Josh Matthews
Guillaume Gomez
Rohit Zambre
Campbell Barton
Per Lundberg
Dirkjan Ochtman
Mátyás Mustoha
Dongie Agnir
Matthias Krüger
James 'zofrex' Sanderson
Murali Ramanujam
York Xiang
Jason Williams
n-liam
Oleksii Fedorov
Adrian Heine né Lang