clang-tidy suggestions in "part 3 - Console API exposed to worklets".
MozReview-Commit-ID: Aab74PCau9m
--HG--
extra : rebase_source : 0f4a5500e391ee734c3e5fcc0c7930007310de27
Initial version r=smaug.
Rebased to c616a6fd5e4b by Jan-Ivar Bruaroey <jib@mozilla.com> r=karlt.
Rebased to 83de58ddda20 by Karl Tomlinson <karlt+@karlt.net> r=baku.
MozReview-Commit-ID: G5E5OXydj3a
--HG--
extra : rebase_source : 4c6c9d396debce92299496c86bb6f55fbbb15a8a
Initial version r=smaug.
Rebased to c616a6fd5e4b by Jan-Ivar Bruaroey <jib@mozilla.com> r=karlt.
Rebased to 83de58ddda20 by Karl Tomlinson <karlt+@karlt.net> r=baku.
MozReview-Commit-ID: Lo8TWtN8qyz
--HG--
extra : rebase_source : ffcb7b835ea49cda3e25dfa94a91b3725fdbfb29
We currently reduce the precision of timestamps emitted by console.time
in the main context, but not in a Worker. Because web page content cannot
read the content of messages emitted to the console (right?), we don't
actually need to reduce the precision of this data.
MozReview-Commit-ID: EfpIEICy0tX
--HG--
extra : rebase_source : 9516943b11dd7d4ccbcf38a80a981a6fb4662c40
This is a large patch which tries to switch many of the external consumers of
nsGlobalWindow to instead use the new Inner or Outer variants.
MozReview-Commit-ID: 99648Lm46T5
XPCOM's string API doesn't have the notion of a "null string". But it does have
the notion of a "void string" (or "voided string"), and that's what these
functions are returning. So the names should reflect that.
--HG--
extra : rebase_source : 4e3f982e0873877174a08a25413595ff66f7d20e
This patch replaces four functions of the name AssignWithConversion which
are essentially wrappers around CopyASCIItoUTF16 and LossyCopyUTF16toASCII
with direct calls to the latter two functions. The replaced functions are:
void nsCString::AssignWithConversion( const nsAString& aData )
void nsString::AssignWithConversion( const nsACString& aData )
void nsTString_CharT::AssignWithConversion(
const incompatible_char_type* aData,
int32_t aLength = -1);
The last of the three exists inside the double-included nsTString* world and
so describes two functions, giving four in total.
This has two advantages:
* it removes code
* at the call points, it makes clear (from the replacement name) which
conversion is being carried out. The generic name "AssignWithConversion"
doesn't make that obvious -- one had to infer it from the types.
The patch also removes two commented out lines from
editor/composer/nsComposerCommands.cpp, that appear to be related. They are
at top level, where they would never have compiled. They look like
leftovers from some previous change.
--HG--
extra : rebase_source : fb47bf450771c3c9ee3341dd14520f5da69ec4f5
Jan de Mooij
Andrea Marchesini
Karl Tomlinson
Tom Ritter
Boris Zbarsky
Narcis Beleuzu
Nika Layzell
Nicholas Nethercote
Alexandre Poirot
Masatoshi Kimura
Julian Seward
Mats Palmgren
Bevis Tseng