Граф коммитов

163 Коммитов

Автор SHA1 Сообщение Дата
Marco Bonardo 59f27ba50d Bug 1477671 - Stop allowing creation of new live bookmarks from the backend. r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D7083

--HG--
extra : rebase_source : 89475d197e412ad5756eb1e9f4b9a4ea06dbf2a2
2018-10-06 10:32:13 +01:00
Doug Thayer 218843ef6a Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak
See https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit#
for further info. This essentially follows the same philosophy as
the onVisits migration.

MozReview-Commit-ID: I4bOvFH0ZQR

Depends on D4605

Differential Revision: https://phabricator.services.mozilla.com/D4606

--HG--
extra : moz-landing-system : lando
2018-10-09 14:47:27 +00:00
Mark Banner bf2dba5c9f Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796

--HG--
extra : moz-landing-system : lando
2018-08-22 15:44:43 +00:00
Mark Banner f1731211b5 Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak
MozReview-Commit-ID: HeO3Mm5Dibo

Differential Revision: https://phabricator.services.mozilla.com/D2582

--HG--
extra : moz-landing-system : lando
2018-08-01 10:13:59 +00:00
Marco Bonardo 23cf556fe1 Bug 1477996 - Move getURIsForTag to the bookmarking API. r=Standard8,lina
The tagging API is being merged into the bookmarking API. This is part of it.

Differential Revision: https://phabricator.services.mozilla.com/D2450

--HG--
extra : moz-landing-system : lando
2018-07-27 15:16:57 +00:00
Marco Bonardo 3489683af3 Bug 1452067 - Move AllTags to an async method in the bookmarking API. r=Standard8
The tagging API is moving to the bookmarking API, this is one step

Differential Revision: https://phabricator.services.mozilla.com/D2316

--HG--
extra : moz-landing-system : lando
2018-07-25 14:04:14 +00:00
Marco Bonardo 6da5d81859 Bug 1452068 - Move MAX_TAG_LENGTH to the bookmarking API. r=Standard8
The tagging API is moving to the bookmarking API, this is one step

Differential Revision: https://phabricator.services.mozilla.com/D2315

--HG--
extra : moz-landing-system : lando
2018-07-24 18:45:13 +00:00
Lina Cambridge 48335a1fdc Bug 1474033 - Ensure `PlacesUtils.bookmarks.moveToFolder` bumps the Sync change counter for items moved between different parents. r=Standard8
This patch unifies `updateBookmark` and `moveBookmark`.
`update` already handles the Sync change counter, and `move` specially
optimizes for moves. We can consolidate the two by reusing the queries
from `move` in `update`, moving its extra `setAncestorsLastModified`
call to `PlacesUtils.bookmarks.update`, and removing its transaction
and wrapper.

Differential Revision: https://phabricator.services.mozilla.com/D2016

--HG--
extra : moz-landing-system : lando
2018-07-09 14:12:41 +00:00
Drew Willcoxon b6ae98cf37 Bug 1467627 - Calculate origin frecency as the sum of all URL frecencies instead of the max. r=mak
MozReview-Commit-ID: KZi9C7olvsj

--HG--
extra : rebase_source : e95bf70b9de576fe464d21f17aa0eeb27decb60b
2018-07-04 14:01:28 -07:00
Mark Banner acb2be40d6 Bug 1446325 - Stop inserting the default smart bookmarks into new profiles. r=mak,lina
MozReview-Commit-ID: AGQaw1rgukO

Differential Revision: https://phabricator.services.mozilla.com/D1831

--HG--
extra : moz-landing-system : lando
2018-07-02 16:25:09 +00:00
Mark Banner 1808cc5dec Bug 1467996 - Remove all the code adding a description annotation. r=mak,lina
MozReview-Commit-ID: CRBSxJtJELp

Differential Revision: https://phabricator.services.mozilla.com/D1748
2018-06-26 12:33:45 +00:00
Mark Banner 183a2fd1d5 Bug 1404909 - Improve performance of moving bookmarks via cut/paste or drag/drop by providing a bulk-move handling API. r=mak
The moveBookmark implementation is largely a simplification of the updateBookmark but with a focus on optimising for moves, and handling multiple-move cases.

The performance improvements come from only having one places wrapper, and one database transaction, rather than one-per-item to be moved. There's also some minor optimisations in the flow, as it can be simplified compared to a full update.

MozReview-Commit-ID: 5So28A7Dcpp

--HG--
extra : rebase_source : abf984135cb96d2ad12389e7a1580b4a8f494fce
2018-04-24 16:38:16 +01:00
Kris Maglione 7b7264f453 Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB

--HG--
extra : rebase_source : 2931dd0eec0e4206414b698a9700fc20d922eb3a
2018-05-25 17:02:29 -07:00
Mark Banner d13db67be4 Bug 1460849 - Allow new items (as well as existing) to be skipped in nsNavHistoryFolderResultNode::OnItemMoved if excludeItems is set. r=mak
MozReview-Commit-ID: CUCAsmG99A8

--HG--
extra : rebase_source : d190f2a5d236dfea25fe247142c69f9754b3cd4f
2018-05-11 13:23:41 +01:00
Drew Willcoxon cd74785cab Bug 1239708: Improve awesomebar autofill. Part 2: Non-core follow-ons. r=mak
MozReview-Commit-ID: IFm1arAhjF5

--HG--
extra : rebase_source : f1d8c838e2b690de30bfbc688926aba62880509e
2018-05-14 11:25:33 -07:00
Kris Maglione a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Marco Bonardo ba1483da46 Bug 1450210 - Remove remaining references to the POST data anno. r=standard8
MozReview-Commit-ID: 5AOMj1VBgT7

--HG--
extra : rebase_source : 3b89f4a26e77b37a0da8ff8640af4a648c93b351
2018-03-30 12:33:02 +02:00
Kit Cambridge 4f0c3cba86 Bug 1199077 - Add Places APIs to store the bookmarks sync ID and last sync time. r=mak,tcsc
MozReview-Commit-ID: 7yEGZl5pIru

--HG--
extra : rebase_source : bdb8a72ed179a20ade7bf5f46097fb9337d1895b
2018-03-03 11:27:58 -08:00
Kit Cambridge 0c40fa1232 Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
MozReview-Commit-ID: 1glcCPj2X90

--HG--
extra : rebase_source : 2d8372029df5851ecbb30a65393325442addd84c
2018-03-01 13:37:13 -08:00
Mark Banner 2155e56144 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R

--HG--
extra : rebase_source : c98e6a50702ef0c238d036fa2a26f4a6ac9f15af
2018-02-16 20:30:04 +00:00
Dorel Luca 7065341d2f Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)

--HG--
extra : rebase_source : cb7317f5afa7c828ec3b6d9b7679b474fa9cf5da
2018-03-14 18:23:46 +02:00
Mark Banner 80abee119b Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R

--HG--
extra : rebase_source : a956958f5c9adde0ee775e9bc918a8970564bbb7
2018-02-16 20:30:04 +00:00
Mark Banner 28f08cc0dc Bug 1443835 - Prevent modifications to the root folder via PlacesUtils.bookmarks.insert and PlacesUtils.bookmarks.update. r=mak
MozReview-Commit-ID: KQjxc3PA2SY

--HG--
extra : rebase_source : 1a6063f424271ac3bfdae23af25a4e8abdd71ac9
2018-03-07 17:24:01 +00:00
Mark Banner 8e43da7d18 Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut. r=mak
MozReview-Commit-ID: OqKDMEqxeA

--HG--
extra : rebase_source : d716baa2dc2cf6433a7e7c4be79882b085d1ed51
2018-03-02 15:42:25 +00:00
Mark Banner 2e4db142aa Bug 1440761 - Enable no-unused-vars for global scope on jsm files in toolkit/. r=mossop
MozReview-Commit-ID: 7Okqmw5dBcL

--HG--
extra : rebase_source : 6fff67e5e4bf483e6903a68a713d0b7d6c659d3b
2018-02-23 19:25:59 +00:00
Florian Quèze 682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Kit Cambridge e5d15ed6c2 Bug 1435354 - Remove the keywords cache observer and implement cache invalidation. r=mak
MozReview-Commit-ID: dRGyz042JM

--HG--
extra : rebase_source : 06e6a38403f2aabe322520d74bbe0a178cd30684
2018-02-20 22:04:59 -08:00
Felipe Gomes 35c0e50b23 Bug 1438577 - Add API to fetch bookmarks by GUID prefix. r=mak
MozReview-Commit-ID: GPEp5Vxrz5z

--HG--
extra : rebase_source : f8be9cfdad6db7f00366cef587751649538f74df
2018-02-20 13:31:41 -03:00
Mark Banner d6729b8d28 Bug 1432614 - Remove now unnecessary updating and maintenance of Places' root folder titles. r=kitcambridge,mak
The titles for the root bookmark folders in the database will now never get updated. This
avoids doing maintenance and changing them if the locale changes.

The UI is now responsible for displaying the correct title.

WebExtensions API will get the UI visible names.

MozReview-Commit-ID: ErPPJXxy2d3

--HG--
extra : rebase_source : f08caa5b0d00ae81ffabf4a1076bd56b66414418
2018-01-04 16:35:56 +00:00
Mark Banner 362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Coroiu Cristina 1c85c04c62 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner 7785b2e489 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione 918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou 9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione 6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Mark Banner 85b029c2ae Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak
MozReview-Commit-ID: 9ZMA2A879O8

--HG--
rename : toolkit/components/places/tests/bookmarks/test_protectRoots.js => toolkit/components/places/tests/legacy/test_protectRoots.js
extra : rebase_source : d386b6e8b9e1bfc4568032d094a48d7d9a3b3a48
2017-12-21 09:16:48 +00:00
Doug Thayer 43771ba19d Bug 1414892 - Optimize moz_places_afterinsert_trigger r=mak
This uses a similar strategy as that employed by moz_places_afterdelete_trigger,
creating a temp table which we write host inserts into, and then deleting all
the rows from it when we're done inserting, effectively resulting in a per-
statement trigger to only do the significant work per host.

MozReview-Commit-ID: 5TUueknq3ng

--HG--
extra : rebase_source : 1892edfcaa7b6afd29ce794a93d6ab3d46c48895
2017-11-07 12:01:53 -08:00
Mark Banner 0e947c9d32 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : 5cd1c4d848dc32611349e25eb7297ba50890f0a9
2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs 1d0ba383ae Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE 2017-10-31 14:19:52 +02:00
Mark Banner d059b763bb Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : ca8ec95e51899bc1fb18e7a39f42a96569a2d4d1
2017-10-26 10:14:14 +01:00
Marco Bonardo c4ffb970fc Bug 1404631 - Bookmarks.insertTree should have an option to fixup input and skip broken entries. r=standard8
MozReview-Commit-ID: 47edAJolOwE

--HG--
extra : rebase_source : 4d9e286ca108a687c786ad842db3976f1d3fc814
2017-10-07 11:15:47 +02:00
Dan Banner 7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Josh Aas 8d88b9d1a8 Bug 1095427 - Convert HTML bookmarks import code to the new async Bookmarks.jsm API. r=mak
Original patch by Josh, completed by Standard8.

MozReview-Commit-ID: Baun3n69n1b

--HG--
extra : rebase_source : e83e6a3cb0cc448c407042eabf6f6acaf1aabe68
2017-10-02 16:53:00 +01:00
Mark Banner f1daedfa92 Bug 1407164 - Fix strict warnings in Bookmarks.jsm relating to undefined property source - don't delete item properties too soon. r=mak
MozReview-Commit-ID: AJJRSHYqPch

--HG--
extra : rebase_source : bb2d043215be9e2493ddd5dff452999dd95d1db2
2017-10-10 09:13:19 +01:00
Mark Banner 1a2f65447b Bug 1405317 - When inserting trees of bookmarks, avoid updating the last modified date when marking annotations. r=mak
MozReview-Commit-ID: Ik8DKwtiXoM

--HG--
extra : rebase_source : 4e6f0b5b1778cd8b9355a35908baccd850d7c5ca
2017-10-03 21:18:10 +01:00
Kit Cambridge 0d29ca233e Bug 1393904 - Ensure `insertTree` removes Sync tombstones for restored bookmarks. r=mak
MozReview-Commit-ID: EbGybRbhWKJ

--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
2017-08-25 12:04:22 -07:00
Bob Silverberg 8268904c53 Bug 1293853 - Part 2: Include separators in results from bookmarks.search, r=standard8
This API is only used by WebExtensions, which previously wanted to exclude separators,
but now we want the WebExtensions APIs to be able to return separators.

MozReview-Commit-ID: 7PApWDwWMr1

--HG--
extra : rebase_source : c5e816900cb0288f1cdba86ec07f6565a1c79880
2017-08-29 13:19:05 -04:00