This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.
Differential Revision: https://phabricator.services.mozilla.com/D8739
--HG--
extra : moz-landing-system : lando
Sometimes the protocol buffer data (RiceEncodingData) sent by Google's Safe Browsing server has the following properties:
1. |has_first_value| is false
2. |num_entries| > 0
In this case, we can still parse the data and apply partial update correctly by assuming that the first value is equal to 0.
Differential Revision: https://phabricator.services.mozilla.com/D6393
--HG--
extra : moz-landing-system : lando
The slowIframe added in bug 1488974 shares the same target HTML page with fastIframe, and the resource will be canceled by ChannelUnifier and only loaded once.
Sometimes, when slowIframe is loaded faster than fastIframe, the resource in fastIframe will be canceled, that's the root cause of the intermittent.
Differential Revision: https://phabricator.services.mozilla.com/D8423
--HG--
extra : moz-landing-system : lando
The test used to assume that the load event didn't matter and so
the expected values had to be updated to match the new behavior.
A new "slowIFrame" test was added to capture what was previously
tested by the "badIFrame".
Differential Revision: https://phabricator.services.mozilla.com/D7031
--HG--
extra : moz-landing-system : lando
A directory-based file copy without checkpoint to abort may take lots
of time to finish. This cause an issue that if firefox is shutting down
and try to close an ongoing update thread, main-thread may be blocked
for a long time.
This patch adds a wrapper for copying an entire directory, within this
wrapper, we use file-based copy and add checkpoints to let update thread
has a chance to abort.
Differential Revision: https://phabricator.services.mozilla.com/D3414
--HG--
extra : moz-landing-system : lando
A directory-based file copy without checkpoint to abort may take lots
of time to finish. This cause an issue that if firefox is shutting down
and try to close an ongoing update thread, main-thread may be blocked
for a long time.
This patch adds a wrapper for copying an entire directory, within this
wrapper, we use file-based copy and add checkpoints to let update thread
has a chance to abort.
Differential Revision: https://phabricator.services.mozilla.com/D3414
--HG--
extra : moz-landing-system : lando
Also remove a useless call to SetCapacity().
MozReview-Commit-ID: LarsWKI3qwz
Differential Revision: https://phabricator.services.mozilla.com/D3882
--HG--
extra : moz-landing-system : lando
Automatic changes by ESLint, except for manual corrections for .xml files.
Differential Revision: https://phabricator.services.mozilla.com/D4439
--HG--
extra : moz-landing-system : lando
There are surprisingly many of them.
(Plus a couple of unnecessary checks after `new` calls that were nearby.)
--HG--
extra : rebase_source : 47b6d5d7c5c99b1b50b396daf7a3b67abfd74fc1
Before this patch -- with the nsCString return type -- we have to do heap
allocation and copying to produce the return value. But the callers don't
actually care about having a nsCString -- they just call .get() to access the
character buffer, and log it, and then they're done. They can do this just as
easily with the stack-allocated nsAutoCString that PartialHashHex() works with
locally, so let's change the return type so that Return Value Optimization
can give them that variable directly and avoid needless copying/allocation.
This patch addresses the following clang 8.0 build warning:
LookupCache.h:63:12 [-Wreturn-std-move]
local variable 'hex' will be copied despite being returned by name
Differential Revision: https://phabricator.services.mozilla.com/D3920
--HG--
extra : moz-landing-system : lando
The enable/disable logic of the list manager was wrong. If multiple features
shared a given table (e.g. tracking protection and tracking annotations)
and only one of them was enabled, then updates could either be disabled
or enabled depending on which feature was checked first.
By disabling everything at the beginning and selectively re-enabling tables,
we can ensure that no table gets both enabled and disabled by different
feature toggles.
Differential Revision: https://phabricator.services.mozilla.com/D3259
--HG--
extra : moz-landing-system : lando
Ehsan Akhgari
Julian Descottes
Dimi Lee
Francois Marier
Andreas Farre
Liang-Heng Chen
Cristina Coroiu
arthur.iakab
Noemi Erli
Jonathan Kingston
Brindusan Cristian
Gurzau Raul
Andreea Pavel
Tiberius Oros
Henri Sivonen
Cosmin Sabou
Mark Banner
Nicholas Nethercote
Ciure Andrei
Alex Gaynor
Andrea Marchesini
Daniel Holbert