Chris Pearce
ab7252caa2
Bug 1267918
- Add do_AddRef(const RefPtr<T>& aObj). r=froydnj
...
This means we can return already_AddRefed<T> for any RefPtr<T>s
being held as instance variables easier.
MozReview-Commit-ID: HFHdkF8EUsK
--HG--
extra : rebase_source : df650d39c010386afcb8cb2dd48292c26fbc6501
2016-06-30 10:06:10 +12:00
Jeff Walden
e20f0f4551
Bug 1282795 - Silence warnings when MOZ_ALWAYS_{TRUE,FALSE} are passed expressions with embedded side effects, that would ordinarily trigger side effects but don't inside certain unevaluated contexts within MOZ_ASSERT, which then triggers compiler warnings with new-enough clang. You are not expected to understand this. r=froydnj
...
--HG--
extra : rebase_source : ffe6d35af74c50b04dbddc9cc3965292875c64a0
2016-06-28 17:12:14 +01:00
Andi-Bogdan Postelnicu
5e3fc1519f
Bug 525063 - renamed MOZ_INITIALIZED_OUTSIDE_CONSTRUCTOR -> MOZ_INIT_OUTSIDE_CTOR. r=nfroyd
...
MozReview-Commit-ID: GPQY8b2OM2V
2016-06-28 16:30:49 +03:00
Seth Fowler
a2712d4b0e
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-22 16:32:40 -07:00
Carsten "Tomcat" Book
c46c20b362
Backed out changeset 7b03f23fdde5 (bug 1255632) for bustage on a CLOSED TREE
2016-06-22 08:48:25 +02:00
Seth Fowler
358b410aaa
Bug 1255632 - Make Maybe::map and Maybe::apply support lambdas. r=waldo,njn
2016-06-21 22:15:27 -07:00
Luke Wagner
fa9fafb015
Bug 1277896 - add Vector::initLengthUninitialized (r=waldo)
...
MozReview-Commit-ID: He6Kzr0giLU
2016-06-10 13:28:04 -05:00
Luke Wagner
6b6f143161
Bug 1278391 - add move constructor to EnumeratedArray (r=njn)
...
MozReview-Commit-ID: AQjH3xx9TSq
--HG--
extra : rebase_source : 599dc2bf76fa2921de6bf3b41c7d384db70a7ff9
2016-06-09 08:42:16 -05:00
Andi-Bogdan Postelnicu
12bac0f757
Bug 525063 - add attribute to mark member variables that should be skipped by clang plugin initialization checker. r=nfroyd
...
MozReview-Commit-ID: 4V1YcK2thiF
2016-06-09 09:32:11 +03:00
Andi-Bogdan Postelnicu
c735dfa442
Bug 1278201 - prevent writing |mRefCnt| after it's freed. r=Ms2ger
...
MozReview-Commit-ID: G7fZzrGWHmW
--HG--
extra : rebase_source : 6f311948a8d2222358aec860f2c6d6223862e814
2016-06-06 17:23:10 +03:00
L. David Baron
97c2e11d8c
Bug 1273048 - Add MOZ_GCC_VERSION_AT_MOST macro. r=froydnj
...
MozReview-Commit-ID: 4VjAra5B6GM
--HG--
extra : transplant_source : %D3%C7C%05%7EB%24%90q%D3%22%C8%F5%8F%C7%C3%B4%00%A6%E2
2016-06-03 20:08:41 -07:00
Boris Chiou
acc84881a2
Bug 1277740
- Add const to RangedPtr<T>::operator+ and operator-. r=Waldo
...
MozReview-Commit-ID: FlHmq5eh5ph
--HG--
extra : rebase_source : 7e8939f0a9531426fa8fa742351d47f1d2351e72
2016-06-03 12:16:33 +08:00
Boris Chiou
4b68d2e1e4
Bug 1276550 - Support operator-> for RangedPtr. r=Waldo
...
MozReview-Commit-ID: EiOfo7ly34P
--HG--
extra : rebase_source : 6acbd9b3b6681f5c777e779713a21e8f808b89bf
2016-05-30 11:55:57 +08:00
Luke Wagner
e574e0eda0
Bug 1277377 - prevent unsafe C-style cast in Vector (r=waldo)
...
MozReview-Commit-ID: L0bTDSBHOeY
2016-06-02 14:38:02 -05:00
Nicholas Nethercote
b3d842431f
Bug 1272203 (part 1) - Add mozilla::NotNull to MFBT. r=froydnj.
...
This patch implements mozilla::NotNull, which is similar but not identicial to
gsl::not_null.
The current draft(?) implementation of gsl::not_null is at
https://github.com/Microsoft/GSL/blob/master/include/gsl.h .
The main difference is that not_null allows implicit conversion from T to
not_null<T>. In contrast, NotNull only allows explicit conversion from T to
NotNull<T> via WrapNotNull().
The rationale for this is that when converting from a less-constrained type to
a more constrained type, implicit conversion is undesirable. For example, if I
changed a function f from this:
f(int* aPtr);
to this:
f(gsl::not_null<int*> aPtr);
no call sites would have to be modified. But if I changed it to this:
f(mozilla::NotNull<int*> aPtr);
call sites *would* need to be modified. This is a good thing! It forces the
author to audit the call sites for non-nullness, and encourages them to
back-propagate NotNull throughout the code.
The other difference between not_null and NotNull is that not_null disables
pointer arithmetic, which means it cannot be used with array pointers. I have
not implemented this restriction for NotNull because it seems arbitrary and
unnecessary.
2016-05-12 14:21:16 +10:00
Chris Peterson
11ef78ae89
Bug 1275016 - Rename Endian.h to EndianUtils.h to avoid #include confusion with Android's endian.h stdlib header. r=froydnj
...
--HG--
rename : mfbt/Endian.h => mfbt/EndianUtils.h
2016-05-22 13:31:11 -07:00
Bill McCloskey
308608ab39
Bug 1262671 - Introduce MFBT BufferList class (r=froydnj)
2016-05-27 09:57:40 -07:00
Jan de Mooij
eb2ea5c544
Bug 1269319 - Make AlignedStorage/AlignedStorage2 non-copyable to fix strict aliasing issues. r=Waldo
2016-05-19 20:57:36 +02:00
Michael Layzell
09a0151088
Bug 1209227 - Part 2: Mark mfbt::Variant as MOZ_INHERIT_TYPE_ANNOTATIONS_FROM_TEMPLATE_ARGS, r=froydnj
2016-05-19 09:34:01 -04:00
Chris Peterson
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
Benjamin Bouvier
88fbb75f4c
Bug 1271972: wasm: Implement i64.ctz, i64.clz, i64.popcount; r=sunfish
...
MozReview-Commit-ID: 2XXloMWmbjV
--HG--
extra : rebase_source : a332d6b5c3e0cfe3d5018cdc53e4c20b80b6a52a
extra : histedit_source : d413c95a2d1bc56f8d6f0deacecf37190a612397
2016-05-11 19:00:53 +02:00
James Cheng
4d3ad00b0e
Bug 1269968 - Remove unnecessary deduction on RefPtr.h. r=froydnj
...
MozReview-Commit-ID: HoLyJD6oh
--HG--
extra : rebase_source : ac10cf1b3fae96ae91e7b5dd9b5a54797cec6e6d
2016-05-03 20:45:00 +02:00
Luke Wagner
df166c688f
Bug 1271022 - add Vector::podResizeToFit (r=njn)
...
MozReview-Commit-ID: 9HTY6O9GY4U
--HG--
extra : rebase_source : 55c226d23bd6dbb7b3bb21b356e64ae7499d3f0a
2016-05-09 08:59:10 -05:00
Nicholas Nethercote
d8dc169af0
Bug 1268754 - Tweak some MFBT return values. r=Ms2ger.
...
This patch:
- Adds MOZ_MUST_USE to AllocPolicy::checkSimulatedOOM().
- Adds MOZ_MUST_USE to LZ4::decompress() (both variants) and fixes their
comments.
- Changes the return type of SplayTree::insert() from bool to void, because it
always returns true and its callers don't check the return value.
- Changes the return type of SplayTree::finishInsertion() from T* to void,
because it makes things clearer -- it was just returning the aNew argument.
- Adds MOZ_MUST_USE to a Vector::growTo() (both variants).
--HG--
extra : rebase_source : 1547cdeb9ee71d0ecec608ab474ab5e75bfc4b42
2016-04-29 13:14:34 +10:00
Benoit Girard
6b1ce5f87f
Bug 1268246 - Add a simple Poison class lifetime checker. r=froydnj
...
MozReview-Commit-ID: HpUjIaLPV7u
--HG--
extra : rebase_source : e5586cbb9d71005181671f362583a5b3b9006a4d
2016-04-29 13:54:54 -04:00
Nicholas Nethercote
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
Nicholas Nethercote
a5c843fe5f
Bug 1267550 (part 1) - Rename MOZ_MUST_USE as MOZ_MUST_USE_TYPE. r=ehsan.
...
This will allow MOZ_MUST_USE to be used for a different and more common case.
MozReview-Commit-ID: 4dQsdWjJfc6
--HG--
extra : rebase_source : 390ab56ef83d71eb6d28759a0195a79a78b153bd
2016-04-27 08:22:10 +10:00
Jon Coppeard
b0359cb30b
Bug 1266404 - Allow construction of an EnumSet<T> using an initializer list r=Waldo
2016-04-28 14:25:05 +01:00
Jon Coppeard
7dd2771dd7
Bug 1266402 - Add iteration to EnumSet<T> so that it can be used in range-based for loops r=Waldo
2016-04-28 14:25:05 +01:00
Dan Gohman
592be23acb
Bug 1265892 - Change Vector to use Impl::new_ consistently. r=Waldo
2016-04-26 16:26:17 -07:00
Jon Coppeard
99cbfbd0dc
Bug 1259021 - Add Vector::extractRawBuffer method that doesn't copy the buffer r=Waldo
2016-04-25 13:41:25 +01:00
Jon Coppeard
d5b6a661f0
Bug 1259021 - Rename Vector::extractRawBuffer to extractOrCopyRawBuffer r=Waldo
2016-04-25 13:41:25 +01:00
Chris Peterson
1999c10d91
Bug 1266294 - Remove unnecessary compiler version checks for gcc <= 4.8.0 in mfbt. r=froydnj
2016-04-17 17:08:10 -07:00
Ehsan Akhgari
575dbe7dfd
Bug 1264827 - Part 3: Add the MOZ_NEEDS_MEMMOVABLE_MEMBERS annotation to MFBT; r=froydnj
2016-04-18 15:43:48 -04:00
Carsten "Tomcat" Book
558930f4e9
Backed out changeset e673dbc9848f (bug 1232686) for breaking VS2013 Builds
2016-04-16 10:57:53 +02:00
Terrence Cole
2177cca5cd
Bug 1232686 - Use decltype to infer Variant::match return type; r=fitzgen
2015-12-15 07:45:22 -08:00
Jan de Mooij
67e655e4bf
Bug 1261361 - Make Vector::infallibleGrowByUninitialized check mReserved instead of mCapacity. r=Waldo
...
--HG--
extra : rebase_source : 2b6cdfae61946505b83748c016ef0b112ecf4780
2016-04-14 17:32:48 +02:00
Ralph Giles
8ed91454ea
Bug 1262663 - Clean up UniquePtr return documentation. r=Waldo
...
The prohibition against returning a UniquePtr was based on
bugs in older compilers which required an explicit Move()
to properly transfer ownership. This is no longer the case
since we now have code returning this type directly.
--HG--
extra : rebase_source : 6190b3f14b650d448f18f7611a22576701657795
2016-04-11 14:36:29 -07:00
Lee Salzman
c9a80c9abd
Bug 1263342 - don't use REFCOUNTED_VIRTUAL_TYPENAME for mfbt FunctionImplBase. r=froydnj
2016-04-08 23:14:59 -04:00
Lee Salzman
f1057b0380
Bug 1262577 - allow comparing mozilla::function with nullptr. r=froydnj
2016-04-06 15:18:01 -04:00
Terrence Cole
0ef3ab81a0
Bug 1232418 - Allow mozilla::Tuple to support equality comparison; r=Waldo
...
--HG--
extra : rebase_source : d57231f1c4a4c58715d2d552dd2e02257a73891e
2015-12-14 12:01:17 -08:00
Timothy Nikkel
6aeb6d5d05
Bug 1260247. In chaos mode randomly decide to start a new image load even if the image is in the image cache when allowed by spec. r=seth
...
If the image load is from the same document that cached the image we are required to use the cached version. Otherwise we should be free to ignore the cached version.
2016-04-02 13:53:12 -05:00
Bobby Holley
5790b832fa
Bug 1261452 - do_AddRef shouldn't require an rvalue-reference. r=froydnj
2016-04-01 19:14:42 -07:00
David Keeler
9825c57bc3
bug 1239166 - platform work to support Microsoft Family Safety functionality r=froydnj,mgoodwin,mhowell,rbarnes,vladan
...
MozReview-Commit-ID: GhpJqJB97r9
--HG--
extra : rebase_source : e943c1e4d0f008ffd6b6bb4bb63e1daf27ae2c96
2016-01-12 15:39:43 -08:00
Jeff Walden
1dd8dbc3f7
Bug 1246061. r=jandem, r=bz, r=luke, r=froydnj
...
--HG--
extra : rebase_source : 5b314d4c4c6e0b553290884be7338f8e79c22f71
2016-03-09 00:37:20 -08:00
Markus Stange
04177e1aa2
Bug 1209100 - Back out bug 1165185 on inbound.
...
MozReview-Commit-ID: JqohyXNvjiU
--HG--
extra : rebase_source : c2165d279a6ca57a3439ebbfc081961369a42124
2016-03-21 16:16:52 -04:00
Mike Hommey
3fe18eae3b
Bug 1175546 - Update GCC to 4.8.5 and bump minimum GCC version required to build. r=froydnj
2016-03-12 09:03:37 +09:00
Benoit Girard
52f227c58b
Bug 1253678 - Rename mozilla::Function to mozilla::function. r=froydnj
...
MozReview-Commit-ID: 60RPmEsYDN2
--HG--
extra : rebase_source : 9d0bebc7362af2778d123425c56ac20553d9303b
2016-03-11 16:49:13 -05:00
Ehsan Akhgari
30ce323e87
Bug 1255857
- Allow mozilla::UniquePtr's deleter template argument to customize the pointer type; r=froydnj
2016-03-11 15:35:43 -05:00
Nick Fitzgerald
3508cf5f6a
Bug 1254565 - Allow passing matchers as rvalues to Variant::match. r=froydnj
...
--HG--
extra : rebase_source : 9863e7cde9ff918af22de94ca7ec29988c154bbd
2016-03-10 13:35:00 -05:00