016cc78dda
Bug 1638256 - Some casts and fixes in mozStorage to make clang-tidy happy. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D181551
2023-06-24 10:11:28 +00:00
95fe144ede
Bug 1638256 - Use mTelemetryFilename for the mozStorage thread name. r=asuth
...
Depends on D181037
Differential Revision: https://phabricator.services.mozilla.com/D181038
2023-06-24 10:11:28 +00:00
81f54fd826
Bug 1638256 - Initialize mTelemetryFilename in the Connection constructor. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D181037
2023-06-24 10:11:28 +00:00
45e83e3152
Backed out 3 changesets (bug 1638256) for causing GTest failures CLOSED TREE
...
Backed out changeset 556614d4b90a (bug 1638256)
Backed out changeset dfd4d3679ccf (bug 1638256)
Backed out changeset 30c66c06f6ce (bug 1638256)
2023-06-21 22:41:40 +03:00
02b6c343ec
Bug 1638256 - Some casts and fixes in mozStorage to make clang-tidy happy. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D181551
2023-06-21 18:47:19 +00:00
48ecbc8fd9
Bug 1638256 - Use mTelemetryFilename for the mozStorage thread name. r=asuth
...
Depends on D181037
Differential Revision: https://phabricator.services.mozilla.com/D181038
2023-06-21 18:47:19 +00:00
6bfee9629b
Bug 1638256 - Initialize mTelemetryFilename in the Connection constructor. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D181037
2023-06-21 18:47:19 +00:00
130a655906
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
8219a5c503
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
17cb194f8d
Bug 1833799 - Avoid a copy that clang 7 warns about. r=dom-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D178417
2023-05-18 21:31:33 +00:00
e0a38c914c
Bug 1833233 - Add description for some database header fields; r=dom-storage-reviewers,hsingh,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D178230
2023-05-16 20:59:36 +00:00
cc5fae2ee8
Bug 1833233: Fix incremental vacuum on encrypted sqlite IDB databases.r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D178200
2023-05-16 19:44:36 +00:00
4de92044b6
Bug 1820478 - Set a default Sqlite journal size limit, and persist auxiliary files. r=asuth
...
Set a default journal_size_limit, so journals are always truncated to a sensible
max size. Change existing consumers to just use the default, but Places that is
using a larger 4MiB limit.
Change auxiliary files (-shm, -journal, -wal, ...) persistance on disk, to
avoid the cost of creating and removing them. Since there is a journal_size_limit
they will be truncated instead of deleted.
Differential Revision: https://phabricator.services.mozilla.com/D172185
2023-05-12 09:45:02 +00:00
b0f78a8a6b
Bug 1065923 - Remove histograms from Storage BaseVFS. r=janv,mossop,dom-storage-reviewers
...
As previously discussed, we're not using this telemetry at the moment, we used
it in the past to study main thread IO.
Simplifying the VFS allows us to more easily experiment with other settings
in the future.
Differential Revision: https://phabricator.services.mozilla.com/D172016
2023-05-10 11:51:49 +00:00
b99a4a2645
Bug 1065923 - Rename Storage TelemetryVFS to BaseVFS. r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D172015
2023-05-10 11:51:48 +00:00
bee102a1b1
Bug 1827351 - Fix non-unified-build bustage in storage/test/gtest/test_deadlock_detector.cpp; r=sergesanspaille
...
Differential Revision: https://phabricator.services.mozilla.com/D175098
2023-04-11 07:03:37 +00:00
ac281d953a
Bug 1822889 - Fix problems in ObfuscatingVFS with decoding frames read from the WAL file during recovery; r=dom-storage-reviewers,asuth,hsingh
...
Differential Revision: https://phabricator.services.mozilla.com/D172824
2023-04-04 14:10:39 +00:00
75254c349a
Bug 1826074 - Make storage/test/gtest buildable outside of a unified build environment r=andi
...
Depends on D174459
Differential Revision: https://phabricator.services.mozilla.com/D174460
2023-04-03 20:39:13 +00:00
13e51277df
Bug 1825324 - Make widget/* buildable outside of a unified build environment r=andi,geckoview-reviewers,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D173969
2023-04-01 08:31:12 +00:00
d90fc7ba40
Bug 1824557 - Make storage/ buildable outside of a unified build environment
...
Differential Revision: https://phabricator.services.mozilla.com/D173637
2023-03-31 13:29:43 +00:00
8e06a7a853
Backed out 12 changesets (bug 1825325, bug 1825336, bug 1825333, bug 1825332, bug 1825324, bug 1824557, bug 1825328, bug 1825335, bug 1825330, bug 1825329, bug 1825327, bug 1825331) for causing build bustages in nsClipboard.cpp CLOSED TREE
...
Backed out changeset 9de3ed24d3a0 (bug 1825336)
Backed out changeset aef787728f19 (bug 1825335)
Backed out changeset a04c341244c1 (bug 1825333)
Backed out changeset e3ad15f762ba (bug 1825332)
Backed out changeset eed23da92a27 (bug 1825331)
Backed out changeset 8213bb54376e (bug 1825330)
Backed out changeset 747ec5ac4994 (bug 1825329)
Backed out changeset e91ff431f92d (bug 1825328)
Backed out changeset 59c18d13768b (bug 1825327)
Backed out changeset 538096d99e49 (bug 1825325)
Backed out changeset c76eb9d9b095 (bug 1825324)
Backed out changeset 8b81410eb686 (bug 1824557)
2023-03-31 12:58:53 -04:00
0702cdc836
Bug 1825324 - Make widget/* buildable outside of a unified build environment r=andi,geckoview-reviewers,m_kato
...
Depends on D173637
Differential Revision: https://phabricator.services.mozilla.com/D173969
2023-03-31 13:29:44 +00:00
ab98027047
Bug 1824557 - Make storage/ buildable outside of a unified build environment
...
Differential Revision: https://phabricator.services.mozilla.com/D173637
2023-03-31 13:29:43 +00:00
8b8e0dab50
Bug 1824076 - Storage Error categorical histogram is reporting to the wrong label. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D173409
2023-03-27 13:36:39 +00:00
f3e842d937
Bug 1813986 - Add an asyncVacuum() method to storage async connections, and let VacuumManager use it. r=asuth
...
Add asyncVacuum to mozIStorageAsyncConnection, that dispatches a runnable to
the helper thread, where it will execute a full or incremental vacuum, depending
on the connection auto_vacuum value.
It also supports vacuuming attached schemas.
asyncVacuum() supports changing both the page_size and auto_vacuum.
Change mozIStorageVacuumParticipant to return a mozIStorageAsyncConnection and
allow specifying whether incremental vacuum should be enabled.
Change vacuumManager notification from heavy-io-task to vacuum-begin and vacuum-end
since the original proposal of notifying heavy IO didn't take off.
Cleanup test_vacuum to be able to use instances of the test VacuumParticipant,
that means we can remove the no more necessary registerESM hack.
Fix Places History as the only cpp consumer.
Differential Revision: https://phabricator.services.mozilla.com/D168298
2023-03-22 15:36:37 +00:00
eac4250835
Backed out 2 changesets (bug 1813986) for causing build bustages in Logging.h
...
Backed out changeset 14879c9b6b3c (bug 1813986)
Backed out changeset d90fa56c73e5 (bug 1813986)
2023-03-22 01:19:57 +02:00
daa6ee1e11
Bug 1813986 - Add an asyncVacuum() method to storage async connections, and let VacuumManager use it. r=asuth
...
Add asyncVacuum to mozIStorageAsyncConnection, that dispatches a runnable to
the helper thread, where it will execute a full or incremental vacuum, depending
on the connection auto_vacuum value.
It also supports vacuuming attached schemas.
asyncVacuum() supports changing both the page_size and auto_vacuum.
Change mozIStorageVacuumParticipant to return a mozIStorageAsyncConnection and
allow specifying whether incremental vacuum should be enabled.
Change vacuumManager notification from heavy-io-task to vacuum-begin and vacuum-end
since the original proposal of notifying heavy IO didn't take off.
Cleanup test_vacuum to be able to use instances of the test VacuumParticipant,
that means we can remove the no more necessary registerESM hack.
Fix Places History as the only cpp consumer.
Differential Revision: https://phabricator.services.mozilla.com/D168298
2023-03-21 17:28:04 +00:00
c0343f9fe5
Bug 1781116 - QuotaManager needs to deal with SQLite path canonicalization/symlink piercing; r=asuth,dom-storage-reviewers
...
Depends on D171440
Differential Revision: https://phabricator.services.mozilla.com/D171869
2023-03-07 15:56:51 +00:00
4e8833f029
Bug 1819535 - Extract quota related stuff from TelemetryVFS into standalone QuotaVFS; r=dom-storage-reviewers,mak,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D171440
2023-03-07 14:27:07 +00:00
d32855254f
Backed out changeset 80713e5124f3 (bug 1819535) for causing build bustages on mozStorageService.cpp. CLOSED TREE
2023-03-07 14:35:19 +02:00
f99b601e9b
Bug 1819535 - Extract quota related stuff from TelemetryVFS into standalone QuotaVFS; r=dom-storage-reviewers,mak,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D171440
2023-03-07 10:47:07 +00:00
f4ab16d8c2
Bug 1810791 - Check `SQLITE_IOERR_SHORT_READ` against `rc`. r=dom-storage-reviewers,asuth,hsingh
...
Differential Revision: https://phabricator.services.mozilla.com/D167051
2023-01-18 18:28:03 +00:00
a2bf81cc32
Bug 1730547 - Return exact error instead of generic one. r=dom-storage-reviewers,jstutte
...
Differential Revision: https://phabricator.services.mozilla.com/D164707
2023-01-10 17:16:17 +00:00
8730eec697
Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D165002
2022-12-23 12:37:07 +00:00
04363d3827
Bug 1802689 - Add missing licenses info in Cargo.toml r=mhoye,necko-reviewers,kershaw,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D163157
2022-12-13 09:14:44 +00:00
e073cbb0b6
Bug 1657551 - Part 6: Have a static ConcurrentStatementsHolder::Create function that handles errors returned from mozIStorageConnection::AsyncClone and transform some MOZ_ASSERT into NS_ENSURE_SUCCESS. r=mak
...
Depends on D163050
Differential Revision: https://phabricator.services.mozilla.com/D163083
2022-12-12 15:21:28 +00:00
5d0257721a
Bug 1798711 - Remove duplication of DisableCrashReporter on gtest r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D162972
2022-11-30 14:41:42 +00:00
2418374def
Bug 1801495 - Add a shim no-lock VFS that implements immutable behavior. r=asuth
...
When ignoreLockingMode option is used, we default to the unix-none or win32-none
VFS, and enforce the connection to be read-only, because it's trivial to
corrupt data using a no-lock VFS.
Unfortunately read-only mode doesn't allow to open a WAL database if the journal
files are missing, unless the device is marked as "immutable".
There is no SQLITE_OPEN_* flag for immutable, and adding one could easily be
misinterpreted since it only makes sense for read-only.
This implement a readonly-immutable-nolock VFS shim on top of unix-none or
win32-none that overrides device characteristics with immutable. When
ignoreLockingMode option is specified, we use this VFS. It can only be used on
read-only connections, as enforced both by Storage service and a MOZ_ASSERT.
Differential Revision: https://phabricator.services.mozilla.com/D162492
2022-11-29 20:35:23 +00:00
ec76a72706
Bug 1799314 - Convert consumers of testing modules to import ES modules direct (miscellaneous). r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D161917
2022-11-17 12:00:32 +00:00
8802995594
Bug 1784966: Encrypt IDB files and data in PBM, r=dom-storage-reviewers,jari,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D158597
2022-10-27 12:57:16 +00:00
2489592bdd
Bug 1795322 - Update toolkit modules references in places and storage code. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D160032
2022-10-26 08:06:36 +00:00
5f9da7b301
Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE
...
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
2022-10-25 23:47:58 +03:00
4088495edb
Bug 1795322 - Update toolkit modules references in places and storage code. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D160032
2022-10-25 19:49:26 +00:00
964b5b473b
Backed out changeset a266f691a68c (bug 1784966) for causing IDB Encryption related failures CLOSED TREE
2022-10-24 23:06:55 +03:00
138caba956
Bug 1784966: Encrypt IDB files and data in PBM, r=dom-storage-reviewers,jari,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D158597
2022-10-24 17:43:40 +00:00
c1a22477a0
Bug 1795586 - Migrate storage/test/unit/VacuumParticipant.jsm to ESM. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D159474
2022-10-19 20:25:11 +00:00
2ffde1e92f
Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
...
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
c547aefdbc
Bug 1794615 - replace TYPED_TEST_CASE by TYPED_TEST_SUITE in test_StatementCache r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D159045
2022-10-13 12:14:29 +00:00
1d8e8baed3
Bug 1793882 - Don't "return" c_void in NS_NewHashPropertyBag declaration. r=emilio
...
A function that "returns" c_void in rust ends up transposed as returning
a bool (i1) at the LLVM-IR level, compared to the definition in C/C++
returning a void at the LLVM-IR level.
Differential Revision: https://phabricator.services.mozilla.com/D158722
2022-10-06 06:34:17 +00:00
2da84b8ac4
Bug 1792574, part 3 - Don't include nsMemory where it isn't needed. r=xpcom-reviewers,necko-reviewers,valentin,nika
...
There are only 3 places where nsMemory.h is still needed (image/RasterImage.cpp,
gfx/thebes/gfxFT2FontList.cpp, and nsMemory.cpp). Remove the rest.
Differential Revision: https://phabricator.services.mozilla.com/D158213
2022-09-28 15:17:46 +00:00
Marco Bonardo
Marco Bonardo
Norisz Fay
Mark Banner
Mike Hommey
Jan Varga
hsingh
serge-sans-paille
Cristian Tuns
Noemi Erli
Iulian Moraru
Jan Rio Krause
Sylvestre Ledru
Jens Stutte
Alexandre Lissy
Csoregi Natalia
Basix
Robert Longson
Andrew McCreight