We're already going to copy the data when we initialize the
nsISupportsString here. There's no need to copy the data into a
temporary object before passing it in to the nsISupportsString.
And as long as we're fixing the big mistakes, we might as well fix the
small ones, like copying the flavor string from the IPC object.
Remote WebExtension panels can cause us to recreate the widget for a view that
already has a size. In the past, popup widgets were always created with an
initial size of 0x0, so setting the initial size of the ChildView to 0x0
resulted in correct behavior because the window would be resized to the correct
size shortly afterwards, and resize the ChildView along with it via its auto
resizing mask.
When we recreate a widget which already has a known size, setting the initial
size to 0x0 is wrong. We need to set the ChildView's size so that it fills the
contentView of the popup window completely.
MozReview-Commit-ID: 53d3AX3z5h2
--HG--
extra : rebase_source : 7720a6dd12ad7f8efc102cd1430a9e1ed2f5ee0f
Many of these could probably be fuzzed but in the interests of getting
the reftest suite turned on sooner I'm doing a blanket fails-if. This
covers all the reftests where there is more fuzz with webrender on
windows than any of existing annotations account for. In some cases the
fuzz is only a few pixels more than the equivalent Linux fuzz already
annotated, but I'll clean that up in a future bug.
MozReview-Commit-ID: IaKarbnL46d
--HG--
extra : rebase_source : 71889340305b0b12fa8eace722e42bb3faf14419
And then fix up everything else that needs to change as well.
MozReview-Commit-ID: GDMfERqdQAc
--HG--
extra : rebase_source : 01fe06c3182245a409099a53383d92bf4fa0155c
nsBaseWidget::BoundsUseDesktopPixels() states that window types before
eWindowType_sheet take desktop pixels rather than device pixels for
parameters of Move and Resize.
Cocoa widget seems to treat all of them as desktop pixels, and sheet is
one of the window types that it can actually open, so it should be put
before popup so that BoundsUseDesktopPixels() is correct on that.
MozReview-Commit-ID: FPqOoUQlQCy
--HG--
extra : rebase_source : cf625c6bf75888abfdf2393b3c3937a073c3b613
extra : source : e2080039ee9e7270b87a5512927bb151a1154b3f
On Mac, when dragging an image, add the image request's MIME type to
the transfer so that the MIME-extension check can be done in the
parent process to avoid content sandboxing issues.
MozReview-Commit-ID: 3cb4fCr6GnL
--HG--
extra : rebase_source : 43720237b467765401b5504c57bbc1b43d4dfdc0
GetClipboardText() calls gtk_clipboard_request_text() to request text clipboard data from Gtk+
and leave Gtk+ to do clipboard text format conversions. Also unify data getting code for text/data/targets.
MozReview-Commit-ID: 9DGSdOACho1
--HG--
extra : rebase_source : f1d95609f8a7587a4abc11739db9d17ec5446a7b
We don't have any binding in the tree that extends="xul:menupopup", which is the
only thing that would change the result. Also, I constrained it to the XUL
namespace instead of just checking the node name.
But again, we don't have non-XUL menupopups.
MozReview-Commit-ID: 7M0beoJI86Y
--HG--
extra : rebase_source : f50a186d5e78ca808d6c8873ec982663f4bbbde5
Add a new interface, nsIAndroidEventFinalizer, that is called whenever a
callback object is finalized, i.e. there can be no more callbacks for a
particular dispatch. Add the finalizer as a new parameter to dispatch().
Existing callers that don't need a finalizer are not affected.
This functionality is required in order to unregister our message
manager listener in a child process, after dispatching an event with
callback from a child process.
MozReview-Commit-ID: 8n89c63UGNm
--HG--
extra : rebase_source : 4913b449588e128122d7f4f64145a7794de5ab5d
There are some legacy APIs in Messaging.jsm that we can remove, now that
we no longer have to support legacy add-ons.
MozReview-Commit-ID: 3Gfg12hmkN7
--HG--
extra : rebase_source : 874b812be89a7591d9c06fbb616347aca9a8db9d
This function doesn't use any StackingContextHelper state anymore.
We should make what it does clearer and move it to a better place.
--HG--
extra : rebase_source : 1727be9657169547d842ec9b6887837abedbefdf
nsIClipboardDragDropHooks and nsIClipboardDragDropHookList allow XUL apps
to customize drag and drop operation and paste operation. However, this
feature was used only by ChatZilla and it doesn't work on Gecko anymore.
So, we can get rid of them from our tree.
MozReview-Commit-ID: Ibs3V1gI8Ry
--HG--
extra : rebase_source : 83428293d59aaca432d76c71b214aa7799f7f9de