fde06f6d21
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
964cca3198
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
5f29324f60
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
02a7b4ebdf
Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
da1098d4aa
Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
...
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
c0cea3b0fa
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
1ff59cb7a3
Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE
2020-10-22 03:51:06 +03:00
50762dacab
Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
d1ed75b2b4
Bug 1626555 - Make `dom/simpledb` buildable outside of `unified-build` environment. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D94079
2020-10-21 13:18:15 +00:00
f92973bd13
Bug 1663924 - Replace output parameters by return values on GetInfo* methods. r=dom-workers-and-storage-reviewers,ttung
...
This also changes all methods that use a pair of group/origin or a tuple of
suffix/group/origin input/output parameters to use a single GroupAndOrigin
resp. QuotaInfo struct input parameter or return value. Also, several types
having a pair or 3-tuple of such data members are changed to use these structs
instead.
Differential Revision: https://phabricator.services.mozilla.com/D91131
2020-10-20 11:46:31 +00:00
8e6a721680
Bug 1663924 - Replace output parameter by return value for EnsureStorageAndOriginIsInitialized. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D92199
2020-10-14 15:46:24 +00:00
9b138be378
Bug 1663924 - Use TRY macros with PrincipalInfoToPrincipal. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D91245
2020-10-14 15:44:59 +00:00
976d8082ca
Bug 1671118 - Rename remaining QM_TRY_VAR occurrences to QM_TRY_ASSIGN/QM_TRY_UNWRAP/QM_TRY_INSPECT (including quota client equivalents); r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D93477
2020-10-14 12:14:14 +00:00
a1b49eac52
Bug 1671109 - Remove QM_DEBUG_TRY/QM_DEBUG_TRY_UNWRAP/QM_DEBUG_TRY_RETURN/QM_DEBUG_FAIL macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D93474
2020-10-14 10:01:20 +00:00
20a9b720d4
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-02 13:23:49 +00:00
ae5e3a0d7c
Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
...
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
8598a731fc
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 15:37:50 +00:00
104db9798f
Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
...
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
4c5b983d6f
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 12:02:26 +00:00
c711008a61
Bug 1666219 - Introduce QM_TRY_INSPECT to avoid unwrapping Result objects where not necessary. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D90843
2020-09-29 10:57:14 +00:00
f0debef582
Bug 1663565 - Introduce QM_TRY_RETURN/QM_TRY_DEBUG_RETURN macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D89413
2020-09-17 14:01:01 +00:00
b26988fef6
Bug 1664412 - Mark some error handling functions as MOZ_COLD. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D89885
2020-09-14 12:14:17 +00:00
75112e975a
Bug 1661711 - Use Result<V, E> for GetDirectoryOrigin and use *_TRY_VAR for its callsites; r=sg,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D89704
2020-09-10 12:37:37 +00:00
ec62d45a35
Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv
...
Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.
Differential Revision: https://phabricator.services.mozilla.com/D89148
2020-09-08 07:40:30 +00:00
ffb37d08c1
Bug 1660751 - Make HandleError function MOZ_NEVER_INLINE. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D89147
2020-09-02 15:03:06 +00:00
ebcfb83228
Bug 1660751 - QM: Log failures in the browser console; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88004
2020-09-08 07:40:46 +00:00
7e31de8547
Bug 1662004 - Add support for nested QM_TRY/QM_TRY_VAR macros; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88764
2020-09-07 18:00:00 +00:00
16aa57011b
Bug 1661988 - Introduce QM_DEBUG_TRY/QM_DEBUG_TRY_VAR/QM_DEBUG_FAIL macros and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D88760
2020-09-07 10:05:13 +00:00
f2f47372af
Bug 1659959 - Introduce QM_FAIL macro and quota client specific equivalents; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87633
2020-08-27 11:10:10 +00:00
843f943758
Bug 1519636 - Reformat recent changes to the Google coding style r=andi
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D85678
2020-08-02 15:29:15 +00:00
e8f3f74ef6
Bug 1656411 - Move typed array, ArrayBuffer, and dataview-related functions out of jsfriendapi.h to two new headers. r=mgaudet,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D85524
2020-07-31 16:37:27 +00:00
fbc97fdb2b
Bug 1651016 - Introduce SDB_TRY and SDB_TRY_VAR macros; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D84663
2020-07-24 11:47:48 +00:00
bcb2ab8676
Bug 1621920 - Polish directory traversal done by SDB client; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D81691
2020-07-02 12:47:19 +00:00
7b8ef5617f
Bug 1621920 - Convert SDB client to use the new macro for warning about unknown stuff and add handling of unknown directories in SDB client directory; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D81690
2020-07-02 07:20:06 +00:00
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
e3c223da3e
Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
8193fe19be
Bug 1641512 - Use distinct types for file and database usage. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77462
2020-06-25 09:30:06 +00:00
55e3bdd7f8
Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of InitOrigin and add separate InitOriginWithoutTracking. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77453
2020-06-25 09:31:39 +00:00
c23800e5f2
Bug 1641512 - Use Result<UsageInfo, nsresult> as return type of GetUsageForOrigin. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77452
2020-06-25 08:34:43 +00:00
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
2e8e66ab3c
Bug 1641512 - Rename AppendTo*Usage methods to Increment*Usage. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D77450
2020-06-11 10:42:16 +00:00
d123d73b2d
Bug 1621916 - Remove unused argument in Client::InitOrigin; r=dom-workers-and-storage-reviewers,sg
...
Depends on D77070
Differential Revision: https://phabricator.services.mozilla.com/D77072
2020-05-27 15:52:49 +00:00
5183f79beb
Bug 1621916 - Unify reporting of unknown files across quota manager, idb, sdb and ls quota client; r=dom-workers-and-storage-reviewers,ttung
...
Depends on D76703
Differential Revision: https://phabricator.services.mozilla.com/D76717
2020-05-26 07:02:07 +00:00
4acff3dff1
Bug 1621916 - Fix SimpleDB to ignore unknown files during initialization and usage calculation; r=dom-workers-and-storage-reviewers,ttung
...
SimpleDB files on disk now use a suffix, so unknown files can be filtered out.
Depends on D76700
Differential Revision: https://phabricator.services.mozilla.com/D76701
2020-05-25 15:57:54 +00:00
cf852bbfb9
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D73868
2020-05-12 19:02:05 +00:00
5cebbc21b1
Bug 1619592 - Refactor persistence type checks using new IsValidPersistenceType method; r=dom-workers-and-storage-reviewers,sg
...
This patch makes use of the IsValidPersistenceType function it adds at places where individual checks were done before. It also moves some checks to the parameter validation phase.
Differential Revision: https://phabricator.services.mozilla.com/D66947
--HG--
extra : moz-landing-system : lando
2020-03-17 13:06:17 +00:00
a87575bf55
Bug 1619592 - Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D65937
--HG--
extra : moz-landing-system : lando
2020-03-13 12:55:20 +00:00
0b7c33c8d9
Backed out changeset 50af9d58c645 (bug 1619592) for causing build bustages in /builds/worker/checkouts/gecko/dom/quota/PersistenceType.cpp CLOSED TREE
2020-03-11 10:37:51 +02:00
a415028a3c
Bug 1619592 - Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D65937
--HG--
extra : moz-landing-system : lando
2020-03-11 08:08:46 +00:00
0173f3b38f
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/simpledb. r=smaug
...
Depends on D66028
Differential Revision: https://phabricator.services.mozilla.com/D66029
--HG--
extra : moz-landing-system : lando
2020-03-09 15:01:18 +00:00
Sylvestre Ledru
Butkovits Atila
Ricky Stewart
Bogdan Tara
Dorel Luca
Simon Giesecke
Jan Varga
Sebastian Hengst
Tom Tung
Jeff Walden
Jean-Yves Avenard
Jan Varga
ssengupta
shindli