0075a7ce1f
Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221445
2024-09-12 21:08:44 +00:00
7f08ffc091
Bug 1917530 - Fix ESLint no-shadow issues in devtools code. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,nchevobbe,julienw,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221442
2024-09-12 21:08:43 +00:00
6a28b1e440
Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE
...
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
2024-09-12 20:45:28 +03:00
1a8d60d410
Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221445
2024-09-12 16:41:59 +00:00
53305158e8
Bug 1917530 - Fix ESLint no-shadow issues in devtools code. r=devtools-reviewers,profiler-reviewers,frontend-codestyle-reviewers,nchevobbe,julienw,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D221442
2024-09-12 16:41:57 +00:00
71420d91a6
Bug 1864896: Enable unused argument lint rule. r=Standard8,perftest-reviewers,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,nchevobbe,robwu,sparky,issammani,sgalich,owlish,migration-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D195632
2024-03-21 08:50:00 +00:00
43d2964f1b
Bug 1884623 - Cleanup jsm references in ESLint files. r=mossop,devtools-reviewers,omc-reviewers,ochameau,aminomancer
...
Differential Revision: https://phabricator.services.mozilla.com/D204180
2024-03-11 15:26:27 +00:00
8e8cc1684d
Bug 1879811 - Avoid re-enabling ESLint rules when they are already enabled by ESLint's recommended configuration, or mozilla-central's one. r=Gijs,webcompat-reviewers,extension-reviewers,devtools-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D201361
2024-02-12 18:46:28 +00:00
56cc7346e1
Bug 1878009 - Remove Babel integration from ESLint. r=mossop,devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D200365
2024-02-02 18:45:08 +00:00
ef6c673ba7
Bug 1835250 - [devtools] Migrate compatibility constants and helpers to dedicated modules. r=jdescottes,devtools-reviewers,Standard8.
...
Differential Revision: https://phabricator.services.mozilla.com/D179222
2023-05-31 04:55:22 +00:00
33687e166a
Bug 1812646 - [devtools] Convert base-loader JSM to ESM. r=devtools-reviewers,jdescottes
...
Having it be a JSM make it so that part of the loader is still using the
shared loader global, which can cause various troubles in the browser toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D167962
2023-01-31 13:46:48 +00:00
ff6deaa55d
Bug 1578975 - [devtools] Remove now-unused setupInParent code. r=devtools-reviewers,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D166695
2023-01-29 20:50:48 +00:00
8b2a94432f
Bug 1806404 - [devtools] Remove code related to content process message forwarding. r=nchevobbe
...
This was legacy code and isn't used by today's browser toolbox.
Instead we retrieve the content process messages directly from ContentProcess or BrowsingContext targets.
Differential Revision: https://phabricator.services.mozilla.com/D165025
2022-12-20 19:30:30 +00:00
94b0ede386
Bug 1793604 - [devtools] Inject JSM/ESM globals directly from Loader.jsm/sys.mjs. r=jdescottes
...
ESM can't be loaded while loading.
So that Loader.jsm/sys.mjs can't load builtin-modules.js with itself loading Loader.jsm/sys.mjs.
We do that in order to inject JSM/ESM globals from builtin-modules.js.
Let's instead inject the few globals of JSM/ESM directly from Loader.
This isn't ideal, but as Loader is meant to be removed when moving to ESM...
Differential Revision: https://phabricator.services.mozilla.com/D158583
2022-10-14 12:19:42 +00:00
f2bc8a3148
Bug 1276347 - [devtools] Remove "reportError" from devtools module globals. r=jdescottes
...
This might have only be useful from the source actor.
In workers, you don't have access to Cu, so nor have access to Cu.reportError.
Otherwise from the main thread, you can safely use Cu.reportError.
In couple of places I'm removing the usage of reportError.
Hopefully throwing an exception is enough to get the error displayed!
Differential Revision: https://phabricator.services.mozilla.com/D157909
2022-09-26 10:48:04 +00:00
5bfeb8f498
Bug 1788601 - [devtools] Fix ESLint consistent-return failures in devtools/client/framework. r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D156159
2022-09-12 17:41:33 +00:00
fa06502ad1
Bug 1788594 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/. r=bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D156156
2022-09-12 17:41:33 +00:00
e26a356c6b
Bug 1788032 - [devtools] Convert devtools/client JSM to ES Modules. r=bomsy
...
This is the result of:
$ ./mach esmify devtools/client/
Differential Revision: https://phabricator.services.mozilla.com/D156181
2022-09-06 18:37:10 +00:00
3074bcadc6
Bug 1787389 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/src/actions. r=bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D155824
2022-08-31 11:40:15 +00:00
65f7672999
Bug 1786699 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/src/selectors. r=bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D155452
2022-08-25 11:00:10 +00:00
dfb1d40244
Bug 1786241 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/src/workers. r=bomsy.
...
Differential Revision: https://phabricator.services.mozilla.com/D155196
2022-08-23 12:18:13 +00:00
39880dc213
Bug 1784073 - [devtools] Fix ESLint consistent-return failures in devtools/client/debugger/src/utils/. r=bomsy.
...
Depends on D154244
Differential Revision: https://phabricator.services.mozilla.com/D154245
2022-08-12 07:00:36 +00:00
a77c3be794
Bug 1784071 - [devtools] Remove debugger specific eslint override for consistent-return rule. r=bomsy.
...
Instead, we put all the failing file into devtools eslintrc.js.
Differential Revision: https://phabricator.services.mozilla.com/D154244
2022-08-12 07:00:36 +00:00
a6855db57e
Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
4cb7265185
Bug 1782819 - Enable some ESLint rules for devtools to be consistent with the rest of mozilla-central. r=jdescottes
...
Depends on D153536
Differential Revision: https://phabricator.services.mozilla.com/D153537
2022-08-03 08:24:21 +00:00
795c5f035b
Bug 1782819 - Remove ESlint rules from devtools/.eslintrc.js where they are already turned off or obsolete. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D153536
2022-08-03 08:24:20 +00:00
e88ac8dc9f
Bug 1508688 - Enable 'react/no-deprecated' ESLint rule for devtools/. r=devtools-reviewers,nchevobbe
...
This enables https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-deprecated.md
Differential Revision: https://phabricator.services.mozilla.com/D149485
2022-06-16 10:03:12 +00:00
8895997060
Bug 1508688 - Add 'UNSAFE_' lifecycle methods to 'react/sort-comp' rule for devtools/. r=devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D149475
2022-06-16 10:03:08 +00:00
78e1056d4c
Bug 1771088 - [devtools] Disable react-hooks/rules-of-hooks eslint rule. r=jdescottes
...
This rule was matching any function prefixed with `use`, even in modules
that weren't React components.
In addition to that, DevTools aren't using React hooks, so this rule is uncessary.
Differential Revision: https://phabricator.services.mozilla.com/D147283
2022-06-01 14:38:35 +00:00
3b0258336e
Bug 1769569 - Enable ESLint rule no-define-cc-etc for devtools sjs files. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D146449
2022-05-18 08:13:18 +00:00
c552340e0c
Backed out 5 changesets (bug 1769569) for causing devtools' browser/browser_page_redirection.js to fail. CLOSED TREE
...
Backed out changeset 66a42eb3a366 (bug 1769569)
Backed out changeset d3cc9629cd9a (bug 1769569)
Backed out changeset edcd3dade079 (bug 1769569)
Backed out changeset 29d8dd058b7a (bug 1769569)
Backed out changeset 1aed34fdf2d3 (bug 1769569)
2022-05-17 19:49:17 +02:00
55789cb268
Bug 1769569 - Enable ESLint rule no-define-cc-etc for devtools sjs files. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D146449
2022-05-17 16:50:31 +00:00
7a084ed84c
Bug 1725952 - Upgrade ESLint to v8.x. r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D144002
2022-04-22 11:23:30 +00:00
f3012297a4
Bug 1762601 - Migrate all of devtools from Cu.import to ChromeUtils.import. r=jdescottes,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D142693
2022-04-04 13:41:02 +00:00
d049bb7498
Bug 1609100 - [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D141464
2022-03-28 11:12:06 +00:00
66797d7700
Backed out 5 changesets (bug 1609100) for causing mochitest failures on browser_check_identity_state.js CLOSED TREE
...
Backed out changeset 521cbbae0914 (bug 16091001609100160910016091001609100
2022-03-28 13:11:58 +03:00
db5d601b00
Bug 1609100 - [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D141464
2022-03-28 08:57:36 +00:00
abdf9aa97b
Bug 1757397 - [devtools] Enable consistant return eslint rule in the debugger. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D139844
2022-02-28 17:59:32 +00:00
26c5ba2c1a
Bug 1757397 - [devtools] Enable strict eslint rule in the debugger. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D139843
2022-02-28 17:59:32 +00:00
4f6825b177
Bug 1755907 - [devtools] Enable eslint on debugger tests (except their test pages). r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D139366
2022-02-23 18:38:26 +00:00
212faeb0c3
Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
...
Depends on D131216
Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
5502682b68
Bug 1714527 - [devtools] Remove unused serviceworker actor code in DevTools server r=nchevobbe,devtools-backward-compat-reviewers
...
The actor code for attaching/detaching service worker targets and to push/start workers should no longer be used when parentintercept is disabled because all the UI triggering this is disabled in that case.
Consequently we can remove the server side code supporting this. We still have to be able to list service worker targets when parentintercept is disabled, so there are still some codepaths using isParentInterceptEnabled in the server.
Differential Revision: https://phabricator.services.mozilla.com/D116850
2021-06-07 20:13:26 +00:00
cb230e8e99
Bug 1705536 - [devtools] Add linter errors when using componentDidUnmount r=bomsy
...
Differential Revision: https://phabricator.services.mozilla.com/D112272
2021-04-16 14:00:37 +00:00
349e77181c
Bug 1700106 - [devtools] Exclude tests from general DevTools camelcase eslint rule. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D109478
2021-03-23 15:51:17 +00:00
8efc49e6bd
Bug 1700106 - [devtools] Exclude tests from general reject-some-requires eslint rule. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D109477
2021-03-23 15:51:17 +00:00
e0fea8d6ee
Bug 1652690 - Remove outdated eslint rule for devtools/shared/platform r=nchevobbe,perftest-reviewers,sparky
...
Small cleanup of eslint rules.
Differential Revision: https://phabricator.services.mozilla.com/D83477
2020-07-15 14:59:19 +00:00
d566f06f12
Bug 1651135, remove framescript and message manager usage from devtools json tests, r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D82571
2020-07-10 00:51:20 +00:00
5cf56b802f
Bug 1650690, remove frame scripts from devtools animation tests, and use SpecialPowers.spawn instead, r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D82307
2020-07-07 11:35:15 +00:00
36c00b6af2
Bug 1650690, remove frame scripts from inspector tests, and use SpecialPowers.spawn instead, r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D82306
2020-07-07 11:35:03 +00:00
e4f51c32b7
Bug 1645237: Lazily load JSONView components via static registration. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D79385
2020-06-12 18:48:47 +00:00
Mark Banner
Sandor Molnar
Dave Townsend
Nicolas Chevobbe
Alexandre Poirot
Tetsuharu Ohzeki
Sebastian Hengst
Julian Descottes
Norisz Fay
Neil Deakin
Kris Maglione